11776 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Julien Fastré	261d47a8a4	Add changies ... [ci-skip]	2024-11-12 21:25:23 +01:00
Julien Fastré	6453237340	Mark class as final and readonly	2024-11-12 21:22:51 +01:00
Julien Fastré	79621e8ab7	Add guard to block signatures on related entities without objects ... Implemented a guard to prevent signatures on related entities that lack a stored object. It also includes corresponding tests and added translation for the error message in French.	2024-11-12 18:14:30 +01:00
Julien Fastré	bfa58177e0	fix url for granting access to workflow by key	2024-11-12 17:48:44 +01:00
Julien Fastré	ddf73e1a48	Updated URL in French workflow notification template ... The absolute url in the French version of the workflow notification content to user group has been updated. It now points to 'chill_main_workflow_grant_access_by_key' instead of 'chill_main_workflow_show'. This update improves the user experience by taking the user directly to the desired page.	2024-11-12 14:52:39 +01:00
Julien Fastré	c3cc6c8353	Do not fail displaying notification when workflow has been deleted	2024-11-12 13:57:48 +01:00
Julien Fastré	3ec0d26001	Fix type error for displaying comment in accompanying period work detail view page	2024-11-12 10:13:20 +01:00
Julien Fastré	64d91e2afe	Allow users to edit a document if they were added to the previous step of a workflow. ... OP#826 Workflow - les utilisateurs des étapes précédentes sur un workflow doivent aussi avoir la main sur les étapes en cours du workflow (Vendee/accent-suivi-developpement/1289) https://champs-libres.openproject.com/work_packages/826	2024-11-08 20:34:45 +01:00
Julien Fastré	5339d4f5d9	Refactor button to add a manual zone ... - do not show the button if a zone is selected (to avoid to create two selected zones on the document); - change the button while waiting for the user to create a new zone: this make visible the fact that the app is waiting for a user action	2024-11-08 19:35:03 +01:00
Julien Fastré	0439c29305	Prevent workflow execution for finalized transitions ... Added a check in the workflow-show page script to stop the execution if a transition is marked as finalized (`toFinal`). This ensures that transitions leading to final states are not processed further.	2024-11-07 21:52:44 +01:00
Julien Fastré	8e34f6962a	Add conditional cursor style for canvas when a zone is added within the canvas ... Modified the canvas element to conditionally apply a CSS class when adding a zone. This change ensures the cursor changes to 'copy' for visual feedback during the add operation.	2024-11-07 21:34:49 +01:00
Julien Fastré	e5148f603b	Add TransitionHasSignerIfSignature validator ... Introduced a new validator `TransitionHasSignerIfSignature` to enforce that a signature transition must have a designated signer. Included related tests, updated DTO annotations, and added translations for new validation messages.	2024-11-07 19:55:09 +01:00
Julien Fastré	b6c141a785	Change zoomLevel from const to let. ... Replaced `const` with `let` for `zoomLevel` in `App.vue` to allow reassignment. This change ensures proper handling of dynamic zoom levels during document signature operations.	2024-11-06 19:51:56 +01:00
Julien Fastré	db4d7669f1	Add duplication feature for evaluation documents within generic doc ... Introduced a new method to duplicate evaluation documents and forward return path URLs. Updated templates to include duplication buttons and adjusted routing for handling the duplication process.	2024-11-06 19:34:41 +01:00
Julien Fastré	9526d016c6	Merge branch 'signature-app/zoom-button' into 'signature-app-master' ... Signature app/zoom button See merge request Chill-Projet/chill-bundles!751	2024-11-06 18:34:14 +00:00
Julien Fastré	b2f6dbbe30	Show the zoom level also if there is only one page in the document	2024-11-06 19:32:12 +01:00
Julien Fastré	5447ad2961	Fix casting zoom level from string to floatInt ... Changed the type of the zoomLevel parameter from number to string and updated the assignment to parse the zoomLevel as a float. This ensures that the zoom functionality properly handles string inputs by converting them to numerical values.	2024-11-06 19:31:01 +01:00
Julien Fastré	ac353ec3bc	fix cs	2024-11-06 17:10:53 +01:00
Julien Fastré	7aca08c89e	Allow to remove the canceled workflow to be deleted, if canceled ... - OP#812 - https://champs-libres.openproject.com/work_packages/812	2024-11-06 17:10:48 +01:00
Julien Fastré	43b70fd773	Rename translation key for workflow signature titles ... Updated the translation key from 'workflow.signature_required_title' to 'workflow.signatures_title' in the workflow history view. This change ensures consistency and proper usage of the translation key across different parts of the application.	2024-11-04 15:26:07 +01:00
Julien Fastré	5c0a383909	Add null check to canRun method in CancelStaleWorkflowCronJob ... Ensure the canRun method in CancelStaleWorkflowCronJob returns true when the cron job execution is null. This change includes updating the corresponding test case to cover the new behavior.	2024-11-04 14:16:52 +01:00
Julien Fastré	4dc2348893	Change behaviour to allow to add a new workflow (if available) and open the modal to list existing workflows in the same button ... Use the feature of splitted dropdown buttons, from bootstrap. See: - OP#776 - https://champs-libres.openproject.com/work_packages/776	2024-11-04 14:05:57 +01:00
nobohan	76458cf375	signature: cancel button at the left + changed style	2024-10-30 10:38:34 +01:00
nobohan	5259ea71a1	signature vue app: improve responsive design	2024-10-30 10:29:08 +01:00
nobohan	3bc6595f58	add a zoom button for zooming to the document	2024-10-26 12:09:00 +02:00
Julien Fastré	989fdad561	Add chill_path_force_return_path method to routing helper ... Implemented a new Twig function `chill_path_force_return_path` to enforce a specific return path within the URL. Updated relevant template to utilize this new function for better control over URL routing and return path management. OP#787 https://champs-libres.openproject.com/work_packages/787	2024-10-25 18:33:22 +02:00
Julien Fastré	d7174cdb95	Reintroduce pending signatures section in person list view ... Moved the pending signatures section within the person list view template to the correct location. OP#771 https://champs-libres.openproject.com/work_packages/771	2024-10-25 18:20:58 +02:00
Julien Fastré	182e2fc3af	Set 'required' to false for Email field in UserGroupType form. ... Changed the Email field's 'required' option to false, allowing it to be optional. This adjustment aims to improve the usability and flexibility of the UserGroupType form.	2024-10-25 11:18:38 +02:00
Julien Fastré	7df5a22b14	Merge branch 'signature-app/OP768-alter-sending-after-signature' into 'signature-app-master' ... When a user applies a signature in a workflow, the signer is the futureDestUser of the next step See merge request Chill-Projet/chill-bundles!749	2024-10-24 16:04:44 +00:00
Julien Fastré	f750cfecac	Show userGroup in workflow breadcrumb ... related: - https://champs-libres.openproject.com/wp/774 - OP#774 - Vendee/accent-suivi-developpement#1274	2024-10-24 16:15:49 +02:00
Julien Fastré	bf85e9bb71	When a user applies a signature in a workflow, the signer is the futureDestUser of the next step ... See: - Vendee/accent-suivi-developpement#1252 - https://champs-libres.openproject.com/wp/768 - OP#768	2024-10-24 15:49:59 +02:00
Julien Fastré	97729de66d	Update conditional rendering logic for displaying list of workflows ... Ensure the workflow modal is displayed when either workflows_availables or workflows are non-empty. This improves the user interface by correctly triggering the modal in more scenarios. - OP#762 - https://champs-libres.openproject.com/work_packages/762 - Vendee/accent-suivi-developpement#1254	2024-10-24 15:11:07 +02:00
Julien Fastré	4e0a421a03	Refactor PDF mounting process to use ArrayBuffer ... Changed mountPdf function to accept an ArrayBuffer instead of a URL. This improves handling of documents by simplifying the data flow and eliminates the need for URL object creation.	2024-10-23 22:08:25 +02:00
Julien Fastré	00408b91a9	Merge branch 'signature-app/OP#767-block-external-send-when-no-document' into 'signature-app-master' ... Add workflow guard to block external send when the handler does not provide a public view See merge request Chill-Projet/chill-bundles!748	2024-10-23 13:45:18 +00:00
Julien Fastré	fd69568842	Add workflow guard to block external send without public view ... Introduce `EntityWorkflowGuardSendExternalIfNoPublicView` class to prevent workflows from transitioning to an external send state if the entity lacks a public view. Included unit tests to verify functionality for entities both with and without public views.	2024-10-23 15:26:25 +02:00
Julien Fastré	71aaf01687	Merge branch 'signature-app/OP762-fix-create-workflow-action' into 'signature-app-master' ... Fix the triggering of the vent goToGenerateWorkflow when relatedentityId is not know in PickWorkflow vue component See merge request Chill-Projet/chill-bundles!747	2024-10-23 11:51:05 +00:00
Julien Fastré	a256307b82	Fix the triggering of the event goToGenerateWorkflow when relatedEntityId is not known ... The component PickWorkflow emitted the event "goToGenerateWorkflow" when the normal behaviour is intercepted. But that event generated the link to create the workflow to pass it in the payload's event. That generation failed, causing the whole event to fail. Now, if the link could not been generated, the link is a blank string. There is a supplementary parameter `isLinkValid`, boolean, inform if the link is valid or not.	2024-10-23 13:44:31 +02:00
Julien Fastré	a6480191e5	Merge branch 'signature-app/OP753-suggest-users-persons' into 'signature-app-master' ... Add suggestion for users, persons and thirdparties in workflow See merge request Chill-Projet/chill-bundles!746	2024-10-23 09:47:43 +00:00
Julien Fastré	19eb6f7ebb	Add suggested persons and third parties in form ... Integrated suggested persons and third parties into the WorkflowStepType form. This enhancement auto-populates suggestion fields for better user experience. It ensures that the suggestion data for persons and third parties is readily available in the form configuration.	2024-10-23 11:41:20 +02:00
Julien Fastré	261bc88b5e	Add suggested persons and third parties methods ... Introduced getSuggestedPersons and getSuggestedThirdParties methods across various WorkflowHandlers. These methods integrate with ProvidePersonsAssociated and ProvideThirdPartiesAssociated services to fetch related entities, enhancing the workflow handling capabilities.	2024-10-23 11:41:19 +02:00
Julien Fastré	4f18b1d2b2	Add services and tests for associated entities management ... Implemented services to provide associated persons and third parties for accompanying periods and their works. Included comprehensive tests to ensure proper functionality and associations.	2024-10-23 00:51:37 +02:00
Julien Fastré	968835a262	Refactor user suggestion logic in workflow ... Removed duplicate user suggestion handling from `WorkflowController` and centralized it in `WorkflowStepType`. This change simplifies the controller and makes user suggestion logic more maintainable.	2024-10-22 23:51:48 +02:00
Julien Fastré	85dc9bdb2f	Add getSuggestedUsers method in EntityWorkflowManager ... Implemented the method to retrieve a list of suggested users for an entity workflow, filtering out duplicates. Added corresponding unit tests to verify the method's functionality and ensure its correctness in various scenarios.	2024-10-22 23:35:13 +02:00
Julien Fastré	c877076429	Add and update test handlers for suggested users retrieval ... Introduced new test files for workflow handlers and adjusted existing `getSuggestedUsers` methods to handle related entity checks and duplicates removal. Also, modified repos to align with test dependencies.	2024-10-22 23:24:10 +02:00
Julien Fastré	418794e586	Merge branch 'signature-app/OP730-create-entities-sending' into 'signature-app-master' ... Implement feature to send document to an external See merge request Chill-Projet/chill-bundles!745	2024-10-21 15:56:12 +00:00
Julien Fastré	fd66dbf26e	Merge remote-tracking branch 'origin/signature-app-master' into signature-app/OP730-create-entities-sending	2024-10-21 17:50:03 +02:00
Julien Fastré	fde74b190d	Add mock for TempUrlGeneratorInterface in StoredObjectTypeTest ... Updated the StoredObjectNormalizer initialization to include a mock for TempUrlGeneratorInterface. This ensures tests handle all dependencies of StoredObjectNormalizer correctly.	2024-10-21 17:45:12 +02:00
Julien Fastré	527cf23d4f	Fix Canceling of stale workflow cronjob ... Refactor workflow cancellation logic to encapsulate transition checks in a dedicated method, and update CronJob handling to use entity workflows instead of IDs. Enhance test coverage to ensure proper handling and instantiate mocks for EntityManagerInterface.	2024-10-21 17:42:00 +02:00
Julien Fastré	1d708a481d	Fix the display of old documents in the storedobject's history list modal ... OP#737 https://champs-libres.openproject.com/work_packages/737	2024-10-21 17:42:00 +02:00
Julien Fastré	ff5640e193	Allow to edit storedObject associated with workflow which are canceled ... OP#753	2024-10-21 17:41:59 +02:00