Clean code by commenting out some variable, and allowing some dead code.

src/error.rs

@@ -7,7 +7,7 @@ pub struct GeneralError {
 }
 
 impl From<InvalidHeaderValue> for GeneralError {
-    fn from(value: InvalidHeaderValue) -> Self {
+    fn from(_value: InvalidHeaderValue) -> Self {
         GeneralError {
             description: "Unable to convert the token into header value".to_string(),
         }

src/gitea/client.rs

@@ -1,7 +1,7 @@
 use crate::config::{Config, GiteaConfig};
 use crate::error::GeneralError;
 use reqwest::header::{HeaderMap, ACCEPT, AUTHORIZATION};
-use reqwest::{Body, ClientBuilder, StatusCode};
+use reqwest::{ClientBuilder, StatusCode};
 use serde::de::DeserializeOwned;
 use serde::Serialize;
 use url::Url;
@@ -9,7 +9,7 @@ use url::Url;
 #[derive(Debug)]
 pub struct Client {
     token: String,
-    base_uri: String,
+    // base_uri: String,
 }
 
 fn is_client_for_url(url: &Url, config: &GiteaConfig) -> bool {
@@ -29,6 +29,7 @@ pub(crate) fn has_client_for_url(url: &Url, config: &Config) -> bool {
     false
 }
 
+#[allow(dead_code)]
 fn client_for_url(url: &Url, config: &Config) -> Result<Client, GeneralError> {
     for c in &config.gitea {
         if is_client_for_url(url, c) {
@@ -46,10 +47,10 @@ impl Client {
         Self::new(&config.token, &config.domain)
     }
 
-    pub fn new(token: &String, domain: &String) -> Self {
+    pub fn new(token: &String, _domain: &String) -> Self {
         Client {
             token: token.clone(),
-            base_uri: format!("https://{}", domain.clone()),
+            // base_uri: format!("https://{}", domain.clone()),
         }
     }
 

src/gitea/issue.rs

@@ -1,13 +1,11 @@
 use crate::error::GeneralError;
-use crate::gitea::client::Client;
 use crate::gitea::repository::Repository;
-use reqwest::Body;
 use serde::{Deserialize, Serialize};
 use url::Url;
 
 #[derive(Debug, Deserialize)]
 pub struct Issue {
-    pub id: u64,
+    // pub id: u64,
     pub number: u64,
     pub title: String,
     pub body: String,
@@ -20,16 +18,6 @@ pub struct IssueWriteSetBody {
     pub body: String,
 }
 
-pub trait IssueClient {
-    fn get_issue(owner_or_organisation: &String, repo: &String, number: &u64) -> Option<Issue>;
-}
-
-impl IssueClient for Client {
-    fn get_issue(_owner_or_organisation: &String, _repo: &String, number: &u64) -> Option<Issue> {
-        todo!()
-    }
-}
-
 pub fn issue_html_url_to_api(url: &Url) -> Result<Url, GeneralError> {
     let mut parts = url.path_segments().unwrap();
     let domain = parts.next().unwrap();

src/gitea/repository.rs

@@ -2,8 +2,8 @@ use serde::Deserialize;
 
 #[derive(Debug, Deserialize)]
 pub struct Repository {
-    id: u64,
-    name: String,
-    owner: String,
+    // id: u64,
+    // name: String,
+    // owner: String,
     pub full_name: String,
 }

src/gitlab/client.rs

@@ -3,10 +3,6 @@ use crate::error::GeneralError;
 use gitlab::{AsyncGitlab, GitlabBuilder};
 use url::Url;
 
-pub struct ClientProvider {}
-
-impl ClientProvider {}
-
 fn is_client_for_url(url: &Url, config: &GitlabConfig) -> bool {
     if url.domain() == Some(config.domain.as_str()) {
         return true;

src/openproject/hal.rs

@@ -1,13 +1,13 @@
 use serde::Deserialize;
 
-#[derive(Deserialize, Debug)]
-pub struct HalEntity {
-    #[serde(rename = "_type")]
-    pub d_type: String,
-}
+// #[derive(Deserialize, Debug)]
+// pub struct HalEntity {
+//     // #[serde(rename = "_type")]
+//     // pub d_type: String,
+// }
 
 #[derive(Deserialize, Debug, Clone)]
 pub struct Link {
     pub href: String,
-    pub title: Option<String>,
+    // pub title: Option<String>,
 }

src/openproject/root.rs

@@ -1,11 +1,11 @@
 use crate::openproject::client::{handle_response_status, Client, OpenProjectError};
-use crate::openproject::hal::HalEntity;
+// use crate::openproject::hal::HalEntity;
 use serde::Deserialize;
 
 #[derive(Deserialize, Debug)]
 pub struct User {
     pub href: String,
-    pub title: String,
+    // pub title: String,
 }
 #[derive(Deserialize, Debug)]
 pub struct Links {
@@ -13,12 +13,12 @@ pub struct Links {
 }
 #[derive(Deserialize, Debug)]
 pub struct Root {
-    #[serde(rename = "instanceName")]
-    pub instance_name: String,
+    // #[serde(rename = "instanceName")]
+    // pub instance_name: String,
     #[serde(rename = "_links")]
     pub links: Links,
-    #[serde(flatten)]
-    pub hal_entity: HalEntity,
+    // #[serde(flatten)]
+    // pub hal_entity: HalEntity,
 }
 
 pub trait RootClient {

src/openproject/user.rs

@@ -10,13 +10,10 @@ pub struct UserLink {
 }
 #[derive(Deserialize, Debug, Clone)]
 pub struct User {
-    #[serde(rename = "_type")]
-    #[allow(unused_variables)]
-    pub d_type: String,
-    #[allow(unused_variables)]
-    pub id: u64,
-    #[allow(unused_variables)]
-    pub name: String,
+    // #[serde(rename = "_type")]
+    // pub d_type: String,
+    // pub id: u64,
+    // pub name: String,
     #[serde(rename = "_links")]
     pub d_links: UserLink,
 }