fix person last address (from @loophp on old framagit repo)

See https://framagit.org/Chill-project/Chill-Person/-/merge_requests/13

src/Bundle/ChillPersonBundle/Entity/Person.php

@@ -1022,18 +1022,20 @@ class Person implements HasCenterInterface
      */
     public function getLastAddress(\DateTime $date = null)
     {
-        if ($date === null) {
-            $date = new \DateTime('now');
-        }
+        $from ??= new DateTime('now');
 
-        $addresses = $this->getAddresses();
+        /** @var ArrayIterator $addressesIterator */
+        $addressesIterator = $this->getAddresses()
+            ->filter(static fn (Address $address): bool => $address->getValidFrom() <= $from)
+            ->getIterator();
 
-        if ($addresses == null) {
+        $addressesIterator->uasort(
+            static fn (Address $left, Address $right): int => $right->getValidFrom() <=> $left->getValidFrom()
+        );
 
-            return null;
-        }
-
-        return $addresses->first();
+        return [] === ($addresses = iterator_to_array($addressesIterator)) ?
+            null :
+            current($addresses);
     }
 
     /**

src/Bundle/ChillPersonBundle/Tests/Entity/PersonTest.php

@@ -24,6 +24,11 @@ namespace Chill\PersonBundle\Tests\Entity;
 
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Entity\AccompanyingPeriod;
+use Chill\MainBundle\Entity\Address;
+use DateInterval;
+use DateTime;
+use Generator;
+
 
 /**
  * Unit tests for the person Entity
@@ -151,4 +156,53 @@ class PersonTest extends \PHPUnit\Framework\TestCase
         
         $this->assertEquals($r['result'], Person::ERROR_ADDIND_PERIOD_AFTER_AN_OPEN_PERIOD);
     }
+
+    public function dateProvider(): Generator
+    {
+        yield [(DateTime::createFromFormat('Y-m-d', '2021-01-05'))->settime(0, 0)];
+        yield [(DateTime::createFromFormat('Y-m-d', '2021-02-05'))->settime(0, 0)];
+        yield [(DateTime::createFromFormat('Y-m-d', '2021-03-05'))->settime(0, 0)];
+    }
+
+    /**
+     * @dataProvider dateProvider
+     */
+    public function testGetLastAddress(DateTime $date)
+    {
+        $p = new Person($date);
+
+        // Make sure that there is no last address.
+        $this::assertNull($p->getLastAddress());
+
+        // Take an arbitrary date before the $date in parameter.
+        $addressDate = clone $date;
+
+        // 1. Smoke test: Test that the first address added is the last one.
+        $address1 = (new Address())->setValidFrom($addressDate->sub(new DateInterval('PT180M')));
+        $p->addAddress($address1);
+
+        $this::assertCount(1, $p->getAddresses());
+        $this::assertSame($address1, $p->getLastAddress());
+
+        // 2. Add an older address, which should not be the last address.
+        $addressDate2 = clone $addressDate;
+        $address2 = (new Address())->setValidFrom($addressDate2->sub(new DateInterval('PT30M')));
+        $p->addAddress($address2);
+
+        $this::assertCount(2, $p->getAddresses());
+        $this::assertSame($address1, $p->getLastAddress());
+
+        // 3. Add a newer address, which should be the last address.
+        $addressDate3 = clone $addressDate;
+        $address3 = (new Address())->setValidFrom($addressDate3->add(new DateInterval('PT30M')));
+        $p->addAddress($address3);
+
+        $this::assertCount(3, $p->getAddresses());
+        $this::assertSame($address3, $p->getLastAddress());
+
+        // 4. Get the last address from a specific date.
+        $this::assertEquals($address1, $p->getLastAddress($addressDate));
+        $this::assertEquals($address2, $p->getLastAddress($addressDate2));
+        $this::assertEquals($address3, $p->getLastAddress($addressDate3));
+    }
 }