Various improvements
- Introduce tests for twig functions ;
- Make the twig function `chill_custom_field_is_emtpy` consistent with other functions ;
- remove dead code from CustomFieldsHelper ;
- add validation on custom field slug
- fix bug in test
- re-introduce the units label in numeric/integer custom fields
See merge request !12
The method chill_custom_fields_is_empty take now the fields as first argument, and the customField as second argument, to be consistent with other twig methods.
Now, the CustomFieldsHelper methods and the twig function which render customFields require always a `Chill\CustomFields\Entity\CustomField`.
The possibility to add a slug and an object as argument to those method is abandoned, and was not used in other bundle (nevertheless, the method to catch a customField from his slug was buggy).
The composer root version is required to let composer decide on which branch he is, as we have mirrored dependencies (custom field requires person, which requires custom field).
The php 7 build select now php 7 image
bug description :
> if you change the options of a custom field choice (i.e. from a
> multiple to a single, removing or adding allow_other), the data
> representation change and do not match with the expected
> representation of the form.
This commit fix this bug by switching the data representation to the
current options.
A new parameter is defined :
```
chill_custom_fields:
show_empty_values_in_views = true|false
```
A new method is added to CustomFieldInterface: `isEmptyValue`. To ease
the dev of new classes, an AbstractCustomField class is created, which
implements the most commons function (currently, only isEmptyValue).
A new Twig Filter is added: `chill_custom_field_is_empty`
The twig filter `chill_custom_fields_group_widget` has a new possibility
in array option : `show_empty`. Default to
chill_custom_fields.show_empty_values_in_view. May be forced by
true/false.
add a required field to custom fields type
ref Chill-project/Chill-CustomFields#17
Add a `required` column to the `customfield` table, add a `required` field in customfieldsGroup form.
If the customfield is required, the field is marked as required in the customfield type (when the form is compiled). Although, for compound type (like choices) it is necessary to mark the type manually as required.
See merge request !8
The `custom field long choice` aim to provide a way to deal with choices
with a big possibilities.
The `custom field long choice` allow :
- to persist different options in the database ;
- each option has a key, a text (translatable string), and eventually a
parent, and an internal_key
- every key can be activate or not. If the parent is inactivated, all
childs are inactivated
- the internal key have two purposes :
- link to an external csv file, with their own key ;
- add a special class to results, to allow custom layout.
Currently, the field exists, but some elements are missing :
- a script for CSV import
- possibility to select multiple items
- edition of options
- handle of option without parents
- tests are missing
add a number field
The field has three option :
- lesser or equal than. If null, this option is ignored ;
- greather or equal than. If null, this options is ignored ;
- precision : the number of decimal after the number ;
- text after the field : a text to show after the field.
The field is rendered as an HTML integer input if precision = 0, or a
symfony number field if precision > 0.
ref chill-project/Chill-CustomFields#11
See merge request !6
The field has three option :
- lesser or equal than. If null, this option is ignored ;
- greather or equal than. If null, this options is ignored ;
- precision : the number of decimal after the number ;
- text after the field : a text to show after the field.
The field is rendered as an HTML integer input if precision = 0, or a
symfony number field if precision > 0.
ref chill-project/Chill-CustomFields#11
remove 'empty_data' which cause conflict with transformer
this blocked the possibility to uncheck the 'active' field on the
choice.
Should fix chill-project/Chill-CustomFields#12
See merge request !3
Layout of index page for customfieldsgroup
Fix chill-project/custom-fields#2 and chill-project/custom-fields#3
This is a test to see how works merge request in gitlab.
See merge request !1
