12473 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Julien Fastré	6f1a26742d	Refactor method signatures for stricter type safety ... Updated method parameters to enforce stricter type declarations, improving code clarity and reducing potential runtime errors. This change ensures better consistency across interfaces and aligns with modern PHP typing practices.	2025-04-08 13:40:05 +02:00
Julien Fastré	0d0a626f50	Implements return types on aggregators	2025-04-08 12:38:52 +02:00
Julien Fastré	ec5f4ed1d6	Refactor type annotations in export interfaces ... Updated return type annotations in `AggregatorInterface` for clarity and adjusted generics in `ListInterface` to better reflect supported query types. This improves code readability and strengthens type safety.	2025-04-08 12:38:38 +02:00
Julien Fastré	d9251239f7	Remove unused CSVFormatter and improve translations handling ... CSVFormatter was deprecated and is no longer in use, so it was removed. Additionally, translation handling was enhanced across multiple formatters, supporting `TranslatableInterface` to ensure better localization compatibility.	2025-04-08 10:38:07 +02:00
Julien Fastré	b2d3d806b6	Fix PHPDocs and return type declarations in export interfaces ... Corrected typos in PHPDocs, added missing type templates, and ensured proper return type declarations. These changes improve code readability, consistency, and type safety across export-related interfaces.	2025-04-08 10:37:47 +02:00
Julien Fastré	8e952cc966	Implements new return types	2025-04-07 14:35:29 +02:00
Julien Fastré	1c4ee37507	Refactor entity normalization to handle Doctrine Collection. ... Updated `normalizeDoctrineEntity` to support normalizing `Collection` objects and handle null values in arrays. This ensures compatibility with a broader range of entity structures and improves data integrity during normalization.	2025-04-07 14:35:07 +02:00
Julien Fastré	8331a836f2	Add explicit return types and TranslatableInterface support ... Updated interfaces to include explicit return types for improved type safety and readability. Integrated support for Symfony's TranslatableInterface in relevant methods to enhance translation handling.	2025-04-07 14:26:11 +02:00
Julien Fastré	2482dcc62e	Refactor ExportManager integration and remove ExportsCompilerPass ... Replaced direct ExportManager dependencies in formatters with an ExportManagerAwareTrait to decouple components and enhance flexibility. Removed the ExportsCompilerPass as it is no longer required, and adjusted service configurations to improve reliability and consistency.	2025-04-07 12:42:28 +02:00
Julien Fastré	f9a55a1bfd	Fix debug artifact in ExportFormHelper ... Removed unnecessary `dump()` calls when resolving centers and regroupments. This ensures cleaner processing and	2025-04-07 12:37:29 +02:00
Julien Fastré	15aa565caf	Add custom exception classes for export errors ... Introduced `ExportRuntimeException` and `ExportLogicException` to better categorize exceptions in the export process. Updated `ExportGenerationException` to extend `ExportRuntimeException` for clearer hierarchy and improved maintainability.	2025-04-07 11:38:42 +02:00
Julien Fastré	566b72ec9e	Add $context parameter to export query generation ... This update introduces the $context parameter to the query generator method. It ensures additional contextual data can be passed and utilized, improving the flexibility of export generation logic.	2025-04-07 11:31:52 +02:00
Julien Fastré	bb42ee25ff	Update initiateQuery method to include ExportGenerationContext ... The `initiateQuery` method now consistently incorporates the `ExportGenerationContext` parameter across various export classes, improving functionality and standardization. This change ensures compatibility and alignment with the expected method signature.	2025-04-07 11:29:04 +02:00
Julien Fastré	aebeca1d7a	Use readonly properties in constructors for better immutability. ... Converted constructor properties to readonly where applicable, ensuring immutability and promoting safer code practices. Updated throwable class reference for clarity and consistency.	2025-04-05 00:56:54 +02:00
Julien Fastré	1955249a60	Fix type handling in JSON decode for migration script ... Ensure `json_decode` explicitly casts database values to strings to avoid type errors during migration. This prevents potential issues when processing `options` fields that may not already be of string type.	2025-04-05 00:53:01 +02:00
Julien Fastré	3b0a4e9c73	Refactor exports to include ExportGenerationContext. ... Updated initiateQuery methods to pass ExportGenerationContext, enabling better user-specific query filtering. Removed redundant user retrieval in FilterListAccompanyingPeriodHelper, now relying on context-provided user data.	2025-04-05 00:35:42 +02:00
Julien Fastré	b5fd9cf4af	Add SavedExportOptionsMigrator for migrating export options ... Introduced SavedExportOptionsMigrator to handle the migration of saved export options with structures ensuring versioning. Added unit tests to validate transformation logic and edge cases for better reliability.	2025-04-05 00:35:16 +02:00
Julien Fastré	bb30ddc876	Add logging and validation to export generation handler ... Introduce a logger to track processing steps, durations, and outcomes in `ExportRequestGenerationMessageHandler`. Add validation to prevent reprocessing of already generated export objects, ensuring robust error handling and improved traceability.	2025-04-05 00:08:37 +02:00
Julien Fastré	5ebb53173e	Fix PHPStan comment format in ExportGenerator.php ... Updated the PHPStan ignore comment to use a single asterisk for consistency with comment style. This change does not affect functionality but improves code readability and adherence to coding standards.	2025-04-05 00:08:21 +02:00
Julien Fastré	d1d6a00ebf	Add failure handling for export generation errors ... Introduce `OnExportGenerationFails` subscriber to handle export generation failures. It logs errors, updates the export status to failure, and records generation errors. Added tests to validate the new functionality.	2025-04-05 00:07:08 +02:00
Julien Fastré	e48bec490c	Compute allowed centers and regroupment at the time of generating the export	2025-04-03 17:47:46 +02:00
Julien Fastré	128d365a72	Convert Rolling date using the clock instead of the built-in pivot date	2025-04-03 17:47:08 +02:00
Julien Fastré	10f66afdcd	Update date formatting and add null-safe checks for pivot dates ... Revised the date normalization format to align with ISO standards and ensure consistency. Additionally, introduced null-safe checks for pivot dates to avoid potential errors when these values are unset. Updated related tests to reflect these changes.	2025-04-02 11:35:47 +02:00
Julien Fastré	89aed74355	Refactor RollingDateConverter to use ClockInterface ... Introduced ClockInterface for better time mocking and handling, replacing default instantiation with dependency injection. Adjusted RollingDate logic to accept nullable pivot dates and updated related tests for improved flexibility and accuracy.	2025-04-02 11:08:01 +02:00
Julie Lenaerts	b3bf405c5b	Fix merge service and test	2025-04-01 16:15:34 +02:00
Julien Fastré	9124fa68e8	Refactor flash message handling to use translatable messages ... Replaced raw translations with Symfony's TranslatableMessage for flash messages in the controller. Updated Twig templates to use the `|trans` filter for consistency in rendering translations. This ensures better handling of multilingual content across the application.	2025-04-01 14:47:39 +02:00
Julien Fastré	68b61b7d8a	Refactor export-related controllers and helpers ... Removed unused dependencies, obsolete methods, and redundant parameters across ExportController, ExportFormHelper, and SavedExportController. Simplified session handling and aligned method signatures to improve maintainability and code readability.	2025-04-01 14:19:15 +02:00
Julien Fastré	80d8f967fa	Moved export listing functionality from ExportController to a new ExportIndexController ... for improved separation of concerns. Updated tests accordingly to reflect the new controller structure.	2025-04-01 13:20:48 +02:00
Julien Fastré	1375a41de2	Refactor export handling to support ExportGeneration and SavedExport ... Unified handling of ExportGeneration and SavedExport entities by introducing the SavedExportOrExportGenerationRepository. Simplified form data conversion using ExportConfigNormalizer, removing redundant FormBuilder logic. Adjusted dependent methods and controllers to accommodate these changes.	2025-04-01 10:38:51 +02:00
Julie Lenaerts	4fa4d3b65c	Phpstan and cs fixes	2025-03-27 14:32:06 +01:00
Julie Lenaerts	bd4c34cc1d	Fix eslint issues and add ts interfaces for typing	2025-03-27 14:26:43 +01:00
Julie Lenaerts	4cea678e93	Fix updating of manyToMany relationships	2025-03-27 13:34:16 +01:00
Julie Lenaerts	5e6833975b	Fix handling comments and workflows on acpw	2025-03-26 20:25:54 +01:00
Julie Lenaerts	f523b9adb3	Fix typing errors	2025-03-26 20:25:39 +01:00
Julie Lenaerts	a211549432	Adjust template and add translations	2025-03-26 15:16:27 +01:00
Julie Lenaerts	17b1363113	Fixes after rebase + apply item styling for accompanying course work	2025-03-26 14:08:45 +01:00
Julie Lenaerts	3356ed8e57	Correct for loop to display accompanying period list items	2025-03-24 16:13:56 +01:00
Julie Lenaerts	2a7fa517ee	Only show merge button if there are more than 1 works attached to the parcours	2025-03-24 16:07:47 +01:00
Julie Lenaerts	95972399a1	Remove redundant lines in test	2025-03-24 15:28:58 +01:00
Julie Lenaerts	85781c8e14	Use item renderbox for display of accompanyingperiodwork	2025-03-19 11:04:01 +01:00
Julie Lenaerts	00eb435896	Add chevron icon in merge button	2025-03-19 11:04:01 +01:00
Julie Lenaerts	ed71cffd6a	Change behavior of information exchange between backend and frontend	2025-03-19 11:03:59 +01:00
Julie Lenaerts	ae679e6997	Fix merge service and passing of json to vue	2025-03-19 11:03:53 +01:00
Julie Lenaerts	e1d308fd97	WIP create new picker for accompanying period works	2025-03-19 11:03:42 +01:00
Julie Lenaerts	d9acda67e3	WIP dynamic picking of accompanying period work	2025-03-19 11:03:42 +01:00
Julie Lenaerts	e88da74882	WIP fusion accompanyingperiodwork: controller, form, templates	2025-03-19 11:03:41 +01:00
Julie Lenaerts	591c44d1a0	Create types	2025-03-19 11:03:18 +01:00
Julie Lenaerts	bf04b7981c	Improve merge service according to specifications	2025-03-19 11:03:02 +01:00
Julie Lenaerts	df33eec30f	WIP merge service	2025-03-19 11:03:00 +01:00
Julie Lenaerts	c657c98918	Styling and organization of components	2025-03-19 11:02:55 +01:00