Use readonly properties in constructors for better immutability.

Converted constructor properties to readonly where applicable, ensuring immutability and promoting safer code practices. Updated throwable class reference for clarity and consistency.
This commit is contained in:
Julien Fastré 2025-04-05 00:56:54 +02:00
parent 1955249a60
commit aebeca1d7a
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
2 changed files with 9 additions and 9 deletions

View File

@ -28,11 +28,11 @@ use Symfony\Component\Serializer\SerializerInterface;
class ExportGenerationCreateFromSavedExportController
{
public function __construct(
private Security $security,
private EntityManagerInterface $entityManager,
private MessageBusInterface $messageBus,
private ClockInterface $clock,
private SerializerInterface $serializer,
private readonly Security $security,
private readonly EntityManagerInterface $entityManager,
private readonly MessageBusInterface $messageBus,
private readonly ClockInterface $clock,
private readonly SerializerInterface $serializer,
) {}
#[Route('/api/1.0/main/export/export-generation/create-from-saved-export/{id}', methods: ['POST'])]

View File

@ -24,9 +24,9 @@ class OnExportGenerationFails implements EventSubscriberInterface
private const LOG_PREFIX = '[export_generation failed] ';
public function __construct(
private LoggerInterface $logger,
private ExportGenerationRepository $repository,
private EntityManagerInterface $entityManager,
private readonly LoggerInterface $logger,
private readonly ExportGenerationRepository $repository,
private readonly EntityManagerInterface $entityManager,
) {}
public static function getSubscribedEvents()
@ -58,7 +58,7 @@ class OnExportGenerationFails implements EventSubscriberInterface
'alias' => $exportGeneration->getExportAlias(),
'throwable_message' => $event->getThrowable()->getMessage(),
'throwable_trace' => $event->getThrowable()->getTraceAsString(),
'throwable' => get_class($event->getThrowable()),
'throwable' => $event->getThrowable()::class,
'full_generation_duration_failure' => microtime(true) - $exportGeneration->getCreatedAt()->getTimestamp(),
]);