11742 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Julien Fastré	fd69568842	Add workflow guard to block external send without public view ... Introduce `EntityWorkflowGuardSendExternalIfNoPublicView` class to prevent workflows from transitioning to an external send state if the entity lacks a public view. Included unit tests to verify functionality for entities both with and without public views.	2024-10-23 15:26:25 +02:00
Julien Fastré	71aaf01687	Merge branch 'signature-app/OP762-fix-create-workflow-action' into 'signature-app-master' ... Fix the triggering of the vent goToGenerateWorkflow when relatedentityId is not know in PickWorkflow vue component See merge request Chill-Projet/chill-bundles!747	2024-10-23 11:51:05 +00:00
Julien Fastré	a256307b82	Fix the triggering of the event goToGenerateWorkflow when relatedEntityId is not known ... The component PickWorkflow emitted the event "goToGenerateWorkflow" when the normal behaviour is intercepted. But that event generated the link to create the workflow to pass it in the payload's event. That generation failed, causing the whole event to fail. Now, if the link could not been generated, the link is a blank string. There is a supplementary parameter `isLinkValid`, boolean, inform if the link is valid or not.	2024-10-23 13:44:31 +02:00
Julien Fastré	a6480191e5	Merge branch 'signature-app/OP753-suggest-users-persons' into 'signature-app-master' ... Add suggestion for users, persons and thirdparties in workflow See merge request Chill-Projet/chill-bundles!746	2024-10-23 09:47:43 +00:00
Julien Fastré	19eb6f7ebb	Add suggested persons and third parties in form ... Integrated suggested persons and third parties into the WorkflowStepType form. This enhancement auto-populates suggestion fields for better user experience. It ensures that the suggestion data for persons and third parties is readily available in the form configuration.	2024-10-23 11:41:20 +02:00
Julien Fastré	261bc88b5e	Add suggested persons and third parties methods ... Introduced getSuggestedPersons and getSuggestedThirdParties methods across various WorkflowHandlers. These methods integrate with ProvidePersonsAssociated and ProvideThirdPartiesAssociated services to fetch related entities, enhancing the workflow handling capabilities.	2024-10-23 11:41:19 +02:00
Julien Fastré	4f18b1d2b2	Add services and tests for associated entities management ... Implemented services to provide associated persons and third parties for accompanying periods and their works. Included comprehensive tests to ensure proper functionality and associations.	2024-10-23 00:51:37 +02:00
Julien Fastré	968835a262	Refactor user suggestion logic in workflow ... Removed duplicate user suggestion handling from `WorkflowController` and centralized it in `WorkflowStepType`. This change simplifies the controller and makes user suggestion logic more maintainable.	2024-10-22 23:51:48 +02:00
Julien Fastré	85dc9bdb2f	Add getSuggestedUsers method in EntityWorkflowManager ... Implemented the method to retrieve a list of suggested users for an entity workflow, filtering out duplicates. Added corresponding unit tests to verify the method's functionality and ensure its correctness in various scenarios.	2024-10-22 23:35:13 +02:00
Julien Fastré	c877076429	Add and update test handlers for suggested users retrieval ... Introduced new test files for workflow handlers and adjusted existing `getSuggestedUsers` methods to handle related entity checks and duplicates removal. Also, modified repos to align with test dependencies.	2024-10-22 23:24:10 +02:00
Julien Fastré	418794e586	Merge branch 'signature-app/OP730-create-entities-sending' into 'signature-app-master' ... Implement feature to send document to an external See merge request Chill-Projet/chill-bundles!745	2024-10-21 15:56:12 +00:00
Julien Fastré	fd66dbf26e	Merge remote-tracking branch 'origin/signature-app-master' into signature-app/OP730-create-entities-sending	2024-10-21 17:50:03 +02:00
Julien Fastré	fde74b190d	Add mock for TempUrlGeneratorInterface in StoredObjectTypeTest ... Updated the StoredObjectNormalizer initialization to include a mock for TempUrlGeneratorInterface. This ensures tests handle all dependencies of StoredObjectNormalizer correctly.	2024-10-21 17:45:12 +02:00
Julien Fastré	527cf23d4f	Fix Canceling of stale workflow cronjob ... Refactor workflow cancellation logic to encapsulate transition checks in a dedicated method, and update CronJob handling to use entity workflows instead of IDs. Enhance test coverage to ensure proper handling and instantiate mocks for EntityManagerInterface.	2024-10-21 17:42:00 +02:00
Julien Fastré	1d708a481d	Fix the display of old documents in the storedobject's history list modal ... OP#737 https://champs-libres.openproject.com/work_packages/737	2024-10-21 17:42:00 +02:00
Julien Fastré	ff5640e193	Allow to edit storedObject associated with workflow which are canceled ... OP#753	2024-10-21 17:41:59 +02:00
Julien Fastré	d45de5405b	Use the twig function chill_entity_render_string to render the person's name	2024-10-21 17:41:59 +02:00
Julien Fastré	7b322d7bab	Rename signature templates by removing underscores ... Standardized template names in WorkflowController and WorkflowAddSignatureController for better consistency. Updated references and renamed template files accordingly.	2024-10-21 17:41:59 +02:00
Julien Fastré	daef18408a	fix the return type of the EntityWorkflowCreation constraint	2024-10-18 19:26:09 +02:00
Julien Fastré	91a4b45607	Add notification to user groups on workflow transition ... Implemented NotificationToUserGroupsOnTransition to send group emails upon workflow completion. Also updated NotificationOnTransition to prevent double notifications and created a unit test for the new functionality.	2024-10-18 19:25:03 +02:00
Julien Fastré	29fa086fde	Set return types to MetadataExtractor	2024-10-18 19:14:23 +02:00
Julien Fastré	508c4cd674	Add an email address ot UserGroup entity	2024-10-18 19:14:13 +02:00
Julien Fastré	9fe20b5e81	Show pending signatures in the person's search results	2024-10-15 15:15:32 +02:00
Julien Fastré	d8ded80582	Add an option "suggest_myself" on PickUserDynamicType and PickUserGroupOrUserDynamicType, and use this option in WorkflowStepType ... This will suggest the current user in PickUserDynamicType	2024-10-15 11:31:25 +02:00
Julien Fastré	d283d62049	!fixup Automatically execute body renderer when posting an	2024-10-15 11:10:31 +02:00
Julien Fastré	6cd336922f	Fix error when denormalizing empty array for pick third party dynampic type	2024-10-15 11:09:17 +02:00
Julien Fastré	13dbbb6741	Fix race condition in ChillCollectionType ... In some dcase, the collection is not initialized when a showHide is launched before the collection is fully initialized.	2024-10-15 09:08:29 +02:00
Julien Fastré	1313b6f138	Automatically execute body renderer when posting an email in Chill ... + adaptation of services which already uses body renderer	2024-10-10 14:06:00 +02:00
Julien Fastré	3d53e7da65	Show the list of pending views in the workflows index page	2024-10-10 13:40:25 +02:00
Julien Fastré	8589bada3f	Layout for the email to external	2024-10-10 13:40:07 +02:00
Julien Fastré	292034d64d	Add public view rendering to workflow handler for AccompanyingPeriodWorkEvaluationDocument ... Implemented the `EntityWorkflowWithPublicViewInterface` in `AccompanyingPeriodWorkEvaluationDocumentWorkflowHandler`. Included the `renderPublicView` method using `WorkflowWithPublicViewDocumentHelper` for enhanced document handling.	2024-10-10 11:42:04 +02:00
Julien Fastré	3f7c5d23dc	Add return type hint to getTargets method ... The getTargets method now explicitly returns an array, enhancing type safety and readability. This change ensures that the return type is clear to any developers interacting with this method.	2024-10-10 11:41:25 +02:00
Julien Fastré	78445f0d65	fixup! Add message handling for public view creation	2024-10-10 11:39:04 +02:00
Julien Fastré	c329a1f1f8	fixup! Add message handling for public view creation	2024-10-10 09:39:45 +02:00
Julien Fastré	9d722110a6	fixup! Add direct download link feature with new button implementation	2024-10-09 21:39:55 +02:00
Julien Fastré	82e2b9a0f6	Add message handling for public view creation ... Introduce `PostPublicViewMessage` and `PostPublicViewMessageHandler` to handle external user views on public links by applying workflow transitions. Integrate with `WorkflowViewSendPublicController` and add relevant tests.	2024-10-09 21:39:27 +02:00
Julien Fastré	40b8fae8ba	Add vizualisation of public views in the workflow history	2024-10-08 16:17:11 +02:00
Julien Fastré	b99ea3b17a	!fixup Add direct download link feature	2024-10-08 16:16:10 +02:00
Julien Fastré	3f80d62ca2	Add public workflow view functionality ... Introduced the ability to render public views for workflows, including new templates, handlers, and metadata support. Updated entity interfaces and translations to enhance the public sharing of workflow documents.	2024-10-08 15:15:58 +02:00
Julien Fastré	118ae291e2	Add direct download link feature with new button implementation ... Introduce a new feature that allows for direct download links by integrating TempUrlGeneratorInterface. Added new DOWNLOAD_LINK_ONLY group and corresponding logic to generate download links in StoredObjectNormalizer. Implement a new Twig filter and Vue component for rendering the download button. Updated tests to cover the new functionality.	2024-10-08 15:15:38 +02:00
Julien Fastré	5c0f3cb317	Implement the controller action to view the EntityworkflowSend	2024-10-07 15:35:36 +02:00
Julien Fastré	a0b5c208eb	Send an email when a workflow is send to an external ... - create an event subscriber to catch the workflow which arrive to a "sentExternal" step; - add a messenger's message to handle the generation of the email; - add a simple message, and a simple controller for viewing the document - add dedicated tests	2024-10-04 13:52:18 +02:00
Julien Fastré	7913a377c8	Move the logic to check if dest users are required to a dedicated constraint ... - Create a dedicated constraint to check if the destUsers are required by the applied transition. - Apply on WorkflowTransitionContextDTO and, if required, use the built-in constraints - create tests	2024-10-04 13:41:20 +02:00
Julien Fastré	7cd638c5fc	Add TransitionHasDestineeIfIsSentExternal validator ... This commit introduces a new validator to ensure that transitions marked as 'sent' have a designated external recipient. It includes related tests for scenarios with and without recipients and covers integration with the workflow context.	2024-10-04 13:41:20 +02:00
Julien Fastré	071c5e3c55	Update the form to allow sending a workflow to an external destinee ... OP#734 Modification du formulaire pour permettre l'envoi d'un workflow https://champs-libres.openproject.com/work_packages/734	2024-10-04 13:41:20 +02:00
Julien Fastré	da6589ba87	Add ThirdPartyHasEmail validator ... Introduce a new validator that ensures a third party has an email address, including the corresponding translation for error messaging and unit tests to verify its functionality.	2024-10-04 13:41:19 +02:00
Julien Fastré	a563ba644e	clean the file from code in error	2024-10-04 13:41:19 +02:00
Julien Fastré	2213f6f429	Add EntityWorkflowSend and EntityWorkflowSendView entities ... Introduced EntityWorkflowSend and EntityWorkflowSendView entities to enable tracking of workflow content sent to external parties. Updated EntityWorkflowStep to associate with these entities and added a corresponding database migration script.	2024-10-04 13:41:19 +02:00
Julien Fastré	9a9d14eb5a	Enhance behaviour of duplicating storedObject to keep only the last "kept before conversion" version if any ... Enhance the duplication service to selectively handle versions tagged with "KEEP_BEFORE_CONVERSION". Modify StoredObject to support retrieval and checking of such versions. Add relevant test cases to validate this behavior.	2024-10-04 13:41:18 +02:00
Julien Fastré	4cc001a070	Enhance behaviour of duplicating storedObject to keep only the last "kept before conversion" version if any ... Enhance the duplication service to selectively handle versions tagged with "KEEP_BEFORE_CONVERSION". Modify StoredObject to support retrieval and checking of such versions. Add relevant test cases to validate this behavior.	2024-10-02 13:13:26 +02:00