Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

Merge branch 'issue214_fix_error_empty_comment' into 'master'

Browse Source 
Notification: avoid the comment's content to be null

Closes #214

See merge request Chill-Projet/chill-bundles!623
This commit is contained in:
Julien Fastré 2023-12-05 16:26:06 +00:00
commit fa3b305ab9
4 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/unreleased/Fixed-20231129-113458.yaml Normal file
View File

@ -0,0 +1,5 @@
kind: Fixed
body: Fix error when posting an empty comment on an accompanying period.
time: 2023-11-29T11:34:58.986983057+01:00
custom:
Issue: "214"

2
src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod/Comment.php
View File

@ -41,7 +41,7 @@ class Comment implements TrackCreationInterface, TrackUpdateInterface
private ?AccompanyingPeriod $accompanyingPeriod = null;
/**
* @ORM\Column(type="text")
* @ORM\Column(type="text", nullable=false, options={"default":""})
*
* @Groups({"read", "write", "docgen:read"})
*

1
src/Bundle/ChillPersonBundle/Form/AccompanyingCourseCommentType.php
View File

@ -26,6 +26,7 @@ class AccompanyingCourseCommentType extends AbstractType
{
$builder->add('content', ChillTextareaType::class, [
'required' => false,
'empty_data' => '',
]);
}

36
src/Bundle/ChillPersonBundle/migrations/Version20231128143534.php Normal file
View File

@ -0,0 +1,36 @@
<?php
declare(strict_types=1);
/*
* Chill is a software for social workers
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/
namespace Chill\Migrations\Person;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;
final class Version20231128143534 extends AbstractMigration
{
public function getDescription(): string
{
return 'Set a default for the content column of accompanying_period_comment';
}
public function up(Schema $schema): void
{
$this->addSql("UPDATE chill_person_accompanying_period_comment SET content='' WHERE content IS NULL");
$this->addSql('ALTER TABLE chill_person_accompanying_period_comment ALTER COLUMN content SET NOT NULL');
$this->addSql('ALTER TABLE chill_person_accompanying_period_comment ALTER COLUMN content SET DEFAULT \'\'');
}
public function down(Schema $schema): void
{
$this->addSql('ALTER TABLE chill_person_accompanying_period_comment ALTER COLUMN content DROP DEFAULT');
$this->addSql('ALTER TABLE chill_person_accompanying_period_comment ALTER COLUMN content DROP NOT NULL');
}
}