make test easier to read

This commit is contained in:
Julie Lenaerts 2023-09-29 08:51:14 +02:00
parent 0c5b35926b
commit b0a7612329

View File

@ -62,8 +62,8 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase
* @dataProvider dataProviderExclusionOnClosingMotive
*/
public function testExclusionOnClosingMotive(
AccompanyingPeriod $periodA, //canceled
AccompanyingPeriod $periodB, // not canceled
AccompanyingPeriod $periodA, //not canceled
AccompanyingPeriod $periodB, // canceled
AccompanyingPeriod $periodC // canceled (child cm of canceled cm)
): void {
$qb = $this->em->getRepository(AccompanyingPeriod::class)->createQueryBuilder('acp');
@ -77,8 +77,8 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase
$periodB = $this->em->find(AccompanyingPeriod::class, $periodB->getId());
$periodC = $this->em->find(AccompanyingPeriod::class, $periodC->getId());
self::assertContains($periodB->getId(), $periodIdsFound, 'Period without canceled closing motive has been found');
self::assertNotContains($periodA->getdId(), $periodIdsFound, 'Period with canceled closing motive has not been found');
self::assertContains($periodA->getId(), $periodIdsFound, 'Period without canceled closing motive has been found');
self::assertNotContains($periodB->getdId(), $periodIdsFound, 'Period with canceled closing motive has not been found');
self::assertNotContains($periodC->getId(), $periodIdsFound, 'Period with child canceled closing motive has not been found');
}
@ -87,13 +87,13 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase
$this->setUp();
$cmA = new ClosingMotive();
$cmA->setIsCanceledAccompanyingPeriod(true);
$cmA->setIsCanceledAccompanyingPeriod(false);
$cmB = new ClosingMotive();
$cmB->setIsCanceledAccompanyingPeriod(false);
$cmB->setIsCanceledAccompanyingPeriod(true);
$cmChild = new ClosingMotive();
$cmChild->setParent($cmA);
$cmChild->setParent($cmB);
$this->em->persist($cmA);
$this->em->persist($cmB);