From b0a7612329d43ab6c878016061518e02f0d669b9 Mon Sep 17 00:00:00 2001 From: Julie Lenaerts Date: Fri, 29 Sep 2023 08:51:14 +0200 Subject: [PATCH] make test easier to read --- .../Export/AccompanyingCourseExportHelperTest.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Bundle/ChillMainBundle/Tests/Export/AccompanyingCourseExportHelperTest.php b/src/Bundle/ChillMainBundle/Tests/Export/AccompanyingCourseExportHelperTest.php index bb124c4bb..1e10e4834 100644 --- a/src/Bundle/ChillMainBundle/Tests/Export/AccompanyingCourseExportHelperTest.php +++ b/src/Bundle/ChillMainBundle/Tests/Export/AccompanyingCourseExportHelperTest.php @@ -62,8 +62,8 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase * @dataProvider dataProviderExclusionOnClosingMotive */ public function testExclusionOnClosingMotive( - AccompanyingPeriod $periodA, //canceled - AccompanyingPeriod $periodB, // not canceled + AccompanyingPeriod $periodA, //not canceled + AccompanyingPeriod $periodB, // canceled AccompanyingPeriod $periodC // canceled (child cm of canceled cm) ): void { $qb = $this->em->getRepository(AccompanyingPeriod::class)->createQueryBuilder('acp'); @@ -77,8 +77,8 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase $periodB = $this->em->find(AccompanyingPeriod::class, $periodB->getId()); $periodC = $this->em->find(AccompanyingPeriod::class, $periodC->getId()); - self::assertContains($periodB->getId(), $periodIdsFound, 'Period without canceled closing motive has been found'); - self::assertNotContains($periodA->getdId(), $periodIdsFound, 'Period with canceled closing motive has not been found'); + self::assertContains($periodA->getId(), $periodIdsFound, 'Period without canceled closing motive has been found'); + self::assertNotContains($periodB->getdId(), $periodIdsFound, 'Period with canceled closing motive has not been found'); self::assertNotContains($periodC->getId(), $periodIdsFound, 'Period with child canceled closing motive has not been found'); } @@ -87,13 +87,13 @@ class AccompanyingCourseExportHelperTest extends KernelTestCase $this->setUp(); $cmA = new ClosingMotive(); - $cmA->setIsCanceledAccompanyingPeriod(true); + $cmA->setIsCanceledAccompanyingPeriod(false); $cmB = new ClosingMotive(); - $cmB->setIsCanceledAccompanyingPeriod(false); + $cmB->setIsCanceledAccompanyingPeriod(true); $cmChild = new ClosingMotive(); - $cmChild->setParent($cmA); + $cmChild->setParent($cmB); $this->em->persist($cmA); $this->em->persist($cmB);