Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-09-27 09:05:01 +00:00
Code Issues Actions Projects Releases Wiki Activity

Use readonly properties in constructors for better immutability.

Browse Source 
Converted constructor properties to readonly where applicable, ensuring immutability and promoting safer code practices. Updated throwable class reference for clarity and consistency.
This commit is contained in:
Julien Fastré
2025-04-05 00:56:54 +02:00
parent 1955249a60
commit aebeca1d7a
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Bundle/ChillMainBundle/Controller/ExportGenerationCreateFromSavedExportController.php
View File

@@ -28,11 +28,11 @@ use Symfony\Component\Serializer\SerializerInterface;
class ExportGenerationCreateFromSavedExportController class ExportGenerationCreateFromSavedExportController
{ {
public function __construct( public function __construct(
private Security $security, private readonly Security $security,
private EntityManagerInterface $entityManager, private readonly EntityManagerInterface $entityManager,
private MessageBusInterface $messageBus, private readonly MessageBusInterface $messageBus,
private ClockInterface $clock, private readonly ClockInterface $clock,
private SerializerInterface $serializer, private readonly SerializerInterface $serializer,
) {} ) {}
#[Route('/api/1.0/main/export/export-generation/create-from-saved-export/{id}', methods: ['POST'])] #[Route('/api/1.0/main/export/export-generation/create-from-saved-export/{id}', methods: ['POST'])]

8
src/Bundle/ChillMainBundle/Export/Messenger/OnExportGenerationFails.php
View File

@@ -24,9 +24,9 @@ class OnExportGenerationFails implements EventSubscriberInterface
private const LOG_PREFIX = '[export_generation failed] '; private const LOG_PREFIX = '[export_generation failed] ';
public function __construct( public function __construct(
private LoggerInterface $logger, private readonly LoggerInterface $logger,
private ExportGenerationRepository $repository, private readonly ExportGenerationRepository $repository,
private EntityManagerInterface $entityManager, private readonly EntityManagerInterface $entityManager,
) {} ) {}
public static function getSubscribedEvents() public static function getSubscribedEvents()
@@ -58,7 +58,7 @@ class OnExportGenerationFails implements EventSubscriberInterface
'alias' => $exportGeneration->getExportAlias(), 'alias' => $exportGeneration->getExportAlias(),
'throwable_message' => $event->getThrowable()->getMessage(), 'throwable_message' => $event->getThrowable()->getMessage(),
'throwable_trace' => $event->getThrowable()->getTraceAsString(), 'throwable_trace' => $event->getThrowable()->getTraceAsString(),
'throwable' => get_class($event->getThrowable()), 'throwable' => $event->getThrowable()::class,
'full_generation_duration_failure' => microtime(true) - $exportGeneration->getCreatedAt()->getTimestamp(), 'full_generation_duration_failure' => microtime(true) - $exportGeneration->getCreatedAt()->getTimestamp(),
]); ]);