Apply 3 suggestion(s) to 3 file(s)

This commit is contained in:
Julien Fastré 2023-10-16 15:42:55 +00:00
parent ada28265ee
commit 444f37ad18
3 changed files with 4 additions and 5 deletions

View File

@ -1,6 +1,6 @@
kind: Feature kind: Feature
body: Allow closing motives to be identified as 'canceling the accompanying period' body: Allow closing motives to be identified as 'canceling the accompanying period'
+ don't take canceled accompanying periods into account + don't take canceled accompanying periods into account in exports
time: 2023-10-04T12:08:57.586865276+02:00 time: 2023-10-04T12:08:57.586865276+02:00
custom: custom:
Issue: "146" Issue: "146"

View File

@ -17,11 +17,11 @@ final readonly class AccompanyingCourseExportHelper
{ {
public static function addClosingMotiveExclusionClause(QueryBuilder $qb): QueryBuilder public static function addClosingMotiveExclusionClause(QueryBuilder $qb): QueryBuilder
{ {
$qb->leftJoin('acp.closingMotive', 'cm') $qb->leftJoin('acp.closingMotive', 'acpmotive')
->andWhere( ->andWhere(
$qb->expr()->orX( $qb->expr()->orX(
$qb->expr()->eq('cm.isCanceledAccompanyingPeriod', 'false'), $qb->expr()->eq('acpmotive.isCanceledAccompanyingPeriod', 'false'),
$qb->expr()->isNull('acp.closingMotive') $qb->expr()->isNull('acpmotive.closingMotive')
) )
); );

View File

@ -53,4 +53,3 @@ services:
tags: tags:
- { name: chill.export_formatter, alias: 'csv_pivoted_list' } - { name: chill.export_formatter, alias: 'csv_pivoted_list' }
Chill\MainBundle\Export\AccompanyingCourseExportHelper: ~