mirror of
https://gitlab.com/Chill-Projet/chill-bundles.git
synced 2025-06-07 18:44:08 +00:00
Julien Fastré
b6c58a5c31
* fix center resolver dispatcher * add scope resolver * tests for authorization helper
566 lines
21 KiB
PHP
566 lines
21 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (C) 2015 Julien Fastré <julien.fastre@champs-libres.coop>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
namespace Chill\MainBundle\Tests\Security\Authorization;
|
|
|
|
use Chill\MainBundle\Entity\HasCenterInterface;
|
|
use Chill\MainBundle\Entity\HasCentersInterface;
|
|
use Chill\MainBundle\Entity\HasScopeInterface;
|
|
use Chill\MainBundle\Entity\HasScopesInterface;
|
|
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
|
|
use Chill\MainBundle\Test\PrepareUserTrait;
|
|
use Chill\MainBundle\Test\PrepareCenterTrait;
|
|
use Chill\MainBundle\Test\PrepareScopeTrait;
|
|
use Chill\MainBundle\Test\ProphecyTrait;
|
|
use Chill\MainBundle\Entity\User;
|
|
use Symfony\Component\Security\Core\Role\Role;
|
|
use Chill\MainBundle\Entity\Scope;
|
|
use Chill\MainBundle\Entity\Center;
|
|
|
|
/**
|
|
*
|
|
*
|
|
* @author Julien Fastré <julien.fastre@champs-libres.coop>
|
|
*/
|
|
class AuthorizationHelperTest extends KernelTestCase
|
|
{
|
|
|
|
use PrepareUserTrait, PrepareCenterTrait, PrepareScopeTrait, ProphecyTrait;
|
|
|
|
public function setUp()
|
|
{
|
|
static::bootKernel();
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @return \Chill\MainBundle\Security\Authorization\AuthorizationHelper
|
|
*/
|
|
private function getAuthorizationHelper()
|
|
{
|
|
return static::$container
|
|
->get('chill.main.security.authorization.helper')
|
|
;
|
|
}
|
|
|
|
/**
|
|
* Test function userCanReach of helper.
|
|
*
|
|
* A user can reach center => the function should return true.
|
|
*/
|
|
public function testUserCanReachCenter_UserShouldReach()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'ANY_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
|
|
$this->assertTrue($helper->userCanReachCenter($user, $center));
|
|
}
|
|
|
|
/**
|
|
* Test function userCanReach of helper
|
|
*
|
|
* A user can not reachcenter =>W the function should return false
|
|
*/
|
|
public function testUserCanReachCenter_UserShouldNotReach()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(2, 'centerB');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'ANY_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
|
|
$this->assertFalse($helper->userCanReachCenter($user, $centerB));
|
|
|
|
}
|
|
|
|
public function testUserHasAccess_shouldHaveAccess_EntityWithoutScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->getCenter()->willReturn($center);
|
|
|
|
$this->assertTrue($helper->userHasAccess($user, $entity->reveal(),
|
|
'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_ShouldHaveAccessWithInheritance_EntityWithoutScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'CHILL_MASTER_ROLE']
|
|
)
|
|
)
|
|
));
|
|
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->getCenter()->willReturn($center);
|
|
|
|
$this->assertTrue($helper->userHasAccess($user, $entity->reveal(),
|
|
'CHILL_INHERITED_ROLE_1'));
|
|
}
|
|
|
|
|
|
public function testuserHasAccess_UserHasNoRole_EntityWithoutScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'ANY_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->getCenter()->willReturn($center);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
/**
|
|
* test that a user has no access on a entity, but is granted on the same role
|
|
* on another center
|
|
*/
|
|
public function testUserHasAccess_userHasNoRole_UserHasRoleOnAnotherCenter_EntityWithoutScope()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(2, 'centerB');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'ANY_ROLE']
|
|
),
|
|
array(
|
|
'centerB' => $centerB, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'ANY_ROLE'],
|
|
['scope' => $scope, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->getCenter()->willReturn($centerA);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testtestUserHasAccess_UserShouldHaveAccess_EntityWithScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasScopeInterface');
|
|
$entity->getCenter()->willReturn($center);
|
|
$entity->getScope()->willReturn($scope);
|
|
|
|
$this->assertTrue($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_UserHasNoRole_EntityWithScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasScopeInterface');
|
|
$entity->getCenter()->willReturn($center);
|
|
$entity->getScope()->willReturn($scope);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'ANOTHER_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_UserHasNoCenter_EntityWithScope()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center'); //the user will have this center
|
|
$centerB = $this->prepareCenter(2, 'centerB'); //the entity will have another center
|
|
$scope = $this->prepareScope(1, 'default');
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA, 'permissionsGroup' => array(
|
|
['scope' => $scope, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasCenterInterface');
|
|
$entity->willImplement('\Chill\MainBundle\Entity\HasScopeInterface');
|
|
$entity->getCenter()->willReturn($centerB);
|
|
$entity->getScope()->willReturn($scope);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_UserHasNoScope_EntityWithScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$scopeA = $this->prepareScope(1, 'default'); //the entity will have this scope
|
|
$scopeB = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement(HasCenterInterface::class);
|
|
$entity->willImplement(HasScopeInterface::class);
|
|
$entity->getCenter()->willReturn($center);
|
|
$entity->getScope()->willReturn($scopeA);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_MultiCenter_EntityWithoutScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(1, 'centerB');
|
|
$scopeB = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement(HasCentersInterface::class);
|
|
$entity->getCenters()->willReturn([$center, $centerB]);
|
|
|
|
$this->assertTrue($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasNoAccess_MultiCenter_EntityWithoutScope()
|
|
{
|
|
$center = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(1, 'centerB');
|
|
$centerC = $this->prepareCenter(1, 'centerC');
|
|
$scopeB = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $center, 'permissionsGroup' => array(
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement(HasCentersInterface::class);
|
|
$entity->getCenters()->willReturn([$centerB, $centerC]);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasNoAccess_EntityMultiScope()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(1, 'centerB');
|
|
$scopeA = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$scopeB = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$scopeC = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA, 'permissionsGroup' => array(
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement(HasCentersInterface::class);
|
|
$entity->willImplement(HasScopesInterface::class);
|
|
$entity->getCenters()->willReturn([$centerA, $centerB]);
|
|
$entity->getScopes()->willReturn([$scopeB, $scopeC]);
|
|
|
|
$this->assertFalse($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
public function testUserHasAccess_EntityMultiScope()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center');
|
|
$centerB = $this->prepareCenter(1, 'centerB');
|
|
$scopeA = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$scopeB = $this->prepareScope(2, 'other'); //the user will be granted this scope
|
|
$user = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA, 'permissionsGroup' => array(
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE']
|
|
)
|
|
)
|
|
));
|
|
$helper = $this->getAuthorizationHelper();
|
|
$entity = $this->getProphet()->prophesize();
|
|
$entity->willImplement(HasCentersInterface::class);
|
|
$entity->willImplement(HasScopesInterface::class);
|
|
$entity->getCenters()->willReturn([$centerA, $centerB]);
|
|
$entity->getScopes()->willReturn([$scopeA, $scopeB]);
|
|
|
|
$this->assertTrue($helper->userHasAccess($user, $entity->reveal(), 'CHILL_ROLE'));
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
*
|
|
* @dataProvider dataProvider_getReachableCenters
|
|
* @param Center $shouldHaveCenter
|
|
* @param User $user
|
|
* @param Role $role
|
|
* @param Scope $scope
|
|
*/
|
|
public function testGetReachableCenters($test, $result, $msg)
|
|
{
|
|
$this->assertEquals($test, $result, $msg);
|
|
}
|
|
|
|
public function dataProvider_getReachableCenters()
|
|
{
|
|
$this->setUp();
|
|
$centerA = $this->prepareCenter(1, 'center A');
|
|
$centerB = $this->prepareCenter(2, 'center B');
|
|
$scopeA = $this->prepareScope(1, 'scope default');
|
|
$scopeB = $this->prepareScope(2, 'scope B');
|
|
$scopeC = $this->prepareScope(3, 'scope C');
|
|
|
|
$userA = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA,
|
|
'permissionsGroup' => array(
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE_1'],
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE_2']
|
|
)
|
|
),
|
|
array(
|
|
'center' => $centerB,
|
|
'permissionsGroup' => array(
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE_2'],
|
|
['scope' => $scopeC, 'role' => 'CHILL_ROLE_2']
|
|
)
|
|
)
|
|
|
|
));
|
|
|
|
$ah = $this->getAuthorizationHelper();
|
|
|
|
return array(
|
|
// without scopes
|
|
array(
|
|
true,
|
|
in_array($centerA, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_1'), null)),
|
|
'center A should be available for userA, with role 1 '
|
|
),
|
|
array(
|
|
true,
|
|
in_array($centerA, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_2'), null)),
|
|
'center A should be available for userA, with role 2 '
|
|
),
|
|
array(
|
|
true,
|
|
in_array($centerB, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_2'), null)),
|
|
'center A should be available for userA, with role 2 '
|
|
),
|
|
array(
|
|
false,
|
|
in_array($centerB, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_1'), null)),
|
|
'center B should NOT be available for userA, with role 1 '
|
|
),
|
|
// with scope
|
|
array(
|
|
true,
|
|
in_array($centerA, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_1'), $scopeB)),
|
|
'center A should be available for userA, with role 1, scopeC '
|
|
),
|
|
array(
|
|
false,
|
|
in_array($centerA, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_2'), $scopeC)),
|
|
'center A should NOT be available for userA, with role 2, scopeA '
|
|
),
|
|
array(
|
|
true,
|
|
in_array($centerB, $ah->getReachableCenters($userA,
|
|
new Role('CHILL_ROLE_2'), $scopeA)),
|
|
'center B should be available for userA, with role 2, scopeA '
|
|
),
|
|
);
|
|
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @dataProvider dataProvider_getReachableScopes
|
|
* @param boolean $expectedResult
|
|
* @param Scope $testedScope
|
|
* @param User $user
|
|
* @param Role $role
|
|
* @param Center $center
|
|
* @param string $message
|
|
*/
|
|
public function testGetReachableScopes($expectedResult, Scope $testedScope,
|
|
User $user, Role $role, Center $center, $message)
|
|
{
|
|
$reachableScopes = $this->getAuthorizationHelper()
|
|
->getReachableScopes($user, $role, $center);
|
|
|
|
$this->assertEquals($expectedResult, in_array($testedScope, $reachableScopes),
|
|
$message);
|
|
}
|
|
|
|
public function dataProvider_getReachableScopes()
|
|
{
|
|
$centerA = $this->prepareCenter(1, 'center A');
|
|
$centerB = $this->prepareCenter(2, 'center B');
|
|
$scopeA = $this->prepareScope(1, 'scope default');
|
|
$scopeB = $this->prepareScope(2, 'scope B');
|
|
$scopeC = $this->prepareScope(3, 'scope C');
|
|
|
|
$userA = $this->prepareUser(array(
|
|
array(
|
|
'center' => $centerA,
|
|
'permissionsGroup' => array(
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE_1'],
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE_2']
|
|
)
|
|
),
|
|
array(
|
|
'center' => $centerB,
|
|
'permissionsGroup' => array(
|
|
['scope' => $scopeA, 'role' => 'CHILL_ROLE_2'],
|
|
['scope' => $scopeC, 'role' => 'CHILL_ROLE_2'],
|
|
['scope' => $scopeB, 'role' => 'CHILL_ROLE_2']
|
|
)
|
|
)
|
|
|
|
));
|
|
|
|
return array(
|
|
array(
|
|
true,
|
|
$scopeA,
|
|
$userA,
|
|
new Role('CHILL_ROLE_2'),
|
|
$centerA,
|
|
"Assert that a scope is found within accessible scopes"
|
|
),
|
|
array(
|
|
false,
|
|
$scopeB,
|
|
$userA,
|
|
new Role('CHILL_ROLE_2'),
|
|
$centerA,
|
|
"Assert that a scope not reachable is NOT found within accessible scopes"
|
|
),
|
|
array(
|
|
false,
|
|
$scopeB,
|
|
$userA,
|
|
new Role('CHILL_ROLE_1'),
|
|
$centerB,
|
|
"Assert that a scope not reachable is not found within accessible scopes."
|
|
. " Trying on filter centering"
|
|
)
|
|
);
|
|
}
|
|
|
|
public function testGetParentRoles()
|
|
{
|
|
$parentRoles = $this->getAuthorizationHelper()
|
|
->getParentRoles('CHILL_INHERITED_ROLE_1');
|
|
|
|
$this->assertContains('CHILL_MASTER_ROLE', $parentRoles,
|
|
"Assert that `CHILL_MASTER_ROLE` is a parent of `CHILL_INHERITED_ROLE_1`");
|
|
}
|
|
|
|
public function testFindUsersReaching()
|
|
{
|
|
$centerA = static::$kernel->getContainer()
|
|
->get('doctrine.orm.entity_manager')
|
|
->getRepository(Center::class)
|
|
->findOneByName('Center A');
|
|
|
|
$users = $this->getAuthorizationHelper()
|
|
->findUsersReaching(new Role('CHILL_PERSON_SEE'),
|
|
$centerA);
|
|
|
|
$usernames = \array_map(function(User $u) { return $u->getUsername(); }, $users);
|
|
|
|
$this->assertContains('center a_social', $usernames);
|
|
}
|
|
|
|
}
|