Compare commits

..

18 Commits

Author SHA1 Message Date
b2aa465b03 unreleased changie file deleted 2023-10-26 17:44:49 +02:00
0fa8944c29 Update changelog 2023-10-26 17:39:55 +02:00
7494dbfc7c changie made 2023-10-26 17:38:22 +02:00
642958bde2 Merge branch 'master' of gitlab.com:Chill-Projet/chill-bundles 2023-10-26 17:35:22 +02:00
57bd6d1be4 remove dump 2023-10-26 17:33:39 +02:00
bbcbbf078f remove dump 2023-10-26 17:04:56 +02:00
ba778b1cf8 update changelog 2023-10-26 16:07:34 +02:00
728fd642fa Merge branch 'replace_translator' 2023-10-26 16:05:17 +02:00
4150eb56b4 changie v2.10.2 2023-10-26 15:23:01 +02:00
2927561c02 added changie 2023-10-26 15:22:22 +02:00
5188891108 php style fixer 2023-10-26 15:21:20 +02:00
c6deb21606 replace old method of getting translator with injection of translatorInterface 2023-10-26 15:20:19 +02:00
cdfb084fe4 update changelog 2023-10-26 14:17:15 +02:00
5ce21aadce Merge branch 'master' of gitlab.com:Chill-Projet/chill-bundles 2023-10-26 14:14:51 +02:00
b9000a38d3 add changie 2023-10-26 14:14:36 +02:00
89a185a34f replace get->('translator') with injection of translatorInterface 2023-10-26 14:13:12 +02:00
bc6c3a1089 Release: 2.10.1 2023-10-24 20:52:46 +02:00
2c50f484f0 Fix export controller when generating an export without any data in session 2023-10-24 20:46:23 +02:00
16 changed files with 98 additions and 101 deletions

3
.changes/v2.10.1.md Normal file
View File

@@ -0,0 +1,3 @@
## v2.10.1 - 2023-10-24
### Fixed
* Fix export controller when generating an export without any data in session

3
.changes/v2.10.2.md Normal file
View File

@@ -0,0 +1,3 @@
## v2.10.2 - 2023-10-26
### Fixed
* ([#175](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/175)) Use injection of translator instead of ->get().

3
.changes/v2.10.3.md Normal file
View File

@@ -0,0 +1,3 @@
## v2.10.3 - 2023-10-26
### Fixed
* ([#175](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/175)) Replace old method of getting translator with injection of translatorInterface

3
.changes/v2.10.4.md Normal file
View File

@@ -0,0 +1,3 @@
## v2.10.4 - 2023-10-26
### Fixed
* Fix null value constraint errors when merging relationships in doubles

View File

@@ -6,6 +6,22 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html),
and is generated by [Changie](https://github.com/miniscruff/changie). and is generated by [Changie](https://github.com/miniscruff/changie).
## v2.10.4 - 2023-10-26
### Fixed
* Fix null value constraint errors when merging relationships in doubles
## v2.10.3 - 2023-10-26
### Fixed
* ([#175](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/175)) Replace old method of getting translator with injection of translatorInterface
## v2.10.2 - 2023-10-26
### Fixed
* ([#175](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/175)) Use injection of translator instead of ->get().
## v2.10.1 - 2023-10-24
### Fixed
* Fix export controller when generating an export without any data in session
## v2.10.0 - 2023-10-24 ## v2.10.0 - 2023-10-24
### Feature ### Feature
* ([#172](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/172)) [export] Add a filter "grouping accompanying period by opening date" and "grouping accompanying period by closing date" * ([#172](https://gitlab.com/Chill-Projet/chill-bundles/-/issues/172)) [export] Add a filter "grouping accompanying period by opening date" and "grouping accompanying period by closing date"

View File

@@ -18,12 +18,15 @@ use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\Form\Extension\Core\Type\SubmitType; use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\Routing\Annotation\Route;
use Symfony\Contracts\Translation\TranslatorInterface;
/** /**
* Class CustomFieldController. * Class CustomFieldController.
*/ */
class CustomFieldController extends AbstractController class CustomFieldController extends AbstractController
{ {
public function __construct(private readonly TranslatorInterface $translator) {}
/** /**
* Creates a new CustomField entity. * Creates a new CustomField entity.
* *
@@ -40,13 +43,13 @@ class CustomFieldController extends AbstractController
$em->persist($entity); $em->persist($entity);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The custom field has been created')); ->trans('The custom field has been created'));
return $this->redirectToRoute('customfieldsgroup_show', ['id' => $entity->getCustomFieldsGroup()->getId()]); return $this->redirectToRoute('customfieldsgroup_show', ['id' => $entity->getCustomFieldsGroup()->getId()]);
} }
$this->addFlash('error', $this->get('translator') $this->addFlash('error', $this->translator
->trans('The custom field form contains errors')); ->trans('The custom field form contains errors'));
return $this->render('@ChillCustomFields/CustomField/new.html.twig', [ return $this->render('@ChillCustomFields/CustomField/new.html.twig', [
@@ -130,13 +133,13 @@ class CustomFieldController extends AbstractController
if ($editForm->isSubmitted() && $editForm->isValid()) { if ($editForm->isSubmitted() && $editForm->isValid()) {
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The custom field has been updated')); ->trans('The custom field has been updated'));
return $this->redirectToRoute('customfield_edit', ['id' => $id]); return $this->redirectToRoute('customfield_edit', ['id' => $id]);
} }
$this->addFlash('error', $this->get('translator') $this->addFlash('error', $this->translator
->trans('The custom field form contains errors')); ->trans('The custom field form contains errors'));
return $this->render('@ChillCustomFields/CustomField/edit.html.twig', [ return $this->render('@ChillCustomFields/CustomField/edit.html.twig', [

View File

@@ -118,7 +118,7 @@ class EventController extends AbstractController
$this->addFlash( $this->addFlash(
'success', 'success',
$this->get('translator') $this->translator
->trans('The event has been sucessfully removed') ->trans('The event has been sucessfully removed')
); );
@@ -249,7 +249,7 @@ class EventController extends AbstractController
$em->persist($entity); $em->persist($entity);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The event was created')); ->trans('The event was created'));
return $this->redirectToRoute('chill_event__event_show', ['event_id' => $entity->getId()]); return $this->redirectToRoute('chill_event__event_show', ['event_id' => $entity->getId()]);
@@ -364,7 +364,7 @@ class EventController extends AbstractController
if ($editForm->isValid()) { if ($editForm->isValid()) {
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The event was updated')); ->trans('The event was updated'));
return $this->redirectToRoute('chill_event__event_edit', ['event_id' => $event_id]); return $this->redirectToRoute('chill_event__event_edit', ['event_id' => $event_id]);

View File

@@ -23,6 +23,7 @@ use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\FormInterface; use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Contracts\Translation\TranslatorInterface;
/** /**
* Class ParticipationController. * Class ParticipationController.
@@ -32,7 +33,7 @@ class ParticipationController extends AbstractController
/** /**
* ParticipationController constructor. * ParticipationController constructor.
*/ */
public function __construct(private readonly LoggerInterface $logger) {} public function __construct(private readonly LoggerInterface $logger, private readonly TranslatorInterface $translator) {}
/** /**
* @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/event/participation/create", name="chill_event_participation_create") * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/event/participation/create", name="chill_event_participation_create")
@@ -177,7 +178,7 @@ class ParticipationController extends AbstractController
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The participations were created' 'The participations were created'
)); ));
@@ -211,7 +212,7 @@ class ParticipationController extends AbstractController
$em->persist($participation); $em->persist($participation);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The participation was created' 'The participation was created'
)); ));
@@ -260,7 +261,7 @@ class ParticipationController extends AbstractController
$this->addFlash( $this->addFlash(
'success', 'success',
$this->get('translator') $this->translator
->trans('The participation has been sucessfully removed') ->trans('The participation has been sucessfully removed')
); );
@@ -340,7 +341,7 @@ class ParticipationController extends AbstractController
switch ($event->getParticipations()->count()) { switch ($event->getParticipations()->count()) {
case 0: case 0:
// if there aren't any participation, redirect to the 'show' view with an add flash // if there aren't any participation, redirect to the 'show' view with an add flash
$this->addFlash('warning', $this->get('translator') $this->addFlash('warning', $this->translator
->trans('There are no participation to edit for this event')); ->trans('There are no participation to edit for this event'));
return $this->redirectToRoute( return $this->redirectToRoute(
@@ -434,7 +435,7 @@ class ParticipationController extends AbstractController
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The participation was updated' 'The participation was updated'
)); ));
@@ -480,7 +481,7 @@ class ParticipationController extends AbstractController
if ($form->isSubmitted() && $form->isValid()) { if ($form->isSubmitted() && $form->isValid()) {
$this->getDoctrine()->getManager()->flush(); $this->getDoctrine()->getManager()->flush();
$this->addFlash('success', $this->get('translator')->trans('The participations ' $this->addFlash('success', $this->translator->trans('The participations '
.'have been successfully updated.')); .'have been successfully updated.'));
return $this->redirectToRoute( return $this->redirectToRoute(
@@ -652,7 +653,7 @@ class ParticipationController extends AbstractController
if ([] === $newParticipations) { if ([] === $newParticipations) {
// if we do not have nay participants, redirect to event view // if we do not have nay participants, redirect to event view
$this->addFlash('error', $this->get('translator')->trans( $this->addFlash('error', $this->translator->trans(
'None of the requested people may participate ' 'None of the requested people may participate '
.'the event: they are maybe already participating.' .'the event: they are maybe already participating.'
)); ));

View File

@@ -281,7 +281,7 @@ class ExportController extends AbstractController
$options = match ($step) { $options = match ($step) {
'export', 'generate_export' => [ 'export', 'generate_export' => [
'export_alias' => $alias, 'export_alias' => $alias,
'picked_centers' => $exportManager->getPickedCenters($data['centers']), 'picked_centers' => $exportManager->getPickedCenters($data['centers'] ?? []),
], ],
'formatter', 'generate_formatter' => [ 'formatter', 'generate_formatter' => [
'export_alias' => $alias, 'export_alias' => $alias,
@@ -339,9 +339,9 @@ class ExportController extends AbstractController
$exportManager = $this->exportManager; $exportManager = $this->exportManager;
// check we have data from the previous step (export step) // check we have data from the previous step (export step)
$data = $this->session->get('centers_step', null); $data = $this->session->get('centers_step', []);
if (null === $data) { if (null === $data && true === $this->filterStatsByCenters) {
return $this->redirectToRoute('chill_main_export_new', [ return $this->redirectToRoute('chill_main_export_new', [
'step' => $this->getNextStep('export', $export, true), 'step' => $this->getNextStep('export', $export, true),
'alias' => $alias, 'alias' => $alias,

View File

@@ -32,12 +32,13 @@ use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface; use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface; use Symfony\Component\Validator\Validator\ValidatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
class UserController extends CRUDController class UserController extends CRUDController
{ {
final public const FORM_GROUP_CENTER_COMPOSED = 'composed_groupcenter'; final public const FORM_GROUP_CENTER_COMPOSED = 'composed_groupcenter';
public function __construct(private readonly LoggerInterface $logger, private readonly ValidatorInterface $validator, private readonly UserPasswordEncoderInterface $passwordEncoder, private readonly UserRepository $userRepository, protected ParameterBagInterface $parameterBag) {} public function __construct(private readonly LoggerInterface $logger, private readonly ValidatorInterface $validator, private readonly UserPasswordEncoderInterface $passwordEncoder, private readonly UserRepository $userRepository, protected ParameterBagInterface $parameterBag, private readonly TranslatorInterface $translator) {}
/** /**
* @Route("/{_locale}/admin/main/user/{uid}/add_link_groupcenter", * @Route("/{_locale}/admin/main/user/{uid}/add_link_groupcenter",
@@ -65,7 +66,7 @@ class UserController extends CRUDController
if (0 === $this->validator->validate($user)->count()) { if (0 === $this->validator->validate($user)->count()) {
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans('The ' $this->addFlash('success', $this->translator->trans('The '
.'permissions have been successfully added to the user')); .'permissions have been successfully added to the user'));
$returnPathParams = $request->query->has('returnPath') ? $returnPathParams = $request->query->has('returnPath') ?
@@ -115,14 +116,14 @@ class UserController extends CRUDController
try { try {
$user->removeGroupCenter($groupCenter); $user->removeGroupCenter($groupCenter);
} catch (\RuntimeException $ex) { } catch (\RuntimeException $ex) {
$this->addFlash('error', $this->get('translator')->trans($ex->getMessage())); $this->addFlash('error', $this->translator->trans($ex->getMessage()));
return $this->redirectToRoute('chill_crud_admin_user_edit', ['id' => $uid]); return $this->redirectToRoute('chill_crud_admin_user_edit', ['id' => $uid]);
} }
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The permissions where removed.')); ->trans('The permissions where removed.'));
return $this->redirectToRoute('chill_crud_admin_user_edit', ['id' => $uid]); return $this->redirectToRoute('chill_crud_admin_user_edit', ['id' => $uid]);
@@ -207,7 +208,7 @@ class UserController extends CRUDController
$user->setCurrentLocation($currentLocation); $user->setCurrentLocation($currentLocation);
$this->getDoctrine()->getManager()->flush(); $this->getDoctrine()->getManager()->flush();
$this->addFlash('success', $this->get('translator')->trans('Current location successfully updated')); $this->addFlash('success', $this->translator->trans('Current location successfully updated'));
return $this->redirect( return $this->redirect(
$request->query->has('returnPath') ? $request->query->get('returnPath') : $request->query->has('returnPath') ? $request->query->get('returnPath') :
@@ -243,7 +244,7 @@ class UserController extends CRUDController
$user->setPassword($this->passwordEncoder->encodePassword($user, $password)); $user->setPassword($this->passwordEncoder->encodePassword($user, $password));
$this->getDoctrine()->getManager()->flush(); $this->getDoctrine()->getManager()->flush();
$this->addFlash('success', $this->get('translator')->trans('Password successfully updated!')); $this->addFlash('success', $this->translator->trans('Password successfully updated!'));
return $this->redirect( return $this->redirect(
$request->query->has('returnPath') ? $request->query->get('returnPath') : $request->query->has('returnPath') ? $request->query->get('returnPath') :

View File

@@ -25,8 +25,8 @@ class PersonMoveRelationHandler implements PersonMoveSqlHandlerInterface
public function getSqls(string $className, string $field, Person $from, Person $to): array public function getSqls(string $className, string $field, Person $from, Person $to): array
{ {
$insertSql = sprintf(<<<'SQL' $insertSql = sprintf(<<<'SQL'
INSERT INTO chill_person_relationships (id, relation_id, reverse, fromperson_id, toperson_id) INSERT INTO chill_person_relationships (id, relation_id, reverse, createdat, createdby_id, fromperson_id, toperson_id)
SELECT nextval('chill_person_relationships_id_seq'), relation_id, reverse, fromperson_id, toperson_id SELECT nextval('chill_person_relationships_id_seq'), relation_id, reverse, createdat, createdby_id, fromperson_id, toperson_id
FROM chill_person_relationships cpr FROM chill_person_relationships cpr
WHERE fromperson_id = %d OR toperson_id = %d WHERE fromperson_id = %d OR toperson_id = %d
AND NOT EXISTS ( AND NOT EXISTS (

View File

@@ -113,7 +113,7 @@ class AccompanyingCourseController extends \Symfony\Bundle\FrameworkBundle\Contr
$em->remove($accompanyingCourse); $em->remove($accompanyingCourse);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The accompanying course has been successfully removed.')); ->trans('The accompanying course has been successfully removed.'));
if (null !== $person_id) { if (null !== $person_id) {

View File

@@ -26,6 +26,7 @@ use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Validator\ConstraintViolationListInterface; use Symfony\Component\Validator\ConstraintViolationListInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface; use Symfony\Component\Validator\Validator\ValidatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
use function array_filter; use function array_filter;
/** /**
@@ -33,24 +34,12 @@ use function array_filter;
*/ */
class AccompanyingPeriodController extends AbstractController class AccompanyingPeriodController extends AbstractController
{ {
/**
* @var EventDispatcherInterface
*/
protected $eventDispatcher;
/**
* @var ValidatorInterface
*/
protected $validator;
public function __construct( public function __construct(
protected AccompanyingPeriodACLAwareRepositoryInterface $accompanyingPeriodACLAwareRepository, protected AccompanyingPeriodACLAwareRepositoryInterface $accompanyingPeriodACLAwareRepository,
EventDispatcherInterface $eventDispatcher, private readonly EventDispatcherInterface $eventDispatcher,
ValidatorInterface $validator private readonly ValidatorInterface $validator,
) { private readonly TranslatorInterface $translator
$this->eventDispatcher = $eventDispatcher; ) {}
$this->validator = $validator;
}
/** /**
* @throws \Exception * @throws \Exception
@@ -65,7 +54,7 @@ class AccompanyingPeriodController extends AbstractController
if (false === $person->isOpen()) { if (false === $person->isOpen()) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans( ->trans(
'Beware period is closed', 'Beware period is closed',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@@ -92,7 +81,7 @@ class AccompanyingPeriodController extends AbstractController
if (0 === \count($errors)) { if (0 === \count($errors)) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('success', $this->get('translator') ->add('success', $this->translator
->trans('An accompanying period has been closed.', [ ->trans('An accompanying period has been closed.', [
'%name%' => $person->__toString(), '%name%' => $person->__toString(),
])); ]));
@@ -104,7 +93,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans('Error! Period not closed!')); ->trans('Error! Period not closed!'));
foreach ($errors as $error) { foreach ($errors as $error) {
@@ -115,7 +104,7 @@ class AccompanyingPeriodController extends AbstractController
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add( ->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('Pediod closing form is not valid') ->trans('Pediod closing form is not valid')
); );
@@ -175,7 +164,7 @@ class AccompanyingPeriodController extends AbstractController
$em->flush(); $em->flush();
$flashBag->add( $flashBag->add(
'success', 'success',
$this->get('translator')->trans( $this->translator->trans(
'A period has been created.' 'A period has been created.'
) )
); );
@@ -184,7 +173,7 @@ class AccompanyingPeriodController extends AbstractController
'person_id' => $person->getId(), 'person_id' => $person->getId(),
]); ]);
} }
$flashBag->add('error', $this->get('translator') $flashBag->add('error', $this->translator
->trans('Error! Period not created!')); ->trans('Error! Period not created!'));
foreach ($errors as $error) { foreach ($errors as $error) {
@@ -244,7 +233,7 @@ class AccompanyingPeriodController extends AbstractController
// in case the person is already open // in case the person is already open
if ($person->isOpen()) { if ($person->isOpen()) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans( ->trans(
'Error! Period %name% is not closed ; it can be open', 'Error! Period %name% is not closed ; it can be open',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@@ -276,7 +265,7 @@ class AccompanyingPeriodController extends AbstractController
if (\count($errors) <= 0) { if (\count($errors) <= 0) {
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('success', $this->get('translator') ->add('success', $this->translator
->trans( ->trans(
'An accompanying period has been opened.', 'An accompanying period has been opened.',
['%name%' => $person->__toString()] ['%name%' => $person->__toString()]
@@ -289,7 +278,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add('error', $this->get('translator') ->add('error', $this->translator
->trans('Period not opened')); ->trans('Period not opened'));
foreach ($errors as $error) { foreach ($errors as $error) {
@@ -300,7 +289,7 @@ class AccompanyingPeriodController extends AbstractController
$this->get('session')->getFlashBag() $this->get('session')->getFlashBag()
->add( ->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('Period not opened : form is invalid') ->trans('Period not opened : form is invalid')
); );
} }
@@ -340,7 +329,7 @@ class AccompanyingPeriodController extends AbstractController
$this->getDoctrine()->getManager()->flush(); $this->getDoctrine()->getManager()->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The period has been re-opened' 'The period has been re-opened'
)); ));
@@ -413,7 +402,7 @@ class AccompanyingPeriodController extends AbstractController
$flashBag->add( $flashBag->add(
'success', 'success',
$this->get('translator')->trans('An accompanying period has been updated.') $this->translator->trans('An accompanying period has been updated.')
); );
return $this->redirectToRoute('chill_person_accompanying_period_list', [ return $this->redirectToRoute('chill_person_accompanying_period_list', [
@@ -421,7 +410,7 @@ class AccompanyingPeriodController extends AbstractController
]); ]);
} }
$flashBag->add('error', $this->get('translator') $flashBag->add('error', $this->translator
->trans('Error when updating the period')); ->trans('Error when updating the period'));
foreach ($errors as $error) { foreach ($errors as $error) {

View File

@@ -18,6 +18,7 @@ use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\Form\Extension\Core\Type\SubmitType; use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Validator\Validator\ValidatorInterface; use Symfony\Component\Validator\Validator\ValidatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
/** /**
* Class PersonAddressController * Class PersonAddressController
@@ -25,18 +26,10 @@ use Symfony\Component\Validator\Validator\ValidatorInterface;
*/ */
class PersonAddressController extends AbstractController class PersonAddressController extends AbstractController
{ {
/**
* @var ValidatorInterface
*/
protected $validator;
/** /**
* PersonAddressController constructor. * PersonAddressController constructor.
*/ */
public function __construct(ValidatorInterface $validator) public function __construct(private readonly ValidatorInterface $validator, private readonly TranslatorInterface $translator) {}
{
$this->validator = $validator;
}
/** /**
* @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/person/{person_id}/address/create", name="chill_person_address_create", methods={"POST"}) * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/person/{person_id}/address/create", name="chill_person_address_create", methods={"POST"})
@@ -77,14 +70,14 @@ class PersonAddressController extends AbstractController
$this->addFlash( $this->addFlash(
'success', 'success',
$this->get('translator')->trans('The new address was created successfully') $this->translator->trans('The new address was created successfully')
); );
return $this->redirectToRoute('chill_person_address_list', [ return $this->redirectToRoute('chill_person_address_list', [
'person_id' => $person->getId(), 'person_id' => $person->getId(),
]); ]);
} else { } else {
$this->addFlash('error', $this->get('translator') $this->addFlash('error', $this->translator
->trans('Error! Address not created!')); ->trans('Error! Address not created!'));
} }
} }
@@ -213,7 +206,7 @@ class PersonAddressController extends AbstractController
$this->getDoctrine()->getManager() $this->getDoctrine()->getManager()
->flush(); ->flush();
$this->addFlash('success', $this->get('translator')->trans( $this->addFlash('success', $this->translator->trans(
'The address has been successfully updated' 'The address has been successfully updated'
)); ));
@@ -221,7 +214,7 @@ class PersonAddressController extends AbstractController
'person_id' => $person->getId(), 'person_id' => $person->getId(),
]); ]);
} else { } else {
$this->addFlash('error', $this->get('translator') $this->addFlash('error', $this->translator
->trans('Error when updating the period')); ->trans('Error when updating the period'));
} }
} }

View File

@@ -82,7 +82,6 @@ class PersonDuplicateController extends \Symfony\Bundle\FrameworkBundle\Controll
$connection->beginTransaction(); $connection->beginTransaction();
foreach ($sqls as $sql) { foreach ($sqls as $sql) {
dump($sql);
$connection->executeQuery($sql); $connection->executeQuery($sql);
} }
$connection->commit(); $connection->commit();

View File

@@ -22,39 +22,22 @@ use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType; use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\FormType; use Symfony\Component\Form\Extension\Core\Type\FormType;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Contracts\Translation\TranslatorInterface;
/** /**
* Class ReportController. * Class ReportController.
*/ */
class ReportController extends AbstractController class ReportController extends AbstractController
{ {
/**
* @var AuthorizationHelper
*/
protected $authorizationHelper;
/**
* @var EventDispatcherInterface
*/
protected $eventDispatcher;
/**
* @var PaginatorFactory
*/
protected $paginator;
/** /**
* ReportController constructor. * ReportController constructor.
*/ */
public function __construct( public function __construct(
EventDispatcherInterface $eventDispatcher, private readonly EventDispatcherInterface $eventDispatcher,
AuthorizationHelper $authorizationHelper, private readonly AuthorizationHelper $authorizationHelper,
PaginatorFactory $paginator private readonly PaginatorFactory $paginator,
) { private readonly TranslatorInterface $translator
$this->eventDispatcher = $eventDispatcher; ) {}
$this->authorizationHelper = $authorizationHelper;
$this->paginator = $paginator;
}
/** /**
* Create a new report for a given person and of a given type. * Create a new report for a given person and of a given type.
@@ -98,7 +81,7 @@ class ReportController extends AbstractController
->getFlashBag() ->getFlashBag()
->add( ->add(
'success', 'success',
$this->get('translator') $this->translator
->trans('Success : report created!') ->trans('Success : report created!')
); );
@@ -108,7 +91,7 @@ class ReportController extends AbstractController
$this->get('session') $this->get('session')
->getFlashBag()->add( ->getFlashBag()->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('The form is not valid. The report has not been created !') ->trans('The form is not valid. The report has not been created !')
); );
@@ -135,11 +118,11 @@ class ReportController extends AbstractController
$report = $em->getRepository('ChillReportBundle:Report')->find($report_id); $report = $em->getRepository('ChillReportBundle:Report')->find($report_id);
if (!$report) { if (!$report) {
throw $this->createNotFoundException($this->get('translator')->trans('Unable to find this report.')); throw $this->createNotFoundException($this->translator->trans('Unable to find this report.'));
} }
if ((int) $person_id !== (int) $report->getPerson()->getId()) { if ((int) $person_id !== (int) $report->getPerson()->getId()) {
throw new \RuntimeException($this->get('translator')->trans('This is not the report of the person.'), 1); throw new \RuntimeException($this->translator->trans('This is not the report of the person.'), 1);
} }
$this->denyAccessUnlessGranted('CHILL_REPORT_UPDATE', $report); $this->denyAccessUnlessGranted('CHILL_REPORT_UPDATE', $report);
@@ -418,7 +401,7 @@ class ReportController extends AbstractController
$report = $em->getRepository('ChillReportBundle:Report')->find($report_id); $report = $em->getRepository('ChillReportBundle:Report')->find($report_id);
if (!$report) { if (!$report) {
throw $this->createNotFoundException($this->get('translator')->trans('Unable to find this report.')); throw $this->createNotFoundException($this->translator->trans('Unable to find this report.'));
} }
$this->denyAccessUnlessGranted('CHILL_REPORT_UPDATE', $report); $this->denyAccessUnlessGranted('CHILL_REPORT_UPDATE', $report);
@@ -433,7 +416,7 @@ class ReportController extends AbstractController
->getFlashBag() ->getFlashBag()
->add( ->add(
'success', 'success',
$this->get('translator') $this->translator
->trans('Success : report updated!') ->trans('Success : report updated!')
); );
@@ -453,7 +436,7 @@ class ReportController extends AbstractController
->getFlashBag() ->getFlashBag()
->add( ->add(
'error', 'error',
$this->get('translator') $this->translator
->trans('The form is not valid. The report has not been updated !') ->trans('The form is not valid. The report has not been updated !')
); );
@@ -480,7 +463,7 @@ class ReportController extends AbstractController
$entity = $em->getRepository('ChillReportBundle:Report')->find($report_id); $entity = $em->getRepository('ChillReportBundle:Report')->find($report_id);
if (!$entity || !$person) { if (!$entity || !$person) {
throw $this->createNotFoundException($this->get('translator')->trans('Unable to find this report.')); throw $this->createNotFoundException($this->translator->trans('Unable to find this report.'));
} }
$this->denyAccessUnlessGranted('CHILL_REPORT_SEE', $entity); $this->denyAccessUnlessGranted('CHILL_REPORT_SEE', $entity);