308 Commits

Author	SHA1	Message	Date
Julien Fastré	bfa58177e0	fix url for granting access to workflow by key	2024-11-12 17:48:44 +01:00
Julien Fastré	e5148f603b	Add TransitionHasSignerIfSignature validator ... Introduced a new validator `TransitionHasSignerIfSignature` to enforce that a signature transition must have a designated signer. Included related tests, updated DTO annotations, and added translations for new validation messages.	2024-11-07 19:55:09 +01:00
Julien Fastré	ac353ec3bc	fix cs	2024-11-06 17:10:53 +01:00
Julien Fastré	7aca08c89e	Allow to remove the canceled workflow to be deleted, if canceled ... - OP#812 - https://champs-libres.openproject.com/work_packages/812	2024-11-06 17:10:48 +01:00
Julien Fastré	5c0a383909	Add null check to canRun method in CancelStaleWorkflowCronJob ... Ensure the canRun method in CancelStaleWorkflowCronJob returns true when the cron job execution is null. This change includes updating the corresponding test case to cover the new behavior.	2024-11-04 14:16:52 +01:00
Julien Fastré	bf85e9bb71	When a user applies a signature in a workflow, the signer is the futureDestUser of the next step ... See: - Vendee/accent-suivi-developpement#1252 - https://champs-libres.openproject.com/wp/768 - OP#768	2024-10-24 15:49:59 +02:00
Julien Fastré	fd69568842	Add workflow guard to block external send without public view ... Introduce `EntityWorkflowGuardSendExternalIfNoPublicView` class to prevent workflows from transitioning to an external send state if the entity lacks a public view. Included unit tests to verify functionality for entities both with and without public views.	2024-10-23 15:26:25 +02:00
Julien Fastré	261bc88b5e	Add suggested persons and third parties methods ... Introduced getSuggestedPersons and getSuggestedThirdParties methods across various WorkflowHandlers. These methods integrate with ProvidePersonsAssociated and ProvideThirdPartiesAssociated services to fetch related entities, enhancing the workflow handling capabilities.	2024-10-23 11:41:19 +02:00
Julien Fastré	85dc9bdb2f	Add getSuggestedUsers method in EntityWorkflowManager ... Implemented the method to retrieve a list of suggested users for an entity workflow, filtering out duplicates. Added corresponding unit tests to verify the method's functionality and ensure its correctness in various scenarios.	2024-10-22 23:35:13 +02:00
Julien Fastré	527cf23d4f	Fix Canceling of stale workflow cronjob ... Refactor workflow cancellation logic to encapsulate transition checks in a dedicated method, and update CronJob handling to use entity workflows instead of IDs. Enhance test coverage to ensure proper handling and instantiate mocks for EntityManagerInterface.	2024-10-21 17:42:00 +02:00
Julien Fastré	7b322d7bab	Rename signature templates by removing underscores ... Standardized template names in WorkflowController and WorkflowAddSignatureController for better consistency. Updated references and renamed template files accordingly.	2024-10-21 17:41:59 +02:00
Julien Fastré	91a4b45607	Add notification to user groups on workflow transition ... Implemented NotificationToUserGroupsOnTransition to send group emails upon workflow completion. Also updated NotificationOnTransition to prevent double notifications and created a unit test for the new functionality.	2024-10-18 19:25:03 +02:00
Julien Fastré	d283d62049	!fixup Automatically execute body renderer when posting an	2024-10-15 11:10:31 +02:00
Julien Fastré	1313b6f138	Automatically execute body renderer when posting an email in Chill ... + adaptation of services which already uses body renderer	2024-10-10 14:06:00 +02:00
Julien Fastré	c329a1f1f8	fixup! Add message handling for public view creation	2024-10-10 09:39:45 +02:00
Julien Fastré	82e2b9a0f6	Add message handling for public view creation ... Introduce `PostPublicViewMessage` and `PostPublicViewMessageHandler` to handle external user views on public links by applying workflow transitions. Integrate with `WorkflowViewSendPublicController` and add relevant tests.	2024-10-09 21:39:27 +02:00
Julien Fastré	5c0f3cb317	Implement the controller action to view the EntityworkflowSend	2024-10-07 15:35:36 +02:00
Julien Fastré	a0b5c208eb	Send an email when a workflow is send to an external ... - create an event subscriber to catch the workflow which arrive to a "sentExternal" step; - add a messenger's message to handle the generation of the email; - add a simple message, and a simple controller for viewing the document - add dedicated tests	2024-10-04 13:52:18 +02:00
Julien Fastré	7913a377c8	Move the logic to check if dest users are required to a dedicated constraint ... - Create a dedicated constraint to check if the destUsers are required by the applied transition. - Apply on WorkflowTransitionContextDTO and, if required, use the built-in constraints - create tests	2024-10-04 13:41:20 +02:00
Julien Fastré	7cd638c5fc	Add TransitionHasDestineeIfIsSentExternal validator ... This commit introduces a new validator to ensure that transitions marked as 'sent' have a designated external recipient. It includes related tests for scenarios with and without recipients and covers integration with the workflow context.	2024-10-04 13:41:20 +02:00
Julien Fastré	803332ba5f	Remove the feature "send a workflow to an email address"	2024-10-01 18:49:51 +02:00
Julien Fastré	0c1d9ee4be	Add support for handling user groups in workflow counters and list workflows in "my workflows" controller ... - rewrite queries in repositories; - fix cache key cleaning for members of users when a workflow is transitionned	2024-09-27 10:35:57 +02:00
Julien Fastré	87599425df	Send a notification to all User which are members of UserGroups, when a workflow is sent to them	2024-09-26 17:29:27 +02:00
Julien Fastré	86ec6f82da	Do not block transition in EntityWorkflow when the user is member of a dest user group ... - refactor EntityWorkflowGuardTransition + tests - allow to find easily user within userGroup by adding a dedicated method to UserGroup::contains	2024-09-26 16:04:53 +02:00
Julien Fastré	82cd77678b	Create a PickUserGroupOrUserDynamicType ... - add necessary vue component to render usergroup within the component AddPersons; - add necessary normalization and denormalization process for matching the selected usergroup with entities in database	2024-09-26 15:39:12 +02:00
Julien Fastré	9e69c97250	Add search functionality for user groups ... Implemented `SearchUserGroupApiProvider` to handle user group search requests. Added `UserGroupRepository` and its interface to support search queries. Updated API specs to include user group as a searchable type.	2024-09-26 15:39:11 +02:00
Julien Fastré	5287824dbe	Add async handling for signature state changes ... Introduce MessageBus to handle post-signature operations asynchronously. This ensures that further steps are executed through dispatched messages, improving system scalability and performance. Implement new handlers and messages for the workflow state transitions.	2024-09-25 11:58:41 +02:00
Julien Fastré	758a14366e	Add OpenedEntityWorkflowHelper and tests ... Implemented OpenedEntityWorkflowHelper to handle final state checks for EntityWorkflow. This includes methods to determine if a workflow has reached positive or negative final steps. Added corresponding unit tests to ensure proper functionality.	2024-09-24 14:25:00 +02:00
Julien Fastré	cf2fe1bba7	Add guards and tests for entity workflow transitions ... Introduced EntityWorkflowGuardUnsignedTransition to block transitions with pending signatures. Implemented a new center resolver and added comprehensive unit tests for verifying transition rules and permissions.	2024-09-24 11:08:22 +02:00
Julien Fastré	d9b36533a2	Fix the query to find staled entity workflows ... Add a test to check that the query still works	2024-09-19 12:31:46 +02:00
Julien Fastré	4d8de46ac9	Apply the voter to allow all transition on EntityWorkflowGuardTransition ... This allow to effectively check that a user is allowed to apply all transitions on a workflow and, if yes, enable the given transition.	2024-09-16 14:47:00 +02:00
Julien Fastré	4696332a46	Create a voter for applying all transitions on all workflow's steps ... This voter checks that the related entity's centers is reachable by the user.	2024-09-16 14:42:37 +02:00
Julien Fastré	0d54637d35	Add missing constructor argument in SignatureStepStateChangerTest	2024-09-16 13:19:14 +02:00
Julien Fastré	45323e9136	Merge remote-tracking branch 'origin/upgrade-sf5' into signature-app-master	2024-09-16 11:51:33 +02:00
Julien Fastré	9f1afb8423	Add access controls and permissions for signature steps ... Implemented a Voter to enforce permissions on signature steps, ensuring only authorized users can sign steps. Updated relevant controllers and templates to reflect these permissions, and added corresponding tests to validate the changes.	2024-09-13 17:04:57 +02:00
Julien Fastré	8e984f2006	do not allow to sign if the signature is already applyied	2024-09-13 16:16:42 +02:00
Julien Fastré	bc34d84d63	Merge remote-tracking branch 'origin/master' into upgrade-sf5	2024-09-12 13:36:50 +02:00
Julien Fastré	f0f651edea	update cs after php-cs-fixer upgrade	2024-09-12 12:02:33 +02:00
Julien Fastré	70671dadac	Refactor workflow guard logic and add internal methods ... Removed guard logic from EntityWorkflowTransitionEventSubscriber and created a new EntityWorkflowGuardTransition class for separation of concerns. Marked several setter methods in EntityWorkflowStepSignature as internal to guide proper usage. Added comprehensive tests to ensure the new guard logic functions correctly.	2024-09-11 21:13:58 +02:00
Julien Fastré	d0ee381627	Upgrade of php-cs-fixer	2024-09-11 14:21:32 +02:00
nobohan	1197a46f5f	Refactor PDF signature handling and add signature state changer ... Simplified PdfSignedMessageHandler by delegating signature state changes to a new SignatureStepStateChanger class. Added utility method to EntityWorkflowStepSignature for checking pending signatures and created new test cases for the SignatureStepStateChanger.	2024-09-10 21:27:55 +02:00
Julien Fastré	2fb46c65c2	Refactor CancelStaleWorkflowCronJobTest to simplify setup ... Replaced KernelTestCase with TestCase to simplify test setup and removed dependency on the database connection. Added NullLogger to replace mocked LoggerInterface during testing. Updated method call in tests to correctly reference CancelStaleWorkflowMessage class.	2024-09-09 15:16:10 +02:00
Julien Fastré	f4356ac249	Add test for detecting stale workflows and enhance handler ... Added a new test to check if workflows are stale in EntityWorkflowTest. Enhanced CancelStaleWorkflowHandler to handle stale workflows more accurately, including checking if workflows have transitioned recently. Updated EntityWorkflow entity to cascade remove workflow steps. Refactor tests for handler, to avoid using $kernel during tests	2024-09-09 15:08:39 +02:00
Julien Fastré	d152efe084	Refactor imports and remove redundant type strings ... This commit refactors the usage of \DateTimeImmutable to ensure consistent namespacing and removes unnecessary string type declarations from constants in CancelStaleWorkflowCronJob. These changes improve code readability and maintainability.	2024-09-09 14:58:19 +02:00
Julie Lenaerts	b97eabf0d2	Get workflowComponent directly from registry	2024-09-09 10:46:35 +02:00
Julie Lenaerts	2e69d2df90	Adjust test to work with actual workflow + minor fix of handler logic	2024-09-09 10:46:33 +02:00
Julie Lenaerts	cb446edd18	Suffix message class with 'Message' and add check on workflow to assert no transitions were applied since message placed in queue	2024-09-09 10:40:42 +02:00
Julie Lenaerts	5d84e997c1	Php cs fixes	2024-09-09 10:40:42 +02:00
Julie Lenaerts	35199b6993	Create test for CancelStaleWorkflowHandler: wip state	2024-09-09 10:40:42 +02:00
Julie Lenaerts	dab68fb409	Add CancelStaleWorkflowCronJobTest	2024-09-09 10:40:41 +02:00