326 Commits

Author	SHA1	Message	Date
Julien Fastré	0d54637d35	Add missing constructor argument in SignatureStepStateChangerTest	2024-09-16 13:19:14 +02:00
Julien Fastré	45323e9136	Merge remote-tracking branch 'origin/upgrade-sf5' into signature-app-master	2024-09-16 11:51:33 +02:00
Julien Fastré	9f1afb8423	Add access controls and permissions for signature steps ... Implemented a Voter to enforce permissions on signature steps, ensuring only authorized users can sign steps. Updated relevant controllers and templates to reflect these permissions, and added corresponding tests to validate the changes.	2024-09-13 17:04:57 +02:00
Julien Fastré	8e984f2006	do not allow to sign if the signature is already applyied	2024-09-13 16:16:42 +02:00
Julien Fastré	bc34d84d63	Merge remote-tracking branch 'origin/master' into upgrade-sf5	2024-09-12 13:36:50 +02:00
Julien Fastré	f0f651edea	update cs after php-cs-fixer upgrade	2024-09-12 12:02:33 +02:00
Julien Fastré	70671dadac	Refactor workflow guard logic and add internal methods ... Removed guard logic from EntityWorkflowTransitionEventSubscriber and created a new EntityWorkflowGuardTransition class for separation of concerns. Marked several setter methods in EntityWorkflowStepSignature as internal to guide proper usage. Added comprehensive tests to ensure the new guard logic functions correctly.	2024-09-11 21:13:58 +02:00
Julien Fastré	d0ee381627	Upgrade of php-cs-fixer	2024-09-11 14:21:32 +02:00
nobohan	1197a46f5f	Refactor PDF signature handling and add signature state changer ... Simplified PdfSignedMessageHandler by delegating signature state changes to a new SignatureStepStateChanger class. Added utility method to EntityWorkflowStepSignature for checking pending signatures and created new test cases for the SignatureStepStateChanger.	2024-09-10 21:27:55 +02:00
Julien Fastré	2fb46c65c2	Refactor CancelStaleWorkflowCronJobTest to simplify setup ... Replaced KernelTestCase with TestCase to simplify test setup and removed dependency on the database connection. Added NullLogger to replace mocked LoggerInterface during testing. Updated method call in tests to correctly reference CancelStaleWorkflowMessage class.	2024-09-09 15:16:10 +02:00
Julien Fastré	f4356ac249	Add test for detecting stale workflows and enhance handler ... Added a new test to check if workflows are stale in EntityWorkflowTest. Enhanced CancelStaleWorkflowHandler to handle stale workflows more accurately, including checking if workflows have transitioned recently. Updated EntityWorkflow entity to cascade remove workflow steps. Refactor tests for handler, to avoid using $kernel during tests	2024-09-09 15:08:39 +02:00
Julien Fastré	d152efe084	Refactor imports and remove redundant type strings ... This commit refactors the usage of \DateTimeImmutable to ensure consistent namespacing and removes unnecessary string type declarations from constants in CancelStaleWorkflowCronJob. These changes improve code readability and maintainability.	2024-09-09 14:58:19 +02:00
Julie Lenaerts	b97eabf0d2	Get workflowComponent directly from registry	2024-09-09 10:46:35 +02:00
Julie Lenaerts	2e69d2df90	Adjust test to work with actual workflow + minor fix of handler logic	2024-09-09 10:46:33 +02:00
Julie Lenaerts	cb446edd18	Suffix message class with 'Message' and add check on workflow to assert no transitions were applied since message placed in queue	2024-09-09 10:40:42 +02:00
Julie Lenaerts	5d84e997c1	Php cs fixes	2024-09-09 10:40:42 +02:00
Julie Lenaerts	35199b6993	Create test for CancelStaleWorkflowHandler: wip state	2024-09-09 10:40:42 +02:00
Julie Lenaerts	dab68fb409	Add CancelStaleWorkflowCronJobTest	2024-09-09 10:40:41 +02:00
Julien Fastré	49ad25b4c8	Refactor WorkflowOnHoldController and improve tests ... Refactored WorkflowOnHoldController to remove dependencies and improve redirect handling. Updated test cases to use PHPUnit instead of KernelTestCase and mock proper dependencies. Added relationship handling in EntityWorkflowStep to manage EntityWorkflowStepHold instances accurately.	2024-09-06 14:02:11 +02:00
Julien Fastré	e8f09b507f	Fix cs after php-cs-fixer upgrade, fix phpstan and rector errors	2024-09-05 18:00:37 +02:00
Julie Lenaerts	8c4f342ca1	Correct instantiation of controller within test	2024-09-05 17:19:28 +02:00
Julie Lenaerts	745a29f742	Adjust logic for removing the hold on a workflow only by user who owns the hold and when a transition is applied on the workflow	2024-09-05 17:19:27 +02:00
Julie Lenaerts	41ffc470a0	Adjust test to check creation of onHold if user is allowed to apply a transition	2024-09-05 17:19:27 +02:00
Julie Lenaerts	8c5e94e295	Work on test for workflowOnHold controller	2024-09-05 17:19:25 +02:00
Julie Lenaerts	9c8a84cdbd	Add test for WorkflowOnHoldControllerTest	2024-09-05 17:19:24 +02:00
Julien Fastré	313fb9ffdf	PHP CS Fixer updated (3.63.1 -> v3.64.0)	2024-09-04 14:38:56 +02:00
Julien Fastré	e17203ca3a	Add PDF signature zone availability checks ... Introduce `PDFSignatureZoneAvailable` service to check available PDF signature zones. Updated `WorkflowAddSignatureController` to use the new service. Added unit tests to verify the correctness of the functionality.	2024-09-04 13:55:08 +02:00
Julien Fastré	bb848746d5	Merge branch 'upgrade-sf5' into signature-app-master	2024-08-28 13:23:12 +02:00
Julien Fastré	3738c110f8	Add missing import	2024-08-28 12:38:11 +02:00
Julien Fastré	6b4e1ed2d3	PHP CS Fixer updated (3.59.3 -> v3.63.1)	2024-08-28 12:06:08 +02:00
Julien Fastré	db94af0958	Add support for user signatures in workflow transitions ... This update introduces the ability to specify user signatures in workflow transitions. It allows a nullable user to be declared that may be requested to apply a signature. The code now handles the use-case of signing a transition by a user in addition to previous functionality of having it signed by a "Person" entity. Corresponding tests are also updated to validate this new feature.	2024-07-10 12:47:02 +02:00
Julien Fastré	7f3de62b2c	Move the metadata on each workflow transition from the event subscriber to the entity EntityWorkflow::setStep method ... The main update is in the setStep method of EntityWorkflow, where parameters are added to capture the transition details. These include the exact transition, the user who made the transition and the time of transition. The WorkflowController extracts this information and put it into the transition's context. The MarkingStore transfer it to the EntityWorkflow::setStep method, and all metadata are recorded within the entities themselve.	2024-07-10 10:40:17 +02:00
Ronchie Blondiau	2d67843901	added unread and read all function with endpoints for notifications	2024-07-05 13:36:31 +00:00
LenaertsJ	029524ba2c	Resolve "Add active/inactive filter to user list in admin"	2024-07-05 08:52:46 +00:00
Julien Fastré	a309cc0774	Refactor workflow classes and forms ... - the workflow controller add a context to each transition; - the state of the entity workflow is applyied using a dedicated marking store - the method EntityWorkflow::step use the context to associate the new step with the future destination user, cc users and email. This makes the step consistent at every step. - this allow to remove some logic which was processed in eventSubscribers, - as counterpart, each workflow must specify a dedicated marking_store: ```yaml framework: workflows: vendee_internal: # ... marking_store: service: Chill\MainBundle\Workflow\EntityWorkflowMarkingStore ```	2024-07-02 08:30:28 +02:00
Julien Fastré	3db4fff80d	Add signature functionality to workflow entities ... Created new files to add signature functionality to the workflow entities, including signature state enums and signature metadata. Added these changes to the migration script as well. Updated EntityWorkflowStep to include a collection for signatures.	2024-07-01 14:50:03 +02:00
Julien Fastré	916724c0c5	Merge branch 'master' into upgrade-sf5	2024-06-24 10:46:21 +02:00
Julien Fastré	0bfb3de465	fix cs	2024-06-11 16:58:33 +02:00
Julien Fastré	61877e0157	Refactor UserRenderTest and remove unused methods ... The UserRenderTest class has been refactored significantly. Redundant methods related to the booting kernel of Symfony have been removed. The approach of mocking objects has been changed, swapping from traditional mocking to prophecy mocking.	2024-06-07 13:06:11 +02:00
Julie Lenaerts	c9e13be736	pipeline fixes for phpstan, cs-fixer, rector	2024-04-16 20:16:45 +02:00
Julie Lenaerts	b9b342fe44	Set isActive property for userjob	2024-04-16 20:09:00 +02:00
Julie Lenaerts	0bc9fff825	test still failing with error saying column phonenumber of relation users does not exist	2024-04-16 12:01:40 +02:00
Julie Lenaerts	4e0d8e4def	fix userNormalizerTest by adding clock in the construct of UserNormalizer	2024-04-16 12:01:40 +02:00
Julie Lenaerts	addc623add	php style fixer	2024-04-16 12:01:37 +02:00
Julie Lenaerts	1b96deb4ee	try to fix userRenderTest: mock not working	2024-04-16 11:55:54 +02:00
Julie Lenaerts	835409cb94	work on userRenderTest	2024-04-16 11:55:54 +02:00
Julie Lenaerts	8d58805abd	work on user render test	2024-04-16 11:55:54 +02:00
Julie Lenaerts	c3a799cb7d	work on test logic	2024-04-16 11:55:54 +02:00
Julie Lenaerts	d91b1a70bf	work on userRender test	2024-04-16 11:52:58 +02:00
Julien Fastré	29d53c53a4	fixup! Fix configuration and usage of password hasher	2024-04-08 13:45:37 +02:00