Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-14 14:24:24 +00:00
Code Issues Actions Projects Releases Wiki Activity
11,904 Commits 146 Branches 99 Tags
Commit Graph

126 Commits

Author SHA1 Message Date
Julien Fastré
7aca08c89e
Allow to remove the canceled workflow to be deleted, if canceled 
- OP#812
- https://champs-libres.openproject.com/work_packages/812
 2024-11-06 17:10:48 +01:00
Julien Fastré
479651b31e
Add a list of user groups in User menu, and implements the feature to add / remove users 2024-10-01 18:49:51 +02:00
Julien Fastré
cfce531754
Add reject functionality for workflow signatures 
Implemented the ability to reject workflow signatures by adding necessary templates, routes, and authorization checks. Updated the `WorkflowSignatureCancelController` to handle rejection and modified existing templates and translations to support the new feature.
 2024-09-25 11:31:27 +02:00
Julien Fastré
83121c2a83
Implement signature cancellation feature 
Added functionality to cancel signatures in workflow, including controller, view, and tests. Updated translations and adjusted templates to support and display cancellation actions.
 2024-09-25 10:58:53 +02:00
Julien Fastré
5a5d259d18
Add duplicate workflow prevention in MetadataExtractor 
Integrate DuplicateEntityWorkflowFinder to prevent creating workflows for entities with existing opened or positive final workflows. Updated EntityWorkflowVoter to implement the same check before allowing creation. Removed unnecessary blank workflow parameter from Twig template.
 2024-09-24 14:25:00 +02:00
Julien Fastré
cf2fe1bba7
Add guards and tests for entity workflow transitions 
Introduced EntityWorkflowGuardUnsignedTransition to block transitions with pending signatures. Implemented a new center resolver and added comprehensive unit tests for verifying transition rules and permissions.
 2024-09-24 11:08:22 +02:00
Julien Fastré
27df3b2c9b
Add support for ManagerAwareCenterResolverInterface 
Introduce ManagerAwareCenterResolverInterface to ensure resolvers can reference their manager. Added a trait for implementing the interface and updated the CenterResolverManager to initialize resolvers correctly.
 2024-09-24 10:58:01 +02:00
Julien Fastré
4696332a46
Create a voter for applying all transitions on all workflow's steps 
This voter checks that the related entity's centers is reachable by the user.
 2024-09-16 14:42:37 +02:00
Julien Fastré
45323e9136
Merge remote-tracking branch 'origin/upgrade-sf5' into signature-app-master 2024-09-16 11:51:33 +02:00
Julien Fastré
9f1afb8423
Add access controls and permissions for signature steps 
Implemented a Voter to enforce permissions on signature steps, ensuring only authorized users can sign steps. Updated relevant controllers and templates to reflect these permissions, and added corresponding tests to validate the changes.
 2024-09-13 17:04:57 +02:00
Julien Fastré
bc34d84d63
Merge remote-tracking branch 'origin/master' into upgrade-sf5 2024-09-12 13:36:50 +02:00
Julien Fastré
f0f651edea
update cs after php-cs-fixer upgrade 2024-09-12 12:02:33 +02:00
Julien Fastré
01c2848a83
Fix deprecated method in redis 2024-09-11 14:23:23 +02:00
Julien Fastré
d0ee381627
Upgrade of php-cs-fixer 2024-09-11 14:21:32 +02:00
Julien Fastré
313fb9ffdf
PHP CS Fixer updated (3.63.1 -> v3.64.0) 2024-09-04 14:38:56 +02:00
Julien Fastré
bb848746d5
Merge branch 'upgrade-sf5' into signature-app-master 2024-08-28 13:23:12 +02:00
Julien Fastré
c1cf27c42d
Refactor workflow handlers and update comments 
Changes include class refactoring for Workflow handlers, using `readonly` and better indentation in constructors for better readability. In addition, outdated comments are removed. Also, entity workflow handlers now implement the EntityWorkflowHandlerInterface type for better type safety.
 2024-07-10 10:40:18 +02:00
Julien Fastré
84f515d451
Merge remote-tracking branch 'origin/master' into upgrade-sf5 2024-05-28 14:16:01 +02:00
Julien Fastré
56d173046d
fix phpstan, cs, and rector rules 2024-05-28 12:54:56 +02:00
Julie Lenaerts
dddb6d66bc php cs fixes after merge 2024-05-22 16:44:02 +02:00
Julie Lenaerts
9ce1788a14 phpstan en rector fixes 2024-05-22 16:42:47 +02:00
Julie Lenaerts
ed3e0f889e Rector changes + namespace changes 2024-04-23 17:43:23 +02:00
Julien Fastré
579bd829f8
Apply rector rules: symfony up to 54 2024-04-04 23:30:25 +02:00
Julien Fastré
553fb271e4
fix container operations within tests 2024-04-04 22:26:42 +02:00
Julien Fastré
92800f5dd0
fix cs 2024-04-04 22:19:56 +02:00
Julien Fastré
d6a6cc2572
Rename chill.role tag to chill_main.provide_role and optimize role provider 
The `chill.role` tag has been renamed to `chill_main.provide_role` to prevent any confusion and make the namespaces more consistent. During this process, the class RoleProvidersCompilerPass was deleted, simplifying the role provision process by injecting tagged services directly into the RoleProvider. The change is also reflected in multiple YAML service configurations and explained in the MIGRATION.md file.
 2024-04-03 17:14:02 +02:00
Julien Fastré
f889d67e94
fixes after merge of master into upgrade-sf4 2024-02-12 22:31:16 +01:00
Julien Fastré
37af488f69
Merge branch 'master' into upgrade-sf5 2024-02-12 21:50:34 +01:00
Julien Fastré
036fe8d6f8
upgrade php-cs 3.49 2024-02-07 10:43:53 +01:00
Julien Fastré
27ce322690
upgrade php-cs-fixer to 3.47.0 2024-01-22 12:14:39 +01:00
Julie Lenaerts
3c8e59e088 php cs fixes after updating php cs fixer 2024-01-10 10:31:25 +01:00
Julien Fastré
af663cf27c
Create the helper ChillSecurity 
En symfony 5.4 le typage a été vraiment amélioré, et phpstan peut détecter plus d'erreur potentielles.

Mais le problème est que Symfony "type" les `User` avec son propre `Symfony\Component\Security\Core\User\UserInterface` alors qu'on a besoin de `Chill\MainBundle\Entity\User`.

Imaginons qu'on a ceci:

```php

namespace Chill\Bundle\Service;

final readonly class SomeService
{
    public function myMethod(\Chill\MainBundle\Entity\User $user): void
    {
        // ...
    }
}
```

Quand on l'appelle dans un contrôleur ou dans un service:

```php

namespace Chill\Bundle\Service;

use Symfony\Component\Security\Core\Security;

final readonly OtherService
{
    public function __construct(private Security $security, private SomeService $service) {}

    public function __invoke(): void
    {
        $this->service->myMethod($this->security->getUser());
    }
}
```

PHPstan va se plaindre:

```
Parameter #1 $user of method SomeService::myMethod() expects Chill\MainBundle\Entity\User, Symfony\Component\Security\Core\User\UserInterface|null given.
```

Du coup, j'ai créé ce service:

```php
<?php

namespace Chill\MainBundle\Security;

use Chill\MainBundle\Entity\User;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Security;

/**
 * Security helper for Chill user
 *
 * Provides security-related functionality such as user retrieval, authorization checks,
 * and token retrieval, in a context where only an authenticated @see{User::class} is expected.
 *
 */
final readonly class ChillSecurity implements AuthorizationCheckerInterface
{

    public function hasUser(): bool
    {
        // implementation detail not shown here
    }

    public function getUser(): User
    {
        // implementation detail not shown here
    }

    public function isGranted($attribute, $subject = null): bool
    {
        // implementation detail not shown here
    }

    public function getToken(): ?TokenInterface
    {
        // implementation detail not shown here
    }
}
```

Et maintenant, on peut faire:

```php

namespace Chill\Bundle\Service;

use Chill\MainBundle\Security\ChillSecurity;

final readonly OtherService
{
    public function __construct(private ChillSecurity $security, private SomeService $service) {}

    public function __invoke(): void
    {
        $this->service->myMethod($this->security->getUser());
    }
}
```

Et tout va bien se passer.

Ca sera dans la version de chill qui fait passer à symfony 5.4.
 2023-12-12 22:43:24 +01:00
Julien Fastré
bc2041cbdd
apply more cs rules for php-cs 2023-10-17 13:27:03 +02:00
Julien Fastré
a6fcdb5256
Merge remote-tracking branch 'origin/rector/rules-symfony' into rector/rules-symfony 2023-10-16 18:07:42 +02:00
Julien Fastré
6b8d6b76ba
Upgrade code from 146 to new standards 2023-10-16 18:04:40 +02:00
Julien Fastré
51a4ffca2e
Fix cs with new cs rules (php-cs-fixer version 3.35) 2023-10-16 11:59:49 +02:00
Julien Fastré
58e189ee07
Improve type declaration 2023-10-04 11:21:39 +02:00
Julien Fastré
d8b0e0671a
ScopeResolverDispatcher: better type hinting 2023-09-26 16:59:09 +02:00
Julien Fastré
cd9611a669
Remove unused dependency on DefaultVoter (+ fix when throwing an exception) 2023-09-13 10:12:04 +02:00
Julien Fastré
d3b68f8f8f
AuthorizationHelper: compare center and scope based on id, not on equality 
For an unknown reason, in some circumstances, the use of the `===` comparator does not work when comparing Center instances and Scope instances. Then, we compare them based on the id.
 2023-09-13 10:08:44 +02:00
Julien Fastré
d2323e91ca
new cs rule: single_line_empty_body 
Rule is added to the last version of php-cs-fixer
 2023-09-12 15:58:59 +02:00
Julien Fastré
e72df84442
DX: rector corrections 2023-09-01 11:08:13 +02:00
Julien Fastré
7c58880139
Remove usage of deprecated Role class 2023-08-31 17:08:18 +02:00
Julien Fastré
f570fe92a5
apply rector rules 2023-07-28 02:40:02 +02:00
Julien Fastré
c20f65eebb
apply rector rules: symfony **UP TO** 44 2023-07-28 01:52:53 +02:00
Julien Fastré
aa553db659
apply rector rules after updating the code with master branch 2023-07-19 23:43:26 +02:00
Julien Fastré
023a29cb78
apply rector rules: php up to php82 2023-07-19 23:19:50 +02:00
Julien Fastré
74ed34ba97
apply rules rector 2023-07-19 22:48:26 +02:00
Julien Fastré
224c2c74e8
Merge remote-tracking branch 'origin/master' into rector/rules-up-to-php80 
Conflicts:
	src/Bundle/ChillActivityBundle/Controller/ActivityController.php
	src/Bundle/ChillActivityBundle/Export/Aggregator/ACPAggregators/DateAggregator.php
	src/Bundle/ChillActivityBundle/Menu/PersonMenuBuilder.php
	src/Bundle/ChillActivityBundle/Repository/ActivityACLAwareRepository.php
	src/Bundle/ChillActivityBundle/Service/DocGenerator/ActivityContext.php
	src/Bundle/ChillCalendarBundle/Command/MapAndSubscribeUserCalendarCommand.php
	src/Bundle/ChillCalendarBundle/RemoteCalendar/Connector/MSGraph/MSGraphUserRepository.php
	src/Bundle/ChillDocStoreBundle/Controller/DocumentAccompanyingCourseController.php
	src/Bundle/ChillDocStoreBundle/Controller/DocumentPersonController.php
	src/Bundle/ChillDocStoreBundle/Repository/PersonDocumentACLAwareRepository.php
	src/Bundle/ChillEventBundle/Search/EventSearch.php
	src/Bundle/ChillMainBundle/Controller/ExportController.php
	src/Bundle/ChillMainBundle/Controller/PermissionsGroupController.php
	src/Bundle/ChillMainBundle/Cron/CronManager.php
	src/Bundle/ChillMainBundle/Entity/CronJobExecution.php
	src/Bundle/ChillMainBundle/Export/ExportManager.php
	src/Bundle/ChillMainBundle/Form/Type/Export/PickCenterType.php
	src/Bundle/ChillMainBundle/Form/Type/Listing/FilterOrderType.php
	src/Bundle/ChillMainBundle/Repository/NotificationRepository.php
	src/Bundle/ChillMainBundle/Templating/Listing/FilterOrderHelper.php
	src/Bundle/ChillMainBundle/Templating/Listing/FilterOrderHelperBuilder.php
	src/Bundle/ChillMainBundle/Templating/Listing/FilterOrderHelperFactory.php
	src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseWorkController.php
	src/Bundle/ChillPersonBundle/Controller/SocialWorkSocialActionApiController.php
	src/Bundle/ChillPersonBundle/Export/Aggregator/PersonAggregators/AgeAggregator.php
	src/Bundle/ChillPersonBundle/Export/Export/ListAccompanyingPeriod.php
	src/Bundle/ChillPersonBundle/Export/Export/ListHouseholdInPeriod.php
	src/Bundle/ChillPersonBundle/Repository/AccompanyingPeriodACLAwareRepository.php
	src/Bundle/ChillPersonBundle/Security/Authorization/AccompanyingPeriodVoter.php
	src/Bundle/ChillPersonBundle/Service/DocGenerator/AccompanyingPeriodContext.php
	src/Bundle/ChillPersonBundle/Service/DocGenerator/AccompanyingPeriodWorkEvaluationContext.php
	src/Bundle/ChillPersonBundle/Service/DocGenerator/PersonContext.php
	src/Bundle/ChillReportBundle/DataFixtures/ORM/LoadReports.php
	src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php
 2023-07-17 12:49:13 +02:00
Julien Fastré
dd344aed52
Implements right "see confidential course" on method findByPerson 
Add unit tests for that
 2023-07-04 15:59:39 +02:00