107 Commits

Author	SHA1	Message	Date
Julien Fastré	3af7824d01	Refactor transaction handling for signature state changes, to wrap them into transactions ... Wrap signature state changes in transactions to prevent race conditions and ensure data integrity. Update controller and test class names to reflect broader state change capabilities. Enhance documentation with comments to clarify transaction requirements and procedure details for signature operations.	2024-12-06 12:37:17 +01:00
Julien Fastré	83ef12a2ef	Upgrade CS to PHP CS Fixer 3.65.0 (700668e) Persian Successor (was version 3.64.x)	2024-11-26 12:15:29 +01:00
Julie Lenaerts	38886cd0b6	Rector correction in NotificationOnTransition	2024-11-20 10:23:33 +01:00
Julien Fastré	3a1947df9e	Add entity workflow title to notification ... Introduced `EntityWorkflowManager` to `NotificationOnTransition` to fetch and include the entity workflow title in notifications. Updated relevant tests to support the new functionality and verify the entity title retrieval process.	2024-11-19 12:01:31 +01:00
Julien Fastré	9a44cf060f	Add workflow title to notification emails for workflow transition, to user groups ... Incorporated the workflow title into notification emails to provide more context to users. Updated the NotificationToUserGroupsOnTransition class and its tests to include the title from EntityWorkflowManager. Adjusted the French email templates to display the workflow title correctly.	2024-11-18 15:05:03 +01:00
Julien Fastré	b7e27536bd	Merge remote-tracking branch 'origin/master' into signature-app-master	2024-11-14 12:18:07 +01:00
Julien Fastré	829fb669fe	Update Workflow Permission Handling ... Refactor the `WorkflowRelatedEntityPermissionHelper` to enhance permission checks for workflow-related entities. This includes updating methods, improving test coverage, and incorporating `MockClock` for date-sensitive operations.	2024-11-14 12:07:21 +01:00
Julien Fastré	903a87c589	Merge branch '323-related-entity-permission-give-from-workflow' into signature-app-master	2024-11-13 22:44:29 +01:00
Julien Fastré	c99dda0126	Rename WorkflowStoredObjectPermissionHelper to WorkflowRelatedEntityPermissionHelper and create method isAllowedByWorkflow ... Refactored class names and namespaces from WorkflowStoredObjectPermissionHelper to WorkflowRelatedEntityPermissionHelper across various modules. Updated associated tests and voter classes to reflect the changes, ensuring consistency and clarity in the codebase.	2024-11-13 22:41:23 +01:00
Julien Fastré	d6c55c830b	Persist EntityWorkflow and its steps with EntityManager ... Refactored NotificationToUserGroupsOnTransition to utilize EntityManager for persisting EntityWorkflowStep. This ensures entities have generated IDs, leading to proper email notifications during workflow transitions.	2024-11-13 12:40:53 +01:00
Julien Fastré	6453237340	Mark class as final and readonly	2024-11-12 21:22:51 +01:00
Julien Fastré	79621e8ab7	Add guard to block signatures on related entities without objects ... Implemented a guard to prevent signatures on related entities that lack a stored object. It also includes corresponding tests and added translation for the error message in French.	2024-11-12 18:14:30 +01:00
Julien Fastré	c3cc6c8353	Do not fail displaying notification when workflow has been deleted	2024-11-12 13:57:48 +01:00
Julien Fastré	e5148f603b	Add TransitionHasSignerIfSignature validator ... Introduced a new validator `TransitionHasSignerIfSignature` to enforce that a signature transition must have a designated signer. Included related tests, updated DTO annotations, and added translations for new validation messages.	2024-11-07 19:55:09 +01:00
Julien Fastré	bf85e9bb71	When a user applies a signature in a workflow, the signer is the futureDestUser of the next step ... See: - Vendee/accent-suivi-developpement#1252 - https://champs-libres.openproject.com/wp/768 - OP#768	2024-10-24 15:49:59 +02:00
Julien Fastré	fd69568842	Add workflow guard to block external send without public view ... Introduce `EntityWorkflowGuardSendExternalIfNoPublicView` class to prevent workflows from transitioning to an external send state if the entity lacks a public view. Included unit tests to verify functionality for entities both with and without public views.	2024-10-23 15:26:25 +02:00
Julien Fastré	261bc88b5e	Add suggested persons and third parties methods ... Introduced getSuggestedPersons and getSuggestedThirdParties methods across various WorkflowHandlers. These methods integrate with ProvidePersonsAssociated and ProvideThirdPartiesAssociated services to fetch related entities, enhancing the workflow handling capabilities.	2024-10-23 11:41:19 +02:00
Julien Fastré	85dc9bdb2f	Add getSuggestedUsers method in EntityWorkflowManager ... Implemented the method to retrieve a list of suggested users for an entity workflow, filtering out duplicates. Added corresponding unit tests to verify the method's functionality and ensure its correctness in various scenarios.	2024-10-22 23:35:13 +02:00
Julien Fastré	daef18408a	fix the return type of the EntityWorkflowCreation constraint	2024-10-18 19:26:09 +02:00
Julien Fastré	91a4b45607	Add notification to user groups on workflow transition ... Implemented NotificationToUserGroupsOnTransition to send group emails upon workflow completion. Also updated NotificationOnTransition to prevent double notifications and created a unit test for the new functionality.	2024-10-18 19:25:03 +02:00
Julien Fastré	29fa086fde	Set return types to MetadataExtractor	2024-10-18 19:14:23 +02:00
Julien Fastré	9fe20b5e81	Show pending signatures in the person's search results	2024-10-15 15:15:32 +02:00
Julien Fastré	d283d62049	!fixup Automatically execute body renderer when posting an	2024-10-15 11:10:31 +02:00
Julien Fastré	1313b6f138	Automatically execute body renderer when posting an email in Chill ... + adaptation of services which already uses body renderer	2024-10-10 14:06:00 +02:00
Julien Fastré	8589bada3f	Layout for the email to external	2024-10-10 13:40:07 +02:00
Julien Fastré	3f7c5d23dc	Add return type hint to getTargets method ... The getTargets method now explicitly returns an array, enhancing type safety and readability. This change ensures that the return type is clear to any developers interacting with this method.	2024-10-10 11:41:25 +02:00
Julien Fastré	78445f0d65	fixup! Add message handling for public view creation	2024-10-10 11:39:04 +02:00
Julien Fastré	c329a1f1f8	fixup! Add message handling for public view creation	2024-10-10 09:39:45 +02:00
Julien Fastré	82e2b9a0f6	Add message handling for public view creation ... Introduce `PostPublicViewMessage` and `PostPublicViewMessageHandler` to handle external user views on public links by applying workflow transitions. Integrate with `WorkflowViewSendPublicController` and add relevant tests.	2024-10-09 21:39:27 +02:00
Julien Fastré	3f80d62ca2	Add public workflow view functionality ... Introduced the ability to render public views for workflows, including new templates, handlers, and metadata support. Updated entity interfaces and translations to enhance the public sharing of workflow documents.	2024-10-08 15:15:58 +02:00
Julien Fastré	5c0f3cb317	Implement the controller action to view the EntityworkflowSend	2024-10-07 15:35:36 +02:00
Julien Fastré	a0b5c208eb	Send an email when a workflow is send to an external ... - create an event subscriber to catch the workflow which arrive to a "sentExternal" step; - add a messenger's message to handle the generation of the email; - add a simple message, and a simple controller for viewing the document - add dedicated tests	2024-10-04 13:52:18 +02:00
Julien Fastré	7913a377c8	Move the logic to check if dest users are required to a dedicated constraint ... - Create a dedicated constraint to check if the destUsers are required by the applied transition. - Apply on WorkflowTransitionContextDTO and, if required, use the built-in constraints - create tests	2024-10-04 13:41:20 +02:00
Julien Fastré	7cd638c5fc	Add TransitionHasDestineeIfIsSentExternal validator ... This commit introduces a new validator to ensure that transitions marked as 'sent' have a designated external recipient. It includes related tests for scenarios with and without recipients and covers integration with the workflow context.	2024-10-04 13:41:20 +02:00
Julien Fastré	071c5e3c55	Update the form to allow sending a workflow to an external destinee ... OP#734 Modification du formulaire pour permettre l'envoi d'un workflow https://champs-libres.openproject.com/work_packages/734	2024-10-04 13:41:20 +02:00
Julien Fastré	803332ba5f	Remove the feature "send a workflow to an email address"	2024-10-01 18:49:51 +02:00
Julien Fastré	0c1d9ee4be	Add support for handling user groups in workflow counters and list workflows in "my workflows" controller ... - rewrite queries in repositories; - fix cache key cleaning for members of users when a workflow is transitionned	2024-09-27 10:35:57 +02:00
Julien Fastré	87599425df	Send a notification to all User which are members of UserGroups, when a workflow is sent to them	2024-09-26 17:29:27 +02:00
Julien Fastré	86ec6f82da	Do not block transition in EntityWorkflow when the user is member of a dest user group ... - refactor EntityWorkflowGuardTransition + tests - allow to find easily user within userGroup by adding a dedicated method to UserGroup::contains	2024-09-26 16:04:53 +02:00
Julien Fastré	17f4c85fa5	Add user group support in entity workflow steps ... Enhanced the WorkflowTransitionContextDTO to include user groups alongside individual users for future steps. Updated the relevant entity and form classes to accommodate this change and included the necessary database migration script.	2024-09-26 15:39:13 +02:00
Julien Fastré	5287824dbe	Add async handling for signature state changes ... Introduce MessageBus to handle post-signature operations asynchronously. This ensures that further steps are executed through dispatched messages, improving system scalability and performance. Implement new handlers and messages for the workflow state transitions.	2024-09-25 11:58:41 +02:00
Julien Fastré	cfce531754	Add reject functionality for workflow signatures ... Implemented the ability to reject workflow signatures by adding necessary templates, routes, and authorization checks. Updated the `WorkflowSignatureCancelController` to handle rejection and modified existing templates and translations to support the new feature.	2024-09-25 11:31:27 +02:00
Julien Fastré	83121c2a83	Implement signature cancellation feature ... Added functionality to cancel signatures in workflow, including controller, view, and tests. Updated translations and adjusted templates to support and display cancellation actions.	2024-09-25 10:58:53 +02:00
Julien Fastré	5a5d259d18	Add duplicate workflow prevention in MetadataExtractor ... Integrate DuplicateEntityWorkflowFinder to prevent creating workflows for entities with existing opened or positive final workflows. Updated EntityWorkflowVoter to implement the same check before allowing creation. Removed unnecessary blank workflow parameter from Twig template.	2024-09-24 14:25:00 +02:00
Julien Fastré	758a14366e	Add OpenedEntityWorkflowHelper and tests ... Implemented OpenedEntityWorkflowHelper to handle final state checks for EntityWorkflow. This includes methods to determine if a workflow has reached positive or negative final steps. Added corresponding unit tests to ensure proper functionality.	2024-09-24 14:25:00 +02:00
Julien Fastré	7b06c80c2a	Merge branch 'signature-app/wp-706-no-forward-unless-signed' into 'signature-app-master' ... Block transition if there is a pending signature for the entityWorkflow See merge request Chill-Projet/chill-bundles!736	2024-09-24 09:13:45 +00:00
Julien Fastré	cf2fe1bba7	Add guards and tests for entity workflow transitions ... Introduced EntityWorkflowGuardUnsignedTransition to block transitions with pending signatures. Implemented a new center resolver and added comprehensive unit tests for verifying transition rules and permissions.	2024-09-24 11:08:22 +02:00
Julien Fastré	a8c5d1f660	Remove unused constructor parameter	2024-09-19 17:48:34 +02:00
Julien Fastré	4d8de46ac9	Apply the voter to allow all transition on EntityWorkflowGuardTransition ... This allow to effectively check that a user is allowed to apply all transitions on a workflow and, if yes, enable the given transition.	2024-09-16 14:47:00 +02:00
Julien Fastré	4e588ed0e0	Add logging to SignatureStepStateChanger ... Enhanced the SignatureStepStateChanger by integrating a LoggerInterface to provide detailed logging at key points in the state transition process. This includes informational messages when marking signatures or skipping transitions, as well as debug messages when determining the next steps.	2024-09-11 21:14:07 +02:00