2818 Commits

Author	SHA1	Message	Date
Julien Fastré	45323e9136	Merge remote-tracking branch 'origin/upgrade-sf5' into signature-app-master	2024-09-16 11:51:33 +02:00
Julien Fastré	9f1afb8423	Add access controls and permissions for signature steps ... Implemented a Voter to enforce permissions on signature steps, ensuring only authorized users can sign steps. Updated relevant controllers and templates to reflect these permissions, and added corresponding tests to validate the changes.	2024-09-13 17:04:57 +02:00
Julien Fastré	911dfc2878	fix rector errors	2024-09-13 16:22:09 +02:00
Julien Fastré	8e984f2006	do not allow to sign if the signature is already applyied	2024-09-13 16:16:42 +02:00
nobohan	ae1459cf77	Signature: topbar UI	2024-09-12 14:22:58 +02:00
Julien Fastré	bc34d84d63	Merge remote-tracking branch 'origin/master' into upgrade-sf5	2024-09-12 13:36:50 +02:00
Julien Fastré	f0f651edea	update cs after php-cs-fixer upgrade	2024-09-12 12:02:33 +02:00
Julien Fastré	09563979a2	Refactor entity rendering with manager pattern ... Introduce ChillEntityRenderManager to centralize entity rendering logic, reducing redundancy and improving code organization. Update dependencies and service configuration to support the new manager pattern, enhancing maintainability and flexibility of entity rendering in templates.	2024-09-12 11:18:35 +02:00
nobohan	d08212df46	Signature: add and process returnPath in the signature app	2024-09-12 09:46:14 +02:00
nobohan	4933238f3f	Signature - improve UI signature app	2024-09-12 09:46:14 +02:00
Julien Fastré	18af2ca70b	Handle null transitionBy and improve display logic ... Added checks for null transitionBy cases in workflow templates to display "Automated transition" when applicable. Also improved conditional rendering for 'destUser' and 'ccUser' fields to avoid empty elements.	2024-09-11 21:52:34 +02:00
Julien Fastré	f1505a9d15	Add locale to workflow URLs in notification templates ... This is required to send notification within a console command	2024-09-11 21:16:54 +02:00
Julien Fastré	4e588ed0e0	Add logging to SignatureStepStateChanger ... Enhanced the SignatureStepStateChanger by integrating a LoggerInterface to provide detailed logging at key points in the state transition process. This includes informational messages when marking signatures or skipping transitions, as well as debug messages when determining the next steps.	2024-09-11 21:14:07 +02:00
Julien Fastré	70671dadac	Refactor workflow guard logic and add internal methods ... Removed guard logic from EntityWorkflowTransitionEventSubscriber and created a new EntityWorkflowGuardTransition class for separation of concerns. Marked several setter methods in EntityWorkflowStepSignature as internal to guide proper usage. Added comprehensive tests to ensure the new guard logic functions correctly.	2024-09-11 21:13:58 +02:00
Julien Fastré	01c2848a83	Fix deprecated method in redis	2024-09-11 14:23:23 +02:00
Julien Fastré	d0ee381627	Upgrade of php-cs-fixer	2024-09-11 14:21:32 +02:00
nobohan	1197a46f5f	Refactor PDF signature handling and add signature state changer ... Simplified PdfSignedMessageHandler by delegating signature state changes to a new SignatureStepStateChanger class. Added utility method to EntityWorkflowStepSignature for checking pending signatures and created new test cases for the SignatureStepStateChanger.	2024-09-10 21:27:55 +02:00
Julien Fastré	1ddd283f26	Add signer type differentiation for workflows ... Added a method to determine if the signer is a 'person' or 'user'. Updated the signature template to handle both types accordingly, ensuring the correct entity type is displayed in workflow signatures.	2024-09-10 17:48:32 +02:00
Julien Fastré	2fb46c65c2	Refactor CancelStaleWorkflowCronJobTest to simplify setup ... Replaced KernelTestCase with TestCase to simplify test setup and removed dependency on the database connection. Added NullLogger to replace mocked LoggerInterface during testing. Updated method call in tests to correctly reference CancelStaleWorkflowMessage class.	2024-09-09 15:16:10 +02:00
Julien Fastré	f4356ac249	Add test for detecting stale workflows and enhance handler ... Added a new test to check if workflows are stale in EntityWorkflowTest. Enhanced CancelStaleWorkflowHandler to handle stale workflows more accurately, including checking if workflows have transitioned recently. Updated EntityWorkflow entity to cascade remove workflow steps. Refactor tests for handler, to avoid using $kernel during tests	2024-09-09 15:08:39 +02:00
Julien Fastré	d152efe084	Refactor imports and remove redundant type strings ... This commit refactors the usage of \DateTimeImmutable to ensure consistent namespacing and removes unnecessary string type declarations from constants in CancelStaleWorkflowCronJob. These changes improve code readability and maintainability.	2024-09-09 14:58:19 +02:00
Julien Fastré	ee9530d03f	More conditions to find staled workflows	2024-09-09 10:46:35 +02:00
Julie Lenaerts	b97eabf0d2	Get workflowComponent directly from registry	2024-09-09 10:46:35 +02:00
Julie Lenaerts	2e69d2df90	Adjust test to work with actual workflow + minor fix of handler logic	2024-09-09 10:46:33 +02:00
Julie Lenaerts	cb446edd18	Suffix message class with 'Message' and add check on workflow to assert no transitions were applied since message placed in queue	2024-09-09 10:40:42 +02:00
Julie Lenaerts	5d84e997c1	Php cs fixes	2024-09-09 10:40:42 +02:00
Julie Lenaerts	35199b6993	Create test for CancelStaleWorkflowHandler: wip state	2024-09-09 10:40:42 +02:00
Julie Lenaerts	dab68fb409	Add CancelStaleWorkflowCronJobTest	2024-09-09 10:40:41 +02:00
Julie Lenaerts	6001bb6447	Add logger messages for possible debugging purposes	2024-09-09 10:40:41 +02:00
Julie Lenaerts	29fec50515	Add cronjob and repository method to find and cancel stale workflows every other day	2024-09-09 10:40:41 +02:00
Julie Lenaerts	34edb02cd0	Create message and handler for canceling stale workflows	2024-09-09 10:40:41 +02:00
Julie Lenaerts	860ae5cedf	Create CancelStaleWorkflow message and handler	2024-09-09 10:40:40 +02:00
Julien Fastré	bf056046ab	Fix cs	2024-09-06 14:40:25 +02:00
Julien Fastré	49ad25b4c8	Refactor WorkflowOnHoldController and improve tests ... Refactored WorkflowOnHoldController to remove dependencies and improve redirect handling. Updated test cases to use PHPUnit instead of KernelTestCase and mock proper dependencies. Added relationship handling in EntityWorkflowStep to manage EntityWorkflowStepHold instances accurately.	2024-09-06 14:02:11 +02:00
Julien Fastré	ad94310981	Refactor workflow hold functionality to avoid relying on database to perform some checks on "user holds entityworkflow" ... Simplify the logic in handling workflow on hold status by moving related checks and operations to `EntityWorkflowStep` and `EntityWorkflow` entities. This includes implementing new methods to check if a step or workflow is held by a specific user and refactoring the controller actions to use these methods.	2024-09-05 20:46:29 +02:00
Julien Fastré	e8f09b507f	Fix cs after php-cs-fixer upgrade, fix phpstan and rector errors	2024-09-05 18:00:37 +02:00
Julien Fastré	e29e1db6ed	Take into account 'destUserByAccessKey' in the list of workflows associated to a user ... Refactor the query to include checks for user membership via both 'destUser' and 'destUserByAccessKey'. This ensures that workflows correctly account for user access by multiple criteria.	2024-09-05 17:38:18 +02:00
Julie Lenaerts	8c4f342ca1	Correct instantiation of controller within test	2024-09-05 17:19:28 +02:00
Julie Lenaerts	745a29f742	Adjust logic for removing the hold on a workflow only by user who owns the hold and when a transition is applied on the workflow	2024-09-05 17:19:27 +02:00
Julie Lenaerts	41ffc470a0	Adjust test to check creation of onHold if user is allowed to apply a transition	2024-09-05 17:19:27 +02:00
Julie Lenaerts	46b31ae1ea	Adjust logic to only allow on hold if user is allowed to apply a transition	2024-09-05 17:19:26 +02:00
Julie Lenaerts	8c5e94e295	Work on test for workflowOnHold controller	2024-09-05 17:19:25 +02:00
Julie Lenaerts	9c8a84cdbd	Add test for WorkflowOnHoldControllerTest	2024-09-05 17:19:24 +02:00
Julie Lenaerts	a82b99aecc	Add template-extends on EntityWorkflowStepHoldRepository	2024-09-05 17:19:23 +02:00
Julie Lenaerts	deb4bda16e	Add unique constraint as attribute on EntityWorkflowStepHold class	2024-09-05 17:19:23 +02:00
Julie Lenaerts	c1e5f4a57e	Move onHold methods to a separate WorkflowOnHold controller	2024-09-05 17:19:20 +02:00
Julie Lenaerts	6fc5a10dc4	Add unique constraint to migration	2024-09-05 17:18:43 +02:00
Julie Lenaerts	18abc84e68	Rector fixes	2024-09-05 17:18:43 +02:00
Julie Lenaerts	e85c31826f	php cs fixes	2024-09-05 17:18:42 +02:00
Julie Lenaerts	d119ba49f7	Add on_hold label to vue components	2024-09-05 17:18:42 +02:00