91 Commits

Author	SHA1	Message	Date
Julien Fastré	261bc88b5e	Add suggested persons and third parties methods ... Introduced getSuggestedPersons and getSuggestedThirdParties methods across various WorkflowHandlers. These methods integrate with ProvidePersonsAssociated and ProvideThirdPartiesAssociated services to fetch related entities, enhancing the workflow handling capabilities.	2024-10-23 11:41:19 +02:00
Julien Fastré	85dc9bdb2f	Add getSuggestedUsers method in EntityWorkflowManager ... Implemented the method to retrieve a list of suggested users for an entity workflow, filtering out duplicates. Added corresponding unit tests to verify the method's functionality and ensure its correctness in various scenarios.	2024-10-22 23:35:13 +02:00
Julien Fastré	daef18408a	fix the return type of the EntityWorkflowCreation constraint	2024-10-18 19:26:09 +02:00
Julien Fastré	91a4b45607	Add notification to user groups on workflow transition ... Implemented NotificationToUserGroupsOnTransition to send group emails upon workflow completion. Also updated NotificationOnTransition to prevent double notifications and created a unit test for the new functionality.	2024-10-18 19:25:03 +02:00
Julien Fastré	29fa086fde	Set return types to MetadataExtractor	2024-10-18 19:14:23 +02:00
Julien Fastré	9fe20b5e81	Show pending signatures in the person's search results	2024-10-15 15:15:32 +02:00
Julien Fastré	d283d62049	!fixup Automatically execute body renderer when posting an	2024-10-15 11:10:31 +02:00
Julien Fastré	1313b6f138	Automatically execute body renderer when posting an email in Chill ... + adaptation of services which already uses body renderer	2024-10-10 14:06:00 +02:00
Julien Fastré	8589bada3f	Layout for the email to external	2024-10-10 13:40:07 +02:00
Julien Fastré	3f7c5d23dc	Add return type hint to getTargets method ... The getTargets method now explicitly returns an array, enhancing type safety and readability. This change ensures that the return type is clear to any developers interacting with this method.	2024-10-10 11:41:25 +02:00
Julien Fastré	78445f0d65	fixup! Add message handling for public view creation	2024-10-10 11:39:04 +02:00
Julien Fastré	c329a1f1f8	fixup! Add message handling for public view creation	2024-10-10 09:39:45 +02:00
Julien Fastré	82e2b9a0f6	Add message handling for public view creation ... Introduce `PostPublicViewMessage` and `PostPublicViewMessageHandler` to handle external user views on public links by applying workflow transitions. Integrate with `WorkflowViewSendPublicController` and add relevant tests.	2024-10-09 21:39:27 +02:00
Julien Fastré	3f80d62ca2	Add public workflow view functionality ... Introduced the ability to render public views for workflows, including new templates, handlers, and metadata support. Updated entity interfaces and translations to enhance the public sharing of workflow documents.	2024-10-08 15:15:58 +02:00
Julien Fastré	5c0f3cb317	Implement the controller action to view the EntityworkflowSend	2024-10-07 15:35:36 +02:00
Julien Fastré	a0b5c208eb	Send an email when a workflow is send to an external ... - create an event subscriber to catch the workflow which arrive to a "sentExternal" step; - add a messenger's message to handle the generation of the email; - add a simple message, and a simple controller for viewing the document - add dedicated tests	2024-10-04 13:52:18 +02:00
Julien Fastré	7913a377c8	Move the logic to check if dest users are required to a dedicated constraint ... - Create a dedicated constraint to check if the destUsers are required by the applied transition. - Apply on WorkflowTransitionContextDTO and, if required, use the built-in constraints - create tests	2024-10-04 13:41:20 +02:00
Julien Fastré	7cd638c5fc	Add TransitionHasDestineeIfIsSentExternal validator ... This commit introduces a new validator to ensure that transitions marked as 'sent' have a designated external recipient. It includes related tests for scenarios with and without recipients and covers integration with the workflow context.	2024-10-04 13:41:20 +02:00
Julien Fastré	071c5e3c55	Update the form to allow sending a workflow to an external destinee ... OP#734 Modification du formulaire pour permettre l'envoi d'un workflow https://champs-libres.openproject.com/work_packages/734	2024-10-04 13:41:20 +02:00
Julien Fastré	803332ba5f	Remove the feature "send a workflow to an email address"	2024-10-01 18:49:51 +02:00
Julien Fastré	0c1d9ee4be	Add support for handling user groups in workflow counters and list workflows in "my workflows" controller ... - rewrite queries in repositories; - fix cache key cleaning for members of users when a workflow is transitionned	2024-09-27 10:35:57 +02:00
Julien Fastré	87599425df	Send a notification to all User which are members of UserGroups, when a workflow is sent to them	2024-09-26 17:29:27 +02:00
Julien Fastré	86ec6f82da	Do not block transition in EntityWorkflow when the user is member of a dest user group ... - refactor EntityWorkflowGuardTransition + tests - allow to find easily user within userGroup by adding a dedicated method to UserGroup::contains	2024-09-26 16:04:53 +02:00
Julien Fastré	17f4c85fa5	Add user group support in entity workflow steps ... Enhanced the WorkflowTransitionContextDTO to include user groups alongside individual users for future steps. Updated the relevant entity and form classes to accommodate this change and included the necessary database migration script.	2024-09-26 15:39:13 +02:00
Julien Fastré	5287824dbe	Add async handling for signature state changes ... Introduce MessageBus to handle post-signature operations asynchronously. This ensures that further steps are executed through dispatched messages, improving system scalability and performance. Implement new handlers and messages for the workflow state transitions.	2024-09-25 11:58:41 +02:00
Julien Fastré	cfce531754	Add reject functionality for workflow signatures ... Implemented the ability to reject workflow signatures by adding necessary templates, routes, and authorization checks. Updated the `WorkflowSignatureCancelController` to handle rejection and modified existing templates and translations to support the new feature.	2024-09-25 11:31:27 +02:00
Julien Fastré	83121c2a83	Implement signature cancellation feature ... Added functionality to cancel signatures in workflow, including controller, view, and tests. Updated translations and adjusted templates to support and display cancellation actions.	2024-09-25 10:58:53 +02:00
Julien Fastré	5a5d259d18	Add duplicate workflow prevention in MetadataExtractor ... Integrate DuplicateEntityWorkflowFinder to prevent creating workflows for entities with existing opened or positive final workflows. Updated EntityWorkflowVoter to implement the same check before allowing creation. Removed unnecessary blank workflow parameter from Twig template.	2024-09-24 14:25:00 +02:00
Julien Fastré	758a14366e	Add OpenedEntityWorkflowHelper and tests ... Implemented OpenedEntityWorkflowHelper to handle final state checks for EntityWorkflow. This includes methods to determine if a workflow has reached positive or negative final steps. Added corresponding unit tests to ensure proper functionality.	2024-09-24 14:25:00 +02:00
Julien Fastré	7b06c80c2a	Merge branch 'signature-app/wp-706-no-forward-unless-signed' into 'signature-app-master' ... Block transition if there is a pending signature for the entityWorkflow See merge request Chill-Projet/chill-bundles!736	2024-09-24 09:13:45 +00:00
Julien Fastré	cf2fe1bba7	Add guards and tests for entity workflow transitions ... Introduced EntityWorkflowGuardUnsignedTransition to block transitions with pending signatures. Implemented a new center resolver and added comprehensive unit tests for verifying transition rules and permissions.	2024-09-24 11:08:22 +02:00
Julien Fastré	a8c5d1f660	Remove unused constructor parameter	2024-09-19 17:48:34 +02:00
Julien Fastré	4d8de46ac9	Apply the voter to allow all transition on EntityWorkflowGuardTransition ... This allow to effectively check that a user is allowed to apply all transitions on a workflow and, if yes, enable the given transition.	2024-09-16 14:47:00 +02:00
Julien Fastré	4e588ed0e0	Add logging to SignatureStepStateChanger ... Enhanced the SignatureStepStateChanger by integrating a LoggerInterface to provide detailed logging at key points in the state transition process. This includes informational messages when marking signatures or skipping transitions, as well as debug messages when determining the next steps.	2024-09-11 21:14:07 +02:00
Julien Fastré	70671dadac	Refactor workflow guard logic and add internal methods ... Removed guard logic from EntityWorkflowTransitionEventSubscriber and created a new EntityWorkflowGuardTransition class for separation of concerns. Marked several setter methods in EntityWorkflowStepSignature as internal to guide proper usage. Added comprehensive tests to ensure the new guard logic functions correctly.	2024-09-11 21:13:58 +02:00
nobohan	1197a46f5f	Refactor PDF signature handling and add signature state changer ... Simplified PdfSignedMessageHandler by delegating signature state changes to a new SignatureStepStateChanger class. Added utility method to EntityWorkflowStepSignature for checking pending signatures and created new test cases for the SignatureStepStateChanger.	2024-09-10 21:27:55 +02:00
Julien Fastré	313fb9ffdf	PHP CS Fixer updated (3.63.1 -> v3.64.0)	2024-09-04 14:38:56 +02:00
Julien Fastré	8aec69f0f9	Merge remote-tracking branch 'origin/signature-app-master' into 286-storedobject-voter	2024-07-16 13:34:36 +02:00
Julien Fastré	9e92ede16f	Handle cases when there are multiple EntityWorkflows associated with one entity	2024-07-15 21:22:30 +02:00
Julien Fastré	db94af0958	Add support for user signatures in workflow transitions ... This update introduces the ability to specify user signatures in workflow transitions. It allows a nullable user to be declared that may be requested to apply a signature. The code now handles the use-case of signing a transition by a user in addition to previous functionality of having it signed by a "Person" entity. Corresponding tests are also updated to validate this new feature.	2024-07-10 12:47:02 +02:00
Julien Fastré	c1cf27c42d	Refactor workflow handlers and update comments ... Changes include class refactoring for Workflow handlers, using `readonly` and better indentation in constructors for better readability. In addition, outdated comments are removed. Also, entity workflow handlers now implement the EntityWorkflowHandlerInterface type for better type safety.	2024-07-10 10:40:18 +02:00
Julien Fastré	fe6b4848e6	Implement workflow handlers for stored objects ... Added new interface, EntityWorkflowWithStoredObjectHandlerInterface, which provides methods to handle workflows associated with stored objects. Two classes, AccompanyingPeriodWorkEvaluationDocumentWorkflowHandler and AccompanyingCourseDocumentWorkflowHandler, have been updated to implement this new interface. The EntityWorkflowManager class has also been updated to handle workflows associated with stored objects.	2024-07-10 10:40:18 +02:00
Julien Fastré	b5af9f7b63	Add futurePersonSignatures property to WorkflowTransitionContextDTO ... A new property named futurePersonSignatures has been added to the WorkflowTransitionContextDTO class. This will hold a list of Person objects expected to sign the next step, improving the scope of information available within the workflow context.	2024-07-10 10:40:18 +02:00
Julien Fastré	7f3de62b2c	Move the metadata on each workflow transition from the event subscriber to the entity EntityWorkflow::setStep method ... The main update is in the setStep method of EntityWorkflow, where parameters are added to capture the transition details. These include the exact transition, the user who made the transition and the time of transition. The WorkflowController extracts this information and put it into the transition's context. The MarkingStore transfer it to the EntityWorkflow::setStep method, and all metadata are recorded within the entities themselve.	2024-07-10 10:40:17 +02:00
Julie Lenaerts	790576863f	Merge signature-app-master into branch	2024-07-04 15:53:01 +02:00
Julie Lenaerts	21b79c1981	Php cs fixes	2024-07-04 11:39:02 +02:00
Julien Fastré	a309cc0774	Refactor workflow classes and forms ... - the workflow controller add a context to each transition; - the state of the entity workflow is applyied using a dedicated marking store - the method EntityWorkflow::step use the context to associate the new step with the future destination user, cc users and email. This makes the step consistent at every step. - this allow to remove some logic which was processed in eventSubscribers, - as counterpart, each workflow must specify a dedicated marking_store: ```yaml framework: workflows: vendee_internal: # ... marking_store: service: Chill\MainBundle\Workflow\EntityWorkflowMarkingStore ```	2024-07-02 08:30:28 +02:00
Julie Lenaerts	c9d2e37cee	Implement logic to check if editing of document is blocked by workflow ... Using the workflow handlers we return the workflow that is attached to an object so that within the workflowDocumentService we can then check whether this workflow blocks the edition of a document.	2024-07-01 12:14:03 +02:00
Julien Fastré	5be85a4fc6	Refactored code to use PHP8 attributes instead of annotations ... In this change, Doctrine and validation annotations have been replaced with PHP8 Attributes. The Rector tool has been configured with a list of annotations to convert to attributes. As a consequence, the PHPStan's rules have been updated to reflect these changes. The PHP8's nullable operator (?) has been added where required, and comments in field declaration have been replaced with #[Attribute] syntax.	2024-04-08 12:11:29 +02:00
Julien Fastré	f889d67e94	fixes after merge of master into upgrade-sf4	2024-02-12 22:31:16 +01:00