Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-08-22 15:43:51 +00:00
Code Issues Actions Projects Releases Wiki Activity

Refactor test methods in AbstractFilterTest to be static + rector rules for updating existing

Browse Source 
All test methods in AbstractFilterTest class have been refactored to be static.

A rector rule has been created to refactor existing test.
This commit is contained in:
Julien Fastré
2024-02-14 22:30:16 +01:00
parent edcf78d6cc
commit fa0204adbc
6 changed files with 357 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/Bundle/ChillMainBundle/Test/Export/AbstractFilterTest.php
View File

@@ -46,11 +46,11 @@ abstract class AbstractFilterTest extends KernelTestCase
/**
* provide data for `testAliasDidNotDisappears`.
*/
public function dataProviderAliasDidNotDisappears()
public static function dataProviderAliasDidNotDisappears()
{
$datas = $this->getFormData();
$datas = static::getFormData();
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
@@ -61,11 +61,11 @@ abstract class AbstractFilterTest extends KernelTestCase
}
}
public function dataProviderAlterQuery()
public static function dataProviderAlterQuery()
{
$datas = $this->getFormData();
$datas = static::getFormData();
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
@@ -76,11 +76,11 @@ abstract class AbstractFilterTest extends KernelTestCase
}
}
public function dataProvideQueryExecution(): iterable
public static function dataProvideQueryExecution(): iterable
{
$datas = $this->getFormData();
$datas = static::getFormData();
foreach ($this->getQueryBuilders() as $qb) {
foreach (static::getQueryBuilders() as $qb) {
if ([] === $datas) {
yield [clone $qb, []];
} else {
@@ -91,9 +91,9 @@ abstract class AbstractFilterTest extends KernelTestCase
}
}
public function dataProviderDescriptionAction()
public static function dataProviderDescriptionAction()
{
foreach ($this->getFormData() as $data) {
foreach (static::getFormData() as $data) {
yield [$data];
}
}
@@ -117,7 +117,7 @@ abstract class AbstractFilterTest extends KernelTestCase
*
* @return array an array of data. Example : `array( array(), array('fields' => array(1,2,3), ...)` where an empty array and `array(1,2,3)` are possible values
*/
abstract public function getFormData();
abstract public static function getFormData();
/**
* Return an array with different minimal query builders.
@@ -127,7 +127,7 @@ abstract class AbstractFilterTest extends KernelTestCase
*
* @return QueryBuilder[] an array of query builder
*/
abstract public function getQueryBuilders();
abstract public static function getQueryBuilders();
/**
* Compare aliases array before and after that filter alter query.