Add external identifiers for person, editable in edit form, with minimal features associated

src/Bundle/ChillPersonBundle/Controller/PersonController.php

@@ -17,7 +17,6 @@ use Chill\PersonBundle\Entity\Household\Household;
 use Chill\PersonBundle\Entity\Household\HouseholdMember;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Form\CreationPersonType;
-use Chill\PersonBundle\Form\PersonType;
 use Chill\PersonBundle\Privacy\PrivacyEvent;
 use Chill\PersonBundle\Repository\PersonRepository;
 use Chill\PersonBundle\Search\SimilarPersonMatcher;
@@ -49,56 +48,6 @@ final class PersonController extends AbstractController
         private readonly EntityManagerInterface $em,
     ) {}
 
-    #[Route(path: '/{_locale}/person/{person_id}/general/edit', name: 'chill_person_general_edit')]
-    public function editAction(int $person_id, Request $request)
-    {
-        $person = $this->_getPerson($person_id);
-
-        if (null === $person) {
-            throw $this->createNotFoundException();
-        }
-
-        $this->denyAccessUnlessGranted(
-            'CHILL_PERSON_UPDATE',
-            $person,
-            'You are not allowed to edit this person'
-        );
-
-        $form = $this->createForm(
-            PersonType::class,
-            $person,
-            [
-                'cFGroup' => $this->getCFGroup(),
-            ]
-        );
-
-        $form->handleRequest($request);
-
-        if ($form->isSubmitted() && !$form->isValid()) {
-            $this->get('session')
-                ->getFlashBag()->add('error', $this->translator
-                ->trans('This form contains errors'));
-        } elseif ($form->isSubmitted() && $form->isValid()) {
-            $this->em->flush();
-
-            $this->get('session')->getFlashBag()
-                ->add(
-                    'success',
-                    $this->translator
-                        ->trans('The person data has been updated')
-                );
-
-            return $this->redirectToRoute('chill_person_view', [
-                'person_id' => $person->getId(),
-            ]);
-        }
-
-        return $this->render(
-            '@ChillPerson/Person/edit.html.twig',
-            ['person' => $person, 'form' => $form->createView()]
-        );
-    }
-
     public function getCFGroup()
     {
         $cFGroup = null;

src/Bundle/ChillPersonBundle/Controller/PersonEditController.php

@@ -0,0 +1,79 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\PersonBundle\Controller;
+
+use Chill\CustomFieldsBundle\EntityRepository\CustomFieldsDefaultGroupRepository;
+use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Form\PersonType;
+use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use Doctrine\ORM\EntityManagerInterface;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
+use Symfony\Component\Form\FormFactoryInterface;
+use Symfony\Component\HttpFoundation\RedirectResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Session\Session;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
+use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
+use Symfony\Component\Security\Core\Security;
+use Symfony\Component\Translation\TranslatableMessage;
+use Twig\Environment;
+
+final readonly class PersonEditController
+{
+    public function __construct(
+        private Security $security,
+        private FormFactoryInterface $formFactory,
+        private CustomFieldsDefaultGroupRepository $customFieldsDefaultGroupRepository,
+        private EntityManagerInterface $entityManager,
+        private UrlGeneratorInterface $urlGenerator,
+        private Environment $twig,
+    ) {}
+
+    /**
+     * @ParamConverter("person", options={"id": "person_id"})
+     */
+    #[Route(path: '/{_locale}/person/{person_id}/general/edit', name: 'chill_person_general_edit')]
+    public function editAction(Person $person, Request $request, Session $session)
+    {
+        if (!$this->security->isGranted(PersonVoter::UPDATE, $person)) {
+            throw new AccessDeniedHttpException('You are not allowed to edit this person.');
+        }
+
+        $form = $this->formFactory->create(
+            PersonType::class,
+            $person,
+            ['cFGroup' => $this->customFieldsDefaultGroupRepository->findOneByEntity(Person::class)?->getCustomFieldsGroup()]
+        );
+
+        $form->handleRequest($request);
+
+        if ($form->isSubmitted() && !$form->isValid()) {
+            $session
+                ->getFlashBag()->add('error', new TranslatableMessage('This form contains errors'));
+        } elseif ($form->isSubmitted() && $form->isValid()) {
+            $this->entityManager->flush();
+
+            $session->getFlashBag()->add('success', new TranslatableMessage('The person data has been updated'));
+
+            return new RedirectResponse(
+                $this->urlGenerator->generate('chill_person_view', ['person_id' => $person->getId()])
+            );
+        }
+
+        return new Response($this->twig->render('@ChillPerson/Person/edit.html.twig', [
+            'form' => $form->createView(),
+            'person' => $person,
+        ]));
+    }
+}