Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-09-27 09:05:01 +00:00
Code Issues Actions Projects Releases Wiki Activity

Remove serializer.yaml configuration, update PersonJsonNormalizer and PersonJsonDenormalizer for improved logic handling, adjust type hints in closures, and rename id to definition_id in PersonIdentifierWorkerNormalizer.

Browse Source
This commit is contained in:
Julien Fastré
2025-09-16 12:43:39 +02:00
parent 5687f16817
commit e845f8266b
5 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php
View File

@@ -96,7 +96,6 @@ class ChillPersonExtension extends Extension implements PrependExtensionInterfac
// We can get rid of this file when the service 'chill.person.repository.person' is no more used. // We can get rid of this file when the service 'chill.person.repository.person' is no more used.
// We should use the PersonRepository service instead of a custom service name. // We should use the PersonRepository service instead of a custom service name.
$loader->load('services/repository.yaml'); $loader->load('services/repository.yaml');
$loader->load('services/serializer.yaml');
$loader->load('services/security.yaml'); $loader->load('services/security.yaml');
$loader->load('services/doctrineEventListener.yaml'); $loader->load('services/doctrineEventListener.yaml');
$loader->load('services/accompanyingPeriodConsistency.yaml'); $loader->load('services/accompanyingPeriodConsistency.yaml');

2
src/Bundle/ChillPersonBundle/PersonIdentifier/Normalizer/PersonIdentifierWorkerNormalizer.php
View File

@@ -24,7 +24,7 @@ final readonly class PersonIdentifierWorkerNormalizer implements NormalizerInter
return [ return [
'type' => 'person_identifier_worker', 'type' => 'person_identifier_worker',
'id' => $object->getDefinition()->getId(), 'definition_id' => $object->getDefinition()->getId(),
'engine' => $object->getDefinition()->getEngine(), 'engine' => $object->getDefinition()->getEngine(),
'label' => $object->getDefinition()->getLabel(), 'label' => $object->getDefinition()->getLabel(),
'isActive' => $object->getDefinition()->isActive(), 'isActive' => $object->getDefinition()->isActive(),

8
src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonJsonDenormalizer.php
View File

@@ -62,7 +62,7 @@ final class PersonJsonDenormalizer implements DenormalizerInterface, Denormalize
$person->setMobilenumber($this->denormalizer->denormalize($data['mobilenumber'], PhoneNumber::class, $format, $context)); $person->setMobilenumber($this->denormalizer->denormalize($data['mobilenumber'], PhoneNumber::class, $format, $context));
} }
if (\array_key_exists('gender', $data)) { if (\array_key_exists('gender', $data) && null !== $data['gender']) {
$gender = $this->denormalizer->denormalize($data['gender'], Gender::class, $format, []); $gender = $this->denormalizer->denormalize($data['gender'], Gender::class, $format, []);
$person->setGender($gender); $person->setGender($gender);
} }
@@ -93,7 +93,7 @@ final class PersonJsonDenormalizer implements DenormalizerInterface, Denormalize
$altNameKey = $altNameData['key']; $altNameKey = $altNameData['key'];
$altNameValue = $altNameData['value']; $altNameValue = $altNameData['value'];
$altName = $person->getAltNames()->findFirst(fn (PersonAltName $personAltName) => $personAltName->getKey() === $altNameKey); $altName = $person->getAltNames()->findFirst(fn (int $key, PersonAltName $personAltName) => $personAltName->getKey() === $altNameKey);
if (null === $altName) { if (null === $altName) {
$altName = new PersonAltName(); $altName = new PersonAltName();
$person->addAltName($altName); $person->addAltName($altName);
@@ -117,7 +117,7 @@ final class PersonJsonDenormalizer implements DenormalizerInterface, Denormalize
$worker = $this->personIdentifierManager->buildWorkerByPersonIdentifierDefinition($definitionId); $worker = $this->personIdentifierManager->buildWorkerByPersonIdentifierDefinition($definitionId);
$personIdentifier = $person->getIdentifiers()->findFirst(fn (PersonIdentifier $personIdentifier) => $personIdentifier->getId() === $definitionId); $personIdentifier = $person->getIdentifiers()->findFirst(fn (int $key, PersonIdentifier $personIdentifier) => $personIdentifier->getId() === $definitionId);
if (null === $personIdentifier) { if (null === $personIdentifier) {
$personIdentifier = new PersonIdentifier($worker->getDefinition()); $personIdentifier = new PersonIdentifier($worker->getDefinition());
$person->addIdentifier($personIdentifier); $person->addIdentifier($personIdentifier);
@@ -132,7 +132,7 @@ final class PersonJsonDenormalizer implements DenormalizerInterface, Denormalize
$person->setEmail($data['email']); $person->setEmail($data['email']);
} }
if (\array_key_exists('civility', $data)) { if (\array_key_exists('civility', $data) && null !== $data['civility']) {
$civility = $this->denormalizer->denormalize($data['civility'], Civility::class, $format, []); $civility = $this->denormalizer->denormalize($data['civility'], Civility::class, $format, []);
$person->setCivility($civility); $person->setCivility($civility);
} }

3
src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonJsonNormalizer.php
View File

@@ -21,11 +21,12 @@ use Doctrine\Common\Collections\Collection;
use Symfony\Component\Serializer\Normalizer\AbstractNormalizer; use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface; use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait; use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
/** /**
* Serialize a Person entity. * Serialize a Person entity.
*/ */
class PersonJsonNormalizer implements NormalizerAwareInterface class PersonJsonNormalizer implements NormalizerAwareInterface, NormalizerInterface
{ {
use NormalizerAwareTrait; use NormalizerAwareTrait;

11
src/Bundle/ChillPersonBundle/config/services/serializer.yaml
View File

@@ -1,11 +0,0 @@
---
services:
# note: normalizers are loaded from ../services.yaml
Chill\PersonBundle\Serializer\Normalizer\:
autowire: true
autoconfigure: true
resource: '../../Serializer/Normalizer'
tags:
- { name: 'serializer.normalizer', priority: 64 }