Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-08-23 16:13:50 +00:00
Code Issues Actions Projects Releases Wiki Activity

upgrade and refactor personhistoryFile

Browse Source
This commit is contained in:
Julien Fastré
2014-11-07 23:48:26 +01:00
parent 29af313582
commit e5f67e32c3
15 changed files with 365 additions and 288 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
Entity/Person.php
View File

@@ -110,11 +110,9 @@ class Person {
*
* @param \DateTime $date
*/
public function open(\DateTime $date, $memo = '') {
$history = new PersonHistoryFile($date);
$history->setMemo($memo);
public function open(PersonHistoryFile $accompanyingPeriod) {
$this->proxyHistoryOpenState = true;
$this->addHistoryFile($history);
$this->addHistoryFile($accompanyingPeriod);
}
/**
@@ -126,30 +124,12 @@ class Person {
*
* To check if the Person and his history are consistent, use validation.
*
* @param \DateTime $date
* @param string $motive
* @param string $memo
* @param PersonHistoryFile
* @throws \Exception if two lines of history are open.
*/
public function close(\DateTime $date, $motive, $memo = '') {
$histories = $this->history;
$found = false;
foreach ($histories as $history) {
if ($history->isOpen()) {
if ($found === true) {
throw new \Exception('two open line in history were found. This should not happen.');
}
$history->setDateClosing($date);
$history->setMotive($motive);
$history->setMemo($memo);
$this->proxyHistoryOpenState = false;
$found = true;
}
}
public function close(PersonHistoryFile $accompanyingPeriod)
{
$this->proxyHistoryOpenState = false;
}
/**