DX: apply rector rules up to php8.0

This commit is contained in:
2023-04-15 01:05:37 +02:00
parent d8870e906f
commit dde3002100
714 changed files with 2348 additions and 9263 deletions

View File

@@ -22,14 +22,8 @@ use Symfony\Component\Workflow\Event\Event;
final class WorkflowByUserCounter implements NotificationCounterInterface, EventSubscriberInterface
{
private CacheItemPoolInterface $cacheItemPool;
private EntityWorkflowStepRepository $workflowStepRepository;
public function __construct(EntityWorkflowStepRepository $workflowStepRepository, CacheItemPoolInterface $cacheItemPool)
public function __construct(private EntityWorkflowStepRepository $workflowStepRepository, private CacheItemPoolInterface $cacheItemPool)
{
$this->workflowStepRepository = $workflowStepRepository;
$this->cacheItemPool = $cacheItemPool;
}
public function addNotification(UserInterface $u): int

View File

@@ -18,16 +18,10 @@ use Symfony\Component\Workflow\Registry;
class EntityWorkflowManager
{
/**
* @var iterable|EntityWorkflowHandlerInterface[]
* @param \Chill\MainBundle\Workflow\EntityWorkflowHandlerInterface[] $handlers
*/
private iterable $handlers;
private Registry $registry;
public function __construct(iterable $handlers, Registry $registry)
public function __construct(private iterable $handlers, private Registry $registry)
{
$this->handlers = $handlers;
$this->registry = $registry;
}
public function getHandler(EntityWorkflow $entityWorkflow, array $options = []): EntityWorkflowHandlerInterface

View File

@@ -25,20 +25,8 @@ use function array_key_exists;
class EntityWorkflowTransitionEventSubscriber implements EventSubscriberInterface
{
private LoggerInterface $chillLogger;
private Security $security;
private UserRender $userRender;
public function __construct(
LoggerInterface $chillLogger,
Security $security,
UserRender $userRender
) {
$this->chillLogger = $chillLogger;
$this->security = $security;
$this->userRender = $userRender;
public function __construct(private LoggerInterface $chillLogger, private Security $security, private UserRender $userRender)
{
}
public function addDests(Event $event): void

View File

@@ -25,28 +25,8 @@ use function in_array;
class NotificationOnTransition implements EventSubscriberInterface
{
private EngineInterface $engine;
private EntityManagerInterface $entityManager;
private MetadataExtractor $metadataExtractor;
private Registry $registry;
private Security $security;
public function __construct(
EntityManagerInterface $entityManager,
EngineInterface $engine,
MetadataExtractor $metadataExtractor,
Security $security,
Registry $registry
) {
$this->entityManager = $entityManager;
$this->engine = $engine;
$this->metadataExtractor = $metadataExtractor;
$this->registry = $registry;
$this->security = $security;
public function __construct(private EntityManagerInterface $entityManager, private EngineInterface $engine, private MetadataExtractor $metadataExtractor, private Security $security, private Registry $registry)
{
}
public static function getSubscribedEvents(): array

View File

@@ -21,23 +21,8 @@ use Symfony\Component\Workflow\Registry;
class SendAccessKeyEventSubscriber
{
private EngineInterface $engine;
private EntityWorkflowManager $entityWorkflowManager;
private MailerInterface $mailer;
private MetadataExtractor $metadataExtractor;
private Registry $registry;
public function __construct(EngineInterface $engine, MetadataExtractor $metadataExtractor, Registry $registry, EntityWorkflowManager $entityWorkflowManager, MailerInterface $mailer)
public function __construct(private EngineInterface $engine, private MetadataExtractor $metadataExtractor, private Registry $registry, private EntityWorkflowManager $entityWorkflowManager, private MailerInterface $mailer)
{
$this->engine = $engine;
$this->metadataExtractor = $metadataExtractor;
$this->registry = $registry;
$this->entityWorkflowManager = $entityWorkflowManager;
$this->mailer = $mailer;
}
public function postPersist(EntityWorkflowStep $step): void

View File

@@ -20,14 +20,8 @@ use function array_key_exists;
class MetadataExtractor
{
private Registry $registry;
private TranslatableStringHelperInterface $translatableStringHelper;
public function __construct(Registry $registry, TranslatableStringHelperInterface $translatableStringHelper)
public function __construct(private Registry $registry, private TranslatableStringHelperInterface $translatableStringHelper)
{
$this->registry = $registry;
$this->translatableStringHelper = $translatableStringHelper;
}
public function availableWorkflowFor(string $relatedEntityClass, ?int $relatedEntityId = 0): array

View File

@@ -20,20 +20,8 @@ use Symfony\Component\Security\Core\Security;
class WorkflowNotificationHandler implements NotificationHandlerInterface
{
private EntityWorkflowManager $entityWorkflowManager;
private EntityWorkflowRepository $entityWorkflowRepository;
private Security $security;
public function __construct(
EntityWorkflowRepository $entityWorkflowRepository,
EntityWorkflowManager $entityWorkflowManager,
Security $security
) {
$this->entityWorkflowRepository = $entityWorkflowRepository;
$this->entityWorkflowManager = $entityWorkflowManager;
$this->security = $security;
public function __construct(private EntityWorkflowRepository $entityWorkflowRepository, private EntityWorkflowManager $entityWorkflowManager, private Security $security)
{
}
public function getTemplate(Notification $notification, array $options = []): string

View File

@@ -23,28 +23,8 @@ use Twig\Extension\RuntimeExtensionInterface;
class WorkflowTwigExtensionRuntime implements RuntimeExtensionInterface
{
private EntityWorkflowManager $entityWorkflowManager;
private MetadataExtractor $metadataExtractor;
private NormalizerInterface $normalizer;
private Registry $registry;
private EntityWorkflowRepository $repository;
public function __construct(
EntityWorkflowManager $entityWorkflowManager,
Registry $registry,
EntityWorkflowRepository $repository,
MetadataExtractor $metadataExtractor,
NormalizerInterface $normalizer
) {
$this->entityWorkflowManager = $entityWorkflowManager;
$this->registry = $registry;
$this->repository = $repository;
$this->metadataExtractor = $metadataExtractor;
$this->normalizer = $normalizer;
public function __construct(private EntityWorkflowManager $entityWorkflowManager, private Registry $registry, private EntityWorkflowRepository $repository, private MetadataExtractor $metadataExtractor, private NormalizerInterface $normalizer)
{
}
public function getTransitionByString(EntityWorkflow $entityWorkflow, string $key): ?Transition

View File

@@ -22,16 +22,12 @@ use function count;
class EntityWorkflowCreationValidator extends \Symfony\Component\Validator\ConstraintValidator
{
private EntityWorkflowManager $entityWorkflowManager;
public function __construct(EntityWorkflowManager $entityWorkflowManager)
public function __construct(private EntityWorkflowManager $entityWorkflowManager)
{
$this->entityWorkflowManager = $entityWorkflowManager;
}
/**
* @param EntityWorkflow $value
* @param Constraint|EntityWorkflowCreation $constraint
*/
public function validate($value, Constraint $constraint)
{
@@ -45,7 +41,7 @@ class EntityWorkflowCreationValidator extends \Symfony\Component\Validator\Const
try {
$handler = $this->entityWorkflowManager->getHandler($value);
} catch (HandlerNotFoundException $e) {
} catch (HandlerNotFoundException) {
$this->context->buildViolation($constraint->messageHandlerNotFound)
->addViolation();

View File

@@ -22,7 +22,6 @@ class StepDestValidValidator extends ConstraintValidator
{
/**
* @param EntityWorkflowStep $value
* @param Constraint|StepDestValid $constraint
*
* @return void
*/