DX: apply rector rules up to php8.0

src/Bundle/ChillMainBundle/Phonenumber/PhonenumberHelper.php

@@ -35,25 +35,19 @@ final class PhonenumberHelper implements PhoneNumberHelperInterface
 
     public const LOOKUP_URI = 'https://lookups.twilio.com/v1/PhoneNumbers/%s';
 
-    private CacheItemPoolInterface $cachePool;
-
     private array $config;
 
     private bool $isConfigured = false;
 
-    private LoggerInterface $logger;
-
     private PhonenumberUtil $phoneNumberUtil;
 
     private Client $twilioClient;
 
     public function __construct(
-        CacheItemPoolInterface $cacheUserData,
+        private CacheItemPoolInterface $cachePool,
         ParameterBagInterface $parameterBag,
-        LoggerInterface $logger
+        private LoggerInterface $logger
     ) {
-        $this->logger = $logger;
-        $this->cachePool = $cacheUserData;
         $this->config = $config = $parameterBag->get('chill_main.phone_helper');
 
         if (
@@ -93,17 +87,11 @@ final class PhonenumberHelper implements PhoneNumberHelperInterface
      */
     public function getType(PhoneNumber $phonenumber): string
     {
-        switch ($this->phoneNumberUtil->getNumberType($phonenumber)) {
-            case PhoneNumberType::MOBILE:
-                return 'mobile';
-
-            case PhoneNumberType::FIXED_LINE:
-            case PhoneNumberType::VOIP:
-                return 'landline';
-
-            default:
-                return 'landline';
-        }
+        return match ($this->phoneNumberUtil->getNumberType($phonenumber)) {
+            PhoneNumberType::MOBILE => 'mobile',
+            PhoneNumberType::FIXED_LINE, PhoneNumberType::VOIP => 'landline',
+            default => 'landline',
+        };
     }
 
     /**

src/Bundle/ChillMainBundle/Phonenumber/Templating.php

@@ -16,11 +16,8 @@ use Twig\TwigFilter;
 
 class Templating extends AbstractExtension
 {
-    protected PhonenumberHelper $phonenumberHelper;
-
-    public function __construct(PhonenumberHelper $phonenumberHelper)
+    public function __construct(protected PhonenumberHelper $phonenumberHelper)
     {
-        $this->phonenumberHelper = $phonenumberHelper;
     }
 
     public function formatPhonenumber($phonenumber)