fix some psalm errors

.gitignore

@@ -22,3 +22,4 @@ docs/build/
 
 /.php-cs-fixer.cache
 /.idea/
+/.psalm/

psalm.xml

@@ -6,6 +6,7 @@
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config tests/app/vendor/vimeo/psalm/config.xsd"
     errorBaseline="psalm-baseline.xml"
+    cacheDirectory="./.psalm"
 >
     <projectFiles>
         <directory name="src" />
@@ -13,4 +14,15 @@
             <directory name="./tests/" />
         </ignoreFiles>
     </projectFiles>
+
+    <!-- suppress error around parameter bags - see https://github.com/symfony/symfony/issues/45609#issuecomment-1056816975 -->
+    <!-- maybe to desactivate with php 8.1 ? -->
+    <issueHandlers>
+        <UndefinedDocblockClass>
+            <errorLevel type="suppress">
+                <referencedClass name="UnitEnum" />
+            </errorLevel>
+        </UndefinedDocblockClass>
+    </issueHandlers>
+
 </psalm>

src/Bundle/ChillBudgetBundle/Menu/HouseholdMenuBuilder.php

@@ -13,6 +13,7 @@ namespace Chill\BudgetBundle\Menu;
 
 use Chill\BudgetBundle\Security\Authorization\BudgetElementVoter;
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;
+use Chill\PersonBundle\Entity\Household\Household;
 use Knp\Menu\MenuItem;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;

src/Bundle/ChillBudgetBundle/Menu/PersonMenuBuilder.php

@@ -13,6 +13,7 @@ namespace Chill\BudgetBundle\Menu;
 
 use Chill\BudgetBundle\Security\Authorization\BudgetElementVoter;
 use Chill\MainBundle\Routing\LocalMenuBuilderInterface;
+use Chill\PersonBundle\Entity\Person;
 use Knp\Menu\MenuItem;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;

src/Bundle/ChillFamilyMembersBundle/Repository/FamilyMemberRepository.php

@@ -9,9 +9,9 @@
 
 declare(strict_types=1);
 
-namespace Chill\AMLI\FamilyMembersBundle\Repository;
+namespace Chill\FamilyMembersBundle\Repository;
 
-use Chill\AMLI\FamilyMembersBundle\Entity\FamilyMember;
+use Chill\FamilyMembersBundle\Entity\FamilyMember;
 use Chill\PersonBundle\Entity\Person;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;

src/Bundle/ChillMainBundle/Entity/Workflow/EntityWorkflowStep.php

@@ -160,6 +160,8 @@ class EntityWorkflowStep
     /**
      * get all the users which are allowed to apply a transition: those added manually, and
      * those added automatically bu using an access key.
+     *
+     * @psalm-suppress DuplicateArrayKey
      */
     public function getAllDestUser(): Collection
     {

src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php

@@ -553,8 +553,6 @@ class AccompanyingPeriod implements
      * 'now'.
      *
      * @param mixed $person
-     *
-     * @return void
      */
     public function closeParticipationFor($person): ?AccompanyingPeriodParticipation
     {

src/Bundle/ChillPersonBundle/Entity/Person.php

@@ -880,7 +880,7 @@ class Person implements HasCenterInterface, TrackCreationInterface, TrackUpdateI
     }
 
     /**
-     * @return Collection|BudgetCharges[]
+     * @return Collection|Charge[]
      */
     public function getBudgetCharges(): Collection
     {
@@ -888,7 +888,7 @@ class Person implements HasCenterInterface, TrackCreationInterface, TrackUpdateI
     }
 
     /**
-     * @return Collection|BudgetResources[]
+     * @return Collection|Resource[]
      */
     public function getBudgetResources(): Collection
     {

src/Bundle/ChillPersonBundle/Tests/Entity/AccompanyingPeriodTest.php

@@ -181,8 +181,12 @@ final class AccompanyingPeriodTest extends \PHPUnit\Framework\TestCase
         $this->assertEquals(1, $participations->count());
 
         $participationL = $period->closeParticipationFor($person);
-        $this->assertSame($participationL, $participation);
-        $this->assertTrue($participationL->getEndDate() instanceof DateTimeInterface);
+        $this->assertNotNull($participationL);
+
+        if ($participationL instanceof AccompanyingPeriodParticipation) {
+            $this->assertSame($participationL, $participation);
+            $this->assertTrue($participationL->getEndDate() instanceof DateTimeInterface);
+        }
 
         $participation = $period->getOpenParticipationContainsPerson($person);
         $this->assertNull($participation);

src/Bundle/ChillPersonBundle/Validator/Constraints/Relationship/RelationshipNoDuplicateValidator.php

@@ -11,10 +11,12 @@ declare(strict_types=1);
 
 namespace Chill\PersonBundle\Validator\Constraints\Relationship;
 
+use Chill\PersonBundle\Entity\Relationships\Relationship;
 use Chill\PersonBundle\Repository\Relationships\RelationshipRepository;
 use Symfony\Component\Form\Exception\UnexpectedTypeException;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
+use Symfony\Component\Validator\Exception\UnexpectedValueException;
 
 class RelationshipNoDuplicateValidator extends ConstraintValidator
 {
@@ -25,14 +27,18 @@ class RelationshipNoDuplicateValidator extends ConstraintValidator
         $this->relationshipRepository = $relationshipRepository;
     }
 
-    public function validate($relationship, Constraint $constraint)
+    public function validate($value, Constraint $constraint)
     {
         if (!$constraint instanceof RelationshipNoDuplicate) {
             throw new UnexpectedTypeException($constraint, RelationshipNoDuplicate::class);
         }
 
-        $fromPerson = $relationship->getFromPerson();
-        $toPerson = $relationship->getToPerson();
+        if (!$value instanceof Relationship) {
+            throw new UnexpectedValueException($value, Relationship::class);
+        }
+
+        $fromPerson = $value->getFromPerson();
+        $toPerson = $value->getToPerson();
 
         $relationships = $this->relationshipRepository->findBy([
             'fromPerson' => [$fromPerson, $toPerson],