Fix phpstan issues

src/Bundle/ChillMainBundle/Controller/WorkflowController.php

@@ -20,6 +20,7 @@ use Chill\MainBundle\Form\WorkflowStepType;
 use Chill\MainBundle\Pagination\PaginatorFactory;
 use Chill\MainBundle\Repository\Workflow\EntityWorkflowRepository;
 use Chill\MainBundle\Security\Authorization\EntityWorkflowVoter;
+use Chill\MainBundle\Security\ChillSecurity;
 use Chill\MainBundle\Workflow\EntityWorkflowManager;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
@@ -27,10 +28,9 @@ use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Routing\Annotation\Route;
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Component\Workflow\Registry;
 use Symfony\Component\Workflow\TransitionBlocker;
@@ -38,7 +38,7 @@ use Symfony\Contracts\Translation\TranslatorInterface;
 
 class WorkflowController extends AbstractController
 {
-    public function __construct(private readonly EntityWorkflowManager $entityWorkflowManager, private readonly EntityWorkflowRepository $entityWorkflowRepository, private readonly ValidatorInterface $validator, private readonly PaginatorFactory $paginatorFactory, private readonly Registry $registry, private readonly EntityManagerInterface $entityManager, private readonly TranslatorInterface $translator, private readonly Security $security) {}
+    public function __construct(private readonly EntityWorkflowManager $entityWorkflowManager, private readonly EntityWorkflowRepository $entityWorkflowRepository, private readonly ValidatorInterface $validator, private readonly PaginatorFactory $paginatorFactory, private readonly Registry $registry, private readonly EntityManagerInterface $entityManager, private readonly TranslatorInterface $translator, private readonly ChillSecurity $security) {}
 
     /**
      * @Route("/{_locale}/main/workflow/create", name="chill_main_workflow_create")
@@ -62,7 +62,7 @@ class WorkflowController extends AbstractController
             ->setRelatedEntityClass($request->query->get('entityClass'))
             ->setRelatedEntityId($request->query->getInt('entityId'))
             ->setWorkflowName($request->query->get('workflow'))
-            ->addSubscriberToFinal($this->getUser());
+            ->addSubscriberToFinal($this->security->getUser());
 
         $errors = $this->validator->validate($entityWorkflow, null, ['creation']);
 
@@ -123,17 +123,17 @@ class WorkflowController extends AbstractController
         }
 
         if (!$this->getUser() instanceof User) {
-            throw new AccessDeniedException('Not a valid user');
+            throw new AccessDeniedHttpException('Not a valid user');
         }
 
         if ($entityWorkflowStep->getAccessKey() !== $accessKey) {
-            throw new AccessDeniedException('Access key is invalid');
+            throw new AccessDeniedHttpException('Access key is invalid');
         }
 
         if (!$entityWorkflowStep->isWaitingForTransition()) {
             $this->addFlash('error', $this->translator->trans('workflow.Steps is not waiting for transition. Maybe someone apply the transition before you ?'));
         } else {
-            $entityWorkflowStep->addDestUserByAccessKey($this->getUser());
+            $entityWorkflowStep->addDestUserByAccessKey($this->security->getUser());
             $this->entityManager->flush();
             $this->addFlash('success', $this->translator->trans('workflow.You get access to this step'));
         }
@@ -150,11 +150,11 @@ class WorkflowController extends AbstractController
     {
         $this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
 
-        $total = $this->entityWorkflowRepository->countByPreviousTransitionned($this->getUser());
+        $total = $this->entityWorkflowRepository->countByPreviousTransitionned($this->security->getUser());
         $paginator = $this->paginatorFactory->create($total);
 
         $workflows = $this->entityWorkflowRepository->findByPreviousTransitionned(
-            $this->getUser(),
+            $this->security->getUser(),
             ['createdAt' => 'DESC'],
             $paginator->getItemsPerPage(),
             $paginator->getCurrentPageFirstItemNumber()
@@ -180,11 +180,11 @@ class WorkflowController extends AbstractController
     {
         $this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
 
-        $total = $this->entityWorkflowRepository->countByPreviousDestWithoutReaction($this->getUser());
+        $total = $this->entityWorkflowRepository->countByPreviousDestWithoutReaction($this->security->getUser());
         $paginator = $this->paginatorFactory->create($total);
 
         $workflows = $this->entityWorkflowRepository->findByPreviousDestWithoutReaction(
-            $this->getUser(),
+            $this->security->getUser(),
             ['createdAt' => 'DESC'],
             $paginator->getItemsPerPage(),
             $paginator->getCurrentPageFirstItemNumber()
@@ -208,11 +208,11 @@ class WorkflowController extends AbstractController
     {
         $this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
 
-        $total = $this->entityWorkflowRepository->countByDest($this->getUser());
+        $total = $this->entityWorkflowRepository->countByDest($this->security->getUser());
         $paginator = $this->paginatorFactory->create($total);
 
         $workflows = $this->entityWorkflowRepository->findByCc(
-            $this->getUser(),
+            $this->security->getUser(),
             ['createdAt' => 'DESC'],
             $paginator->getItemsPerPage(),
             $paginator->getCurrentPageFirstItemNumber()
@@ -235,11 +235,11 @@ class WorkflowController extends AbstractController
     {
         $this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
 
-        $total = $this->entityWorkflowRepository->countByDest($this->getUser());
+        $total = $this->entityWorkflowRepository->countByDest($this->security->getUser());
         $paginator = $this->paginatorFactory->create($total);
 
         $workflows = $this->entityWorkflowRepository->findByDest(
-            $this->getUser(),
+            $this->security->getUser(),
             ['createdAt' => 'DESC'],
             $paginator->getItemsPerPage(),
             $paginator->getCurrentPageFirstItemNumber()
@@ -262,11 +262,11 @@ class WorkflowController extends AbstractController
     {
         $this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
 
-        $total = $this->entityWorkflowRepository->countBySubscriber($this->getUser());
+        $total = $this->entityWorkflowRepository->countBySubscriber($this->security->getUser());
         $paginator = $this->paginatorFactory->create($total);
 
         $workflows = $this->entityWorkflowRepository->findBySubscriber(
-            $this->getUser(),
+            $this->security->getUser(),
             ['createdAt' => 'DESC'],
             $paginator->getItemsPerPage(),
             $paginator->getCurrentPageFirstItemNumber()