Introduce PersonJsonReadDenormalizer and PersonJsonDenormalizer to separate responsibilities for handling person denormalization. Add corresponding test classes for improved coverage. Refactor PersonJsonNormalizer to remove denormalization logic.

src/Bundle/ChillPersonBundle/Serializer/Normalizer/PersonJsonNormalizer.php

@@ -11,169 +11,31 @@ declare(strict_types=1);
 
 namespace Chill\PersonBundle\Serializer\Normalizer;
 
-use Chill\MainBundle\Entity\Center;
-use Chill\MainBundle\Entity\Civility;
-use Chill\MainBundle\Entity\Gender;
 use Chill\MainBundle\Phonenumber\PhoneNumberHelperInterface;
 use Chill\MainBundle\Security\Resolver\CenterResolverManagerInterface;
 use Chill\MainBundle\Templating\Entity\ChillEntityRenderExtension;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Entity\PersonAltName;
-use Chill\PersonBundle\Repository\PersonRepository;
 use Chill\PersonBundle\Repository\ResidentialAddressRepository;
 use Doctrine\Common\Collections\Collection;
-use libphonenumber\PhoneNumber;
-use Symfony\Component\Serializer\Exception\UnexpectedValueException;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
-use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
-use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait;
 use Symfony\Component\Serializer\Normalizer\NormalizerAwareInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerAwareTrait;
-use Symfony\Component\Serializer\Normalizer\ObjectToPopulateTrait;
 
 /**
  * Serialize a Person entity.
  */
-class PersonJsonNormalizer implements DenormalizerAwareInterface, NormalizerAwareInterface, PersonJsonNormalizerInterface
+class PersonJsonNormalizer implements NormalizerAwareInterface
 {
-    use DenormalizerAwareTrait;
-
     use NormalizerAwareTrait;
 
-    use ObjectToPopulateTrait;
-
     public function __construct(
         private readonly ChillEntityRenderExtension $render,
-        /* TODO: replace by PersonRenderInterface, as sthis is the only one required */
-        private readonly PersonRepository $repository,
         private readonly CenterResolverManagerInterface $centerResolverManager,
         private readonly ResidentialAddressRepository $residentialAddressRepository,
         private readonly PhoneNumberHelperInterface $phoneNumberHelper,
     ) {}
 
-    public function denormalize($data, $type, $format = null, array $context = [])
-    {
-        $person = $this->extractObjectToPopulate($type, $context);
-
-        if (\array_key_exists('id', $data) && null === $person) {
-            $person = $this->repository->find($data['id']);
-
-            if (null === $person) {
-                throw new UnexpectedValueException("The person with id \"{$data['id']}\" does ".'not exists');
-            }
-
-            // currently, not allowed to update a person through api
-            // if instantiated with id
-            return $person;
-        }
-
-        if (null === $person) {
-            $person = new Person();
-        }
-
-        $fields = [
-            'firstName',
-            'lastName',
-            'phonenumber',
-            'mobilenumber',
-            'gender',
-            'birthdate',
-            'deathdate',
-            'center',
-            'altNames',
-            'email',
-            'civility',
-        ];
-
-        $fields = array_filter(
-            $fields,
-            static fn (string $field): bool => \array_key_exists($field, $data)
-        );
-
-        foreach ($fields as $item) {
-            switch ($item) {
-                case 'firstName':
-                    $person->setFirstName($data[$item]);
-
-                    break;
-
-                case 'lastName':
-                    $person->setLastName($data[$item]);
-
-                    break;
-
-                case 'phonenumber':
-                    $person->setPhonenumber($this->denormalizer->denormalize($data[$item], PhoneNumber::class, $format, $context));
-
-                    break;
-
-                case 'mobilenumber':
-                    $person->setMobilenumber($this->denormalizer->denormalize($data[$item], PhoneNumber::class, $format, $context));
-
-                    break;
-
-                case 'gender':
-                    $gender = $this->denormalizer->denormalize($data[$item], Gender::class, $format, []);
-
-                    $person->setGender($gender);
-
-                    break;
-
-                case 'birthdate':
-                    $object = $this->denormalizer->denormalize($data[$item], \DateTime::class, $format, $context);
-
-                    $person->setBirthdate($object);
-
-                    break;
-
-                case 'deathdate':
-                    $object = $this->denormalizer->denormalize($data[$item], \DateTimeImmutable::class, $format, $context);
-
-                    $person->setDeathdate($object);
-
-                    break;
-
-                case 'center':
-                    $object = $this->denormalizer->denormalize($data[$item], Center::class, $format, $context);
-                    $person->setCenter($object);
-
-                    break;
-
-                case 'altNames':
-                    foreach ($data[$item] as $altName) {
-                        $oldAltName = $person
-                            ->getAltNames()
-                            ->filter(static fn (PersonAltName $n): bool => $n->getKey() === $altName['key'])->first();
-
-                        if (false === $oldAltName) {
-                            $newAltName = new PersonAltName();
-                            $newAltName->setKey($altName['key']);
-                            $newAltName->setLabel($altName['label']);
-                            $person->addAltName($newAltName);
-                        } else {
-                            $oldAltName->setLabel($altName['label']);
-                        }
-                    }
-
-                    break;
-
-                case 'email':
-                    $person->setEmail($data[$item]);
-
-                    break;
-
-                case 'civility':
-                    $civility = $this->denormalizer->denormalize($data[$item], Civility::class, $format, []);
-
-                    $person->setCivility($civility);
-
-                    break;
-            }
-        }
-
-        return $person;
-    }
-
     /**
      * @param Person      $person
      * @param string|null $format