Merge branch '98-fix-download-document' into 'master'

Resolve "Dans certaines situations, le téléchargement et déchiffrement des documents ne fonctionne pas"

See merge request Chill-Projet/chill-bundles!541

src/Bundle/ChillActivityBundle/Controller/ActivityController.php

@@ -650,8 +650,8 @@ final class ActivityController extends AbstractController
                 throw $this->createNotFoundException('Accompanying Period not found');
             }
 
-        // TODO Add permission
-        // $this->denyAccessUnlessGranted('CHILL_PERSON_SEE', $person);
+            // TODO Add permission
+            // $this->denyAccessUnlessGranted('CHILL_PERSON_SEE', $person);
         } else {
             throw $this->createNotFoundException('Person or Accompanying Period not found');
         }

src/Bundle/ChillActivityBundle/Menu/PersonMenuBuilder.php

@@ -26,12 +26,12 @@ final class PersonMenuBuilder implements LocalMenuBuilderInterface
     /**
      * @var AuthorizationCheckerInterface
      */
-    protected $authorizationChecker;
+    private $authorizationChecker;
 
     /**
      * @var TranslatorInterface
      */
-    protected $translator;
+    private $translator;
 
     public function __construct(
         AuthorizationCheckerInterface $authorizationChecker,

src/Bundle/ChillDocStoreBundle/Resources/public/vuejs/StoredObjectButton/DownloadButton.vue

@@ -34,6 +34,7 @@ async function download_and_open(event: Event): Promise<void> {
     const raw = await download_and_decrypt_doc(urlInfo, props.storedObject.keyInfos, new Uint8Array(props.storedObject.iv));
 
     button.href = window.URL.createObjectURL(raw);
+    button.target = '_blank';
     button.type = props.storedObject.type;
 
     button.download = props.filename || 'document';
@@ -45,10 +46,7 @@ async function download_and_open(event: Event): Promise<void> {
 
     state.is_ready = true;
 
-    // for fixing https://gitlab.com/Chill-Projet/chill-bundles/-/issues/98
-    window.setTimeout(() => {
-        button.click()
-    }, 750);
+    button.click();
   }
 }
 </script>

src/Bundle/ChillThirdPartyBundle/Form/ThirdPartyType.php

@@ -117,7 +117,7 @@ class ThirdPartyType extends AbstractType
                     'label' => 'thirdparty.Contact data are confidential',
                 ]);
 
-        // Institutional ThirdParty (parent)
+            // Institutional ThirdParty (parent)
         } else {
             $builder
                 ->add('nameCompany', TextType::class, [