Merge remote-tracking branch 'origin/master' into features/activity-form

composer.json

@@ -73,7 +73,7 @@
         "symfony/web-profiler-bundle": "^5.0",
         "symfony/var-dumper": "4.*",
         "symfony/debug-bundle": "^5.1",
-        "symfony/phpunit-bridge": "^5.2",    
+        "symfony/phpunit-bridge": "^5.2",
         "nelmio/alice": "^3.8"
     },
     "scripts": {

docs/source/development/timelines.rst

@@ -97,7 +97,7 @@ The has the following signature :
          * 
          * @param string $context
          * @param mixed[] $args the argument to the context.
-         * @return string[]
+         * @return TimelineSingleQuery
          * @throw  \LogicException if the context is not supported
          */
         public function fetchQuery($context, array $args);
@@ -163,18 +163,16 @@ The has the following signature :
 The `fetchQuery` function
 ^^^^^^^^^^^^^^^^^^^^^^^^^
 
-The fetchQuery function help to build the UNION query to gather events. This function should return an associative array MUST have the following key :
+The fetchQuery function help to build the UNION query to gather events. This function should return an instance of :code:`TimelineSingleQuery`. For you convenience, this object may be build using an associative array with the following keys:
 
 * `id` : the name of the id column
 * `type`: a string to indicate the type
 * `date`: the name of the datetime column, used to order entities by date
-* `FROM` (in capital) : the FROM clause. May contains JOIN instructions
+* `FROM`: the FROM clause. May contains JOIN instructions
+* `WHERE`: the WHERE clause;
+* `parameters`: the parameters to pass to the query
 
-Those key are optional:
-
-* `WHERE` (in capital) : the WHERE clause. 
-
- Where relevant, the data must be quoted to avoid SQL injection.
+The parameters should be replaced into the query by :code:`?`. They will be replaced into the query using prepared statements.
 
 `$context` and `$args` are defined by the bundle which will call the timeline rendering. You may use them to build a different query depending on this context.
 
@@ -186,6 +184,15 @@ For instance, if the context is `'person'`, the args will be this array :
         'person' => $person //a \Chill\PersonBundle\Entity\Person entity
     );
 
+For the context :code:`center`, the args will be:
+
+.. code-block:: php
+
+    array(
+        'centers' => [ ]  // an array of \Chill\MainBundle\Entity\Center entities
+    );
+
+
 You should find in the bundle documentation which contexts are arguments the bundle defines.
 
 .. note::
@@ -199,13 +206,12 @@ Example of an implementation :
     namespace Chill\ReportBundle\Timeline;
 
     use Chill\MainBundle\Timeline\TimelineProviderInterface;
+    use Chill\MainBundle\Timeline\TimelineSingleQuery;
     use Doctrine\ORM\EntityManager;
 
     /**
      * Provide report for inclusion in timeline
      *
-     * @author Julien Fastré <julien.fastre@champs-libres.coop>
-     * @author Champs Libres <info@champs-libres.coop>
      */
     class TimelineReportProvider implements TimelineProviderInterface
     {
@@ -227,16 +233,17 @@ Example of an implementation :
                 
                 $metadata = $this->em->getClassMetadata('ChillReportBundle:Report');
                 
-                return array(
+                return TimelineSingleQuery::fromArray([
                    'id' => $metadata->getColumnName('id'),
                    'type' => 'report',
                    'date' => $metadata->getColumnName('date'),
                    'FROM' => $metadata->getTableName(),
-                   'WHERE' => sprintf('%s = %d',
+                   'WHERE' => sprintf('%s = ?',
                          $metadata
-                            ->getAssociationMapping('person')['joinColumns'][0]['name'],
-                         $args['person']->getId())
-                );
+                            ->getAssociationMapping('person')['joinColumns'][0]['name'])
+                         )
+                   'parameters' => [ $args['person']->getId() ]
+                ]);
             }
 
         //....

phpunit.xml.dist

@@ -18,12 +18,19 @@
        <testsuite name="MainBundle">
          <directory suffix="Test.php">src/Bundle/ChillMainBundle/Tests/</directory>
        </testsuite>
-       <!-- remove tests for person temporarily 
        <testsuite name="PersonBundle">
          <directory suffix="Test.php">src/Bundle/ChillPersonBundle/Tests/</directory>
+         <!-- test for export will be runned later -->
          <exclude>src/Bundle/ChillPersonBundle/Tests/Export/*</exclude>
+         <!-- we are rewriting accompanying periods... Work in progress -->
+         <exclude>src/Bundle/ChillPersonBundle/Tests/Controller/AccompanyingPeriodControllerTest.php</exclude>
+         <!-- we are rewriting address, Work in progress -->
+         <exclude>src/Bundle/ChillPersonBundle/Tests/Controller/PersonAddressControllerTest.php</exclude>
+         <!-- find a solution to create multiple configs -->
+         <exclude>src/Bundle/ChillPersonBundle/Tests/Controller/PersonControllerUpdateWithHiddenFieldsTest.php</exclude>
+         <!-- temporarily removed, the time to find a fix -->
+         <exclude>src/Bundle/ChillPersonBundle/Tests/Controller/PersonDuplicateControllerViewTest.php</exclude>
         </testsuite>
-        -->
     </testsuites>
 
     <listeners>

src/Bundle/ChillActivityBundle/Entity/Activity.php

@@ -44,7 +44,7 @@ use Symfony\Component\Serializer\Annotation\DiscriminatorMap;
  * Class Activity
  *
  * @package Chill\ActivityBundle\Entity
- * @ORM\Entity()
+ * @ORM\Entity(repositoryClass="Chill\ActivityBundle\Repository\ActivityRepository")
  * @ORM\Table(name="activity")
  * @ORM\HasLifecycleCallbacks()
  * @DiscriminatorMap(typeProperty="type", mapping={

src/Bundle/ChillActivityBundle/Repository/ActivityACLAwareRepository.php

@@ -0,0 +1,169 @@
+<?php
+
+/*
+ * Chill is a software for social workers
+ *
+ * Copyright (C) 2021, Champs Libres Cooperative SCRLFS,
+ * <http://www.champs-libres.coop>, <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace Chill\ActivityBundle\Repository;
+
+use Chill\ActivityBundle\Entity\Activity;
+use Chill\PersonBundle\Entity\Person;
+use Chill\ActivityBundle\Repository\ActivityRepository;
+use Chill\ActivityBundle\Security\Authorization\ActivityVoter;
+use Chill\MainBundle\Entity\Scope;
+use Doctrine\ORM\QueryBuilder;
+use Doctrine\ORM\Query\Expr\Orx;
+use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
+use Symfony\Component\Security\Core\Role\Role;
+use Doctrine\ORM\EntityManagerInterface;
+
+
+final class ActivityACLAwareRepository 
+{
+    private AuthorizationHelper $authorizationHelper;
+
+    private TokenStorageInterface $tokenStorage;
+
+    private ActivityRepository $repository;
+
+    private EntityManagerInterface $em;
+
+    public function __construct(
+        AuthorizationHelper $authorizationHelper,
+        TokenStorageInterface $tokenStorage,
+        ActivityRepository $repository,
+        EntityManagerInterface $em
+    ) {
+        $this->authorizationHelper = $authorizationHelper;
+        $this->tokenStorage = $tokenStorage;
+        $this->repository = $repository;
+        $this->em = $em;
+    }
+
+    public function queryTimelineIndexer(string $context, array $args = []): array
+    {
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
+
+        $from = $this->getFromClauseCenter($args);
+        [$where, $parameters] = $this->getWhereClause($context, $args);
+
+        return [
+           'id' => $metadataActivity->getTableName()
+                .'.'.$metadataActivity->getColumnName('id'),
+           'type' => 'activity',
+           'date' => $metadataActivity->getTableName()
+                .'.'.$metadataActivity->getColumnName('date'),
+           'FROM' => $from,
+           'WHERE' => $where,
+           'parameters' => $parameters
+       ];
+    }
+
+    private function getFromClauseCenter(array $args): string
+    {
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
+        $metadataPerson = $this->em->getClassMetadata(Person::class);
+        $associationMapping = $metadataActivity->getAssociationMapping('person');
+        
+        return $metadataActivity->getTableName().' JOIN '
+            .$metadataPerson->getTableName().' ON '
+            .$metadataPerson->getTableName().'.'.
+                $associationMapping['joinColumns'][0]['referencedColumnName']
+            .' = '
+            .$associationMapping['joinColumns'][0]['name']
+            ;
+    }
+
+    private function getWhereClause(string $context, array $args): array
+    {
+        $where = '';
+        $parameters = [];
+        
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
+        $metadataPerson = $this->em->getClassMetadata(Person::class);
+        $activityToPerson = $metadataActivity->getAssociationMapping('person')['joinColumns'][0]['name'];
+        $activityToScope  = $metadataActivity->getAssociationMapping('scope')['joinColumns'][0]['name'];
+        $personToCenter = $metadataPerson->getAssociationMapping('center')['joinColumns'][0]['name'];
+
+
+        // acls:
+        $role = new Role(ActivityVoter::SEE);
+        $reachableCenters = $this->authorizationHelper->getReachableCenters($this->tokenStorage->getToken()->getUser(), 
+                $role);
+        
+        if (count($reachableCenters) === 0) {
+            // insert a dummy condition
+            return 'FALSE = TRUE';
+        }
+
+        if ($context === 'person') { 
+            // we start with activities having the person_id linked to person 
+            $where .= sprintf('%s = ? AND ', $activityToPerson);
+            $parameters[] = $person->getId();
+        }
+        
+        // we add acl (reachable center and scopes)
+        $where .= '('; // first loop for the for centers
+        $centersI = 0; // like centers#i
+        foreach ($reachableCenters as $center) {
+            // we pass if not in centers
+            if (!\in_array($center, $args['centers'])) {
+                continue;
+            }
+            // we get all the reachable scopes for this center
+            $reachableScopes = $this->authorizationHelper->getReachableScopes($this->tokenStorage->getToken()->getUser(), $role, $center);
+            // we get the ids for those scopes
+            $reachablesScopesId = array_map(
+                function(Scope $scope) { return $scope->getId(); }, 
+                $reachableScopes
+            );
+
+            // if not the first center
+            if ($centersI > 0) {
+                $where .= ') OR (';
+            }
+
+            // condition for the center
+            $where .= sprintf(' %s.%s = ? ', $metadataPerson->getTableName(), $personToCenter);
+            $parameters[] = $center->getId();
+
+            // begin loop for scopes
+            $where .= ' AND (';
+            $scopesI = 0; //like scope#i
+
+            foreach ($reachablesScopesId as $scopeId) {
+                if ($scopesI > 0) {
+                    $where .= ' OR ';
+                }
+                $where .= sprintf(' %s.%s = ? ', $metadataActivity->getTableName(), $activityToScope);
+                $parameters[] = $scopeId;
+                $scopesI ++;
+            }
+            // close loop for scopes
+            $where .= ') ';
+            $centersI++;
+        }
+        // close loop for centers
+        $where .= ')';
+        
+        return [$where, $parameters];
+    }
+
+}

src/Bundle/ChillActivityBundle/Repository/ActivityRepository.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * Chill is a software for social workers
+ *
+ * Copyright (C) 2021, Champs Libres Cooperative SCRLFS,
+ * <http://www.champs-libres.coop>, <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace Chill\ActivityBundle\Repository;
+
+use Chill\ActivityBundle\Entity\Activity;
+use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
+use Doctrine\Persistence\ManagerRegistry;
+
+/**
+ * @method AccompanyingPeriodParticipation|null find($id, $lockMode = null, $lockVersion = null)
+ * @method AccompanyingPeriodParticipation|null findOneBy(array $criteria, array $orderBy = null)
+ * @method AccompanyingPeriodParticipation[]    findAll()
+ * @method AccompanyingPeriodParticipation[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ */
+class ActivityRepository extends ServiceEntityRepository
+{
+    public function __construct(ManagerRegistry $registry)
+    {
+        parent::__construct($registry, Activity::class);
+    }
+    
+}

src/Bundle/ChillActivityBundle/Resources/views/Timeline/activity_person_context.html.twig

@@ -1,11 +1,11 @@
 {% import 'ChillActivityBundle:ActivityReason:macro.html.twig' as m %}
 
 <div>
-    <h3>{{ activity.date|format_date('long') }}<span class="activity"> / {{ 'Activity'|trans }}</span></h3>
+  <h3>{{ activity.date|format_date('long') }}<span class="activity"> / {{ 'Activity'|trans }}</span>{% if 'person' != context %} / {{ activity.person|chill_entity_render_box({'addLink': true}) }}{% endif %}</h3>
     <div class="statement">
         <span class="statement">{{ '%user% has done an %activity_type%'|trans(
            {
-             '%user%' : user,
+             '%user%' : activity.user,
              '%activity_type%': activity.type.name|localize_translatable_string,
              '%date%' : activity.date|format_date('long') }
         ) }}</span>
@@ -29,13 +29,13 @@
 
     <ul class="record_actions">
         <li>
-            <a href="{{ path('chill_activity_activity_show', { 'person_id': person.id, 'id': activity.id} ) }}" class="sc-button bt-view">
+            <a href="{{ path('chill_activity_activity_show', { 'person_id': activity.person.id, 'id': activity.id} ) }}" class="sc-button bt-view">
                 {{ 'Show the activity'|trans }}
             </a>
         </li>
         {% if is_granted('CHILL_ACTIVITY_UPDATE', activity) %}
         <li>
-            <a href="{{ path('chill_activity_activity_edit', { 'person_id': person.id, 'id': activity.id} ) }}" class="sc-button bt-edit">
+            <a href="{{ path('chill_activity_activity_edit', { 'person_id': activity.person.id, 'id': activity.id} ) }}" class="sc-button bt-edit">
                 {{ 'Edit the activity'|trans }}
             </a>
         </li>

src/Bundle/ChillActivityBundle/Timeline/TimelineActivityProvider.php

@@ -21,6 +21,7 @@
 namespace Chill\ActivityBundle\Timeline;
 
 use Chill\MainBundle\Timeline\TimelineProviderInterface;
+use Chill\ActivityBundle\Repository\ActivityACLAwareRepository;
 use Doctrine\ORM\EntityManager;
 use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
@@ -28,13 +29,13 @@ use Symfony\Component\Security\Core\Role\Role;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Chill\PersonBundle\Entity\Person;
 use Chill\MainBundle\Entity\Scope;
+use Chill\ActivityBundle\Entity\Activity;
+use Chill\MainBundle\Timeline\TimelineSingleQuery;
 
 /**
  * Provide activity for inclusion in timeline
  *
- * @author Julien Fastré <julien.fastre@champs-libres.coop>
- * @author Champs Libres <info@champs-libres.coop>
- */
+*/
 class TimelineActivityProvider implements TimelineProviderInterface
 {
     
@@ -55,6 +56,10 @@ class TimelineActivityProvider implements TimelineProviderInterface
      * @var \Chill\MainBundle\Entity\User 
      */
     protected $user;
+
+    protected ActivityACLAwareRepository $aclAwareRepository;
+
+    private const SUPPORTED_CONTEXTS = [ 'center', 'person'];
     
     /**
      * TimelineActivityProvider constructor.
@@ -66,11 +71,13 @@ class TimelineActivityProvider implements TimelineProviderInterface
     public function __construct(
         EntityManager $em,
         AuthorizationHelper $helper,
-        TokenStorageInterface $storage
+        TokenStorageInterface $storage,
+        ActivityACLAwareRepository $aclAwareRepository
     )
     {
         $this->em = $em;
         $this->helper = $helper;
+        $this->aclAwareRepository = $aclAwareRepository;
         
         if (!$storage->getToken()->getUser() instanceof \Chill\MainBundle\Entity\User)
         {
@@ -86,67 +93,69 @@ class TimelineActivityProvider implements TimelineProviderInterface
      */
     public function fetchQuery($context, array $args)
     {
-        $this->checkContext($context);
+        if ('center' === $context) {
+            return TimelineSingleQuery::fromArray($this->aclAwareRepository
+                ->queryTimelineIndexer($context, $args));
+        }
         
-        $metadataActivity = $this->em->getClassMetadata('ChillActivityBundle:Activity');
-        $metadataPerson = $this->em->getClassMetadata('ChillPersonBundle:Person');
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
+
+        [$where, $parameters] =  $this->getWhereClauseForPerson($args['person']);
         
-        return array(
+        return TimelineSingleQuery::fromArray([
            'id' => $metadataActivity->getTableName()
                 .'.'.$metadataActivity->getColumnName('id'),
            'type' => 'activity',
            'date' => $metadataActivity->getTableName()
                 .'.'.$metadataActivity->getColumnName('date'),
-           'FROM' => $this->getFromClause($metadataActivity, $metadataPerson),
-           'WHERE' => $this->getWhereClause($metadataActivity, $metadataPerson,
-                   $args['person'])
-        );
+           'FROM' => $this->getFromClausePerson($args['person']),
+           'WHERE' => $where,
+           'parameters' => $parameters
+       ]);
     }
     
-    private function getWhereClause(ClassMetadata $metadataActivity, 
-            ClassMetadata $metadataPerson, Person $person)
+    private function getWhereClauseForPerson(Person $person)
     {
-        $role = new Role('CHILL_ACTIVITY_SEE');
-        $reachableCenters = $this->helper->getReachableCenters($this->user, 
-                $role);
+        $parameters = [];
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
         $associationMapping = $metadataActivity->getAssociationMapping('person');
-        
-        if (count($reachableCenters) === 0) {
-            return 'FALSE = TRUE';
+        $role = new Role('CHILL_ACTIVITY_SEE');
+        $reachableScopes =  $this->helper->getReachableScopes($this->user,
+            $role, $person->getCenter());
+        $whereClause = sprintf(' {activity.person_id} = ? AND {activity.scope_id} IN ({scopes_ids}) ');
+        $scopes_ids = [];
+
+        // first parameter: activity.person_id 
+        $parameters[] = $person->getId();
+
+        // loop on reachable scopes 
+        foreach ($reachableScopes as $scope) {
+            if (\in_array($scope->getId(), $scopes_ids)) {
+                continue;
+            }
+            $scopes_ids[] = '?'; 
+            $parameters[] = $scope->getId();
         }
-        
-        // we start with activities having the person_id linked to person 
-        // (currently only context "person" is supported)
-        $whereClause = sprintf('%s = %d',
-                 $associationMapping['joinColumns'][0]['name'],
-                 $person->getId());
-        
-        // we add acl (reachable center and scopes)
-        $centerAndScopeLines = array();
-        foreach ($reachableCenters as $center) {
-            $reachablesScopesId = array_map(
-                    function(Scope $scope) { return $scope->getId(); },
-                    $this->helper->getReachableScopes($this->user, $role, 
-                        $person->getCenter())
-                );
-                    
-            $centerAndScopeLines[] = sprintf('(%s = %d AND %s IN (%s))',
-                    $metadataPerson->getTableName().'.'.
-                        $metadataPerson->getAssociationMapping('center')['joinColumns'][0]['name'],
-                    $center->getId(),
-                    $metadataActivity->getTableName().'.'.
+
+        return [
+            \strtr(
+                $whereClause,
+                [
+                    '{activity.person_id}' => $associationMapping['joinColumns'][0]['name'],
+                    '{activity.scope_id}' => $metadataActivity->getTableName().'.'.
                         $metadataActivity->getAssociationMapping('scope')['joinColumns'][0]['name'],
-                    implode(',', $reachablesScopesId));
-            
-        }
-        $whereClause .= ' AND ('.implode(' OR ', $centerAndScopeLines).')';
-        
-        return $whereClause;
+                    '{scopes_ids}' => \implode(", ", $scopes_ids)
+,
+                ]
+            ),
+            $parameters
+        ];
     }
     
-    private function getFromClause(ClassMetadata $metadataActivity,
-            ClassMetadata $metadataPerson)
+    private function getFromClausePerson()
     {
+        $metadataActivity = $this->em->getClassMetadata(Activity::class);
+        $metadataPerson = $this->em->getClassMetadata(Person::class);
         $associationMapping = $metadataActivity->getAssociationMapping('person');
         
         return $metadataActivity->getTableName().' JOIN '
@@ -157,14 +166,14 @@ class TimelineActivityProvider implements TimelineProviderInterface
             .$associationMapping['joinColumns'][0]['name']
             ;
     }
-
+    
     /**
      * 
      * {@inheritDoc}
      */
     public function getEntities(array $ids)
     {
-        $activities = $this->em->getRepository('ChillActivityBundle:Activity')
+        $activities = $this->em->getRepository(Activity::class)
               ->findBy(array('id' => $ids));
         
         $result = array();
@@ -183,14 +192,13 @@ class TimelineActivityProvider implements TimelineProviderInterface
     {
         $this->checkContext($context);
         
-        return array(
+        return [
            'template' => 'ChillActivityBundle:Timeline:activity_person_context.html.twig',
-           'template_data' => array(
+           'template_data' => [
               'activity' => $entity,
-              'person' => $args['person'],
-              'user' => $entity->getUser()
-           )
-        );
+              'context' => $context
+            ]
+        ];
     }
 
     /**
@@ -210,7 +218,7 @@ class TimelineActivityProvider implements TimelineProviderInterface
      */
     private function checkContext($context)
     {
-        if ($context !== 'person') {
+        if (FALSE === \in_array($context, self::SUPPORTED_CONTEXTS)) {
             throw new \LogicException("The context '$context' is not "
                   . "supported. Currently only 'person' is supported");
         }

src/Bundle/ChillActivityBundle/config/services.yaml

@@ -22,9 +22,11 @@ services:
             - '@doctrine.orm.entity_manager'
             - '@chill.main.security.authorization.helper'
             - '@security.token_storage'
+            - '@Chill\ActivityBundle\Repository\ActivityACLAwareRepository'
         public: true
         tags:
             - { name: chill.timeline, context: 'person' }
+            - { name: chill.timeline, context: 'center' }
 
     Chill\ActivityBundle\Menu\:
         autowire: true

src/Bundle/ChillActivityBundle/config/services/repositories.yaml

@@ -1,18 +1,32 @@
+---
 services:
     chill_activity.repository.activity_type:
         class: Doctrine\ORM\EntityRepository
         factory: ['@doctrine.orm.entity_manager', getRepository]
         arguments:
             - 'Chill\ActivityBundle\Entity\ActivityType'
-            
+
     chill_activity.repository.reason:
         class: Doctrine\ORM\EntityRepository
         factory: ['@doctrine.orm.entity_manager', getRepository]
         arguments:
             - 'Chill\ActivityBundle\Entity\ActivityReason'
-            
+
     chill_activity.repository.reason_category:
         class: Doctrine\ORM\EntityRepository
         factory: ['@doctrine.orm.entity_manager', getRepository]
         arguments:
             - 'Chill\ActivityBundle\Entity\ActivityReasonCategory'
+
+    Chill\ActivityBundle\Repository\ActivityRepository:
+        tags: [doctrine.repository_service]
+        arguments:
+            - '@Doctrine\Persistence\ManagerRegistry'
+
+    Chill\ActivityBundle\Repository\ActivityACLAwareRepository:
+        arguments:
+            $tokenStorage: '@Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface'
+            $authorizationHelper: '@Chill\MainBundle\Security\Authorization\AuthorizationHelper'
+            $repository: '@Chill\ActivityBundle\Repository\ActivityRepository'
+            $em: '@Doctrine\ORM\EntityManagerInterface'
+

src/Bundle/ChillEventBundle/Timeline/TimelineEventProvider.php

@@ -23,6 +23,7 @@ namespace Chill\EventBundle\Timeline;
 use Chill\EventBundle\Entity\Event;
 use Chill\MainBundle\Entity\Scope;
 use Chill\MainBundle\Timeline\TimelineProviderInterface;
+use Chill\MainBundle\Timeline\TimelineSingleQuery;
 use Doctrine\ORM\EntityManager;
 use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
@@ -88,13 +89,14 @@ class TimelineEventProvider implements TimelineProviderInterface
         $metadataParticipation = $this->em->getClassMetadata('ChillEventBundle:Participation');
         $metadataPerson = $this->em->getClassMetadata('ChillPersonBundle:Person');
         
-        $query = array(
+        $query = TimelineSingleQuery::fromArray([
             'id' => $metadataEvent->getTableName().'.'.$metadataEvent->getColumnName('id'),
             'type' => 'event',
             'date' => $metadataEvent->getTableName().'.'.$metadataEvent->getColumnName('date'),
             'FROM' => $this->getFromClause($metadataEvent, $metadataParticipation, $metadataPerson),
-            'WHERE' => $this->getWhereClause($metadataEvent, $metadataParticipation, $metadataPerson, $args['person'])
-        );
+            'WHERE' => $this->getWhereClause($metadataEvent, $metadataParticipation, $metadataPerson, $args['person']),
+            'parameters' => []
+        ]);
         
         return $query;
     }
@@ -238,4 +240,4 @@ class TimelineEventProvider implements TimelineProviderInterface
         );
     }
     
-}
+}

src/Bundle/ChillMainBundle/Controller/AddressController.php

@@ -1,63 +0,0 @@
-<?php
-
-namespace Chill\MainBundle\Controller;
-
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
-use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
-use Symfony\Component\Routing\Annotation\Route;
-use Chill\MainBundle\Entity\Address;
-use Chill\MainBundle\Entity\AddressReference;
-
-/**
- * Class AddressController
- *
- * @package Chill\MainBundle\Controller
- */
-class AddressController extends AbstractController
-{
-
-
-    /**
-     * Get API Data for showing endpoint
-     *
-     * @Route(
-     *     "/{_locale}/main/api/1.0/address/{address_id}/show.{_format}",
-     *     name="chill_main_address_api_show"
-     * )
-     * @ParamConverter("address", options={"id": "address_id"})
-     */
-    public function showAddress(Address $address, $_format): Response
-    {
-        // TODO check ACL ?
-        switch ($_format) {
-            case 'json':
-                return $this->json($address);
-            default:
-                throw new BadRequestException('Unsupported format');
-        }
-    }
-
-
-    /**
-     * Get API Data for showing endpoint
-     *
-     * @Route(
-     *     "/{_locale}/main/api/1.0/address-reference/{address_reference_id}/show.{_format}",
-     *     name="chill_main_address_reference_api_show"
-     * )
-     * @ParamConverter("addressReference", options={"id": "address_reference_id"})
-     */
-    public function showAddressReference(AddressReference $addressReference, $_format): Response
-    {
-        // TODO check ACL ?
-        switch ($_format) {
-            case 'json':
-                return $this->json($addressReference);
-            default:
-                throw new BadRequestException('Unsupported format');
-        }
-
-    }
-}

src/Bundle/ChillMainBundle/Controller/AddressReferenceAPIController.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Chill\MainBundle\Controller;
+
+use Chill\MainBundle\CRUD\Controller\ApiController;
+use Symfony\Component\HttpFoundation\Request;
+
+/**
+ * Class AddressReferenceAPIController
+ *
+ * @package Chill\MainBundle\Controller
+ * @author Champs Libres
+ */
+class AddressReferenceAPIController extends ApiController
+{
+
+    protected function customizeQuery(string $action, Request $request, $qb): void
+    {
+        if ($request->query->has('postal_code')) {
+
+            $qb->where('e.postcode = :postal_code')
+               ->setParameter('postal_code', $request->query->get('postal_code'));
+
+        }
+    }
+
+}

src/Bundle/ChillMainBundle/Controller/PostalCodeAPIController.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Chill\MainBundle\Controller;
+
+use Chill\MainBundle\CRUD\Controller\ApiController;
+use Symfony\Component\HttpFoundation\Request;
+
+/**
+ * Class PostalCodeAPIController
+ *
+ * @package Chill\MainBundle\Controller
+ * @author Champs Libres
+ */
+class PostalCodeAPIController extends ApiController
+{
+
+    protected function customizeQuery(string $action, Request $request, $qb): void
+    {
+        if ($request->query->has('country')) {
+
+            $qb->where('e.country = :country')
+               ->setParameter('country', $request->query->get('country'));
+
+        }
+    }
+
+}

src/Bundle/ChillMainBundle/Controller/TimelineCenterController.php

@@ -0,0 +1,91 @@
+<?php
+
+/*
+ * Copyright (C) 2015 Champs-Libres Coopérative <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace Chill\MainBundle\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Request;
+use Chill\MainBundle\Timeline\TimelineBuilder;
+use Chill\MainBundle\Pagination\PaginatorFactory;
+use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use Symfony\Component\Security\Core\Role\Role;
+use Symfony\Component\Routing\Annotation\Route;
+use Symfony\Component\Security\Core\Security;
+
+class TimelineCenterController extends AbstractController
+{
+    
+    protected TimelineBuilder $timelineBuilder;
+    
+    protected PaginatorFactory $paginatorFactory;
+
+    private Security $security;
+    
+    public function __construct(
+        TimelineBuilder $timelineBuilder,
+        PaginatorFactory $paginatorFactory,
+        Security $security
+    ) {
+        $this->timelineBuilder = $timelineBuilder;
+        $this->paginatorFactory = $paginatorFactory;
+        $this->security = $security;
+    }
+
+    /**
+     * @Route("/{_locale}/center/timeline",
+     *    name="chill_center_timeline",
+     *    methods={"GET"}
+     *  )
+     */ 
+    public function centerAction(Request $request)
+    {
+        // collect reachable center for each group
+        $user = $this->security->getUser();
+        $centers = [];
+        foreach ($user->getGroupCenters() as $group) {
+            $centers[] = $group->getCenter();
+        }
+
+        if (0 === count($centers)) {
+            throw $this->createNotFoundException();
+        }
+        
+        $nbItems = $this->timelineBuilder->countItems('center', 
+            [ 'centers' => $centers ]
+            );
+        
+        $paginator = $this->paginatorFactory->create($nbItems);
+        
+        return $this->render('@ChillMain/Timeline/index.html.twig', array
+            (
+                'timeline' => $this->timelineBuilder->getTimelineHTML(
+                    'center', 
+                    [ 'centers' => $centers ],
+                    $paginator->getCurrentPage()->getFirstItemNumber(),
+                    $paginator->getItemsPerPage()
+                    ),
+                'nb_items' => $nbItems,
+                'paginator' => $paginator
+            )
+        );
+    }
+}

src/Bundle/ChillMainBundle/DependencyInjection/ChillMainExtension.php

@@ -284,6 +284,7 @@ class ChillMainExtension extends Extension implements PrependExtensionInterface,
                     ]
                 ],
                 [
+                    'controller' => \Chill\MainBundle\Controller\AddressReferenceAPIController::class,
                     'class' => \Chill\MainBundle\Entity\AddressReference::class,
                     'name' => 'address_reference',
                     'base_path' => '/api/1.0/main/address-reference',
@@ -304,6 +305,7 @@ class ChillMainExtension extends Extension implements PrependExtensionInterface,
                     ]
                 ],
                 [
+                    'controller' => \Chill\MainBundle\Controller\PostalCodeAPIController::class,
                     'class' => \Chill\MainBundle\Entity\PostalCode::class,
                     'name' => 'postal_code',
                     'base_path' => '/api/1.0/main/postal-code',

src/Bundle/ChillMainBundle/Doctrine/Model/Point.php

@@ -9,11 +9,11 @@ use \JsonSerializable;
  *
  */
 class Point implements JsonSerializable {
-    private float $lat;
-    private float $lon;
+    private ?float $lat = null;
+    private ?float $lon = null;
     public static string $SRID = '4326';
 
-    private function __construct(float $lon, float $lat)
+    private function __construct(?float $lon, ?float $lat)
     {
         $this->lat = $lat;
         $this->lon = $lon;

src/Bundle/ChillMainBundle/Entity/Address.php

@@ -4,6 +4,7 @@ namespace Chill\MainBundle\Entity;
 
 use Doctrine\ORM\Mapping as ORM;
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
+use Symfony\Component\Serializer\Annotation\Groups;
 use Chill\MainBundle\Doctrine\Model\Point;
 use Chill\ThirdPartyBundle\Entity\ThirdParty;
 
@@ -22,6 +23,7 @@ class Address
      * @ORM\Id
      * @ORM\Column(name="id", type="integer")
      * @ORM\GeneratedValue(strategy="AUTO")
+     * @groups({"write"})
      */
     private $id;
 
@@ -29,6 +31,7 @@ class Address
      * @var string
      *
      * @ORM\Column(type="string", length=255)
+     * @groups({"write"})
      */
     private $street = '';
 
@@ -36,6 +39,7 @@ class Address
      * @var string
      *
      * @ORM\Column(type="string", length=255)
+     * @groups({"write"})
      */
     private $streetNumber = '';
 
@@ -43,6 +47,7 @@ class Address
      * @var PostalCode
      *
      * @ORM\ManyToOne(targetEntity="Chill\MainBundle\Entity\PostalCode")
+     * @groups({"write"})
      */
     private $postcode;
 
@@ -50,6 +55,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=16, nullable=true)
+     * @groups({"write"})
      */
     private $floor;
 
@@ -57,6 +63,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=16, nullable=true)
+     * @groups({"write"})
      */
     private $corridor;
 
@@ -64,6 +71,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=16, nullable=true)
+     * @groups({"write"})
      */
     private $steps;
 
@@ -71,6 +79,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"write"})
      */
     private $buildingName;
 
@@ -78,6 +87,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=16, nullable=true)
+     * @groups({"write"})
      */
     private $flat;
 
@@ -85,6 +95,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"write"})
      */
     private $distribution;
 
@@ -92,6 +103,7 @@ class Address
      * @var string|null
      *
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"write"})
      */
     private $extra;
 
@@ -102,6 +114,7 @@ class Address
      * @var \DateTime
      *
      * @ORM\Column(type="date")
+     * @groups({"write"})
      */
     private $validFrom;
 
@@ -112,11 +125,13 @@ class Address
      * @var \DateTime|null
      *
      * @ORM\Column(type="date", nullable=true)
+     * @groups({"write"})
      */
     private $validTo;
 
     /**
      * True if the address is a "no address", aka homeless person, ...
+     * @groups({"write"})
      *
      * @var bool
      */
@@ -128,6 +143,7 @@ class Address
      * @var Point|null
      *
      * @ORM\Column(type="point", nullable=true)
+     * @groups({"write"})
      */
     private $point;
 
@@ -137,6 +153,7 @@ class Address
      * @var ThirdParty|null
      *
      * @ORM\ManyToOne(targetEntity="Chill\ThirdPartyBundle\Entity\ThirdParty")
+     * @groups({"write"})
      * @ORM\JoinColumn(nullable=true, onDelete="SET NULL")
      */
     private $linkedToThirdParty;

src/Bundle/ChillMainBundle/Entity/AddressReference.php

@@ -4,6 +4,7 @@ namespace Chill\MainBundle\Entity;
 
 use Doctrine\ORM\Mapping as ORM;
 use Chill\MainBundle\Doctrine\Model\Point;
+use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
  * @ORM\Entity()
@@ -16,21 +17,25 @@ class AddressReference
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
+     * @groups({"read"})
      */
     private $id;
 
     /**
      * @ORM\Column(type="string", length=255)
+     * @groups({"read"})
      */
     private $refId;
 
     /**
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"read"})
      */
     private $street;
 
     /**
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"read"})
      */
     private $streetNumber;
 
@@ -38,16 +43,19 @@ class AddressReference
      * @var PostalCode
      *
      * @ORM\ManyToOne(targetEntity="Chill\MainBundle\Entity\PostalCode")
+     * @groups({"read"})
      */
     private $postcode;
 
     /**
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"read"})
      */
     private $municipalityCode;
 
     /**
      * @ORM\Column(type="string", length=255, nullable=true)
+     * @groups({"read"})
      */
     private $source;
 
@@ -57,6 +65,7 @@ class AddressReference
      * @var Point
      *
      * @ORM\Column(type="point")
+     * @groups({"read"})
      */
     private $point;
 

src/Bundle/ChillMainBundle/Entity/Country.php

@@ -3,6 +3,7 @@
 namespace Chill\MainBundle\Entity;
 
 use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
  * Country
@@ -20,6 +21,7 @@ class Country
      * @ORM\Id
      * @ORM\Column(name="id", type="integer")
      * @ORM\GeneratedValue(strategy="AUTO")
+     * @groups({"read"})
      */
     private $id;
 
@@ -27,13 +29,16 @@ class Country
      * @var string
      *
      * @ORM\Column(type="json_array")
+     * @groups({"read"})
+     *
      */
     private $name;
-    
+
     /**
      * @var string
      *
      * @ORM\Column(type="string", length=3)
+     * @groups({"read"})
      */
     private $countryCode;
 
@@ -41,7 +46,7 @@ class Country
     /**
      * Get id
      *
-     * @return integer 
+     * @return integer
      */
     public function getId()
     {
@@ -57,20 +62,20 @@ class Country
     public function setName($name)
     {
         $this->name = $name;
-    
+
         return $this;
     }
 
     /**
      * Get name
      *
-     * @return string 
+     * @return string
      */
     public function getName()
     {
         return $this->name;
     }
-    
+
     /**
      * @return string
      */
@@ -90,12 +95,12 @@ class Country
 
     /**
      *
-     * @param string $countryCode            
+     * @param string $countryCode
      */
     public function setCountryCode($countryCode)
     {
         $this->countryCode = $countryCode;
         return $this;
     }
- 
+
 }

src/Bundle/ChillMainBundle/Entity/PostalCode.php

@@ -3,6 +3,7 @@
 namespace Chill\MainBundle\Entity;
 
 use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Serializer\Annotation\Groups;
 
 /**
  * PostalCode
@@ -25,6 +26,7 @@ class PostalCode
      * @ORM\Id
      * @ORM\Column(name="id", type="integer")
      * @ORM\GeneratedValue(strategy="AUTO")
+     * @groups({"read"})
      */
     private $id;
 
@@ -32,6 +34,7 @@ class PostalCode
      * @var string
      *
      * @ORM\Column(type="string", length=255, name="label")
+     * @groups({"read"})
      */
     private $name;
 
@@ -39,6 +42,7 @@ class PostalCode
      * @var string
      *
      * @ORM\Column(type="string", length=100)
+     * @groups({"read"})
      */
     private $code;
 
@@ -46,6 +50,7 @@ class PostalCode
      * @var Country
      *
      * @ORM\ManyToOne(targetEntity="Chill\MainBundle\Entity\Country")
+     * @groups({"read"})
      */
     private $country;
 

src/Bundle/ChillMainBundle/Resources/public/modules/bootstrap/bootstrap.scss

@@ -23,7 +23,7 @@
 // @import "bootstrap/scss/button-group";
 // @import "bootstrap/scss/input-group";
 // @import "bootstrap/scss/custom-forms";
-// @import "bootstrap/scss/nav";
+@import "bootstrap/scss/nav";
 // @import "bootstrap/scss/navbar";
 // @import "bootstrap/scss/card";
 // @import "bootstrap/scss/breadcrumb";

src/Bundle/ChillMainBundle/Resources/public/scss/chillmain.scss

@@ -56,7 +56,7 @@ div#header-accompanying_course-name {
   background: none repeat scroll 0 0 #718596;
   color: #FFF;
   h1 {
-    margin: 0.4em 0;       
+    margin: 0.4em 0;
   }
   span {
     a {
@@ -77,7 +77,7 @@ div#header-accompanying_course-details {
 /*
 *  FLEX RESPONSIVE TABLE/BLOCK PRESENTATION
 */
-div.flex-bloc, 
+div.flex-bloc,
 div.flex-table {
    h2, h3, h4, dl, p {
       margin: 0;
@@ -103,25 +103,35 @@ div.flex-table {
 * Bloc appearance
 */
 div.flex-bloc {
-   box-sizing: border-box; 
+   box-sizing: border-box;
    display: flex;
    flex-direction: row;
    flex-wrap: wrap;
    align-items: stretch;
    align-content: stretch;
-   
+
    div.item-bloc {
       flex-grow: 0; flex-shrink: 1; flex-basis: 50%;
       margin: 0;
       padding: 1em;
+      border-top: 0;
+      &:nth-child(1), &:nth-child(2) {
+         border-top: 1px solid #000;
+      }
+      border-left: 0;
+      &:nth-child(odd) {
+         border-left: 1px solid #000;
+      }
+
+      //background-color: #e6e6e6;
       display: flex;
       flex-direction: column;
-         
+
       div.item-row {
          flex-grow: 1; flex-shrink: 1; flex-basis: auto;
          display: flex;
          flex-direction: column;
-         
+
          div.item-col {
             &:first-child {
                flex-grow: 0; flex-shrink: 0; flex-basis: auto;
@@ -129,7 +139,7 @@ div.flex-bloc {
             &:last-child {
                flex-grow: 1; flex-shrink: 1; flex-basis: auto;
                display: flex;
-               
+
                .list-content { // ul, dl, or div
                }
                ul.record_actions {
@@ -139,7 +149,7 @@ div.flex-bloc {
                   li {
                      margin-right: 5px;
                   }
-               }            
+               }
             }
          }
       }
@@ -150,24 +160,30 @@ div.flex-bloc {
    @media only screen and (max-width: 900px) {
       flex-direction: column;
       margin: auto 0;
+      div.item-bloc {
+         border-left: 1px solid #000;
+         &:nth-child(2) {
+            border-top: 0;
+         }
+      }
    }
 }
 
 /*
 * Table appearance
-*/ 
+*/
 div.flex-table {
    display: flex;
    flex-direction: column;
    align-items: stretch;
    align-content: stretch;
-   
+
    div.item-bloc {
       display: flex;
       flex-direction: column;
       padding: 1em;
       &:nth-child(even) {
-         background-color: #e6e6e6;         
+         background-color: #e6e6e6;
       }
 
       div.item-row {
@@ -179,7 +195,7 @@ div.flex-table {
             padding-top: 0.5em;
             flex-direction: column;
          }
-         
+
          div.item-col {
             &:first-child {
                flex-grow: 0; flex-shrink: 0; flex-basis: 33%;
@@ -188,7 +204,7 @@ div.flex-table {
                flex-grow: 1; flex-shrink: 1; flex-basis: auto;
                display: flex;
                justify-content: flex-end;
-               
+
                .list-content { // ul, dl, or div
                }
                ul.record_actions {
@@ -198,7 +214,7 @@ div.flex-table {
                   li {
                      margin-right: 5px;
                   }
-               }            
+               }
             }
          }
          @media only screen and (max-width: 900px) {
@@ -211,9 +227,47 @@ div.flex-table {
                }
             }
          }
-         
-         // neutralize 
+
+         // neutralize
          div.chill_address div.chill_address_address p { text-indent: 0; }
       }
    }
-}      
+}
+
+
+
+/*
+* Address form
+*/
+div.address_form {
+   display: flex;
+   flex-direction: column;
+   div.address_form__header {
+
+   }
+   div.address_form__select {
+      display: flex;
+      flex-direction: row;
+      justify-content: space-between;
+
+      div.address_form__select__body {
+         display: flex;
+         flex-direction: column;
+         flex-grow: 1;
+      }
+
+      div.address_form__select__map {
+         margin: 0px 20px;
+         div#address_map {
+            height:400px;
+            width:400px;
+         }
+      }
+   }
+   div.address_form__more {
+
+   }
+}
+
+
+

src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/App.vue

@@ -1,5 +1,5 @@
 <template>
-   
+
    <div v-if="address.address">
       {{ address.address.street }}, {{ address.address.streetNumber }}
    </div>
@@ -9,7 +9,7 @@
    <div v-if="address.country">
       {{ address.country.name }}
    </div>
-   
+
    <add-address
       @addNewAddress="addNewAddress">
    </add-address>
@@ -33,7 +33,26 @@ export default {
    methods: {
       addNewAddress({ address, modal }) {
          console.log('@@@ CLICK button addNewAdress', address);
-         this.$store.dispatch('addAddress', address.selected);
+
+         let newAddress = {
+            'isNoAddress': address.isNoAddress,
+            'street': address.selected.address.street,
+            'streetNumber': address.selected.address.streetNumber,
+            'postcode': {'id': address.selected.city.id },
+            'floor': address.floor,
+            'corridor': address.corridor,
+            'steps': address.steps,
+            'flat': address.flat,
+            'buildingName': address.buildingName,
+            'distribution': address.distribution,
+            'extra': address.extra
+         };
+
+         if (address.selected.address.point !== undefined){
+            newAddress = Object.assign(newAddress, {'point': address.selected.address.point.coordinates});
+         }
+
+         this.$store.dispatch('addAddress', newAddress);
          modal.showModal = false;
       }
    }

src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/js/i18n.js

@@ -1,12 +1,13 @@
 const addressMessages = {
    fr: {
-      add_an_address: 'Ajouter une adresse',
-      select_an_address: 'Sélectionner une adresse',
+      add_an_address_title: 'Ajouter une adresse',
+      select_an_address_title: 'Sélectionner une adresse',
       fill_an_address: 'Compléter l\'adresse',
       select_country: 'Choisir le pays',
       select_city: 'Choisir une localité',
       select_address: 'Choisir une adresse',
-      isNoAddress: 'L\'adresse n\'est pas celle d\'un domicile fixe ?',
+      create_address: 'Appuyer sur "Entrée" pour créer une nouvelle adresse',
+      isNoAddress: 'Pas d\'adresse complète',
       floor: 'Étage',
       corridor: 'Couloir',
       steps: 'Escalier',

src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/store/index.js

@@ -1,8 +1,7 @@
 import 'es6-promise/auto';
 import { createStore } from 'vuex';
 
-// le fetch POST serait rangé dans la logique du composant qui appelle AddAddress
-//import { postAddress } from '... api' 
+import { postAddress } from '../../_api/AddAddress'
 
 const debug = process.env.NODE_ENV !== 'production';
 
@@ -10,11 +9,14 @@ const store = createStore({
    strict: debug,
    state: {
       address: {},
-      errorMsg: {}
+      errorMsg: []
    },
    getters: {
    },
    mutations: {
+      catchError(state, error) {
+         state.errorMsg.push(error);
+      },
       addAddress(state, address) {
          console.log('@M addAddress address', address);
          state.address = address;
@@ -23,19 +25,19 @@ const store = createStore({
    actions: {
       addAddress({ commit }, payload) {
          console.log('@A addAddress payload', payload);
-         commit('addAddress', payload); // à remplacer par 
-         
-         // fetch POST qui envoie l'adresse, et récupère la confirmation que c'est ok. 
-         // La confirmation est l'adresse elle-même.
-         //
-         //   postAddress(payload) 
-         //   .fetch(address => new Promise((resolve, reject) => {
-         //      commit('addAddress', address);
-         //      resolve();
-         //   }))
-         //   .catch((error) => { 
-         //      state.errorMsg.push(error.message); 
-         //   }); 
+         //commit('addAddress', payload); // à remplacer par la suite
+
+         //fetch POST qui envoie l'adresse, et récupère la confirmation que c'est ok.
+         //La confirmation est l'adresse elle-même.
+
+         postAddress(payload)
+            .then(address => new Promise((resolve, reject) => {
+               commit('addAddress', address);
+               resolve();
+            }))
+            .catch((error) => {
+               commit('catchError', error);
+            });
       }
    }
 });

src/Bundle/ChillMainBundle/Resources/public/vuejs/_api/AddAddress.js

@@ -1,37 +1,43 @@
 /*
-* Endpoint countries GET
-* TODO
+* Endpoint chill_api_single_country__index
+* method GET, get Country Object
+* @returns {Promise} a promise containing all Country object
 */
 const fetchCountries = () => {
    console.log('<<< fetching countries');
-   return [
-      {id: 1, name: 'France', countryCode: 'FR'},
-      {id: 2, name: 'Belgium', countryCode: 'BE'}
-   ];
+
+   const url = `/api/1.0/main/country.json?item_per_page=1000`;
+   return fetch(url)
+      .then(response => {
+         if (response.ok) { return response.json(); }
+         throw Error('Error with request resource response');
+      });
 };
 
 /*
-* Endpoint cities GET 
-* TODO
+* Endpoint chill_api_single_postal_code__index
+* method GET, get Country Object
+* @returns {Promise} a promise containing all Postal Code objects filtered with country
 */
-const fetchCities = (country) => {   
+const fetchCities = (country) => {
    console.log('<<< fetching cities for', country);
-   return [
-      {id: 1, name: 'Bruxelles', code: '1000', country: 'BE'},
-      {id: 2, name: 'Aisne', code: '85045', country: 'FR'},
-      {id: 3, name: 'Saint-Gervais', code: '85230', country: 'FR'}
-   ];
+   const url = `/api/1.0/main/postal-code.json?item_per_page=1000&country=${country.id}`;
+   return fetch(url)
+      .then(response => {
+         if (response.ok) { return response.json(); }
+         throw Error('Error with request resource response');
+      });
 };
 
 /*
-* Endpoint chill_main_address_reference_api_show
+* Endpoint chill_api_single_address_reference__index
 * method GET, get AddressReference Object
-* @returns {Promise} a promise containing all AddressReference object
+* @returns {Promise} a promise containing all AddressReference objects filtered with postal code
 */
-const fetchReferenceAddresses = (city) => {
-    console.log('<<< fetching references addresses for', city); // city n'est pas utilisé pour le moment
-    
-    const url = `/api/1.0/main/address-reference.json`;
+const fetchReferenceAddresses = (postalCode) => {
+    console.log('<<< fetching references addresses for', postalCode);
+   //TODO deal with huge number of addresses... we should do suggestion...
+    const url = `/api/1.0/main/address-reference.json?item_per_page=1000&postal_code=${postalCode.id}`;
     return fetch(url)
        .then(response => {
           if (response.ok) { return response.json(); }
@@ -39,8 +45,31 @@ const fetchReferenceAddresses = (city) => {
        });
 };
 
+/*
+* Endpoint chill_api_single_address__entity__create
+* method POST, post Address Object
+* @returns {Promise}
+*/
+const postAddress = (address) => {
+   console.log(address);
+   const url = `/api/1.0/main/address.json?`;
+   const body = address;
+
+   return fetch(url, {
+      method: 'POST',
+      headers: {
+         'Content-Type': 'application/json;charset=utf-8'
+         },
+      body: JSON.stringify(body)
+   }).then(response => {
+      if (response.ok) { return response.json(); }
+      throw Error('Error with request resource response');
+   });
+};
+
 export {
    fetchCountries,
    fetchCities,
-   fetchReferenceAddresses
+   fetchReferenceAddresses,
+   postAddress
 };

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/AddAddress.vue

@@ -1,6 +1,6 @@
 <template>
    <button class="sc-button bt-create centered mt-4" @click="openModal">
-      {{ $t('add_an_address') }}
+      {{ $t('add_an_address_title') }}
    </button>
 
    <teleport to="body">
@@ -9,76 +9,64 @@
          @close="modal.showModal = false">
 
          <template v-slot:header>
-            <h3 class="modal-title">{{ $t('add_an_address') }}</h3>
+            <h3 class="modal-title">{{ $t('add_an_address_title') }}</h3>
          </template>
 
          <template v-slot:body>
-            
-            <h4>{{ $t('select_an_address') }}</h4>
-            
-            <label for="isNoAddress">
-               <input type="checkbox" 
-                  name="isNoAddress" 
-                  v-bind:placeholder="$t('isNoAddress')" 
-                  v-model="isNoAddress" 
-                  v-bind:value="value"/>
-               {{ $t('isNoAddress') }}
-            </label>
+            <div class="address_form">
 
-            <country-selection
-               v-bind:address="address"
-               v-bind:getCities="getCities">
-            </country-selection>
-            
-            <city-selection
-               v-bind:address="address"
-               v-bind:getReferenceAddresses="getReferenceAddresses">
-            </city-selection>
-            
-            <address-selection
-               v-bind:address="address"
-               v-bind:updateMapCenter="updateMapCenter">
-            </address-selection>
+               <div class="address_form__header">
+                  <h4>{{ $t('select_an_address_title') }}</h4>
+               </div>
 
-            <address-map
-               v-bind:address="address"
-               ref="addressMap">
-            </address-map>
-            
-            <address-more 
-               v-if="!isNoAddress"
-               v-bind:address="address">
-            </address-more>
-                        
-            <!--
-            <div class="address_form__fields__isNoAddress"></div>
-            <div class="address_form__select">
-               <div class="address_form__select__header"></div>
-               <div class="address_form__select__left"></div>
-               <div class="address_form__map"></div>
+               <div class="address_form__select">
+
+                  <div class="address_form__select__body">
+                     <label for="isNoAddress">
+                        <input type="checkbox"
+                           name="isNoAddress"
+                           v-bind:placeholder="$t('isNoAddress')"
+                           v-model="isNoAddress"
+                           v-bind:value="value"/>
+                        {{ $t('isNoAddress') }}
+                     </label>
+
+                     <country-selection
+                        v-bind:address="address"
+                        v-bind:getCities="getCities">
+                     </country-selection>
+
+                     <city-selection
+                        v-bind:address="address"
+                        v-bind:getReferenceAddresses="getReferenceAddresses">
+                     </city-selection>
+
+                     <address-selection
+                        v-bind:address="address"
+                        v-bind:updateMapCenter="updateMapCenter">
+                     </address-selection>
+                  </div>
+
+                  <div class="address_form__select__map">
+                     <address-map
+                        v-bind:address="address"
+                        ref="addressMap">
+                     </address-map>
+                  </div>
+               </div>
+
+               <div class="address_form__more">
+                  <address-more
+                     v-if="!isNoAddress"
+                     v-bind:address="address">
+                  </address-more>
+               </div>
             </div>
-            <div class="address_form__fields">
-               <div class="address_form__fields__header"></div>
-               <div class="address_form__fields__left"></div>
-               <div class="address_form__fields__right"></div>
-            </div>
-         
-            à discuter, 
-            mais je pense qu'il est préférable de profiter de l'imbriquation des classes css 
-            
-            div.address_form {
-               div.select {
-                  div.header {}
-                  div.left {}
-                  div.map {}
-               }
-            }
-         
-            -->
+
          </template>
 
          <template v-slot:footer>
-            <button class="sc-button green" 
+            <button class="sc-button green"
                @click.prevent="$emit('addNewAddress', { address, modal })">
                <i class="fa fa-plus fa-fw"></i>{{ $t('action.add')}}
             </button>
@@ -155,49 +143,47 @@ export default {
          }
       }
    },
+   mounted() {
+       this.getCountries();
+   },
    methods: {
       openModal() {
          this.modal.showModal = true;
          this.resetAll();
-         this.getCountries();
-         
          //this.$nextTick(function() {
          //   this.$refs.search.focus(); // positionner le curseur à l'ouverture de la modale
          //})
       },
       getCountries() {
          console.log('getCountries');
-         this.address.loaded.countries = fetchCountries(); // à remplacer par
-         //  fetchCountries().then(countries => new Promise((resolve, reject) => {
-         //     this.address.loaded.countries = countries;
-         //     resolve()
-         //  }))
-         //  .catch((error) => { 
-         //     this.errorMsg.push(error.message); 
-         //  }); 
+         fetchCountries().then(countries => new Promise((resolve, reject) => {
+             this.address.loaded.countries = countries.results;
+             resolve()
+          }))
+          .catch((error) => {
+             this.errorMsg.push(error.message);
+          });
       },
       getCities(country) {
          console.log('getCities for', country.name);
-         this.address.loaded.cities = fetchCities(); // à remplacer par
-         //  fetchCities(country).then(cities => new Promise((resolve, reject) => {
-         //     this.address.loaded.cities = cities;
-         //     resolve()
-         //  }))
-         //  .catch((error) => { 
-         //     this.errorMsg.push(error.message); 
-         //  }); 
+         fetchCities(country).then(cities => new Promise((resolve, reject) => {
+            this.address.loaded.cities = cities.results;
+            resolve()
+         }))
+         .catch((error) => {
+            this.errorMsg.push(error.message);
+         });
       },
       getReferenceAddresses(city) {
          console.log('getReferenceAddresses for', city.name);
-         fetchReferenceAddresses(city)  // il me semble que le paramètre city va limiter le poids des adresses de références reçues
-            .then(addresses => new Promise((resolve, reject) => {
+         fetchReferenceAddresses(city).then(addresses => new Promise((resolve, reject) => {
                console.log('addresses', addresses);
                this.address.loaded.addresses = addresses.results;
                resolve();
             }))
-            .catch((error) => { 
-               this.errorMsg.push(error.message); 
-            }); 
+            .catch((error) => {
+               this.errorMsg.push(error.message);
+            });
       },
       updateMapCenter(point) {
          console.log('point', point);
@@ -208,7 +194,7 @@ export default {
       resetAll() {
          console.log('reset all selected');
          this.address.loaded.addresses = [];
-         this.address.selected.address = {}; 
+         this.address.selected.address = {};
          this.address.loaded.cities = [];
          this.address.selected.city = {};
          this.address.selected.country = {};

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/AddAddress/AddressMap.vue

@@ -1,6 +1,6 @@
 <template>
    <div class="container">
-      <div id='address_map' style='height:400px; width:400px;'></div>
+      <div id='address_map'></div>
    </div>
 </template>
 
@@ -11,6 +11,7 @@ import markerIconPng from 'leaflet/dist/images/marker-icon.png'
 import 'leaflet/dist/leaflet.css';
 
 let map;
+let marker;
 
 export default {
    name: 'AddressMap',
@@ -30,13 +31,15 @@ export default {
 
          const markerIcon = L.icon({
             iconUrl: markerIconPng,
+            iconAnchor: [12, 41],
          });
 
-         L.marker([48.8589, 2.3469], {icon: markerIcon}).addTo(map);
+         marker = L.marker([48.8589, 2.3469], {icon: markerIcon}).addTo(map);
 
       },
       update() {
          console.log('update map with : ', this.address.addressMap.center)
+         marker.setLatLng(this.address.addressMap.center);
          map.setView(this.address.addressMap.center, 12);
       }
    },

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/AddAddress/AddressSelection.vue

@@ -1,38 +1,56 @@
 <template>
    <div class="container">
-      <select 
-         v-model="selected">
-         <option :value="{}" disabled selected>{{ $t('select_address') }}</option>
-         <option 
-            v-for="item in this.addresses" 
-            v-bind:item="item" 
-            v-bind:key="item.id" 
-            v-bind:value="item">
-            {{ item.street }}, {{ item.streetNumber }}
-         </option>
-      </select>
+      <VueMultiselect
+         v-model="value"
+         @select="selectAddress"
+         name="field"
+         track-by="id"
+         label="value"
+         :custom-label="transName"
+         :taggable="true"
+         :multiple="false"
+         @tag="addAddress"
+         :placeholder="$t('select_address')"
+         :tagPlaceholder="$t('create_address')"
+         :options="addresses">
+      </VueMultiselect>
    </div>
 </template>
 
 <script>
+import VueMultiselect from 'vue-multiselect';
 
 export default {
    name: 'AddressSelection',
+   components: { VueMultiselect },
    props: ['address', 'updateMapCenter'],
+   data() {
+      return {
+         value: null
+      }
+   },
    computed: {
-      addresses() { 
-         return this.address.loaded.addresses; 
+      addresses() {
+         return this.address.loaded.addresses;
+      }
+   },
+   methods: {
+      transName(value) {
+         return value.streetNumber === undefined ? value.street : `${value.street}, ${value.streetNumber}`
       },
-      selected: {
-         set(value) {
-            console.log('selected value', value);
-            this.address.selected.address = value;
-            this.updateMapCenter(value.point);
-         },
-         get() {
-            return this.address.selected.address;
-         }
+      selectAddress(value) {
+         this.address.selected.address = value;
+         this.updateMapCenter(value.point);
       },
+      addAddress (newAddress) {
+         const address = {
+            street: newAddress
+         };
+         this.value = address;
+         this.address.selected.address = address;
+      }
    }
 };
 </script>
+
+<style src="vue-multiselect/dist/vue-multiselect.css"></style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/AddAddress/CitySelection.vue

@@ -1,38 +1,45 @@
 <template>
    <div class="container">
-      <select 
-         v-model="selected">
-         <option :value="{}" disabled selected>{{ $t('select_city') }}</option>
-         <option 
-            v-for="item in this.cities" 
-            v-bind:item="item" 
-            v-bind:key="item.id" 
-            v-bind:value="item">
-            {{ item.code }}-{{ item.name }}
-         </option>
-      </select>
+      <VueMultiselect
+         v-model="value"
+         @select="selectCity"
+         name="field"
+         track-by="id"
+         label="value"
+         :custom-label="transName"
+         :placeholder="$t('select_city')"
+         :options="cities">
+      </VueMultiselect>
    </div>
 </template>
 
 <script>
+import VueMultiselect from 'vue-multiselect';
 
 export default {
    name: 'CitySelection',
+   components: { VueMultiselect },
    props: ['address', 'getReferenceAddresses'],
+   data() {
+      return {
+         value: null
+      }
+   },
+   methods: {
+      transName(value) {
+         return `${value.code}-${value.name}`
+      },
+      selectCity(value) {
+         this.address.selected.city = value;
+         this.getReferenceAddresses(value);
+      },
+   },
    computed: {
-      cities() { 
-         return this.address.loaded.cities; 
-      },
-      selected: {
-         set(value) {
-            console.log('selected value', value.name);
-            this.address.selected.city = value;
-            this.getReferenceAddresses(value);
-         },
-         get() {
-            return this.address.selected.city;
-         }
-      },
+      cities() {
+         return this.address.loaded.cities;
+      }
    }
 };
 </script>
+
+<style src="vue-multiselect/dist/vue-multiselect.css"></style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/AddAddress/CountrySelection.vue

@@ -1,38 +1,59 @@
 <template>
    <div class="container">
-      <select 
-         v-model="selected">
-         <option :value="{}" disabled selected>{{ $t('select_country') }}</option>
-         <option 
-            v-for="item in this.countries" 
-            v-bind:item="item" 
-            v-bind:key="item.id" 
-            v-bind:value="item">
-            {{ item.name }}
-         </option>
-      </select>
+      <VueMultiselect
+         v-model="value"
+         name="field"
+         track-by="id"
+         label="name"
+         :custom-label="transName"
+         :placeholder="$t('select_country')"
+         :options="countries"
+         @select="selectCountry">
+      </VueMultiselect>
    </div>
 </template>
 
 <script>
+import VueMultiselect from 'vue-multiselect';
 
 export default {
    name: 'CountrySelection',
+   components: { VueMultiselect },
    props: ['address', 'getCities'],
-   computed: {
-      countries() { 
-         return this.address.loaded.countries; 
-      },
-      selected: {
-         set(value) {
-            console.log('selected value', value.name);
-            this.address.selected.country = value;
-            this.getCities(value);
-         },
-         get() {
-            return this.address.selected.country;
+   data() {
+      return {
+         value: this.address.loaded.countries.filter(c => c.countryCode === 'FR')[0]
+      }
+   },
+   methods: {
+      init() {
+         if (this.value !== undefined) {
+            this.getCities(this.value);
          }
+      },
+      transName ({ name }) {
+         return name.fr //TODO multilang
+      },
+      selectCountry(value) {
+         console.log(value);
+         this.address.selected.country = value;
+         this.getCities(value);
+      },
+   },
+   mounted(){
+      this.init()
+   },
+   computed: {
+      countries() {
+         const countries = this.address.loaded.countries;
+         let orderedCountries = [];
+         orderedCountries.push(...countries.filter(c => c.countryCode === 'FR'))
+         orderedCountries.push(...countries.filter(c => c.countryCode === 'BE'))
+         orderedCountries.push(...countries.filter(c => c.countryCode !== 'FR').filter(c => c.countryCode !== 'BE'))
+         return orderedCountries;
       }
    }
 };
 </script>
+
+<style src="vue-multiselect/dist/vue-multiselect.css"></style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly.vue

@@ -0,0 +1,153 @@
+<template>
+  
+   <a class="sc-button" target="_blank"
+      :class="classAction"
+      :title="$t(titleAction)"
+      @click="openModal">
+      {{ buttonText }}
+   </a>
+  
+   <teleport to="body">
+      <modal v-if="modal.showModal"
+         :modalDialogClass="modal.modalDialogClass"
+         @close="modal.showModal = false">
+         
+         <template v-slot:header>
+            <h3 class="modal-title">{{ $t(titleModal) }}</h3>
+         </template>
+         
+         <template v-slot:body v-if="type === 'person'">
+            <on-the-fly-person
+               v-bind:id="id"
+               v-bind:type="type"
+               v-bind:action="action"
+               ref="castPerson">
+            </on-the-fly-person>
+         </template>
+         
+         <template v-slot:body v-else-if="type === 'thirdparty'">
+            <on-the-fly-thirdparty
+               v-bind:id="id"
+               v-bind:type="type"
+               v-bind:action="action"
+               ref="castThirdparty">
+            </on-the-fly-thirdparty>
+         </template>
+         
+         <template v-slot:body v-else>
+            <on-the-fly-create
+               v-bind:action="action"
+               ref="castNew">
+            </on-the-fly-create>
+         </template>
+            
+         <template v-slot:footer>
+            <button v-if="action === 'show'"
+               @click="changeActionTo('edit')"
+               class="sc-button bt-update"> <!-- @click.prevent="$emit('..', ..)" -->
+            </button>
+            <button v-else
+               class="sc-button bt-save"
+               @click="saveAction"
+               > <!--  
+               -->
+               {{ $t('action.save')}}
+            </button>
+         </template>
+         
+      </modal>
+   </teleport>
+   
+</template>
+
+<script>
+import Modal from 'ChillMainAssets/vuejs/_components/Modal.vue';
+import OnTheFlyPerson from 'ChillPersonAssets/vuejs/_components/OnTheFly/Person.vue';
+import OnTheFlyThirdparty from './OnTheFly/ThirdParty.vue';
+import OnTheFlyCreate from './OnTheFly/Create.vue';
+
+export default {
+   name: 'OnTheFly',
+   components: {
+      Modal,
+      OnTheFlyPerson,
+      OnTheFlyThirdparty,
+      OnTheFlyCreate
+   },
+   props: ['type', 'id', 'action', 'buttonText'],
+   data() {
+      return {
+         modal: {
+            showModal: false,
+            modalDialogClass: "modal-dialog-scrollable modal-xl"
+         },
+         action: this.action
+      }
+   },
+   computed: {
+      action() {
+         return this.$data.action;
+      },
+      classAction() {
+         switch (this.action) {
+            case 'show':
+               return 'bt-show';
+            case 'edit':
+               return 'bt-update';
+            case 'create':
+               return 'bt-create';
+         }
+      },
+      titleAction() {
+         switch (this.action) {
+            case 'show':
+               return 'action.show';
+            case 'edit':
+               return 'action.edit';
+            case 'create':
+               return 'action.create';
+         }
+      },
+      titleModal() {
+         switch (this.action) {
+            case 'show':
+               return 'onthefly.show.' + this.type;
+            case 'edit':
+               return 'onthefly.edit.' + this.type;
+            case 'create':
+               return 'onthefly.create.title';
+         }
+      }
+   },
+   methods: {
+      openModal() {
+         this.modal.showModal = true;
+         this.$nextTick(function() {
+            //this.$refs.search.focus();
+         })
+      },
+      changeActionTo(action) {
+         // [BUG] clic first on show item button; in modal clic edit button; close modal; clic again on show item button
+         this.$data.action = action; 
+      },
+      saveAction() {
+         console.log('saveAction');
+         if (this.type === 'person') {
+            this.$refs.castPerson.postData();
+         } else if (this.type === 'thirdparty') {
+            this.$refs.castThirdparty.postData();
+         } else {
+            // saveAction() ==cast=to==> child.castByType() ==cast=to==> grand-child.postData()
+            this.$refs.castNew.castByType();
+         }
+         this.modal.showModal = false;
+      }
+   }
+}
+</script>
+
+<style lang="css" scoped>
+a {
+   cursor: pointer;
+}
+</style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/Create.vue

@@ -0,0 +1,84 @@
+<template>   
+   <ul class="nav nav-tabs">
+      <li class="nav-item">
+         <a class="nav-link" :class="{ active: isActive('person') }">
+            <label for="person">
+               <input type="radio" name="person" v-model="radioType" value="person">
+               {{ $t('onthefly.create.person') }}
+            </label>
+         </a>
+      </li>
+      <li class="nav-item">
+         <a class="nav-link" :class="{ active: isActive('thirdparty') }">
+            <label for="thirdparty">
+               <input type="radio" name="thirdparty" v-model="radioType" value="thirdparty">
+               {{ $t('onthefly.create.thirdparty') }}
+            </label>
+         </a>
+      </li>
+   </ul>
+   
+   <div class="my-4">
+      <on-the-fly-person
+         v-if="type === 'person'"
+         v-bind:action="action"
+         ref="castPerson">
+      </on-the-fly-person>
+      
+      <on-the-fly-thirdparty
+         v-if="type === 'thirdparty'"
+         v-bind:action="action"
+         ref="castThirdparty">
+      </on-the-fly-thirdparty>
+   </div>      
+</template>
+
+<script>
+import OnTheFlyPerson from 'ChillPersonAssets/vuejs/_components/OnTheFly/Person.vue';
+import OnTheFlyThirdparty from './ThirdParty.vue'; // TODO move in ChillThirdpartyAssets
+
+export default {
+   name: "OnTheFlyCreate",
+   props: ['action'], 
+   components: {
+      OnTheFlyPerson,
+      OnTheFlyThirdparty
+   },
+   data() {
+      return {
+         type: 'person' //by default
+      }
+   },
+   computed: {
+      radioType: {
+         set(type) {
+            this.type = type;
+         },
+         get() {
+            return this.type;
+         }
+      }
+   },
+   methods: {
+      isActive(tab) {
+         return (this.type === tab) ? true : false; 
+      },
+      castByType() {
+         console.log('saveActionByType');
+         if (this.type === 'person') {
+            this.$refs.castPerson.postData();
+         } else if (this.type === 'thirdparty') {
+            this.$refs.castThirdparty.postData();
+         } else {
+            throw Error('Invalid type of entity');
+         }
+      }
+   }
+}
+</script>
+
+<style lang="css" scoped>
+label {
+   cursor: pointer;
+}
+</style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_components/OnTheFly/ThirdParty.vue

@@ -0,0 +1,23 @@
+<template>
+   <div v-if="action === 'show'">
+      show
+      thirdparty
+      {{ id }}
+   </div>
+   <div v-else-if="action === 'edit' || action === 'create'">
+      {{ action }}
+      thirdparty 
+      {{ id }}
+   </div>
+</template>
+
+<script>
+export default {
+   name: "OnTheFlyThirdParty",
+   props: ['id', 'type', 'action']
+}
+// TODO move in ChillThirdpartyAssets
+</script>
+
+<style lang="css" scoped>
+</style>

src/Bundle/ChillMainBundle/Resources/public/vuejs/_js/i18n.js

@@ -46,6 +46,22 @@ const messages = {
          previous: "Précédent",
          top: "Haut",
          bottom: "Bas",
+      },
+      onthefly: {
+         show: {
+            person: "Détails de l'usager",
+            thirdparty: "Détails du tiers"
+         },
+         edit: {
+            person: "Modifier un usager",
+            thirdparty: "Modifier un tiers"
+         },
+         create: {
+            button: "Créer \"{q}\"",
+            title: "Créer à la volée…",
+            person: "un nouvel usager",
+            thirdparty: "un nouveau tiers"
+         },         
       }
    }
 };

src/Bundle/ChillMainBundle/Resources/views/Timeline/chain_timelines.html.twig

@@ -0,0 +1,7 @@
+<div class="timeline">
+    {% for result in results %}
+        <div class="timeline-item {% if loop.index0 is even %}even{% else %}odd{% endif %}">
+            {% include result.template with result.template_data %}
+        </div>
+    {% endfor %}
+</div>

src/Bundle/ChillMainBundle/Resources/views/Timeline/index.html.twig

@@ -1,7 +1,15 @@
-<div class="timeline">
-    {% for result in results %}
-        <div class="timeline-item {% if loop.index0 is even %}even{% else %}odd{% endif %}">
-            {% include result.template with result.template_data %}
-        </div>
-    {% endfor %}
-</div>
+{% extends "@ChillMain/layout.html.twig"  %}
+
+{% block content %}
+  <div id="container content">
+    <div class="grid-8 centered">
+      <h1>{{ 'Global timeline'|trans }}</h1>
+
+      {{ timeline|raw }}
+      
+      {% if nb_items > paginator.getItemsPerPage %}
+      {{ chill_pagination(paginator) }}
+      {% endif %}
+    </div>
+  </div>
+  {% endblock content %}

src/Bundle/ChillMainBundle/Routing/MenuBuilder/SectionMenuBuilder.php

@@ -68,6 +68,14 @@ class SectionMenuBuilder implements LocalMenuBuilderInterface
                 'icons' => ['home'],
                 'order' => 0
             ]);
+
+        $menu->addChild($this->translator->trans('Global timeline'), [
+            'route' => 'chill_center_timeline',
+        ])
+            ->setExtras([
+                'order' => 10
+            ]
+        );
         
         if ($this->authorizationChecker->isGranted(ChillExportVoter::EXPORT)) {
             $menu->addChild($this->translator->trans('Export Menu'), [

src/Bundle/ChillMainBundle/Security/Authorization/AuthorizationHelper.php

@@ -110,8 +110,6 @@ class AuthorizationHelper
             return false;
         }
         
-        $role = ($attribute instanceof Role) ? $attribute : new Role($attribute);
-        
         foreach ($user->getGroupCenters() as $groupCenter){
             //filter on center
             if ($groupCenter->getCenter()->getId() === $entity->getCenter()->getId()) {
@@ -119,8 +117,7 @@ class AuthorizationHelper
                 //iterate on roleScopes
                 foreach($permissionGroup->getRoleScopes() as $roleScope) {
                     //check that the role allow to reach the required role
-                    if ($this->isRoleReached($role, 
-                          new Role($roleScope->getRole()))){
+                    if ($this->isRoleReached($attribute, $roleScope->getRole())) {
                         //if yes, we have a right on something...
                         // perform check on scope if necessary
                         if ($entity instanceof HasScopeInterface) {
@@ -149,12 +146,15 @@ class AuthorizationHelper
      * and optionnaly Scope
      * 
      * @param User $user
-     * @param Role $role
+     * @param string|Role $role
      * @param null|Scope $scope
      * @return Center[]
      */
-    public function getReachableCenters(User $user, Role $role, Scope $scope = null)
+    public function getReachableCenters(User $user, $role, Scope $scope = null)
     {
+        if ($role instanceof Role) {
+            $role = $role->getRole();
+        }
         $centers = array();
         
         foreach ($user->getGroupCenters() as $groupCenter){
@@ -162,8 +162,7 @@ class AuthorizationHelper
             //iterate on roleScopes
             foreach($permissionGroup->getRoleScopes() as $roleScope) {
                 //check that the role is in the reachable roles
-                if ($this->isRoleReached($role, 
-                      new Role($roleScope->getRole()))) {
+                if ($this->isRoleReached($role, $roleScope->getRole())) {
                     if ($scope === null) {
                         $centers[] = $groupCenter->getCenter();
                         break 1;
@@ -180,6 +179,30 @@ class AuthorizationHelper
         
         return $centers;
     }
+
+    /**
+     * Filter an array of centers, return only center which are reachable
+     *
+     * @param User $user The user
+     * @param array $centers a list of centers which are going to be filtered
+     * @param string|Center $role
+     */
+    public function filterReachableCenters(User $user, array $centers, $role): array
+    {
+        $results = [];
+
+        if ($role instanceof Role) {
+            $role = $role->getRole();
+        }
+
+        foreach ($centers as $center) {
+            if ($this->userCanReachCenter($user, $center, $role)) {
+                $results[] = $center;
+            }
+        }
+
+        return $results;
+    }
     
     /**
      * Return all reachable scope for a given user, center and role
@@ -191,8 +214,12 @@ class AuthorizationHelper
      * @param Center $center
      * @return Scope[]
      */
-    public function getReachableScopes(User $user, Role $role, Center $center)
+    public function getReachableScopes(User $user, $role, Center $center)
     {
+        if ($role instanceof Role) {
+            $role = $role->getRole();
+        }
+
         return $this->getReachableCircles($user, $role, $center);
     }
     
@@ -200,12 +227,15 @@ class AuthorizationHelper
      * Return all reachable circle for a given user, center and role
      * 
      * @param User $user
-     * @param Role $role
+     * @param string|Role $role
      * @param Center $center
      * @return Scope[]
      */
-    public function getReachableCircles(User $user, Role $role, Center $center)
+    public function getReachableCircles(User $user, $role, Center $center)
     {
+        if ($role instanceof Role) {
+            $role = $role->getRole();
+        }
         $scopes = array();
         
         foreach ($user->getGroupCenters() as $groupCenter){
@@ -215,9 +245,7 @@ class AuthorizationHelper
                 //iterate on roleScopes
                 foreach($permissionGroup->getRoleScopes() as $roleScope) {
                     //check that the role is in the reachable roles
-                    if ($this->isRoleReached($role, 
-                          new Role($roleScope->getRole()))) {
-
+                    if ($this->isRoleReached($role, $roleScope->getRole())) {
                         $scopes[] = $roleScope->getScope();
                     }
                 }
@@ -269,10 +297,10 @@ class AuthorizationHelper
      * @param Role $parentRole The role which should give access to $childRole
      * @return boolean true if the child role is granted by parent role
      */
-    protected function isRoleReached(Role $childRole, Role $parentRole)
+    protected function isRoleReached($childRole, $parentRole)
     {
         $reachableRoles = $this->roleHierarchy
-                ->getReachableRoles([$parentRole]);
+                ->getReachableRoleNames([$parentRole]);
         
         return in_array($childRole, $reachableRoles);
     }

src/Bundle/ChillMainBundle/Serializer/Normalizer/PointNormalizer.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Chill\MainBundle\Serializer\Normalizer;
+
+use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
+use Symfony\Component\Serializer\Exception\InvalidArgumentException;
+
+use Chill\MainBundle\Doctrine\Model\Point;
+
+
+class PointNormalizer implements DenormalizerInterface
+{
+
+    public function supportsDenormalization($data, string $type, string $format = null) : bool
+    {
+        return $type === Point::class;
+    }
+
+    public function denormalize($data, string $type, string $format = null, array $context = [])
+    {
+
+        if (!is_array($data)) {
+            throw new InvalidArgumentException('point data is not an array. It should be an array of 2 coordinates.');
+        } else {
+            if (count($data) !== 2) {
+                throw new InvalidArgumentException('point data is not an array of 2 elements. It should be an array of 2 coordinates.');
+            } else {
+                return Point::fromLonLat($data[0], $data[1]);
+            }
+        }
+
+    }
+
+}

src/Bundle/ChillMainBundle/Timeline/TimelineBuilder.php

@@ -23,11 +23,11 @@ use Doctrine\ORM\Query\ResultSetMapping;
 use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
+use Doctrine\ORM\Query;
+use Doctrine\ORM\NativeQuery;
 
 /**
  * Build timeline
- *
- * @author Julien Fastré <julien.fastre@champs-libres.coop>
  */
 class TimelineBuilder implements ContainerAwareInterface
 {
@@ -78,14 +78,14 @@ class TimelineBuilder implements ContainerAwareInterface
      */
     public function getTimelineHTML($context, array $args, $firstItem = 0, $number = 20)
     {
-        $union = $this->buildUnionQuery($context, $args);
+        list($union, $parameters) = $this->buildUnionQuery($context, $args);
         
         //add ORDER BY clause and LIMIT
         $query = $union . sprintf(' ORDER BY date DESC LIMIT %d OFFSET %d',
             $number, $firstItem);
         
         // run query and handle results
-        $fetched = $this->runUnionQuery($query);
+        $fetched = $this->runUnionQuery($query, $parameters);
         $entitiesByKey = $this->getEntities($fetched, $context);
         
         return $this->render($fetched, $entitiesByKey, $context, $args);
@@ -100,16 +100,18 @@ class TimelineBuilder implements ContainerAwareInterface
      */
     public function countItems($context, array $args)
     {
-        $union = $this->buildUnionQuery($context, $args);
-        
-        // embed the union query inside a count query
-        $count = sprintf('SELECT COUNT(sq.id) AS total FROM (%s) as sq', $union);
-        
         $rsm = (new ResultSetMapping())
             ->addScalarResult('total', 'total', Type::INTEGER);
+
+        list($select, $parameters) = $this->buildUnionQuery($context, $args);
+
+        // embed the union query inside a count query
+        $countQuery = sprintf('SELECT COUNT(sq.id) AS total FROM (%s) as sq', $select);
+
+        $nq = $this->em->createNativeQuery($countQuery, $rsm);
+        $nq->setParameters($parameters);
         
-        return $this->em->createNativeQuery($count, $rsm)
-            ->getSingleScalarResult();
+        return $nq->getSingleScalarResult();
     }
     
     /**
@@ -154,40 +156,59 @@ class TimelineBuilder implements ContainerAwareInterface
      *
      * @uses self::buildSelectQuery to build individual SELECT queries
      *
-     * @param string $context
-     * @param mixed $args
-     * @param int $page
-     * @param int $number
-     * @return string
      * @throws \LogicException if no builder have been defined for this context
+     * @return array, where first element is the query, the second one an array with the parameters
      */
-    private function buildUnionQuery($context, array $args)
+    private function buildUnionQuery(string $context, array $args): array
     {
         //append SELECT queries with UNION keyword between them
         $union = '';
+        $parameters = [];
+
         foreach($this->getProvidersByContext($context) as $provider) {
-            $select = $this->buildSelectQuery($provider, $context, $args);
-            $append = ($union === '') ?  $select : ' UNION '.$select;
+            $data = $provider->fetchQuery($context, $args);
+            list($select, $selectParameters) = $this->buildSelectQuery($data);
+            $append = empty($union) ?  $select : ' UNION '.$select;
             $union .= $append;
+            $parameters = array_merge($parameters, $selectParameters);
         }
         
-        return $union;
+        return [$union, $parameters];
     }
+
+    /**
+     * Hack to replace the arbitrary "AS" statement in DQL
+     * into proper SQL query
+     * TODO remove
+    private function replaceASInDQL(string $dql): string
+    {
+        $pattern = '/^(SELECT\s+[a-zA-Z0-9\_\.\']{1,}\s+)(AS [a-z0-9\_]{1,})(\s{0,},\s{0,}[a-zA-Z0-9\_\.\']{1,}\s+)(AS [a-z0-9\_]{1,})(\s{0,},\s{0,}[a-zA-Z0-9\_\.\']{1,}\s+)(AS [a-z0-9\_]{1,})(\s+FROM.*)/';
+        $replacements = '${1} AS id ${3} AS type ${5} AS date ${7}';
+
+        $s = \preg_replace($pattern, $replacements, $dql, 1);
+
+        if (NULL === $s) {
+            throw new \RuntimeException('Could not replace the "AS" statement produced by '.
+                'DQL with normal SQL AS: '.$dql);
+        }
+
+        return $s;
+    }
+     */
     
     /**
      * return the SQL SELECT query as a string,
      *
-     * @uses TimelineProfiderInterface::fetchQuery use the fetchQuery function
-     * @param \Chill\MainBundle\Timeline\TimelineProviderInterface $provider
-     * @param string $context
-     * @param mixed[] $args
-     * @return string
+     * @return array: first parameter is the sql string, second an array with parameters
      */
-    private function buildSelectQuery(TimelineProviderInterface $provider, $context, array $args)
+    private function buildSelectQuery($data): array
     {
-        $data = $provider->fetchQuery($context, $args);
-        
-        return sprintf(
+        return [$data->buildSql(), $data->getParameters()];
+
+        // dead code
+        $parameters = [];
+
+        $sql = sprintf(
                 'SELECT %s AS id, '
                 . '%s AS "date", '
                 . "'%s' AS type "
@@ -197,16 +218,19 @@ class TimelineBuilder implements ContainerAwareInterface
                 $data['date'],
                 $data['type'],
                 $data['FROM'],
-                $data['WHERE']);
+                is_string($data['WHERE']) ? $data['WHERE'] : $data['WHERE'][0]
+            );
+
+        return [$sql, $data['WHERE'][1]];
+ 
     }
     
     /**
      * run the UNION query and return result as an array
      *
-     * @param string $query
-     * @return array
+     * @return array an array with the results
      */
-    private function runUnionQuery($query)
+    private function runUnionQuery(string $query, array $parameters): array
     {
         $resultSetMapping = (new ResultSetMapping())
                 ->addScalarResult('id', 'id')
@@ -214,7 +238,8 @@ class TimelineBuilder implements ContainerAwareInterface
                 ->addScalarResult('date', 'date');
         
         return $this->em->createNativeQuery($query, $resultSetMapping)
-                ->getArrayResult();
+            ->setParameters($parameters)
+            ->getArrayResult();
     }
     
     /**
@@ -274,7 +299,7 @@ class TimelineBuilder implements ContainerAwareInterface
         }
         
         return $this->container->get('templating')
-                ->render('@ChillMain/Timeline/index.html.twig', array(
+                ->render('@ChillMain/Timeline/chain_timelines.html.twig', array(
                     'results' => $timelineEntries
                 ));
         

src/Bundle/ChillMainBundle/Timeline/TimelineSingleQuery.php

@@ -0,0 +1,155 @@
+<?php
+
+namespace Chill\MainBundle\Timeline;
+
+
+class TimelineSingleQuery
+{
+    private ?string $id;
+
+    private ?string $date;
+
+    private ?string $key;
+
+    private ?string $from;
+
+    private ?string $where;
+
+    private array $parameters = [];
+
+    private bool $distinct = false;
+
+    public function __construct(
+        string $id = null,
+        string $date = null,
+        string $key = null,
+        string $from = null,
+        string $where = null,
+        array $parameters = []
+    ) {
+        $this->id = $id;
+        $this->date = $date;
+        $this->key = $key;
+        $this->from = $from;
+        $this->where = $where;
+        $this->parameters = $parameters;
+    }
+
+    public static function fromArray(array $a)
+    {
+        return new TimelineSingleQuery(
+            $a['id'] ?? null,
+            $a['date'] ?? null,
+            $a['type'] ?? $a['key'] ?? null,
+            $a['FROM'] ?? $a['from'] ?? null,
+            $a['WHERE'] ?? $a['where'] ?? null,
+            $a['parameters'] ?? null);
+    }
+
+    public function getId(): string
+    {
+        return $this->id;
+    }
+    
+    public function setId(string $id): self
+    {
+        $this->id = $id;
+    
+        return $this;
+    }
+
+    public function getDate(): string
+    {
+        return $this->date;
+    }
+    
+    public function setDate(string $date): self
+    {
+        $this->date = $date;
+    
+        return $this;
+    }
+
+    public function getKey(): string
+    {
+        return $this->key;
+    }
+    
+    public function setKey(string $key): self
+    {
+        $this->key = $key;
+    
+        return $this;
+    }
+
+    public function getFrom(): string
+    {
+        return $this->from;
+    }
+    
+    public function setFrom(string $from): self
+    {
+        $this->from = $from;
+    
+        return $this;
+    }
+
+    public function getWhere(): string
+    {
+        return $this->where;
+    }
+    
+    public function setWhere(string $where): self
+    {
+        $this->where = $where;
+    
+        return $this;
+    }
+
+    public function getParameters(): array
+    {
+        return $this->parameters;
+    }
+    
+    public function setParameters(array $parameters): self
+    {
+        $this->parameters = $parameters;
+    
+        return $this;
+    }
+
+    public function setDistinct(bool $distinct): self
+    {
+        $this->distinct = $distinct;
+
+        return $this;
+    }
+
+    public function isDistinct(): bool
+    {
+        return $this->distinct;
+    }
+
+    public function buildSql(): string
+    {
+        $parameters = [];
+
+        $sql = \strtr(
+                'SELECT {distinct} {id} AS id, '
+                . '{date} AS "date", '
+                . "'{key}' AS type "
+                . 'FROM {from} '
+                . 'WHERE {where}',
+                [
+                    '{distinct}' => $this->distinct ? 'DISTINCT' : '',
+                    '{id}' => $this->getId(),
+                    '{date}' => $this->getDate(),
+                    '{key}' => $this->getKey(),
+                    '{from}' => $this->getFrom(),
+                    '{where}' => $this->getWhere(),
+                ]
+            );
+
+        return $sql;
+    }
+}

src/Bundle/ChillMainBundle/config/routes.yaml

@@ -1,3 +1,7 @@
+chill_main_controllers:
+    resource: '../Controller/'
+    type: annotation
+
 chill_main_admin_permissionsgroup:
     resource: "@ChillMainBundle/config/routes/permissionsgroup.yaml"
     prefix:   "{_locale}/admin/permissionsgroup"

src/Bundle/ChillMainBundle/config/services.yaml

@@ -31,14 +31,14 @@ services:
             - [ setContainer, ["@service_container"]]
         tags:
             - { name: twig.extension }
-            
+
     chill.main.twig.widget:
         class: Chill\MainBundle\Templating\Widget\WidgetRenderingTwig
         arguments:
             - "@event_dispatcher"
         tags:
             - { name: twig.extension }
-            
+
     chill.main.twig.csv_cell:
         class: Chill\MainBundle\Templating\CSVCellTwig
         tags:
@@ -65,3 +65,4 @@ services:
             - "@security.authorization_checker"
             - "@chill.main.security.authorization.helper"
             - "@security.token_storage"
+

src/Bundle/ChillMainBundle/config/services/command.yaml

@@ -7,7 +7,7 @@ services:
             $validator: '@Symfony\Component\Validator\Validator\ValidatorInterface'
         tags:
             - { name: console.command }
-            
+
     Chill\MainBundle\Command\ChillUserSendRenewPasswordCodeCommand:
         arguments:
             $logger: '@Psr\Log\LoggerInterface'

src/Bundle/ChillMainBundle/config/services/serializer.yaml

@@ -1,7 +1,7 @@
 ---
 services:
-    
-    # note: the autowiring for serializers and normalizers is declared 
+
+    # note: the autowiring for serializers and normalizers is declared
     # into ../services.yaml
 
     Chill\MainBundle\Serializer\Normalizer\DoctrineExistingEntityNormalizer:

src/Bundle/ChillMainBundle/config/services/timeline.yaml

@@ -4,4 +4,7 @@ services:
         arguments:
             - "@doctrine.orm.entity_manager"
         calls:
-            - [ setContainer, ["@service_container"]]
+            - [ setContainer, ["@service_container"]]
+    # alias:
+    Chill\MainBundle\Timeline\TimelineBuilder: '@chill_main.timeline_builder'
+

src/Bundle/ChillMainBundle/migrations/Version20210528090000.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Chill\Migrations\Main;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Add extension btree_gist
+ */
+final class Version20210528090000 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'add extension btree_gist';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql('CREATE EXTENSION IF NOT EXISTS btree_gist');
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->addSql('DROP EXTENSION btree_gist');
+    }
+}

src/Bundle/ChillMainBundle/translations/messages.fr.yml

@@ -46,6 +46,11 @@ Back to the list: Retour à la liste
 #interval
 Years: Années
 
+# misc date
+Since %date%: Depuis le %date%
+since %date%: depuis le %date%
+Until %date%: Jusqu'au %date%
+until %date%: jusqu'au %date%
 #elements used in software
 centers: centres
 Centers: Centres
@@ -81,6 +86,9 @@ Results %start%-%end% of %total%: Résultats %start%-%end% sur %total%
 See all results: Voir tous les résultats
 Advanced search: Recherche avancée
 
+# timeline
+Global timeline: Historique global
+
 #admin
 Create: Créer
 show: voir

src/Bundle/ChillPersonBundle/Controller/AccompanyingPeriodController.php

@@ -390,13 +390,13 @@ class AccompanyingPeriodController extends AbstractController
         /** @var Person $person */
         $person = $this->_getPerson($person_id);
 
-        $criteria = Criteria::create();
-        $criteria->where($criteria->expr()->eq('id', $period_id));
-
         /* @var $period AccompanyingPeriod */
-        $period = $person->getAccompanyingPeriods()
-                ->matching($criteria)
-                ->first();
+        $period = \array_filter(
+            $person->getAccompanyingPeriods(), 
+            function (AccompanyingPeriod $p) use ($period_id) {
+                return $p->getId() === ($period_id);
+            }
+        )[0] ?? NULL;
 
         if ($period === NULL) {
             throw $this->createNotFoundException('period not found');

src/Bundle/ChillPersonBundle/Controller/HouseholdController.php

@@ -0,0 +1,88 @@
+<?php
+
+namespace Chill\PersonBundle\Controller;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
+use Chill\PersonBundle\Entity\Household\Household;
+
+/**
+ * @Route("/{_locale}/person/household")
+ */
+class HouseholdController extends AbstractController
+{
+    /**
+     * @Route(
+     *      "/{household_id}/summary",
+     *      name="chill_person_household_summary",
+     *      methods={"GET", "HEAD"}
+     *  )
+     *  @ParamConverter("household", options={"id" = "household_id"})
+     */
+    public function summary(Request $request, Household $household)
+    {
+        // TODO ACL
+        return $this->render('@ChillPerson/Household/summary.html.twig',
+            [
+                'household' => $household
+            ]
+        );
+    }
+
+    /**
+     * @Route(
+     *      "/{household_id}/members",
+     *      name="chill_person_household_members",
+     *      methods={"GET", "HEAD"}
+     *  )
+     *  @ParamConverter("household", options={"id" = "household_id"})
+     */
+    public function members(Request $request, Household $household)
+    {
+        // TODO ACL
+        return $this->render('@ChillPerson/Household/members.html.twig',
+            [
+                'household' => $household
+            ]
+        );
+    }
+
+    /**
+     * @Route(
+     *      "/{household_id}/addresses",
+     *      name="chill_person_household_addresses",
+     *      methods={"GET", "HEAD"}
+     *  )
+     *  @ParamConverter("household", options={"id" = "household_id"})
+     */
+    public function addresses(Request $request, Household $household)
+    {
+        // TODO ACL
+        return $this->render('@ChillPerson/Household/addresses.html.twig',
+            [
+                'household' => $household
+            ]
+        );
+    }
+
+    /**
+     * @Route(
+     *      "/{household_id}/address/move",
+     *      name="chill_person_household_address_move",
+     *      methods={"GET", "HEAD", "POST"}
+     *  )
+     *  @ParamConverter("household", options={"id" = "household_id"})
+     */
+    public function addressMove(Request $request, Household $household)
+    {
+        // TODO ACL
+        return $this->render('@ChillPerson/Household/address_move.html.twig',
+            [
+                'household' => $household
+            ]
+        );
+    }
+}

src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace Chill\PersonBundle\Controller;
+
+use Symfony\Component\HttpFoundation\Exception\BadRequestException;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Serializer\Exception;
+use Symfony\Component\Routing\Annotation\Route;
+use Chill\MainBundle\CRUD\Controller\ApiController;
+use Chill\PersonBundle\Household\MembersEditor;
+use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+
+class HouseholdMemberController extends ApiController
+{
+    /**
+     * @Route(
+     *      "/api/1.0/person/household/members/move.{_format}",
+     *      name="chill_person_household_members_move"
+     *  )
+     */
+    public function move(Request $request, $_format): Response
+    {
+        try {
+            $editor = $this->getSerializer()
+                ->deserialize($request->getContent(), MembersEditor::class,
+                    $_format, ['groups' => [ "read" ]]);
+        } catch (Exception\InvalidArgumentException | Exception\UnexpectedValueException $e) {
+            throw new BadRequestException("Deserialization error: {$e->getMessage()}", 45896, $e);
+        }
+
+        // TODO ACL
+        //
+        // TODO validation
+        //
+        $em = $this->getDoctrine()->getManager();
+
+        foreach ($editor->getPersistable() as $el) {
+           $em->persist($el); 
+        }
+        $em->flush();
+        
+        return $this->json($editor->getHousehold(), Response::HTTP_OK, [], [
+            "groups" => ["read"],
+        ]);
+    }
+}

src/Bundle/ChillPersonBundle/Controller/TimelinePersonController.php

@@ -27,32 +27,17 @@ use Symfony\Component\HttpFoundation\Request;
 use Chill\MainBundle\Timeline\TimelineBuilder;
 use Chill\MainBundle\Pagination\PaginatorFactory;
 use Chill\PersonBundle\Security\Authorization\PersonVoter;
+use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use Symfony\Component\Security\Core\Role\Role;
 
-/**
- * Class TimelinePersonController
- *
- * @package Chill\PersonBundle\Controller
- * @author Julien Fastré <julien.fastre@champs-libres.coop>
- */
 class TimelinePersonController extends AbstractController
 {
     
-    /**
-     * @var EventDispatcherInterface
-     */
-    protected $eventDispatcher;
+    protected EventDispatcherInterface $eventDispatcher;
     
-    /**
-     *
-     * @var TimelineBuilder
-     */
-    protected $timelineBuilder;
+    protected TimelineBuilder $timelineBuilder;
     
-    /**
-     *
-     * @var PaginatorFactory
-     */
-    protected $paginatorFactory;
+    protected PaginatorFactory $paginatorFactory;
     
     /**
      * TimelinePersonController constructor.
@@ -62,11 +47,13 @@ class TimelinePersonController extends AbstractController
     public function __construct(
         EventDispatcherInterface $eventDispatcher,
         TimelineBuilder $timelineBuilder,
-        PaginatorFactory $paginatorFactory
+        PaginatorFactory $paginatorFactory,
+        AuthorizationHelper $authorizationHelper
     ) {
         $this->eventDispatcher = $eventDispatcher;
         $this->timelineBuilder = $timelineBuilder;
         $this->paginatorFactory = $paginatorFactory;
+        $this->authorizationHelper = $authorizationHelper;
     }
     
     

src/Bundle/ChillPersonBundle/DataFixtures/ORM/LoadHousehold.php

@@ -0,0 +1,126 @@
+<?php
+
+namespace Chill\PersonBundle\DataFixtures\ORM;
+
+use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Entity\Household\Household;
+use Chill\PersonBundle\Household\MembersEditorFactory;
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\Persistence\ObjectManager;
+use Doctrine\Common\DataFixtures\DependentFixtureInterface;
+
+class LoadHousehold extends Fixture implements DependentFixtureInterface
+{
+    private MembersEditorFactory $editorFactory;
+
+    private EntityManagerInterface $em;
+
+    private CONST NUMBER_OF_HOUSEHOLD = 10;
+
+    public function __construct(MembersEditorFactory $editorFactory, EntityManagerInterface $em)
+    {
+        $this->editorFactory = $editorFactory;
+        $this->em = $em;
+    }
+
+    public function load(ObjectManager $manager)
+    {
+        // generate two times the participation. This will lead to 
+        // some movement in participation (same people in two differents
+        // households)
+
+        $this->preparePersonIds();
+
+        $this->generateHousehold(
+            $manager,
+            \DateTimeImmutable::createFromFormat('Y-m-d', '2010-01-01')
+        );
+
+        $this->preparePersonIds();
+
+        $this->generateHousehold(
+            $manager,
+            \DateTimeImmutable::createFromFormat('Y-m-d', '2015-01-01')
+        );
+
+        $manager->flush();
+    }
+
+    private function generateHousehold(ObjectManager $manager, \DateTimeImmutable $startDate)
+    {
+        for ($i=0; $i < self::NUMBER_OF_HOUSEHOLD; $i++) {
+            $household = new Household();
+            $manager->persist($household);
+
+            $movement = $this->editorFactory->createEditor($household);
+
+            // load adults
+            $k = 0;
+            foreach ($this->getRandomPersons(1, 3) as $person) {
+                $date = $startDate->add(new \DateInterval('P'.\random_int(1, 200).'W'));
+                $position = $this->getReference(LoadHouseholdPosition::ADULT);
+
+                $movement->addMovement($date, $person, $position, $k === 0, "self generated");
+                $k++;
+            }
+
+            // load children
+            foreach ($this->getRandomPersons(0, 3) as $person) {
+                $date = $startDate->add(new \DateInterval('P'.\random_int(1, 200).'W'));
+                $position = $this->getReference(LoadHouseholdPosition::CHILD);
+
+                $movement->addMovement($date, $person, $position, $k === 0, "self generated");
+                $k++;
+            }
+
+            // load children out
+            foreach ($this->getRandomPersons(0, 2) as $person) {
+                $date = $startDate->add(new \DateInterval('P'.\random_int(1, 200).'W'));
+                $position = $this->getReference(LoadHouseholdPosition::CHILD_OUT);
+
+                $movement->addMovement($date, $person, $position, $k === 0, "self generated");
+                $k++;
+            }
+
+            foreach ($movement->getPersistable() as $obj) {
+                $manager->persist($obj);
+            }
+        }
+    }
+
+    private function preparePersonIds()
+    {
+        $this->personIds = $this->em
+            ->createQuery('SELECT p.id FROM '.Person::class.' p '.
+                'JOIN p.center c '.
+                'WHERE c.name = :center '
+            )
+            ->setParameter('center', 'Center A')
+            ->getScalarResult()
+            ;
+        \shuffle($this->personIds);
+    }
+
+    private function getRandomPersons(int $min, int $max)
+    {
+        $nb = \random_int($min, $max);
+
+        for ($i=0; $i < $nb; $i++) {
+            $personId = \array_pop($this->personIds)['id'];
+            $persons[] = $this->em->getRepository(Person::class)
+                ->find($personId)
+                ;
+        }
+
+        return $persons ?? [];
+    }
+
+    public function getDependencies()
+    {
+        return [
+            LoadPeople::class,
+            LoadHouseholdPosition::class
+        ];
+    }
+}

src/Bundle/ChillPersonBundle/DataFixtures/ORM/LoadHouseholdPosition.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace Chill\PersonBundle\DataFixtures\ORM;
+
+use Chill\PersonBundle\Entity\Household\Position;
+use Doctrine\Bundle\FixturesBundle\Fixture;
+use Doctrine\Persistence\ObjectManager;
+
+class LoadHouseholdPosition extends Fixture
+{
+    const POSITIONS_DATA = [
+        ["Adulte", true, true, 1.0, self::ADULT ],
+        ["Enfants", true, false, 2.0, self::CHILD ],
+        ["Enfants hors ménage", false, false, 3.0, self::CHILD_OUT ]
+    ];
+
+    const ADULT = "position_adulte";
+    const CHILD = "position_enfant";
+    const CHILD_OUT = "position_enfant_hors";
+
+    public function load(ObjectManager $manager)
+    {
+        foreach (self::POSITIONS_DATA as list($name, $share, $allowHolder, 
+            $ordering, $ref)) {
+            $position = (new Position())
+                ->setLabel([ "fr" => $name ])
+                ->setAllowHolder($allowHolder)
+                ->setShareHousehold($share)
+                ->setOrdering($ordering)
+                ;
+
+            $manager->persist($position);
+            $this->addReference($ref, $position);
+        }
+
+        $manager->flush();
+    }
+}

src/Bundle/ChillPersonBundle/DependencyInjection/ChillPersonExtension.php

@@ -72,8 +72,8 @@ class ChillPersonExtension extends Extension implements PrependExtensionInterfac
         $loader->load('services/command.yaml');
         $loader->load('services/actions.yaml');
         $loader->load('services/form.yaml');
-        $loader->load('services/templating.yaml');
         $loader->load('services/alt_names.yaml');
+        $loader->load('services/household.yaml');
         // We can get rid of this file when the service 'chill.person.repository.person' is no more used.
         // We should use the PersonRepository service instead of a custom service name.
         $loader->load('services/repository.yaml');

src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php

@@ -369,13 +369,9 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
         return false;
     }
 
-    public function setRemark(string $remark): self
+    public function setRemark(string $remark = null): self
     {
-        if ($remark === null) {
-            $remark = '';
-        }
-
-        $this->remark = $remark;
+        $this->remark = (string) $remark;
 
         return $this;
     }
@@ -447,12 +443,13 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
      */
     public function getParticipationsContainsPerson(Person $person): Collection
     {
-        return $this->getParticipations($person)->filter(
-            function(AccompanyingPeriodParticipation $participation) use ($person) {
-                if ($person === $participation->getPerson()) {
-                    return $participation;
+        return $this
+            ->getParticipations()
+            ->filter(
+                static function(AccompanyingPeriodParticipation $participation) use ($person): bool {
+                    return $person === $participation->getPerson();
                 }
-            });
+            );
     }
 
     /**
@@ -462,12 +459,13 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
      */
     public function getOpenParticipationContainsPerson(Person $person): ?AccompanyingPeriodParticipation
     {
-        $collection = $this->getParticipationsContainsPerson($person)->filter(
-            function(AccompanyingPeriodParticipation $participation) use ($person) {
-                if (NULL === $participation->getEndDate()) {
-                    return $participation;
+        $collection = $this
+            ->getParticipationsContainsPerson($person)
+            ->filter(
+                static function(AccompanyingPeriodParticipation $participation): bool {
+                    return null === $participation->getEndDate();
                 }
-            });
+            );
 
         return $collection->count() > 0 ? $collection->first() : NULL;
     }
@@ -557,15 +555,16 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
             return false;
         }
 
-        $participation = $this->getParticipationsContainsPerson($person);
-        if (!null === $participation)
+        $participation = $this->getOpenParticipationContainsPerson($person);
+
+        if (null === $participation)
         {
-            $person = $participation->getPerson();
-            $periods = $person->getAccompanyingPeriodsOrdered();
-            return end($periods) === $this;
+            return false;
         }
 
-        return false;
+        $periods = $participation->getPerson()->getAccompanyingPeriodsOrdered();
+
+        return end($periods) === $this;
     }
 
     /**
@@ -863,14 +862,18 @@ class AccompanyingPeriod implements TrackCreationInterface, TrackUpdateInterface
 
     /**
      * Get a list of all persons which are participating to this course
+     *
+     * @psalm-return Collection<int, Person>
      */
     public function getPersons(): Collection
     {
-        return $this->participations->map(
-            function(AccompanyingPeriodParticipation $participation) {
-                return $participation->getPerson();
-            }
-        );
+        return $this
+            ->participations
+            ->map(
+                static function(AccompanyingPeriodParticipation $participation): Person {
+                    return $participation->getPerson();
+                }
+            );
     }
 
     public function setCreatedAt(\DateTimeInterface $datetime): self

src/Bundle/ChillPersonBundle/Entity/Household/Household.php

@@ -2,12 +2,21 @@
 
 namespace Chill\PersonBundle\Entity\Household;
 
+use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\ORM\Mapping as ORM;
 use Doctrine\Common\Collections\Collection;
+use Symfony\Component\Serializer\Annotation as Serializer;
 use Chill\MainBundle\Entity\Address;
+use Chill\PersonBundle\Entity\Household\HouseholdMember;
 
 /**
  * @ORM\Entity
+ * @ORM\Table(
+ *      name="chill_person_household"
+ *  )
+ * @Serializer\DiscriminatorMap(typeProperty="type", mapping={
+ *    "household"=Household::class
+ * })
  */
 class Household
 {
@@ -15,17 +24,12 @@ class Household
      * @ORM\Id
      * @ORM\GeneratedValue
      * @ORM\Column(type="integer")
+     * @Serializer\Groups({"read"})
      */
-    private $id;
-
-    public function getId(): ?int
-    {
-        return $this->id;
-    }
+    private ?int $id = null;
 
     /**
      * Addresses
-     * @var Collection
      *
      * @ORM\ManyToMany(
      *     targetEntity="Chill\MainBundle\Entity\Address",
@@ -33,8 +37,27 @@ class Household
      * @ORM\JoinTable(name="chill_person_household_to_addresses")
      * @ORM\OrderBy({"validFrom" = "DESC"})
      */
-    private $addresses;
+    private Collection $addresses;
 
+    /**
+     * @ORM\OneToMany(
+     *      targetEntity=HouseholdMember::class,
+     *      mappedBy="household"
+     *  )
+     * @Serializer\Groups({"read"})
+     */
+    private Collection $members;
+
+    public function __construct()
+    {
+        $this->addresses = new ArrayCollection();
+        $this->members = new ArrayCollection();
+    }
+
+    public function getId(): ?int
+    {
+        return $this->id;
+    }
 
     /**
      * @param Address $address
@@ -66,4 +89,34 @@ class Household
         return $this->addresses;
     }
 
+    /**
+     * @return Collection|HouseholdMember[]
+     */
+    public function getMembers(): Collection
+    {
+        return $this->members;
+    }
+
+    public function addMember(HouseholdMember $member): self
+    {
+        if (!$this->members->contains($member)) {
+            $this->members[] = $member;
+            $member->setHousehold($this);
+        }
+
+        return $this;
+    }
+
+    public function removeMember(HouseholdMember $member): self
+    {
+        if ($this->members->removeElement($member)) {
+            // set the owning side to null (unless already changed)
+            if ($member->getHousehold() === $this) {
+                $member->setHousehold(null);
+            }
+        }
+
+        return $this;
+    }
+
 }

src/Bundle/ChillPersonBundle/Entity/Household/HouseholdMember.php

@@ -0,0 +1,197 @@
+<?php
+
+namespace Chill\PersonBundle\Entity\Household;
+
+use Doctrine\ORM\Mapping as ORM;
+use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Entity\Household\Household;
+use Chill\PersonBundle\Entity\Household\Position;
+use Symfony\Component\Serializer\Annotation as Serializer;
+
+
+/**
+ * @ORM\Entity
+ * @ORM\Table(
+ *      name="chill_person_household_members"
+ *  )
+ */
+class HouseholdMember
+{
+    /**
+     * @ORM\Id
+     * @ORM\GeneratedValue
+     * @ORM\Column(type="integer")
+     * @Serializer\Groups({"read"})
+     */
+    private $id;
+
+    /**
+     * @ORM\ManyToOne(targetEntity=Position::class)
+     * @Serializer\Groups({"read"})
+     */
+    private ?Position $position = null;
+
+    /**
+     * @ORM\Column(type="date_immutable", nullable=true, options={"default": null})
+     * @Serializer\Groups({"read"})
+     */
+    private ?\DateTimeImmutable $startDate = null;
+
+    /**
+     * @ORM\Column(type="date_immutable", nullable= true, options={"default": null})
+     * @Serializer\Groups({"read"})
+     */
+    private ?\DateTimeImmutable $endDate = null;
+
+    /**
+     * @ORM\Column(type="string", length=255, nullable=true)
+     * @Serializer\Groups({"read"})
+     */
+    private ?string $comment = NULL;
+
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    private bool $sharedHousehold = false;
+
+    /**
+     * @ORM\Column(type="boolean", options={"default": false})
+     * @Serializer\Groups({"read"})
+     */
+    private bool $holder = false;
+
+    /**
+     *
+     * @var Person
+     * @ORM\ManyToOne(
+     *  targetEntity="\Chill\PersonBundle\Entity\Person"
+     * )
+     * @Serializer\Groups({"read"})
+     */
+    private ?Person $person = null;
+
+    /**
+     *
+     * @var Household
+     * @ORM\ManyToOne(
+     *  targetEntity="\Chill\PersonBundle\Entity\Household\Household"
+     * )
+     */
+    private ?Household $household = null;
+
+
+    public function getId(): ?int
+    {
+        return $this->id;
+    }
+
+    public function getPosition(): ?Position
+    {
+        return $this->position;
+    }
+
+    public function setPosition(Position $position): self
+    {
+        if ($this->position instanceof Position) {
+            throw new \LogicException("The position is already set. You cannot change ".
+                "a position of a membership");
+        }
+
+        $this->position = $position;
+        $this->sharedHousehold = $position->getShareHousehold();
+
+        return $this;
+    }
+
+    public function getStartDate(): ?\DateTimeImmutable
+    {
+        return $this->startDate;
+    }
+
+    public function setStartDate(\DateTimeImmutable $startDate): self
+    {
+        $this->startDate = $startDate;
+
+        return $this;
+    }
+
+    public function getEndDate(): ?\DateTimeImmutable
+    {
+        return $this->endDate;
+    }
+
+    public function setEndDate(\DateTimeImmutable $endDate): self
+    {
+        $this->endDate = $endDate;
+
+        return $this;
+    }
+
+    public function getComment(): ?string
+    {
+        return $this->comment;
+    }
+
+    public function setComment(?string $comment): self
+    {
+        $this->comment = $comment;
+
+        return $this;
+    }
+
+    /**
+     * @Serializer\Groups({"read"})
+     */
+    public function getShareHousehold(): ?bool
+    {
+        return $this->sharedHousehold;
+    }
+
+
+    public function getPerson(): ?Person
+    {
+        return $this->person;
+    }
+
+    public function setPerson(?Person $person): self
+    {
+        if ($this->person instanceof Person) {
+            throw new \LogicException("You cannot change person ".
+                "on a membership");
+        }
+
+        $this->person = $person;
+        $this->person->addHouseholdParticipation($this);
+
+        return $this;
+    }
+
+    public function getHousehold(): ?Household
+    {
+        return $this->household;
+    }
+
+    public function setHousehold(?Household $household): self
+    {
+        if ($this->household instanceof Household) {
+            throw new \LogicException("You cannot change household ".
+                "on a membership");
+        }
+
+        $this->household = $household;
+
+        return $this;
+    }
+
+    public function setHolder(bool $holder): self
+    {
+        $this->holder = $holder;
+
+        return $this;
+    }
+
+    public function isHolder(): bool
+    {
+        return $this->holder;
+    }
+}

src/Bundle/ChillPersonBundle/Entity/Household/HouseholdMembers.php

@@ -1,152 +0,0 @@
-<?php
-
-namespace Chill\PersonBundle\Entity\Household;
-
-use Doctrine\ORM\Mapping as ORM;
-use Chill\PersonBundle\Entity\Person;
-use Chill\PersonBundle\Entity\Household\Household;
-
-/**
- * @ORM\Entity
- */
-class HouseholdMembers
-{
-    /**
-     * @ORM\Id
-     * @ORM\GeneratedValue
-     * @ORM\Column(type="integer")
-     */
-    private $id;
-
-    /**
-     * @ORM\Column(type="string", length=255, nullable=true)
-     */
-    private $position;
-
-    /**
-     * @ORM\Column(type="date")
-     */
-    private $startDate;
-
-    /**
-     * @ORM\Column(type="date")
-     */
-    private $endDate;
-
-    /**
-     * @ORM\Column(type="string", length=255, nullable=true)
-     */
-    private $comment;
-
-    /**
-     * @ORM\Column(type="boolean")
-     */
-    private $sharedHousehold;
-
-    /**
-     *
-     * @var Person
-     * @ORM\ManyToOne(
-     *  targetEntity="\Chill\PersonBundle\Entity\Person"
-     * )
-     */
-    private $person;
-
-    /**
-     *
-     * @var Household
-     * @ORM\ManyToOne(
-     *  targetEntity="\Chill\PersonBundle\Entity\Household\Household"
-     * )
-     */
-    private $household;
-
-    public function getId(): ?int
-    {
-        return $this->id;
-    }
-
-    public function getPosition(): ?string
-    {
-        return $this->position;
-    }
-
-    public function setPosition(?string $position): self
-    {
-        $this->position = $position;
-
-        return $this;
-    }
-
-    public function getStartDate(): ?\DateTimeInterface
-    {
-        return $this->startDate;
-    }
-
-    public function setStartDate(\DateTimeInterface $startDate): self
-    {
-        $this->startDate = $startDate;
-
-        return $this;
-    }
-
-    public function getEndDate(): ?\DateTimeInterface
-    {
-        return $this->endDate;
-    }
-
-    public function setEndDate(\DateTimeInterface $endDate): self
-    {
-        $this->endDate = $endDate;
-
-        return $this;
-    }
-
-    public function getComment(): ?string
-    {
-        return $this->comment;
-    }
-
-    public function setComment(?string $comment): self
-    {
-        $this->comment = $comment;
-
-        return $this;
-    }
-
-    public function getSharedHousehold(): ?bool
-    {
-        return $this->sharedHousehold;
-    }
-
-    public function setSharedHousehold(bool $sharedHousehold): self
-    {
-        $this->sharedHousehold = $sharedHousehold;
-
-        return $this;
-    }
-
-    public function getPerson(): ?Person
-    {
-        return $this->person;
-    }
-
-    public function setPerson(?Person $person): self
-    {
-        $this->person = $person;
-
-        return $this;
-    }
-
-    public function getHousehold(): ?Household
-    {
-        return $this->household;
-    }
-
-    public function setHousehold(?Household $household): self
-    {
-        $this->household = $household;
-
-        return $this;
-    }
-}

src/Bundle/ChillPersonBundle/Entity/Household/Position.php

@@ -0,0 +1,98 @@
+<?php
+
+namespace Chill\PersonBundle\Entity\Household;
+
+use Chill\PersonBundle\Repository\Household\PositionRepository;
+use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Serializer\Annotation as Serializer;
+
+/**
+ * @ORM\Entity(repositoryClass=PositionRepository::class)
+ * @ORM\Table(name="chill_person_household_position")
+ * @Serializer\DiscriminatorMap(typeProperty="type", mapping={
+ *   "household_position"=Position::class
+ *   })
+ */
+class Position
+{
+    /**
+     * @ORM\Id
+     * @ORM\GeneratedValue
+     * @ORM\Column(type="integer")
+     * @Serializer\Groups({ "read" })
+     */
+    private $id;
+
+    /**
+     * @ORM\Column(type="json")
+     */
+    private $label = [];
+
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    private $shareHouseHold;
+
+    /**
+     * @ORM\Column(type="boolean")
+     */
+    private $allowHolder;
+
+    /**
+     * @ORM\Column(type="float")
+     */
+    private $ordering;
+
+    public function getId(): ?int
+    {
+        return $this->id;
+    }
+
+    public function getLabel(): ?array
+    {
+        return $this->label;
+    }
+
+    public function setLabel(array $label): self
+    {
+        $this->label = $label;
+
+        return $this;
+    }
+
+    public function getShareHousehold(): ?bool
+    {
+        return $this->shareHouseHold;
+    }
+
+    public function setShareHousehold(bool $shareHouseHold): self
+    {
+        $this->shareHouseHold = $shareHouseHold;
+
+        return $this;
+    }
+
+    public function getAllowHolder(): ?bool
+    {
+        return $this->allowHolder;
+    }
+
+    public function setAllowHolder(bool $allowHolder): self
+    {
+        $this->allowHolder = $allowHolder;
+
+        return $this;
+    }
+
+    public function getOrdering(): ?float
+    {
+        return $this->ordering;
+    }
+
+    public function setOrdering(float $ordering): self
+    {
+        $this->ordering = $ordering;
+
+        return $this;
+    }
+}

src/Bundle/ChillPersonBundle/Entity/Person.php

@@ -26,6 +26,7 @@ use ArrayIterator;
 use Chill\MainBundle\Entity\Center;
 use Chill\MainBundle\Entity\Country;
 use Chill\PersonBundle\Entity\MaritalStatus;
+use Chill\PersonBundle\Entity\Household\HouseholdMember;
 use Chill\MainBundle\Entity\HasCenterInterface;
 use Chill\MainBundle\Entity\Address;
 use DateTime;
@@ -272,6 +273,14 @@ class Person implements HasCenterInterface
      */
     private $fullnameCanonical;
 
+    /**
+     * @ORM\OneToMany(
+     *  targetEntity=HouseholdMember::class,
+     *  mappedBy="person"
+     * )
+     */
+    private Collection $householdParticipations;
+
     /**
      * Person constructor.
      *
@@ -284,6 +293,7 @@ class Person implements HasCenterInterface
         $this->addresses = new ArrayCollection();
         $this->altNames = new ArrayCollection();
         $this->otherPhoneNumbers = new ArrayCollection();
+        $this->householdParticipations = new ArrayCollection();
 
         if ($opening === null) {
             $opening = new \DateTime();
@@ -1180,4 +1190,16 @@ class Person implements HasCenterInterface
         $this->fullnameCanonical = $fullnameCanonical;
         return $this;
     }
+
+    public function addHouseholdParticipation(HouseholdMember $member): self
+    {
+        $this->householdParticipations[] = $member;
+
+        return $this;
+    }
+
+    public function getHouseholdParticipations(): Collection
+    {
+        return $this->householdParticipations;
+    }
 }

src/Bundle/ChillPersonBundle/Form/ChoiceLoader/PersonChoiceLoader.php

@@ -21,31 +21,19 @@ namespace Chill\PersonBundle\Form\ChoiceLoader;
 
 use Symfony\Component\Form\ChoiceList\Loader\ChoiceLoaderInterface;
 use Symfony\Component\Form\ChoiceList\ChoiceListInterface;
-use Doctrine\ORM\EntityRepository;
 use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Repository\PersonRepository;
 
 /**
- * Class PersonChoiceLoader
- *
- * @package Chill\PersonBundle\Form\ChoiceLoader
- * @author Julien Fastré <julien.fastre@champs-libres.coop>
+ * Allow to load a list of person
  */
 class PersonChoiceLoader implements ChoiceLoaderInterface
 {
-    /**
-     * @var EntityRepository
-     */
-    protected $personRepository;
+    protected PersonRepository $personRepository;
     
-    /**
-     * @var array
-     */
-    protected $lazyLoadedPersons = [];
+    protected array $lazyLoadedPersons = [];
     
-    /**
-     * @var array
-     */
-    protected $centers = [];
+    protected array $centers = [];
     
     /**
      * PersonChoiceLoader constructor.
@@ -54,7 +42,7 @@ class PersonChoiceLoader implements ChoiceLoaderInterface
      * @param array|null $centers
      */
     public function __construct(
-        EntityRepository $personRepository,
+        PersonRepository $personRepository,
         array $centers = null
     ) {
         $this->personRepository = $personRepository;

src/Bundle/ChillPersonBundle/Household/MembersEditor.php

@@ -0,0 +1,79 @@
+<?php
+
+namespace Chill\PersonBundle\Household;
+
+use Symfony\Component\Validator\ConstraintViolationListInterface;
+use Chill\PersonBundle\Entity\Household\HouseholdMember;
+use Chill\PersonBundle\Entity\Household\Position;
+use Chill\PersonBundle\Entity\Household\Household;
+use Chill\PersonBundle\Entity\Person;
+use Symfony\Component\Validator\Validator\ValidatorInterface;
+
+
+class MembersEditor
+{
+    private ValidatorInterface $validator;
+    private Household $household;
+
+    private array $persistables = [];
+    private array $membershipsAffected = [];
+
+    public function __construct(ValidatorInterface $validator, Household $household)
+    {
+        $this->validation = $validator;
+        $this->household = $household;
+    }
+    
+    public function addMovement(\DateTimeImmutable $date, Person $person, Position $position, ?bool $holder = false, ?string $comment = null): self
+    {
+        if (NULL === $this->household) {
+            throw new \LogicException("You must define a household first");
+        }
+
+        $membership = (new HouseholdMember())
+            ->setStartDate($date)
+            ->setPerson($person)
+            ->setPosition($position)
+            ->setHolder($holder)
+            ->setHousehold($this->household)
+            ->setComment($comment)
+            ;
+
+        if ($position->getShareHousehold()) {
+            foreach ($person->getHouseholdParticipations() as $participation) {
+                if (FALSE === $participation->getShareHousehold()) {
+                    continue;
+                }
+
+                if ($participation === $membership) {
+                    continue;
+                }
+
+                if ($participation->getEndDate() === NULL || $participation->getEndDate() > $date) {
+                    $participation->setEndDate($date);
+                    $this->membershipsAffected[] = $participation;
+                }
+            }
+        }
+
+        $this->membershipsAffected[] = $membership;
+        $this->persistables[] = $membership;
+
+        return $this;
+    }
+
+    public function validate(): ConstraintViolationListInterface
+    {
+
+    }
+
+    public function getPersistable(): array
+    {
+        return $this->persistables;
+    }
+
+    public function getHousehold(): Household
+    {
+        return $this->household;
+    }
+}

src/Bundle/ChillPersonBundle/Household/MembersEditorFactory.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Chill\PersonBundle\Household;
+
+use Chill\PersonBundle\Household\MembersEditor;
+use Chill\PersonBundle\Entity\Household\Household;
+use Symfony\Component\Validator\Validator\ValidatorInterface;
+
+
+class MembersEditorFactory
+{
+    public function __construct(ValidatorInterface $validator)
+    {
+        $this->validator = $validator;
+    }
+
+    public function createEditor(Household $household): MembersEditor
+    {
+        return new MembersEditor($this->validator, $household);
+    }
+}

src/Bundle/ChillPersonBundle/Menu/HouseholdMenuBuilder.php

@@ -0,0 +1,56 @@
+<?php
+
+namespace Chill\PersonBundle\Menu;
+
+use Chill\MainBundle\Routing\LocalMenuBuilderInterface;
+use Chill\PersonBundle\Entity\Household\Household;
+use Knp\Menu\MenuItem;
+use Symfony\Contracts\Translation\TranslatorInterface;
+
+class HouseholdMenuBuilder implements LocalMenuBuilderInterface
+{
+    
+    /**
+     * @var TranslatorInterface
+     */
+    protected $translator;
+    
+    public function __construct(TranslatorInterface $translator)
+    {
+        $this->translator = $translator;
+    }
+    
+    public static function getMenuIds(): array
+    {
+        return [ 'household' ];
+    }
+    
+    public function buildMenu($menuId, MenuItem $menu, array $parameters): void
+    {
+        $household = $parameters['household'];
+
+        $menu->addChild($this->translator->trans('Summary'), [
+            'route' => 'chill_person_household_summary',
+            'routeParameters' => [
+                'household_id' => $household->getId()
+        ]])
+        ->setExtras(['order' => 10]);
+
+        $menu->addChild($this->translator->trans('Members'), [
+            'route' => 'chill_person_household_members',
+            'routeParameters' => [
+                'household_id' => $household->getId()
+        ]])
+        ->setExtras(['order' => 20]);
+        
+        $menu->addChild($this->translator->trans('Addresses'), [
+            'route' => 'chill_person_household_addresses',
+            'routeParameters' => [
+                'household_id' => $household->getId()
+        ]])
+        ->setExtras(['order' => 30]);
+        
+    }
+    
+    
+}

src/Bundle/ChillPersonBundle/Repository/Household/PositionRepository.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Chill\PersonBundle\Repository\Household;
+
+use Chill\PersonBundle\Entity\Household\Position;
+use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
+use Doctrine\Persistence\ManagerRegistry;
+
+/**
+ * @method Position|null find($id, $lockMode = null, $lockVersion = null)
+ * @method Position|null findOneBy(array $criteria, array $orderBy = null)
+ * @method Position[]    findAll()
+ * @method Position[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ */
+class PositionRepository extends ServiceEntityRepository
+{
+    public function __construct(ManagerRegistry $registry)
+    {
+        parent::__construct($registry, Position::class);
+    }
+
+}

src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated.vue

@@ -9,8 +9,7 @@
    <table class="rounded" v-if="participations.length > 0">
       <thead>
          <tr>
-            <th class="chill-orange">{{ $t('persons_associated.firstname') }}</th>
-            <th class="chill-orange">{{ $t('persons_associated.lastname') }}</th>
+            <th class="chill-orange">{{ $t('persons_associated.name') }}</th>
             <th class="chill-orange">{{ $t('persons_associated.startdate') }}</th>
             <th class="chill-orange">{{ $t('persons_associated.enddate') }}</th>
             <th class="chill-orange">{{ $t('action.actions') }}</th>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/PersonsAssociated/PersonItem.vue

@@ -1,7 +1,9 @@
 <template>
 <tr>
-   <td>{{ participation.person.firstName }}</td>
-   <td>{{ participation.person.lastName }}</td>
+   <td>
+      {{ participation.person.firstName }}
+      {{ participation.person.lastName }}
+   </td>
    <td><span v-if="participation.startDate">
        {{ $d(participation.startDate.datetime, 'short') }}</span>
    </td>
@@ -11,16 +13,18 @@
    <td>
       <ul class="record_actions">
          <li>
-            <a class="sc-button bt-show" target="_blank"
-               :href="url.show"
-               :title="$t('action.show')">
-            </a>
+            <on-the-fly
+               v-bind:type="participation.person.type"
+               v-bind:id="participation.person.id"
+               action="show">
+            </on-the-fly>
          </li>
          <li>
-            <a class="sc-button bt-update" target="_blank"
-               :href="url.edit"
-               :title="$t('action.edit')">
-            </a>
+            <on-the-fly
+               v-bind:type="participation.person.type"
+               v-bind:id="participation.person.id"
+               action="edit">
+            </on-the-fly>
          </li>
          <!--li>
             <button class="sc-button bt-delete"
@@ -31,7 +35,7 @@
          <li>
             <button v-if="!participation.endDate"
                class="sc-button bt-remove"
-               :title="$t('action.remove')" 
+               v-bind:title="$t('action.remove')" 
                @click.prevent="$emit('close', participation)">
             </button>
             <button v-else class="sc-button bt-remove disabled"></button>
@@ -42,17 +46,14 @@
 </template>
 
 <script>
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+
 export default {
    name: 'PersonItem',
-   props: ['participation'],
-   data() {
-      return {
-         url: {
-            show: '/fr/person/' + this.participation.person.id + '/general',
-            edit: '/fr/person/' + this.participation.person.id + '/general/edit'
-         }
-      }
+   components: {
+      OnTheFly
    },
-   emits: ['remove', 'close']
+   props: ['participation'],
+   emits: ['remove', 'close'],
 }
 </script>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Requestor.vue

@@ -11,44 +11,50 @@
       </label>
       
       <div class="item-bloc">
-         <div class="item-row">
-            <div class="item-col">
-               <h4>
-                  {{ accompanyingCourse.requestor.text }}
-               </h4>
-               <span class="badge badge-pill badge-secondary">{{ accompanyingCourse.requestor.type }}</span>
-            </div>
-            <div class="item-col">
-               <ul class="content-bloc" v-if="accompanyingCourse.requestor.type === 'person'">
-                  
-                  <li><i>{{ $t('requestor.birthdate') }}</i>   
-                     {{ $d(accompanyingCourse.requestor.birthdate.datetime, 'short') }}
-                  </li>
-                  <li><i>{{ $t('requestor.center') }}</i>   
-                     {{ accompanyingCourse.requestor.center.name }}
-                  </li>
-                  <li><i>{{ $t('requestor.phonenumber') }}</i>   
-                     {{ accompanyingCourse.requestor.phonenumber }}
-                  </li>
-                  <li><i>{{ $t('requestor.mobilenumber') }}</i>   
-                     {{ accompanyingCourse.requestor.mobilenumber }}
-                  </li>
-               </ul>
-               <ul class="content-bloc" v-if="accompanyingCourse.requestor.type === 'thirdparty'">
-                  
-                  <dt>{{ $t('requestor.address') }}</dt>
-                  <dd>{{ accompanyingCourse.requestor.address.text }}</dd>
-                  
-                  <dt>{{ $t('requestor.location') }}</dt>
-                  <dd>{{ accompanyingCourse.requestor.address.postcode.name }}</dd>
-               </ul>
-               <ul class="record_actions">
-                  <li>
-                     <a class="sc-button bt-show" :title="$t('action.show')" target="_blank" :href="url.show"></a>
-                  </li>
-               </ul>
-            </div>
-         </div>
+         <h4>
+            <span class="badge badge-pill badge-secondary">{{ accompanyingCourse.requestor.type }}</span>
+            {{ accompanyingCourse.requestor.text }}
+         </h4>   
+         
+         <dl class="content-bloc" v-if="accompanyingCourse.requestor.type === 'person'">
+            
+            <dt>{{ $t('requestor.birthdate') }}</dt>   
+            <dd>{{ $d(accompanyingCourse.requestor.birthdate.datetime, 'short') }}</dd>
+            
+            <dt>{{ $t('requestor.center') }}</dt>   
+            <dd>{{ accompanyingCourse.requestor.center.name }}</dd>
+            
+            <dt>{{ $t('requestor.phonenumber') }}</dt>   
+            <dd>{{ accompanyingCourse.requestor.phonenumber }}</dd>
+            <dt>{{ $t('requestor.mobilenumber') }}</dt>   
+            <dd>{{ accompanyingCourse.requestor.mobilenumber }}</dd>
+         </dl>
+         
+         <dl class="content-bloc" v-if="accompanyingCourse.requestor.type === 'thirdparty'">
+            
+            <dt>{{ $t('requestor.address') }}</dt>
+            <dd>{{ accompanyingCourse.requestor.address.text }}</dd>
+            
+            <dt>{{ $t('requestor.location') }}</dt>
+            <dd>{{ accompanyingCourse.requestor.address.postcode.name }}</dd>
+         </dl>
+
+         <ul class="record_actions">
+            <li>
+               <on-the-fly
+                  v-bind:type="accompanyingCourse.requestor.type"
+                  v-bind:id="accompanyingCourse.requestor.id"
+                  action="show">
+               </on-the-fly>
+            </li>
+            <li>
+               <on-the-fly
+                  v-bind:type="accompanyingCourse.requestor.type"
+                  v-bind:id="accompanyingCourse.requestor.id"
+                  action="edit">
+               </on-the-fly>
+            </li>
+         </ul>
       </div>
       <ul class="record_actions">
          <li>
@@ -79,12 +85,14 @@
 </template>
 
 <script>
-import AddPersons from 'ChillPersonAssets/vuejs/_components/AddPersons.vue'
+import AddPersons from 'ChillPersonAssets/vuejs/_components/AddPersons.vue';
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
 
 export default {
    name: 'Requestor',
    components: {
       AddPersons,
+      OnTheFly
    },
    data() {
       return {
@@ -110,13 +118,6 @@ export default {
          get() {
             return this.$store.state.accompanyingCourse.requestorAnonymous;
          }
-      },
-      url() {
-         return (this.accompanyingCourse.requestor.type === 'person') ? {
-            show: `/fr/person/${this.accompanyingCourse.requestor.id}/general`,
-         } : {
-            show: `/fr/thirdparty/thirdparty/${this.accompanyingCourse.requestor.id}/show`,
-         }
       }
    },
    methods: {

src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/components/Resources/ResourceItem.vue

@@ -21,24 +21,25 @@
    <td>
       <ul class="record_actions">
          <li>
-            <a class="sc-button bt-show" target="_blank"
-               :href="url.show"
-               :title="$t('action.show')">
-            </a>
+            <on-the-fly
+               v-bind:type="resource.resource.type"
+               v-bind:id="resource.resource.id"
+               action="show">
+            </on-the-fly>
          </li>
          <li>
-            <a class="sc-button bt-update" target="_blank"
-               :href="url.edit"
-               :title="$t('action.edit')">
-            </a>
+            <on-the-fly
+               v-bind:type="resource.resource.type"
+               v-bind:id="resource.resource.id"
+               action="edit">
+            </on-the-fly>
          </li>
          <li>
             <button
                class="sc-button bt-remove"
-               :title="$t('action.remove')" 
+               v-bind:title="$t('action.remove')" 
                @click.prevent="$emit('remove', resource)">
             </button>
-            
          </li>
       </ul>
    </td>
@@ -46,23 +47,14 @@
 </template>
 
 <script>
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+
 export default {
    name: 'ResourceItem',
+   components: {
+      OnTheFly
+   },
    props: ['resource'],
-   emits: ['remove'],
-   computed: {
-      type() {
-         return this.resource.resource.type;
-      },
-      url() {
-         return (this.type === 'person') ? {
-            show: `/fr/person/${this.resource.resource.id}/general`,
-            edit: `/fr/person/${this.resource.resource.id}/general/edit`
-         } : {
-            show: `/fr/thirdparty/thirdparty/${this.resource.resource.id}/show`,
-            edit: `/fr/thirdparty/thirdparty/${this.resource.resource.id}/update`
-         }
-      }
-   }
+   emits: ['remove']
 }
 </script>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/AccompanyingCourse/js/i18n.js

@@ -31,6 +31,7 @@ const appMessages = {
          counter: "Il n'y a pas encore d'usager | 1 usager | {count} usagers",
          firstname: "Prénom",
          lastname: "Nom",
+         name: "Nom",
          startdate: "Date d'entrée",
          enddate: "Date de sortie",
          add_persons: "Ajouter des usagers",
@@ -73,7 +74,7 @@ const appMessages = {
       comment: {
          title: "Observations",
          label: "Ajout d'une note",
-         content: "Rédigez une première note...",
+         content: "Rédigez une première note…",
          created_by: "créé par {0}, le {1}" 
       },
       confirm: {

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_api/OnTheFly.js

@@ -0,0 +1,34 @@
+/*
+* GET a person by id
+*/
+const getPerson = (id) => {
+   const url = `/api/1.0/person/person/${id}.json`;
+   return fetch(url)
+      .then(response => {
+         if (response.ok) { return response.json(); }
+         throw Error('Error with request resource response');
+      });
+};
+
+/*
+* POST a new person
+*/
+const postPerson = (body) => {
+   const url = `/api/1.0/person/person.json`;
+   return fetch(url, {
+         method: 'POST',
+         headers: {
+           'Content-Type': 'application/json;charset=utf-8'
+         },
+         body: JSON.stringify(body)
+      })
+      .then(response => {
+         if (response.ok) { return response.json(); }
+         throw Error('Error with request resource response');
+      });
+};
+   
+export { 
+   getPerson, 
+   postPerson 
+};

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue

@@ -65,9 +65,14 @@
                   @updateSelected="updateSelected">
                </person-suggestion>
 
-               <button v-if="query.length >= 3" class="sc-button bt-create ml-5 mt-2" name="createPerson">
-                  {{ $t('action.create') }} "{{ query }}"
-               </button>
+               <div class="create-button">
+                  <on-the-fly
+                     v-if="query.length >= 3" 
+                     v-bind:buttonText="$t('onthefly.create.button', {q: query})"
+                     action="create"><!-- TODO first close this modal -->
+                  </on-the-fly>
+               </div>
+               
             </div>
          </template>
 
@@ -84,6 +89,7 @@
 
 <script>
 import Modal from 'ChillMainAssets/vuejs/_components/Modal';
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
 import PersonSuggestion from './AddPersons/PersonSuggestion';
 import { searchPersons, searchPersons_2 } from 'ChillPersonAssets/vuejs/_api/AddPersons';
 
@@ -92,6 +98,7 @@ export default {
    components: {
       Modal,
       PersonSuggestion,
+      OnTheFly
    },
    props: [
       'buttonTitle',
@@ -170,7 +177,7 @@ export default {
          if (query.length >= 3) {
             searchPersons_2({ query, options: this.options })
                .then(suggested => new Promise((resolve, reject) => {
-                  console.log('suggested', suggested);
+                  //console.log('suggested', suggested);
                   this.loadSuggestions(suggested.results);
                   resolve();
             }));
@@ -179,14 +186,14 @@ export default {
          }
       },
       loadSuggestions(suggested) { 
-         console.log('suggested', suggested);
+         //console.log('suggested', suggested);
          this.search.suggested = suggested;
          this.search.suggested.forEach(function(item) {
             item.key = this.itemKey(item);
          }, this);
       },
       updateSelected(value) {
-         console.log('value', value);
+         //console.log('value', value);
          this.search.selected = value;
       },
       resetSearch() {
@@ -256,4 +263,8 @@ export default {
          }
       }
    }
+   .create-button > a {
+      margin-top: 0.5em;
+      margin-left: 2.6em;
+   }
 </style>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/PersonSuggestion.vue

@@ -42,7 +42,7 @@ export default {
    computed: {
       selected: {
          set(value) {
-            console.log('value', value);
+            //console.log('value', value);
             this.$emit('updateSelected', value);
          },
          get() {

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypePerson.vue

@@ -14,22 +14,23 @@
       <span class="badge badge-pill badge-secondary" :title="item.key">
          {{ $t('item.type_person') }}
       </span>
-      <a class="sc-button bt-show" target="_blank" :title="item.key" :href="url.show"></a>
+      <on-the-fly
+         type="person"
+         v-bind:id="item.result.id"
+         action="show">
+      </on-the-fly>
       
    </div>
 </template>
 
 <script>
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+
 export default {
    name: 'SuggestionPerson',
-   props: ['item'],
-   data() {
-      return {
-         url: {
-            show: '/fr/person/' + this.item.result.person_id + '/general',
-            edit: '/fr/person/' + this.item.result.person_id + '/general/edit'
-         },
-      }
+   components: {
+      OnTheFly
    },
+   props: ['item']
 }
 </script>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons/TypeThirdParty.vue

@@ -15,22 +15,23 @@
       <span class="badge badge-pill badge-secondary" :title="item.key">
          {{ $t('item.type_thirdparty') }}
       </span>
-      <a class="sc-button bt-show" target="_blank" :title="item.key" :href="url.show"></a>
+      <on-the-fly
+         type="thirdparty"
+         v-bind:id="item.result.id"
+         action="show">
+      </on-the-fly>
       
    </div>
 </template>
 
 <script>
+import OnTheFly from 'ChillMainAssets/vuejs/_components/OnTheFly.vue';
+
 export default {
    name: 'SuggestionThirdParty',
-   props: ['item'],
-   data() {
-      return {
-         url: {
-            show: '/fr/thirdparty/thirdparty/' + this.item.result.thirdparty_id + '/show',
-            edit: '/fr/thirdparty/thirdparty/' + this.item.result.thirdparty_id + '/edit'
-         },
-      }
+   components: {
+      OnTheFly
    },
+   props: ['item']
 }
 </script>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/OnTheFly/Person.vue

@@ -0,0 +1,200 @@
+<template>
+<div v-if="action === 'show'">
+   
+   <div class="flex-table">
+      <div class="item-bloc">
+         <div class="item-row">
+            <div class="item-col">
+               <h3 :title="person.id">{{ person.text }}</h3>
+               <p>
+                  <i class="fa fa-fw" 
+                     :class="genderClass">
+                     <!--
+                     :title="$t(genderTranslation)"
+                     -->
+                  </i>
+                  <span v-if="person.birthdate">
+                     {{ $t('person.born', { e: feminized }) }}
+                     {{ $d(person.birthdate.datetime, 'short') }}
+                  </span>
+               </p>
+            </div>
+            <div class="item-col">
+               <dl class="list-content"> 
+                  <dt>{{ $t('person.firstname') }}</dt>
+                  <dd>{{ person.firstName }}</dd>
+                  
+                  <dt>{{ $t('person.lastname') }}</dt>
+                  <dd>{{ person.lastName }}</dd>
+                  
+                  <dt>{{ $t('person.altnames') }}</dt>
+                  <dd>{{ person.altNames }}</dd>
+                  
+                  <span v-if="person.center">
+                     <dt>{{ $t('person.center_name') }}</dt>
+                     <dd :title="person.center.id">{{ person.center.name }}</dd>
+                  </span>
+                     
+                  <dt>{{ $t('person.phonenumber') }}</dt>
+                  <dd>{{ person.phonenumber }}</dd>
+                  
+                  <dt>{{ $t('person.mobilenumber') }}</dt>
+                  <dd>{{ person.mobilenumber }}</dd>
+                  
+                  <dt>{{ $t('person.gender.title') }}</dt>
+                  <!--
+                  <dd>{{ $t(genderTranslation) }}</dd>
+                  -->
+               </dl>
+            </div>
+         </div>
+      </div>
+   </div>   
+   
+</div>
+<div v-else-if="action === 'edit' || action === 'create'">
+   
+   <input v-model="firstName" :placeholder="$t('person.firstname')" />
+   <input v-model="lastName" :placeholder="$t('person.lastname')" />
+   
+   <!--  TODO fix placeholder if undefined 
+         TODO dynamically get gender options
+   -->
+   <select v-model="gender">
+      <option disabled value="">{{ $t('person.gender.placeholder') }}</option> 
+      <option value="woman">{{ $t('person.gender.woman') }}</option>
+      <option value="man">{{ $t('person.gender.man') }}</option>
+      <option value="neuter">{{ $t('person.gender.neuter') }}</option>  
+   </select>
+   
+   <i class="fa fa-birthday-cake"></i>
+   <input type="date"
+      id="chill_personbundle_person_birthdate" 
+      name="chill_personbundle_person[birthdate]" 
+      v-model="birthDate"
+   />
+   
+   <i class="fa fa-phone">
+   </i><input v-model="phonenumber" :placeholder="$t('person.phonenumber')" />
+   <i class="fa fa-mobile">
+   </i><input v-model="mobilenumber" :placeholder="$t('person.mobilenumber')" />
+   
+</div>
+</template>
+
+<script>
+import { getPerson, postPerson } from '../../_api/OnTheFly';
+
+export default {
+   name: "OnTheFlyPerson",
+   props: ['id', 'type', 'action'],
+   data() {
+      return {
+         person: {
+            type: 'person'
+         }
+      }
+   },
+   computed: {
+      firstName: {
+         set(value) { this.person.firstName = value; },
+         get() { return this.person.firstName; }
+      },
+      lastName: {
+         set(value) { this.person.lastName = value; },
+         get() { return this.person.lastName; }
+      },
+      gender: {
+         set(value) { this.person.gender = value; },
+         get() { return this.person.gender; } 
+      },
+      birthDate: {
+         set(value) { 
+            if (this.person.birthdate) {
+               this.person.birthdate.datetime = value + "T00:00:00+0100"; 
+            } else {
+               this.person.birthdate = { datetime: value + "T00:00:00+0100"};
+            }
+         },
+         get() { 
+            return (this.person.birthdate) ? this.person.birthdate.datetime.split('T')[0] : ''; 
+         } 
+      },
+      phonenumber: {
+         set(value) { this.person.phonenumber = value; },
+         get() { return this.person.phonenumber; }
+      },
+      mobilenumber: {
+         set(value) { this.person.mobilenumber = value; },
+         get() { return this.person.mobilenumber; }
+      },
+      genderClass() {
+         switch (this.person.gender) {
+            case 'woman':
+               return 'fa-venus';
+            case 'man':
+               return 'fa-mars';
+            case 'neuter':
+               return 'fa-neuter';
+         }
+      },
+      genderTranslation() {
+         switch (this.person.gender) {
+            case 'woman':
+               return 'person.gender.woman';
+            case 'man':
+               return 'person.gender.man';
+            case 'neuter':
+               return 'person.gender.neuter';
+         }
+      },
+      feminized() {
+         return (this.person.gender === 'woman')? 'e' : ''; 
+      }
+   },
+   mounted() {
+      if (this.action !== 'create') {
+         this.loadData();
+      }
+   },
+   methods: {
+      loadData() {
+         getPerson(this.id)
+            .then(person => new Promise((resolve, reject) => {
+               this.person = person;
+               console.log('get person', this.person);
+               resolve();
+         }));
+      },
+      postData() {
+         postPerson(this.person)
+            .then(person => new Promise((resolve, reject) => {
+               this.person = person;
+               console.log('post person', person);
+               resolve();
+         }));
+      }
+   }
+}
+</script>
+
+<style lang="scss" scoped>
+ul {
+   li::marker {
+   }
+}
+div.flex-table {
+   div.item-bloc {
+      div.item-row {
+         div.item-col:last-child {
+            justify-content: flex-start;
+         }
+      }
+   }
+}
+dl {
+   dd {
+      margin-left: 1em;
+   }
+}
+</style>

src/Bundle/ChillPersonBundle/Resources/public/vuejs/_js/i18n.js

@@ -15,7 +15,21 @@ const personMessages = {
       person: {
          firstname: "Prénom",
          lastname: "Nom",
-         born: "né le ",
+         born: "né{e} le ",
+         center_id: "Identifiant du centre",
+         center_type: "Type de centre",
+         center_name: "Territoire", // vendée
+         phonenumber: "Téléphone",
+         mobilenumber: "Mobile",
+         altnames: "Autres noms",
+         gender: {
+            title: "Genre",
+            placeholder: "Choisissez le genre de l'usager",
+            woman: "Femme",
+            man: "Homme",
+            neuter: "Neutre",
+         }
+         
       },
       error_only_one_person: "Une seule personne peut être sélectionnée !"
    }

src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/index.html.twig

@@ -31,7 +31,7 @@
                             {% set gender = (p.person.gender == 'woman') ? 'fa-venus' : 
                                 (p.person.gender == 'man') ? 'fa-mars' : 'fa-neuter' %}
                             {% set genderTitle = (p.person.gender == 'woman') ? 'femme' : 
-                                (p.person.gender == 'homme') ? 'fa-mars' : 'neutre' %}
+                                (p.person.gender == 'man') ? 'homme' : 'neutre' %}
                             <i class="fa fa-fw {{ gender }}" title="{{ genderTitle }}"></i>{{ born ~ ' le ' ~ p.person.birthdate|format_date('short') }}
                         </p>
                     </div>

src/Bundle/ChillPersonBundle/Resources/views/Household/address_move.html.twig

@@ -0,0 +1,11 @@
+{% extends '@ChillPerson/Household/layout.html.twig' %}
+
+{% block title 'Move household'|trans %}
+
+{% block content %}
+<h1>{{ block('title') }}</h1>
+
+<p>Household with id {{ household.id }}</p>
+
+
+{% endblock %}

src/Bundle/ChillPersonBundle/Resources/views/Household/addresses.html.twig

@@ -0,0 +1,15 @@
+{% extends '@ChillPerson/Household/layout.html.twig' %}
+
+{% block title 'Addresses history for household'|trans %}
+
+{% block content %}
+<h1>{{ block('title') }}</h1>
+
+<p>Household with id {{ household.id }}</p>
+
+<a class="sc-button bt-update" 
+  href="{{ chill_path_add_return_path('chill_person_household_address_move', { 'household_id': household.id }) }}">
+  {{ 'Move household'|trans }}
+</a>
+
+{% endblock %}

src/Bundle/ChillPersonBundle/Resources/views/Household/banner.html.twig

@@ -0,0 +1,26 @@
+<div class="subheader">
+    <div class="grid-12 parent" id="header-accompanying_course-name" >
+        <div class="grid-10 push-1 grid-mobile-12 grid-tablet-12 push-mobile-0 push-tablet-0 parent">
+
+            <div class="grid-6">{% set title = title %}
+                <h1>
+                    <i class="fa fa-child"></i>
+                    {{ 'Household'|trans }}
+                    <span style="font-weight: lighter; font-size: 50%;">(n°{{ household.id  }})</span>
+                </h1>
+            </div>
+
+            <div class="grid-3" id="banner-flags"></div>
+
+            <div class="grid-3" id="banner-status"></div>
+
+        </div>
+    </div>
+    <div class="grid-12 parent" id="header-accompanying_course-details" >
+        <div class="grid-10 push-1 grid-mobile-12 grid-tablet-12 push-mobile-0 push-tablet-0 parent">
+
+            <div id="banner-misc"></div>
+
+        </div>
+    </div>
+</div>

src/Bundle/ChillPersonBundle/Resources/views/Household/layout.html.twig

@@ -0,0 +1,17 @@
+{% extends "ChillMainBundle::layoutWithVerticalMenu.html.twig" %}
+
+{% block top_banner %}
+    {{ include('@ChillPerson/Household/banner.html.twig', { title: block('title') }) }}
+{% endblock %}
+
+{% block layout_wvm_content %}
+    {% block content %}{% endblock %}
+{% endblock  %}
+
+{% block vertical_menu_content %}
+    {{ chill_menu('household', {
+        'layout': '@ChillPerson/Household/menu.html.twig',
+        'args' : { 'household': household }
+    }) }}
+{% endblock %}
+

src/Bundle/ChillPersonBundle/Resources/views/Household/members.html.twig

@@ -0,0 +1,10 @@
+{% extends '@ChillPerson/Household/layout.html.twig' %}
+
+{% block title 'Household members'|trans %}
+
+{% block content %}
+<h1>{{ block('title') }}</h1>
+
+<p>Household with id {{ household.id }}</p>
+
+{% endblock %}

src/Bundle/ChillPersonBundle/Resources/views/Household/menu.html.twig

@@ -0,0 +1,7 @@
+<ul class="tab-nav">
+    {% for menu in menus %}
+        <li class="">
+            <a href="{{ menu.uri }}" >{{ menu.label|upper }}</a>
+        </li>
+    {% endfor %}
+</ul>

src/Bundle/ChillPersonBundle/Resources/views/Household/summary.html.twig

@@ -0,0 +1,14 @@
+{% extends '@ChillPerson/Household/layout.html.twig' %}
+
+{% block title 'Household summary'|trans %}
+
+{% block content %}
+<h1>{{ block('title') }}</h1>
+
+<p>Household with id {{ household.id }}</p>
+
+<h2>{{ 'Actual household members'|trans }}</h2>
+
+<p>TODO</p>
+
+{% endblock %}

src/Bundle/ChillPersonBundle/Resources/views/Timeline/closing_period.html.twig

@@ -1,11 +1,24 @@
-<h3 class="single-line">
+<div>
+  <h3 class="single-line">
     {{ period.closingDate|format_date('long')  }}
-    <span class="person"> /
-        <a href="{{ path('chill_person_accompanying_period_list', { 'person_id': person.id } ) }}">
-            {{ 'Closing the accompanying period' | trans }}
-        </a>
-    <span>
-    <span class="chill-red">
-        <i class="fa fa-folder"></i>
-    </span>
-</h3> 
+    <span class="person"> / </span>
+    {{ 'An accompanying period ends'|trans }}
+    {% if 'person' != context %}
+      {% for p in period.persons %}
+        / {{ p|chill_entity_render_box({'addLink': true}) }}
+      {% endfor %}
+    {% endif %}
+  </h3>
+
+  <div class="statement">
+    <dl class="chill_view_data">
+      <dd>{{ 'Participants'|trans }}&nbsp;:</dd>
+      <dt>
+      <ul>
+        {% for p in period.participations %}
+        <li>{{ p.person|chill_entity_render_box({ 'addLink': true }) }}: {{ 'since %date%'|trans({'%date%': p.startDate|format_date("long") } ) }}, {{ 'until %date%'|trans({'%date%': (p.endDate is not null ? p.endDate : period.closingDate)|format_date("long") }) }}</li>
+        {% endfor %}
+      </ul>
+      </dt>
+  </div>
+</div>

src/Bundle/ChillPersonBundle/Resources/views/Timeline/opening_period.html.twig

@@ -1,11 +1,24 @@
-<h3 class="single-line">
+<div>
+  <h3 class="single-line">
     {{ period.openingDate|format_date('long')  }}
-    <span class="person"> /
-        <a href="{{ path('chill_person_accompanying_period_list', { 'person_id': person.id } ) }}">
-            {{ 'Opening the accompanying period' | trans }}
-        </a>
-    </span>
-    <span class="chill-green">
-        <i class="fa fa-folder-open"></i>
-    </span>
-</h3> 
+    <span class="person"> / </span>
+    {{ 'An accompanying period starts'|trans }}
+    {% if 'person' != context %}
+      {% for p in period.persons %}
+        / {{ p|chill_entity_render_box({'addLink': true}) }}
+      {% endfor %}
+    {% endif %}
+  </h3>
+
+  <div class="statement">
+    <dl class="chill_view_data">
+      <dd>{{ 'Participants'|trans }}&nbsp;:</dd>
+      <dt>
+      <ul>
+        {% for p in period.participations %}
+        <li>{{ 'Since %date%'|trans( {'%date%': p.startDate|format_date("long") } ) }}&nbsp;: {{ p.person|chill_entity_render_box({ 'addLink': true }) }}</li>
+        {% endfor %}
+      </ul>
+      </dt>
+  </div>
+</div>

src/Bundle/ChillPersonBundle/Serializer/Normalizer/MembersEditorNormalizer.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace Chill\PersonBundle\Serializer\Normalizer;
+
+use Chill\PersonBundle\Entity\Household\Position;
+use Chill\PersonBundle\Entity\Household\Household;
+use Chill\PersonBundle\Entity\Person;
+use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
+use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait;
+use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
+use Symfony\Component\Serializer\Exception;
+use Chill\PersonBundle\Household\MembersEditorFactory;
+use Chill\PersonBundle\Household\MembersEditor;
+
+class MembersEditorNormalizer implements DenormalizerInterface, DenormalizerAwareInterface
+{
+    private MembersEditorFactory $factory;
+
+    use DenormalizerAwareTrait;
+
+    public function __construct(MembersEditorFactory $factory)
+    {
+        $this->factory = $factory;
+    }
+
+    public function denormalize($data, string $type, string $format = null, array $context = [])
+    {
+        $household = $this->denormalizer->denormalize($data['destination'], Household::class, 
+            $format, $context);
+
+        if (NULL === $household) {
+           throw new Exception\InvalidArgumentException("household could not be denormalized. Impossible to process"); 
+        }
+
+        $editor = $this->factory->createEditor($household);
+
+        if (NULL == $data['concerned'] ?? [] 
+            && FALSE === ·\is_array('concerned')) {
+            throw new Exception\UnexpectedValueException("The schema does not have any key 'concerned'");
+        }
+
+        foreach ($data['concerned'] as $key => $concerned) {
+            $person = $this->denormalizer->denormalize($concerned['person'] ?? null, Person::class, 
+                $format, $context); 
+            $position = $this->denormalizer->denormalize($concerned['position'] ?? null, Position::class,
+                $format, $context);
+            $startDate = $this->denormalizer->denormalize($concerned['start_date'] ?? null, \DateTimeImmutable::class,
+                $format, $context);
+
+            $holder = (bool) $concerned['holder'] ?? false;
+            $comment = (string) $concerned['comment'] ?? false;
+
+            if (
+                NULL === $person
+                && NULL === $position
+                && NULL === $startDate
+            ) {
+                throw new Exception\InvalidArgumentException("position with ".
+                    "key $key could not be denormalized: missing ".
+                    "person, position or start_date.");
+            }
+
+            $editor->addMovement($startDate, $person, $position, $holder, 
+                $comment);
+
+            return $editor;
+        }
+    }
+
+    public function supportsDenormalization($data, string $type, string $format = null)
+    {
+        return $type === MembersEditor::class;
+    }
+
+}

src/Bundle/ChillPersonBundle/Serializer/Normalizer/SocialIssueNormalizer.php

@@ -14,14 +14,10 @@ class SocialIssueNormalizer implements NormalizerInterface, NormalizerAwareInter
 
     use NormalizerAwareTrait;
 
-    /**
-     * @param SocialIssueRender $render
-     */
     public function __construct(SocialIssueRender $render)
     {
         $this->render = $render;
     }
-    
 
     public function normalize($socialIssue, string $format = null, array $context = [])
     {

src/Bundle/ChillPersonBundle/Templating/Entity/PersonRender.php

@@ -23,6 +23,8 @@ namespace Chill\PersonBundle\Templating\Entity;
 use Chill\MainBundle\Templating\Entity\AbstractChillEntityRender;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Config\ConfigPersonAltNamesHelper;
+use Symfony\Component\Templating\EngineInterface;
+
 
 /**
  * Render a Person
@@ -30,15 +32,16 @@ use Chill\PersonBundle\Config\ConfigPersonAltNamesHelper;
  */
 class PersonRender extends AbstractChillEntityRender
 {
-    /**
-     *
-     * @var ConfigPersonAltNamesHelper
-     */
-    protected $configAltNamesHelper;
+    private ConfigPersonAltNamesHelper $configAltNamesHelper;
+
+    private EngineInterface $engine;
     
-    public function __construct(ConfigPersonAltNamesHelper $configAltNamesHelper)
-    {
+    public function __construct(
+        ConfigPersonAltNamesHelper $configAltNamesHelper,
+        EngineInterface $engine
+    ) {
         $this->configAltNamesHelper = $configAltNamesHelper;
+        $this->engine = $engine;
     }
     
     /**
@@ -49,13 +52,13 @@ class PersonRender extends AbstractChillEntityRender
      */
     public function renderBox($person, array $options): string
     {
-        return 
-            $this->getDefaultOpeningBox('person').
-            '<span class="chill_denomination">'.$person->getFirstName().'</span>'.
-            ' <span class="chill_denomination">'.$person->getLastName().'</span>'.
-            $this->addAltNames($person, true).
-            $this->getDefaultClosingBox()
-            ;
+        return $this->engine->render('@ChillPerson/Entity/person.html.twig',
+            [
+                'person' => $person,
+                'addAltNames' => $this->configAltNamesHelper->hasAltNames(),
+                'addLink' => $options['addLink'] ?? false
+            ]
+        );
     }
 
     /**
@@ -69,7 +72,7 @@ class PersonRender extends AbstractChillEntityRender
         return $person->getFirstName().' '.$person->getLastName()
             .$this->addAltNames($person, false);
     }
-    
+
     protected function addAltNames(Person $person, bool $addSpan)
     {
         $str = '';

src/Bundle/ChillPersonBundle/Templating/Entity/SocialIssueRender.php

@@ -5,9 +5,10 @@ namespace Chill\PersonBundle\Templating\Entity;
 use Chill\MainBundle\Templating\Entity\ChillEntityRenderInterface;
 use Chill\PersonBundle\Entity\SocialWork\SocialIssue;
 use Chill\MainBundle\Templating\TranslatableStringHelper;
+use RuntimeException;
 use Symfony\Component\Templating\EngineInterface;
 
-class SocialIssueRender implements ChillEntityRenderInterface
+final class SocialIssueRender implements ChillEntityRenderInterface
 {
     private TranslatableStringHelper $translatableStringHelper;
     private EngineInterface $engine;
@@ -28,11 +29,14 @@ class SocialIssueRender implements ChillEntityRenderInterface
     {
         return $entity instanceof SocialIssue;
     }
-    
+
+    /**
+     * @param SocialIssue $socialIssue
+     */
     public function renderString($socialIssue, array $options): string
     {
         /** @var $socialIssue SocialIssue */
-        $options = \array_merge(self::DEFAULT_ARGS, $options); 
+        $options = array_merge(self::DEFAULT_ARGS, $options);
 
         $str = $this->translatableStringHelper->localize($socialIssue->getTitle());
 
@@ -46,26 +50,36 @@ class SocialIssueRender implements ChillEntityRenderInterface
         return $str;
     }
 
-    protected function buildParents($socialIssue): array
+    protected function buildParents(SocialIssue $socialIssue): array
     {
         $parents = [];
+
         while ($socialIssue->hasParent()) {
             $socialIssue = $parents[] = $socialIssue->getParent();
         }
 
         return $parents;
-    } 
-    
+    }
+
+    /**
+     *
+     * @param SocialIssue $socialIssue
+     */
     public function renderBox($socialIssue, array $options): string
     {
-        $options = \array_merge(self::DEFAULT_ARGS, $options); 
+        $options = array_merge(self::DEFAULT_ARGS, $options);
         // give some help to twig: an array of parents
         $parents = $this->buildParents($socialIssue);
 
-        return $this->engine->render('@ChillPerson/Entity/social_issue.html.twig', [
-            'socialIssue' => $socialIssue,
-            'parents' => $parents,
-            'options' => $options
-        ]);
+        return $this
+            ->engine
+            ->render(
+                '@ChillPerson/Entity/social_issue.html.twig',
+                [
+                    'socialIssue' => $socialIssue,
+                    'parents' => $parents,
+                    'options' => $options
+                ]
+            );
     }
 }

src/Bundle/ChillPersonBundle/Tests/Controller/AccompanyingCourseControllerTest.php

@@ -28,7 +28,7 @@ class AccompanyingCourseControllerTest extends WebTestCase
         $this->assertResponseRedirects();
         $location = $this->client->getResponse()->headers->get('Location');
 
-        $this->assertEquals(1, \preg_match("|^\/[^\/]+\/parcours/([\d]+)/show$|", $location));
+        $this->assertEquals(1, \preg_match("|^\/[^\/]+\/parcours/([\d]+)/edit$|", $location));
          
     }
 
@@ -48,7 +48,7 @@ class AccompanyingCourseControllerTest extends WebTestCase
         $location = $this->client->getResponse()->headers->get('Location');
         $matches = [];
 
-        $this->assertEquals(1, \preg_match("|^\/[^\/]+\/parcours/([\d]+)/show$|", $location, $matches));
+        $this->assertEquals(1, \preg_match("|^\/[^\/]+\/parcours/([\d]+)/edit$|", $location, $matches));
         $id = $matches[1];
 
         $period = self::$container->get(EntityManagerInterface::class)

src/Bundle/ChillPersonBundle/Tests/Controller/AccompanyingPeriodControllerTest.php

@@ -148,7 +148,7 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      * Test the closing of a periods
      * 
      * Given that a person as an accompanying period opened since 2015-01-05
-     * and we fill the close form (at /en/person/[id]/accompanying-period/close
+     * and we fill the close form (at /fr/person/[id]/accompanying-period/close
      *      with : dateClosing: 2015-02-01
      *      with : the last closing motive in list
      * Then the response should redirect to period view
@@ -158,10 +158,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testClosingCurrentPeriod()
     {   
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/close');
-        
-        $form = $crawler->selectButton('Close accompanying period')->form();
+
+        $form = $crawler->selectButton('Clôre la période')->form();
 
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
@@ -171,7 +171,7 @@ class AccompanyingPeriodControllerTest extends WebTestCase
         $cr = $this->client->submit($form);
         
         $this->assertTrue($this->client->getResponse()->isRedirect(
-              '/en/person/'.$this->person->getId().'/accompanying-period'),
+              '/fr/person/'.$this->person->getId().'/accompanying-period'),
               'the server redirects to /accompanying-period page');
         $this->assertGreaterThan(0, $this->client->followRedirect()
                 ->filter('.success')->count(),
@@ -182,7 +182,7 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      * Test the closing of a periods
      * 
      * Given that a person as an accompanying period opened since 2015-01-05
-     * and we fill the close form (at /en/person/[id]/accompanying-period/close
+     * and we fill the close form (at /fr/person/[id]/accompanying-period/close
      *      with : dateClosing: 2014-01-01
      *      with : the last closing motive in list
      * Then the response should redirect to period view
@@ -192,10 +192,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testClosingCurrentPeriodWithDateClosingBeforeOpeningFails()
     {
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/close');
         
-        $form = $crawler->selectButton('Close accompanying period')->form();
+        $form = $crawler->selectButton('Clôre la période')->form();
 
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
@@ -223,10 +223,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testAddNewPeriodBeforeActual()
     {
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton('Créer une période d\'accompagnement')->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -237,7 +237,7 @@ class AccompanyingPeriodControllerTest extends WebTestCase
         $this->client->submit($form);
         
         $this->assertTrue($this->client->getResponse()->isRedirect(
-              '/en/person/'.$this->person->getId().'/accompanying-period'),
+              '/fr/person/'.$this->person->getId().'/accompanying-period'),
               'the server redirects to /accompanying-period page');
         $this->assertGreaterThan(0, $this->client->followRedirect()
               ->filter('.success')->count(),
@@ -257,10 +257,13 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testCreatePeriodWithClosingAfterCurrentFails()
     {
-        $crawler = $this->client->request('GET', '/en/person/'
+        $this->markTestSkipped("Multiple period may now cover. This test is kept ".
+            "in case of a configuration may add this feature again");
+
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton("Créer une période d'accompagnement")->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -289,10 +292,13 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testCreatePeriodWithOpeningAndClosingAfterCurrentFails()
     {
-        $crawler = $this->client->request('GET', '/en/person/'
+        $this->markTestSkipped("Multiple period may now cover. This test is kept ".
+            "in case of a configuration may add this feature again");
+
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton("Créer une période d'accompagnement")->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -330,10 +336,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
             ]
         ));
         
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();;
+        $form = $crawler->selectButton('Créer une période d\'accompagnement')->form();;
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -361,10 +367,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
      */
     public function testCreatePeriodWithClosingBeforeOpeningFails()
     {
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton('Créer une période d\'accompagnement')->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -403,10 +409,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
             ]
         ));
         
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton('Créer une période d\'accompagnement')->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -444,10 +450,10 @@ class AccompanyingPeriodControllerTest extends WebTestCase
             ]
         ));
         
-        $crawler = $this->client->request('GET', '/en/person/'
+        $crawler = $this->client->request('GET', '/fr/person/'
               .$this->person->getId().'/accompanying-period/create');
         
-        $form = $crawler->selectButton('Create an accompanying period')->form();
+        $form = $crawler->selectButton('Créer une période d\'accompagnement')->form();
         $form->get(self::CLOSING_MOTIVE_INPUT)
               ->setValue($this->getLastValueOnClosingMotive($form));
         $form->get(self::CLOSING_INPUT)
@@ -498,7 +504,8 @@ class AccompanyingPeriodControllerTest extends WebTestCase
         //$criteria->where(Criteria::expr()->eq('openingDate', \DateTime::createFromFormat()))
         $firstPeriod = reset($periods);
         $lastPeriod = end($periods);
-        
+
+        $this->markTestSkipped("From here, the test should be rewritten"); 
         // test that it is not possible to open the first period in the list
         $this->client->request('GET', 
                 sprintf('/fr/person/%d/accompanying-period/%d/re-open', $this->person->getId(), reset($periods)->getId())
@@ -523,4 +530,4 @@ class AccompanyingPeriodControllerTest extends WebTestCase
                 "Test the response is a redirection => the period is re-opened");
 
     }
-}
+}

src/Bundle/ChillPersonBundle/Tests/Controller/AdminControllerTest.php

@@ -1,16 +0,0 @@
-<?php
-
-namespace Chill\PersonBundle\Tests\Controller;
-
-use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
-
-class AdminControllerTest extends WebTestCase
-{
-    public function testIndex()
-    {
-        $client = static::createClient();
-
-        $crawler = $client->request('GET', '/{_locale}/admin/person');
-    }
-
-}

src/Bundle/ChillPersonBundle/Tests/Controller/HouseholdControllerTest.php

@@ -0,0 +1,97 @@
+<?php
+
+namespace Chill\PersonBundle\Tests\Controller;
+
+use Chill\PersonBundle\Entity\Household\Household;
+use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\HttpFoundation\Request;
+use Chill\MainBundle\Test\PrepareClientTrait;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+
+class HouseholdControllerTest extends WebTestCase
+{
+    use PrepareClientTrait;
+
+    private ?KernelBrowser $client = null;
+
+    protected function setUp()
+    {
+        $this->client = $this->getClientAuthenticated();
+    } 
+
+    /**
+     * @dataProvider generateValidHouseholdIds
+     */
+    public function testSummary($householdId)
+    {
+        $this->client->request(
+            Request::METHOD_GET,
+            "/fr/person/household/{$householdId}/summary"
+        );
+
+        $this->assertResponseIsSuccessful();
+    }
+
+    /**
+     * @dataProvider generateValidHouseholdIds
+     */
+    public function testMembers($householdId)
+    {
+        $this->client->request(
+            Request::METHOD_GET,
+            "/fr/person/household/{$householdId}/members"
+        );
+
+        $this->assertResponseIsSuccessful();
+    }
+
+    /**
+     * @dataProvider generateValidHouseholdIds
+     */
+    public function testAddresses($householdId)
+    {
+        $this->client->request(
+            Request::METHOD_GET,
+            "/fr/person/household/{$householdId}/addresses"
+        );
+
+        $this->assertResponseIsSuccessful();
+    }
+
+    /**
+     * @dataProvider generateValidHouseholdIds
+     */
+    public function testAddressMove($householdId)
+    {
+        $this->client->request(
+            Request::METHOD_GET,
+            "/fr/person/household/{$householdId}/address/move"
+        );
+
+        $this->assertResponseIsSuccessful();
+
+        // ici, il faudrait tester la requête POST
+    }
+
+    public function generateValidHouseholdIds()
+    {
+        self::bootKernel();
+        $em = self::$container->get(EntityManagerInterface::class);
+
+        $ids = $em->createQuery("SELECT DISTINCT h.id FROM ".Household::class." h ".
+            "JOIN h.members m ".
+            "JOIN m.person p ".
+            "JOIN p.center c ".
+            "WHERE c.name = :center"
+        )
+            ->setParameter('center', "Center A")
+            ->setMaxResults(100)
+            ->getScalarResult()
+            ;
+
+        \shuffle($ids);
+
+        yield [ \array_pop($ids)['id'] ]; 
+    }
+}

src/Bundle/ChillPersonBundle/Tests/Controller/HouseholdMemberControllerTest.php

@@ -0,0 +1,98 @@
+<?php
+
+namespace Bundle\ChillPersonBundle\Tests\Controller;
+
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Request;
+use Chill\MainBundle\Test\PrepareClientTrait;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Entity\Household\Household;
+use Chill\PersonBundle\Entity\Household\Position;
+use Doctrine\ORM\EntityManagerInterface;
+
+
+class HouseholdMemberControllerTest extends WebTestCase
+{
+    use PrepareClientTrait;
+
+    /**
+     * @dataProvider provideValidData
+     */
+    public function testMoveMember($personId, $householdId, $positionId, \DateTimeInterface $date)
+    {
+        $client = $this->getClientAuthenticated();
+
+        $client->request(
+            Request::METHOD_POST,
+            '/api/1.0/person/household/members/move.json',
+            [], // parameters
+            [], // files
+            [], // server
+            \json_encode(
+                [
+                    'concerned' => 
+                    [
+                        [ 
+                            'person' => 
+                            [ 
+                                'type' => 'person',
+                                'id' => $personId
+                            ],
+                            'start_date' => 
+                            [
+                                'datetime' => $date->format(\DateTimeInterface::RFC3339)
+                            ],
+                            'position' =>
+                            [
+                                'type' => 'household_position',
+                                'id' => $positionId
+                            ],
+                            'holder' => false,
+                            'comment' => "Introduced by automated test",
+                        ],
+                    ],
+                    'destination' => 
+                    [
+                        'type' => 'household',
+                        'id' => $householdId
+                    ]
+                ],
+            true)
+        );
+
+        $this->assertEquals(Response::HTTP_OK, 
+            $client->getResponse()->getStatusCode()
+        );
+    }
+
+    public function provideValidData(): \Iterator
+    {
+        self::bootKernel();
+        $em = self::$container->get(EntityManagerInterface::class);
+
+        $personIds = $em->createQuery("SELECT p.id FROM ".Person::class." p ".
+            "JOIN p.center c WHERE c.name = :center")
+            ->setParameter('center', "Center A")
+            ->setMaxResults(100)
+            ->getScalarResult()
+            ;
+        \shuffle($personIds);
+
+        $household = new Household();
+        $em->persist($household);
+        $em->flush();
+
+        $positions = $em->createQuery("SELECT pos.id FROM ".Position::class." pos ".
+            "WHERE pos.shareHouseHold = TRUE")
+            ->getResult()
+            ;
+
+        yield [ 
+            \array_pop($personIds)['id'],
+            $household->getId(), 
+            $positions[\random_int(0, count($positions) - 1)]['id'],
+            new \DateTimeImmutable('today')
+        ];
+    }
+}

src/Bundle/ChillPersonBundle/Tests/Controller/PersonControllerCreateTest.php

@@ -25,7 +25,7 @@ namespace Chill\PersonBundle\Tests\Controller;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Component\DomCrawler\Form;
 use Chill\MainBundle\Test\PrepareClientTrait;
-use \Symfony\Component\BrowserKit\Client;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 
 /**
  * Test creation and deletion for persons
@@ -34,7 +34,7 @@ class PersonControllerCreateTest extends WebTestCase
 {
     use PrepareClientTrait;
 
-    private Client $client;
+    private KernelBrowser $client;
 
     const FIRSTNAME_INPUT = 'chill_personbundle_person_creation[firstName]';
     const LASTNAME_INPUT = "chill_personbundle_person_creation[lastName]";
@@ -59,8 +59,8 @@ class PersonControllerCreateTest extends WebTestCase
         string $firstname = 'God',
         string $lastname = 'Jesus'
     ) {
-        $creationForm->get(self::FIRSTNAME_INPUT)->setValue($firstname);
-        $creationForm->get(self::LASTNAME_INPUT)->setValue($lastname);
+        $creationForm->get(self::FIRSTNAME_INPUT)->setValue($firstname.'_'.uniqid());
+        $creationForm->get(self::LASTNAME_INPUT)->setValue($lastname.'_'.uniqid());
         $creationForm->get(self::GENDER_INPUT)->select("man");
         $date = new \DateTime('1947-02-01');
         $creationForm->get(self::BIRTHDATE_INPUT)->setValue($date->format('d-m-Y'));
@@ -114,20 +114,6 @@ class PersonControllerCreateTest extends WebTestCase
         return $form;
     }
     
-    /**
-     * 
-     * @param Form $form
-     * @depends testAddAPersonPage
-     */
-    public function testForgedNullGender(Form $form)
-    {
-        $form->get(self::FIRSTNAME_INPUT)->setValue('john');
-        $form->get(self::LASTNAME_INPUT)->setValue('doe');
-        $date = new \DateTime('1947-02-01');
-        $form->get(self::BIRTHDATE_INPUT)->setValue($date->format('d-m-Y'));
-        $this->client->submit($form);
-        $this->assertResponseStatusCodeSame(500);
-    }
     
     /**
      * Test the creation of a valid person.
@@ -140,8 +126,8 @@ class PersonControllerCreateTest extends WebTestCase
     {
         $this->fillAValidCreationForm($form);
         $client = $this->client;
-        $client->submit($form);
-        
+        $crawler = $client->submit($form);
+
         $this->assertTrue((bool)$client->getResponse()->isRedirect(),
             "a valid form redirect to url /{_locale}/person/{personId}/general/edit");
         $client->followRedirect();