apply more cs rules for php-cs

This commit is contained in:
2023-10-17 13:27:03 +02:00
parent 0b0cbed9db
commit bc2041cbdd
1485 changed files with 8169 additions and 9620 deletions

View File

@@ -14,14 +14,13 @@ namespace Chill\MainBundle\Routing;
use Knp\Menu\MenuItem;
/**
* Implements a builder for menu
* Implements a builder for menu.
*
* @template TParams of array
*/
interface LocalMenuBuilderInterface
{
/**
* @param $menuId
* @param TParams $parameters
*/
public function buildMenu($menuId, MenuItem $menu, array $parameters);

View File

@@ -28,9 +28,6 @@ class SectionMenuBuilder implements LocalMenuBuilderInterface
*/
public function __construct(protected AuthorizationCheckerInterface $authorizationChecker, protected TranslatorInterface $translator, protected ParameterBagInterface $parameterBag) {}
/**
* @param $menuId
*/
public function buildMenu($menuId, MenuItem $menu, array $parameters)
{
$menu->addChild($this->translator->trans('Homepage'), [

View File

@@ -52,7 +52,7 @@ class UserMenuBuilder implements LocalMenuBuilderInterface
$nbNotifications = $this->notificationByUserCounter->countUnreadByUser($user);
//TODO add an icon? How exactly? For example a clock icon...
// TODO add an icon? How exactly? For example a clock icon...
$menu
->addChild($this->translator->trans('absence.Set absence date'), [
'route' => 'chill_main_user_absence_index',

View File

@@ -17,10 +17,6 @@ use Symfony\Component\Routing\RouteCollection;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
use function array_key_exists;
use function array_merge;
use function array_values;
/**
* This class permit to build menu from the routing information
* stored in each bundle.
@@ -53,7 +49,7 @@ class MenuComposer
'order' => $order,
])
->setExtras([
//'icon' => $route['icon'],
// 'icon' => $route['icon'],
// sf4 check: commented to avoid error: `An exception has been thrown during the rendering of a template ("Notice: Undefined index: icon").`
'order' => $order,
]);
@@ -76,7 +72,7 @@ class MenuComposer
* The array is aimed to build route with MenuTwig.
*
* @param string $menuId
* @param array $parameters see https://redmine.champs-libres.coop/issues/179
* @param array $parameters see https://redmine.champs-libres.coop/issues/179
*
* @return array
*/
@@ -87,13 +83,13 @@ class MenuComposer
foreach ($routeCollection->all() as $routeKey => $route) {
if ($route->hasOption('menus')) {
if (array_key_exists($menuId, $route->getOption('menus'))) {
if (\array_key_exists($menuId, $route->getOption('menus'))) {
$route = $route->getOption('menus')[$menuId];
$route['key'] = $routeKey;
$order = $this->resolveOrder($routes, $route['order']);
//we do not want to duplicate order information
// we do not want to duplicate order information
unset($route['order']);
$routes[$order] = $route;
}
@@ -116,7 +112,7 @@ class MenuComposer
*/
public function hasLocalMenuBuilder($menuId): bool
{
return array_key_exists($menuId, $this->localMenuBuilders);
return \array_key_exists($menuId, $this->localMenuBuilders);
}
/**
@@ -147,7 +143,7 @@ class MenuComposer
ksort($ordered);
$menus = array_merge(array_values($ordered), $unordered);
$menus = \array_merge(\array_values($ordered), $unordered);
$menu->reorderChildren($menus);
}
@@ -157,7 +153,7 @@ class MenuComposer
* first next order available.
*
* @param array $routes the routes previously added
* @param int $order
* @param int $order
*
* @return int
*/

View File

@@ -47,7 +47,7 @@ class MenuTwig extends AbstractExtension implements ContainerAwareInterface
*
* @deprecated link: see https://redmine.champs-libres.coop/issues/179 for more informations
*
* @param string $menuId
* @param string $menuId
* @param mixed[] $params
*/
public function chillMenu(Environment $env, $menuId, array $params = [])
@@ -57,7 +57,7 @@ class MenuTwig extends AbstractExtension implements ContainerAwareInterface
$layout = $resolvedParams['layout'];
unset($resolvedParams['layout']);
if ($this->menuComposer->hasLocalMenuBuilder($menuId) === false) {
if (false === $this->menuComposer->hasLocalMenuBuilder($menuId)) {
$resolvedParams['routes'] = $this->menuComposer->getRoutesFor($menuId, $resolvedParams);
return $env->render($layout, $resolvedParams);
@@ -85,7 +85,7 @@ class MenuTwig extends AbstractExtension implements ContainerAwareInterface
return 'chill_menu';
}
public function setContainer(?ContainerInterface $container = null)
public function setContainer(ContainerInterface $container = null)
{
$this->container = $container;
}