apply more cs rules for php-cs

src/Bundle/ChillMainBundle/Controller/PermissionsGroupController.php

@@ -21,7 +21,6 @@ use Chill\MainBundle\Repository\RoleScopeRepository;
 use Chill\MainBundle\Security\RoleProvider;
 use Chill\MainBundle\Templating\TranslatableStringHelper;
 use Doctrine\ORM\EntityManagerInterface;
-use RuntimeException;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormInterface;
@@ -31,8 +30,6 @@ use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
-use function array_key_exists;
-
 /**
  * Class PermissionsGroupController.
  */
@@ -75,7 +72,7 @@ final class PermissionsGroupController extends AbstractController
             $permissionsGroup->addRoleScope($roleScope);
             $violations = $this->validator->validate($permissionsGroup);
 
-            if ($violations->count() === 0) {
+            if (0 === $violations->count()) {
                 $this->em->flush();
 
                 $this->addFlash(
@@ -132,6 +129,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Creates a new PermissionsGroup entity.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/create", name="admin_permissionsgroup_create", methods={"POST"})
      */
     public function createAction(Request $request): Response
@@ -155,6 +153,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * remove an association between permissionsGroup and roleScope.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/{pgid}/delete_link_role_scope/{rsid}", name="admin_permissionsgroup_delete_role_scope", methods={"DELETE"})
      */
     public function deleteLinkRoleScopeAction(int $pgid, int $rsid): Response
@@ -172,11 +171,11 @@ final class PermissionsGroupController extends AbstractController
 
         try {
             $permissionsGroup->removeRoleScope($roleScope);
-        } catch (RuntimeException) {
+        } catch (\RuntimeException) {
             $this->addFlash(
                 'notice',
                 $this->translator->trans("The role '%role%' and circle "
-                        . "'%scope%' is not associated with this permission group", [
+                        ."'%scope%' is not associated with this permission group", [
                             '%role%' => $this->translator->trans($roleScope->getRole()),
                             '%scope%' => $this->translatableStringHelper
                                 ->localize($roleScope->getScope()->getName()),
@@ -188,11 +187,11 @@ final class PermissionsGroupController extends AbstractController
 
         $this->em->flush();
 
-        if ($roleScope->getScope() !== null) {
+        if (null !== $roleScope->getScope()) {
             $this->addFlash(
                 'notice',
                 $this->translator->trans("The role '%role%' on circle "
-                        . "'%scope%' has been removed", [
+                        ."'%scope%' has been removed", [
                             '%role%' => $this->translator->trans($roleScope->getRole()),
                             '%scope%' => $this->translatableStringHelper
                                 ->localize($roleScope->getScope()->getName()),
@@ -212,6 +211,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Displays a form to edit an existing PermissionsGroup entity.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/{id}/edit", name="admin_permissionsgroup_edit")
      */
     public function editAction(int $id): Response
@@ -259,6 +259,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Lists all PermissionsGroup entities.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/", name="admin_permissionsgroup")
      */
     public function indexAction(): Response
@@ -272,6 +273,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Displays a form to create a new PermissionsGroup entity.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/new", name="admin_permissionsgroup_new")
      */
     public function newAction(): Response
@@ -287,6 +289,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Finds and displays a PermissionsGroup entity.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/{id}/show", name="admin_permissionsgroup_show")
      */
     public function showAction(int $id): Response
@@ -304,11 +307,11 @@ final class PermissionsGroupController extends AbstractController
         usort(
             $roleScopes,
             static function (RoleScope $a, RoleScope $b) use ($translatableStringHelper) {
-                if ($a->getScope() === null) {
+                if (null === $a->getScope()) {
                     return 1;
                 }
 
-                if ($b->getScope() === null) {
+                if (null === $b->getScope()) {
                     return +1;
                 }
 
@@ -339,6 +342,7 @@ final class PermissionsGroupController extends AbstractController
 
     /**
      * Edits an existing PermissionsGroup entity.
+     *
      * @\Symfony\Component\Routing\Annotation\Route(path="/{_locale}/admin/permissionsgroup/{id}/update", name="admin_permissionsgroup_update", methods={"POST", "PUT"})
      */
     public function updateAction(Request $request, int $id): Response
@@ -347,8 +351,7 @@ final class PermissionsGroupController extends AbstractController
             ->find($id);
 
         if (!$permissionsGroup) {
-            throw $this->createNotFoundException('Unable to find Permissions'
-                . 'Group entity.');
+            throw $this->createNotFoundException('Unable to find PermissionsGroup entity.');
         }
 
         $editForm = $this->createEditForm($permissionsGroup);
@@ -396,7 +399,7 @@ final class PermissionsGroupController extends AbstractController
      * get a role scope by his parameters. The role scope is persisted if it
      * doesn't exist in database.
      */
-    protected function getPersistentRoleScopeBy(string $role, ?Scope $scope = null): RoleScope
+    protected function getPersistentRoleScopeBy(string $role, Scope $scope = null): RoleScope
     {
         $roleScope = $this->roleScopeRepository
             ->findOneBy(['role' => $role, 'scope' => $scope]);
@@ -487,7 +490,7 @@ final class PermissionsGroupController extends AbstractController
         $expandedRoles = [];
 
         foreach ($roleScopes as $roleScope) {
-            if (!array_key_exists($roleScope->getRole(), $expandedRoles)) {
+            if (!\array_key_exists($roleScope->getRole(), $expandedRoles)) {
                 $expandedRoles[$roleScope->getRole()] =
                       array_map(
                           static fn ($role) => $role,