apply more cs rules for php-cs

This commit is contained in:
2023-10-17 13:27:03 +02:00
parent 0b0cbed9db
commit bc2041cbdd
1485 changed files with 8169 additions and 9620 deletions

View File

@@ -23,8 +23,6 @@ use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Contracts\Translation\TranslatorInterface;
use function get_class;
abstract class AbstractElementController extends AbstractController
{
public function __construct(protected EntityManagerInterface $em, protected TranslatorInterface $translator, protected LoggerInterface $chillMainLogger) {}
@@ -38,7 +36,7 @@ abstract class AbstractElementController extends AbstractController
protected function _delete(AbstractElement $element, Request $request, mixed $template, mixed $flashMessage): Response
{
$this->denyAccessUnlessGranted(BudgetElementVoter::DELETE, $element, 'You are not '
. 'allowed to delete this item');
.'allowed to delete this item');
$form = $this->createDeleteForm();
@@ -50,7 +48,7 @@ abstract class AbstractElementController extends AbstractController
$indexPage = 'chill_budget_elements_household_index';
}
if ($request->getMethod() === Request::METHOD_DELETE) {
if (Request::METHOD_DELETE === $request->getMethod()) {
$form->handleRequest($request);
if ($form->isSubmitted() && $form->isValid()) {

View File

@@ -20,7 +20,7 @@ class ChargeKindController extends CRUDController
{
protected function orderQuery(string $action, $query, Request $request, PaginatorInterface $paginator)
{
/** @var QueryBuilder $query */
/* @var QueryBuilder $query */
$query->addOrderBy('e.ordering', 'ASC');
return $query;

View File

@@ -20,7 +20,7 @@ class ResourceKindController extends CRUDController
{
protected function orderQuery(string $action, $query, Request $request, PaginatorInterface $paginator)
{
/** @var QueryBuilder $query */
/* @var QueryBuilder $query */
$query->addOrderBy('e.ordering', 'ASC');
return $query;

View File

@@ -15,14 +15,13 @@ use Chill\BudgetBundle\Entity\Charge;
use Chill\BudgetBundle\Form\ChargeType;
use Chill\PersonBundle\Entity\Household\Household;
use Chill\PersonBundle\Entity\Person;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\HttpFoundation\Request;
class ChargeController extends AbstractElementController
{
/**
*
* @return \Symfony\Component\HttpFoundation\Response
*
* @\Symfony\Component\Routing\Annotation\Route("{_locale}/budget/charge/{id}/delete", name="chill_budget_charge_delete")
*/
public function deleteAction(Request $request, Charge $charge)
@@ -36,8 +35,8 @@ class ChargeController extends AbstractElementController
}
/**
*
* @return \Symfony\Component\HttpFoundation\Response
*
* @\Symfony\Component\Routing\Annotation\Route("{_locale}/budget/charge/{id}/edit", name="chill_budget_charge_edit")
*/
public function editAction(Request $request, Charge $charge)
@@ -51,8 +50,8 @@ class ChargeController extends AbstractElementController
}
/**
*
* @return \Symfony\Component\HttpFoundation\Response
*
* @\Symfony\Component\Routing\Annotation\Route("{_locale}/budget/charge/by-person/{id}/new", name="chill_budget_charge_new")
*/
public function newAction(Request $request, Person $person)
@@ -66,8 +65,8 @@ class ChargeController extends AbstractElementController
}
/**
*
* @return \Symfony\Component\HttpFoundation\Response
*
* @\Symfony\Component\Routing\Annotation\Route("{_locale}/budget/charge/by-household/{id}/new", name="chill_budget_charge_household_new")
*/
public function newHouseholdAction(Request $request, Household $household)
@@ -81,8 +80,8 @@ class ChargeController extends AbstractElementController
}
/**
*
* @return \Symfony\Component\HttpFoundation\Response
*
* @\Symfony\Component\Routing\Annotation\Route("{_locale}/budget/charge/{id}/view", name="chill_budget_charge_view")
*/
public function viewAction(Charge $charge)

View File

@@ -12,22 +12,12 @@ declare(strict_types=1);
namespace Chill\BudgetBundle\Controller;
use Chill\BudgetBundle\Calculator\CalculatorManager;
use Chill\BudgetBundle\Entity\Charge;
use Chill\BudgetBundle\Entity\Resource;
use Chill\BudgetBundle\Repository\ChargeRepository;
use Chill\BudgetBundle\Repository\ResourceRepository;
use Chill\BudgetBundle\Security\Authorization\BudgetElementVoter;
use Chill\PersonBundle\Entity\Household\Household;
use Chill\PersonBundle\Entity\Person;
use DateTime;
use Doctrine\ORM\EntityManagerInterface;
use Psr\Log\LoggerInterface;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Contracts\Translation\TranslatorInterface;
use function array_merge;
use function count;
class ElementController extends AbstractController
{
@@ -43,9 +33,9 @@ class ElementController extends AbstractController
$charges = $this->chargeRepository->findAllByEntity($person);
$resources = $this->resourceRepository->findAllByEntity($person);
$elements = array_merge($charges, $resources);
$elements = \array_merge($charges, $resources);
if (count($elements) > 0) {
if (\count($elements) > 0) {
$results = $this->calculator->calculateDefault($elements);
}
@@ -67,9 +57,9 @@ class ElementController extends AbstractController
$charges = $this->chargeRepository->findAllByEntity($household);
$resources = $this->resourceRepository->findAllByEntity($household);
$elements = array_merge($charges, $resources);
$elements = \array_merge($charges, $resources);
if (count($elements) > 0) {
if (\count($elements) > 0) {
$results = $this->calculator->calculateDefault($elements);
}

View File

@@ -15,7 +15,6 @@ use Chill\BudgetBundle\Entity\Resource;
use Chill\BudgetBundle\Form\ResourceType;
use Chill\PersonBundle\Entity\Household\Household;
use Chill\PersonBundle\Entity\Person;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;