Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-07 18:44:08 +00:00
Code Issues Actions Projects Releases Wiki Activity

Add logging and validation to export generation handler

Browse Source 
Introduce a logger to track processing steps, durations, and outcomes in `ExportRequestGenerationMessageHandler`. Add validation to prevent reprocessing of already generated export objects, ensuring robust error handling and improved traceability.
This commit is contained in:
Julien Fastré 2025-04-05 00:08:37 +02:00
parent 5ebb53173e
commit bb30ddc876
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/Bundle/ChillMainBundle/Export/Messenger/ExportRequestGenerationMessageHandler.php
View File

@ -17,22 +17,36 @@ use Chill\MainBundle\Export\ExportGenerator;
use Chill\MainBundle\Repository\ExportGenerationRepository; use Chill\MainBundle\Repository\ExportGenerationRepository;
use Chill\MainBundle\Repository\UserRepositoryInterface; use Chill\MainBundle\Repository\UserRepositoryInterface;
use Doctrine\ORM\EntityManagerInterface; use Doctrine\ORM\EntityManagerInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\Messenger\Attribute\AsMessageHandler; use Symfony\Component\Messenger\Attribute\AsMessageHandler;
use Symfony\Component\Messenger\Exception\UnrecoverableMessageHandlingException;
use Symfony\Component\Messenger\Handler\MessageHandlerInterface; use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
#[AsMessageHandler] #[AsMessageHandler]
final readonly class ExportRequestGenerationMessageHandler implements MessageHandlerInterface final readonly class ExportRequestGenerationMessageHandler implements MessageHandlerInterface
{ {
private const LOG_PREFIX = '[export_generation] ';
public function __construct( public function __construct(
private ExportGenerationRepository $repository, private ExportGenerationRepository $repository,
private UserRepositoryInterface $userRepository, private UserRepositoryInterface $userRepository,
private ExportGenerator $exportGenerator, private ExportGenerator $exportGenerator,
private StoredObjectManagerInterface $storedObjectManager, private StoredObjectManagerInterface $storedObjectManager,
private EntityManagerInterface $entityManager, private EntityManagerInterface $entityManager,
private LoggerInterface $logger,
) {} ) {}
public function __invoke(ExportRequestGenerationMessage $exportRequestGenerationMessage) public function __invoke(ExportRequestGenerationMessage $exportRequestGenerationMessage)
{ {
$start = microtime(true);
$this->logger->info(
self::LOG_PREFIX.'Handle generation message',
[
'exportId' => $exportRequestGenerationMessage->id,
]
);
if (null === $exportGeneration = $this->repository->find($exportRequestGenerationMessage->id)) { if (null === $exportGeneration = $this->repository->find($exportRequestGenerationMessage->id)) {
throw new \UnexpectedValueException('ExportRequestGenerationMessage not found'); throw new \UnexpectedValueException('ExportRequestGenerationMessage not found');
} }
@ -41,10 +55,23 @@ final readonly class ExportRequestGenerationMessageHandler implements MessageHan
throw new \UnexpectedValueException('User not found'); throw new \UnexpectedValueException('User not found');
} }
if (StoredObject::STATUS_PENDING !== $exportGeneration->getStatus()) {
throw new UnrecoverableMessageHandlingException('object already generated');
}
$generated = $this->exportGenerator->generate($exportGeneration->getExportAlias(), $exportGeneration->getOptions(), $user); $generated = $this->exportGenerator->generate($exportGeneration->getExportAlias(), $exportGeneration->getOptions(), $user);
$this->storedObjectManager->write($exportGeneration->getStoredObject(), $generated->content, $generated->contentType); $this->storedObjectManager->write($exportGeneration->getStoredObject(), $generated->content, $generated->contentType);
$exportGeneration->getStoredObject()->setStatus(StoredObject::STATUS_READY); $exportGeneration->getStoredObject()->setStatus(StoredObject::STATUS_READY);
$this->entityManager->flush(); $this->entityManager->flush();
$end = microtime(true);
$this->logger->notice(self::LOG_PREFIX.'Export generation successfully finished', [
'exportId' => $exportRequestGenerationMessage->id,
'exportAlias' => $exportGeneration->getExportAlias(),
'full_generation_duration' => $end - $exportGeneration->getCreatedAt()->getTimestamp(),
'message_handler_duration' => $end - $start,
]);
} }
} }