remove accompanying period if not used

DependencyInjection/ChillPersonExtension.php

@@ -73,7 +73,14 @@ class ChillPersonExtension extends Extension implements PrependExtensionInterfac
         $container->setParameter('chill_person.person_fields', $config);
         
         foreach ($config as $key => $value) {
-            $container->setParameter('chill_person.person_fields.'.$key, $value);
+            switch($key) {
+                case 'accompanying_period':
+                    $container->setParameter('chill_person.accompanying_period', $value);
+                    break;
+                default:
+                    $container->setParameter('chill_person.person_fields.'.$key, $value);
+                    break;
+            }
         }
     }
 

DependencyInjection/CompilerPass/AccompanyingPeriodTimelineCompilerPass.php

@@ -0,0 +1,66 @@
+<?php
+/*
+ * Copyright (C) 2018 Champs-Libres <info@champs-libres.coop>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+namespace Chill\PersonBundle\DependencyInjection\CompilerPass;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+
+/**
+ * Remove services which add AccompanyingPeriod to timeline if 
+ * accompanying_periods are set to `hidden` 
+ *
+ */
+class AccompanyingPeriodTimelineCompilerPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container)
+    {
+        // remove services when accompanying period are hidden
+        if ($container->getParameter('chill_person.accompanying_period') !== 'hidden') {
+            return;
+        }
+        
+        $definitions = [
+            'chill.person.timeline.accompanying_period_opening',
+            'chill.person.timeline.accompanying_period_closing'
+        ];
+        
+        foreach($definitions as $definition) {
+            $container
+                ->removeDefinition($definition)
+                ;
+        }
+        
+        $definition = $container->getDefinition('chill.main.timeline_builder');
+        
+        // we have to remove all methods call, and re-add them if not linked 
+        // to this service
+        $calls = $definition->getMethodCalls();
+        
+        foreach($calls as list($method, $arguments)) {
+            if ($method !== 'addProvider') {
+                continue;
+            }
+            
+            $definition->removeMethodCall('addProvider');
+            
+            if (FALSE === \in_array($arguments[1], $definitions)) {
+                $definition->addMethodCall($method, $arguments);
+            } 
+        }
+    }
+}

DependencyInjection/Configuration.php

@@ -74,6 +74,7 @@ class Configuration implements ConfigurationInterface
                                 ->append($this->addFieldNode('marital_status'))
                                 ->append($this->addFieldNode('spoken_languages'))
                                 ->append($this->addFieldNode('address'))
+                                ->append($this->addFieldNode('accompanying_period'))
                         ->end() //children for 'person_fields', parent = array 'person_fields'
                     ->end() // person_fields, parent = children of root
                 ->end() // children of 'root', parent = root
@@ -87,11 +88,20 @@ class Configuration implements ConfigurationInterface
     {
         $tree = new TreeBuilder();
         $node = $tree->root($key, 'enum');
+        
+        switch($key) {
+            case 'accompanying_period':
+                $info = "If the accompanying periods are shown";
+                break;
+            default:
+                $info = "If the field $key must be shown";
+                break;
+        }
 
         $node
                 ->values(array('hidden', 'visible'))
                 ->defaultValue('visible')
-                ->info("If the field $key must be shown")
+                ->info($info)
             ->end();
 
         return $node;