fix validation when comment content is empty

src/Bundle/ChillMainBundle/Controller/NotificationController.php

@@ -235,6 +235,8 @@ class NotificationController extends AbstractController
                         'id' => $notification->getId(),
                         '_fragment' => 'comment-' . $commentId,
                     ]);
+                } elseif ($editedCommentForm->isSubmitted() && !$editedCommentForm->isValid()) {
+                    $this->addFlash('error', $this->translator->trans('This form contains errors'));
                 }
             }
         }
@@ -256,6 +258,8 @@ class NotificationController extends AbstractController
                     return $this->redirectToRoute('chill_main_notification_show', [
                         'id' => $notification->getId(),
                     ]);
+                } elseif ($appendCommentForm->isSubmitted() && !$appendCommentForm->isValid()) {
+                    $this->addFlash('error', $this->translator->trans('This form contains errors'));
                 }
             }
         }

src/Bundle/ChillMainBundle/Entity/NotificationComment.php

@@ -18,6 +18,7 @@ use DateTimeInterface;
 use Doctrine\ORM\Event\LifecycleEventArgs;
 use Doctrine\ORM\Event\PreFlushEventArgs;
 use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Validator\Constraints as Assert;
 
 /**
  * @ORM\Entity
@@ -28,6 +29,7 @@ class NotificationComment implements TrackCreationInterface, TrackUpdateInterfac
 {
     /**
      * @ORM\Column(type="text")
+     * @Assert\NotBlank(message="notification.Comment content might not be blank")
      */
     private string $content = '';
 
@@ -136,9 +138,9 @@ class NotificationComment implements TrackCreationInterface, TrackUpdateInterfac
         $this->recentlyPersisted = true;
     }
 
-    public function setContent(string $content): self
+    public function setContent(?string $content): self
     {
-        $this->content = $content;
+        $this->content = (string) $content;
 
         return $this;
     }

src/Bundle/ChillMainBundle/Resources/views/Notification/_item_comments.html.twig

@@ -15,11 +15,11 @@
 
 <div class="notification-comment-list my-5">
     <h2 class="chill-blue">{{ 'notification.comments_list'|trans }}</h2>
-    
+
     {% if notification.comments|length > 0 %}
         <div class="flex-table">
             {% for comment in notification.comments %}
-                
+
                 {% if editedCommentForm is null or editedCommentId != comment.id %}
                     {{ m.show_comment(comment, {
                         'recordAction': _self.recordAction(comment)
@@ -28,10 +28,11 @@
                     <div class="item-bloc">
                         <div class="item-row row">
                             <a id="comment-{{ comment.id }}"></a>
-                            
+
                             {{ form_start(editedCommentForm) }}
                             {{ form_errors(editedCommentForm) }}
                             {{ form_widget(editedCommentForm.content) }}
+                            {{ form_errors(editedCommentForm.content) }}
                             <input type="hidden" name="form" value="edit" />
                             <ul class="record_actions">
                                 <li class="cancel">
@@ -46,24 +47,25 @@
                                 </li>
                             </ul>
                             {{ form_end(editedCommentForm) }}
-                        
+
                         </div>
                     </div>
                 {% endif %}
-            
+
             {% endfor %}
         </div>
     {% else %}
         <span class="chill-no-data-statement">{{ 'No comments'|trans }}</span>
     {% endif %}
-    
+
     {% if appendCommentForm is not null %}
         <div class="new-comment my-5">
             <h2 class="chill-blue mb-4">{{ 'Write a new comment'|trans }}</h2>
-            
+
             {{ form_start(appendCommentForm) }}
             {{ form_errors(appendCommentForm) }}
             {{ form_widget(appendCommentForm.content) }}
+            {{ form_errors(appendCommentForm.content) }}
             <input type="hidden" name="form" value="append" />
             <ul class="record_actions">
                 <li>
@@ -71,7 +73,7 @@
                 </li>
             </ul>
             {{ form_end(appendCommentForm) }}
-        
+
         </div>
     {% endif %}
-</div>
+</div>

src/Bundle/ChillMainBundle/translations/validators.fr.yml

@@ -27,4 +27,4 @@ address:
 notification:
     At least one addressee: Indiquez au moins un destinataire
     Title must be defined: Un titre doit être indiqué
-
+    Comment content might not be blank: Le commentaire ne peut pas être vide