Fix Eslint issues

2025-10-08 14:29:42 +00:00 · 2025-07-08 13:38:51 +00:00
parent e592b89c94
commit aed114c75c
15 changed files with 379 additions and 348 deletions
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/ExportFormActionGoalResult/App.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/ExportFormActionGoalResult/App.vue
@@ -279,7 +279,7 @@ export default {
                (results) =>
                    ([this.results.options, this.results.value] =
                        this.removeElementInData("results", results)),
-            ).catch;
+            );
        },

        // selectResult(value) {
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/App.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/App.vue
@@ -294,10 +294,13 @@ export default {
        refreshNetwork() {
            //console.log('--- refresh network')
            window.network.setData(this.visgraph_data);
+
+            return 1;
        },

        legendLayers() {
            //console.log('--- refresh legend and rebuild checked Layers')
+            // eslint-disable-next-line vue/no-side-effects-in-computed-properties
            this.checkedLayers = [];
            let layersDisplayed = [
                ...this.nodes.filter((n) => n.id.startsWith("household")),
@@ -309,6 +312,7 @@ export default {
            return [...this.households, ...this.courses];
        },

+        // eslint-disable-next-line vue/no-dupe-keys
        checkedLayers() {
            // required to refresh data checkedLayers
            //console.log('--- checkedLayers')
@@ -386,6 +390,7 @@ export default {
        },
        forceUpdateComponent() {
            //console.log('!! forceUpdateComponent !!')
+            // eslint-disable-next-line @typescript-eslint/no-unused-expressions
            this.refreshNetwork;
            this.$forceUpdate();
        },
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/store.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/store.js
@@ -164,7 +164,8 @@ const store = createStore({
        return;
      }
      let age = getAge(person);
-      age = age === "" ? "" : " - " + age;
+      let separator = person.gender === null ? "" : " - ";
+      age = age === "" ? "" : separator + age;

      let debug = "";
      /// Debug mode: uncomment to display person_id on visgraph
@@ -173,7 +174,7 @@ const store = createStore({
      person.group = person.type;
      person._id = person.id;
      person.id = `person_${person.id}`;
-      person.label = `*${person.text}${person.deathdate ? " (‡)" : ""}*\n_${person.gender.label}${age}_${debug}`;
+      person.label = `*${person.text}${person.deathdate ? " (‡)" : ""}*\n_${person.gender === null ? "" : person.gender?.label}${age}_${debug}`;
      person.folded = false;
      // folded is used for missing persons
      if (options.folded) {
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkItem.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkItem.vue
@@ -1,43 +1,51 @@
 <template>
-  <div class="container">
-    <div class="item-bloc">
-      <div class="item-row">
-        <h2 class="badge-title">
-          <span class="title_label"></span>
-          <span class="title_action">
-            <span class="chill-entity entity-social-action">
-              <span class="badge bg-light text-dark">
-                {{ acpw?.socialAction?.title.fr }}
-              </span>
-            </span>
+    <div class="container">
+        <div class="item-bloc">
+            <div class="item-row">
+                <h2 class="badge-title">
+                    <span class="title_label"></span>
+                    <span class="title_action">
+                        <span class="chill-entity entity-social-action">
+                            <span class="badge bg-light text-dark">
+                                {{ acpw?.socialAction?.title.fr }}
+                            </span>
+                        </span>

-            <ul class="small_in_title columns mt-1">
-              <li>
-                <span class="item-key">
-                  {{ trans(ACCOMPANYING_COURSE_WORK_START_DATE) }} :
-                </span>
-                <b>{{ formatDate(acpw.startDate) }}</b>
-              </li>
+                        <ul class="small_in_title columns mt-1">
+                            <li>
+                                <span class="item-key">
+                                    {{
+                                        trans(
+                                            ACCOMPANYING_COURSE_WORK_START_DATE,
+                                        )
+                                    }}
+                                    :
+                                </span>
+                                <b>{{ formatDate(acpw.startDate) }}</b>
+                            </li>

-              <li v-if="acpw.endDate">
-                <span class="item-key">
-                  {{ trans(ACCOMPANYING_COURSE_WORK_END_DATE) }} :
-                </span>
-                <b>{{ formatDate(acpw.endDate) }}</b>
-              </li>
-            </ul>
-          </span>
-        </h2>
-      </div>
+                            <li v-if="acpw.endDate">
+                                <span class="item-key">
+                                    {{
+                                        trans(ACCOMPANYING_COURSE_WORK_END_DATE)
+                                    }}
+                                    :
+                                </span>
+                                <b>{{ formatDate(acpw.endDate) }}</b>
+                            </li>
+                        </ul>
+                    </span>
+                </h2>
+            </div>
+        </div>
    </div>
-  </div>
 </template>

 <script setup lang="ts">
 import {
-  ACCOMPANYING_COURSE_WORK_END_DATE,
-  ACCOMPANYING_COURSE_WORK_START_DATE,
-  trans,
+    ACCOMPANYING_COURSE_WORK_END_DATE,
+    ACCOMPANYING_COURSE_WORK_START_DATE,
+    trans,
 } from "translator";
 import { ISOToDate } from "ChillMainAssets/chill/js/date";
 import { DateTime } from "ChillMainAssets/types";
@@ -46,15 +54,15 @@ import { AccompanyingPeriodWork } from "../../../types";
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const props = defineProps<{ acpw: AccompanyingPeriodWork }>();
 const formatDate = (dateObject: DateTime) => {
-  if (dateObject) {
-    const parsedDate = ISOToDate(dateObject.datetime);
-    if (parsedDate) {
-      return new Intl.DateTimeFormat("default", { dateStyle: "short" }).format(
-        parsedDate,
-      );
-    } else {
-      return "";
+    if (dateObject) {
+        const parsedDate = ISOToDate(dateObject.datetime);
+        if (parsedDate) {
+            return new Intl.DateTimeFormat("default", {
+                dateStyle: "short",
+            }).format(parsedDate);
+        } else {
+            return "";
+        }
    }
-  }
 };
 </script>
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkList.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkList.vue
@@ -1,24 +1,24 @@
 <template>
-  <div class="results">
-    <div
-      v-for="acpw in accompanyingPeriodWorks"
-      :key="acpw.id"
-      class="list-item"
-    >
-      <label class="acpw-item">
-        <div>
-          <input
-            type="radio"
-            :value="acpw"
-            v-model="selectedAcpw"
-            name="item"
-          />
-        </div>
+    <div class="results">
+        <div
+            v-for="acpw in accompanyingPeriodWorks"
+            :key="acpw.id"
+            class="list-item"
+        >
+            <label class="acpw-item">
+                <div>
+                    <input
+                        type="radio"
+                        :value="acpw"
+                        v-model="selectedAcpw"
+                        name="item"
+                    />
+                </div>

-        <accompanying-period-work-item :acpw="acpw" />
-      </label>
+                <accompanying-period-work-item :acpw="acpw" />
+            </label>
+        </div>
    </div>
-  </div>
 </template>

 <script setup lang="ts">
@@ -28,7 +28,7 @@ import { defineProps, ref, watch } from "vue";

 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const props = defineProps<{
-  accompanyingPeriodWorks: AccompanyingPeriodWork[];
+    accompanyingPeriodWorks: AccompanyingPeriodWork[];
 }>();
 const selectedAcpw = ref<AccompanyingPeriodWork | null>(null);

@@ -36,12 +36,12 @@ const selectedAcpw = ref<AccompanyingPeriodWork | null>(null);
 const emit = defineEmits();

 watch(selectedAcpw, (newValue) => {
-  emit("update:selectedAcpw", newValue);
+    emit("update:selectedAcpw", newValue);
 });
 </script>

 <style>
 .acpw-item {
-  display: flex;
+    display: flex;
 }
 </style>
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkSelectorModal.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AccompanyingPeriodWorkSelector/AccompanyingPeriodWorkSelectorModal.vue
@@ -1,62 +1,78 @@
 <template>
-  <div>
-    <div class="row justify-content-end">
-      <div class="col-md-6 col-sm-10" v-if="selectedAcpw">
-        <ul class="list-suggest remove-items">
-          <li>
-            <span @click="selectedAcpw = null" class="chill-denomination">{{
-              selectedAcpw?.socialAction?.title.fr
-            }}</span>
-          </li>
+    <div>
+        <div class="row justify-content-end">
+            <div class="col-md-6 col-sm-10" v-if="selectedAcpw">
+                <ul class="list-suggest remove-items">
+                    <li>
+                        <span
+                            @click="selectedAcpw = null"
+                            class="chill-denomination"
+                            >{{ selectedAcpw?.socialAction?.title.fr }}</span
+                        >
+                    </li>
+                </ul>
+            </div>
+        </div>
+
+        <ul class="record_actions">
+            <li>
+                <a class="btn btn-sm btn-create mt-3" @click="openModal">
+                    {{ trans(ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK) }}
+                </a>
+            </li>
        </ul>
-      </div>
+
+        <teleport to="body">
+            <modal
+                v-if="showModal"
+                @close="closeModal"
+                modal-dialog-class="modal-dialog-scrollable modal-xl"
+            >
+                <template #header>
+                    <h3>
+                        {{
+                            trans(
+                                ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK,
+                            )
+                        }}
+                    </h3>
+                </template>
+
+                <template #body>
+                    <accompanying-period-work-list
+                        :accompanying-period-works="accompanyingPeriodWorks"
+                        v-model:selectedAcpw="selectedAcpw"
+                    />
+                </template>
+
+                <template #footer>
+                    <button
+                        type="button"
+                        class="btn btn-save"
+                        @click="confirmSelection"
+                    >
+                        {{ trans(CONFIRM) }}
+                    </button>
+                </template>
+            </modal>
+        </teleport>
    </div>
-
-    <ul class="record_actions">
-      <li>
-        <a class="btn btn-sm btn-create mt-3" @click="openModal">
-          {{ trans(ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK) }}
-        </a>
-      </li>
-    </ul>
-
-    <teleport to="body">
-      <modal
-        v-if="showModal"
-        @close="closeModal"
-        modal-dialog-class="modal-dialog-scrollable modal-xl"
-      >
-        <template #header>
-          <h3>{{ trans(ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK) }}</h3>
-        </template>
-
-        <template #body>
-          <accompanying-period-work-list
-            :accompanying-period-works="accompanyingPeriodWorks"
-            v-model:selectedAcpw="selectedAcpw"
-          />
-        </template>
-
-        <template #footer>
-          <button type="button" class="btn btn-save" @click="confirmSelection">
-            {{ trans(CONFIRM) }}
-          </button>
-        </template>
-      </modal>
-    </teleport>
-  </div>
 </template>

 <script setup lang="ts">
-import {onMounted, ref} from "vue";
+import { onMounted, ref } from "vue";
 import Modal from "ChillMainAssets/vuejs/_components/Modal.vue";
 import AccompanyingPeriodWorkList from "./AccompanyingPeriodWorkList.vue";
-import {AccompanyingPeriodWork} from "../../../types";
-import {ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK, CONFIRM, trans,} from "translator";
-import {fetchResults} from "ChillMainAssets/lib/api/apiMethods";
+import { AccompanyingPeriodWork } from "../../../types";
+import {
+    ACPW_DUPLICATE_SELECT_ACCOMPANYING_PERIOD_WORK,
+    CONFIRM,
+    trans,
+} from "translator";
+import { fetchResults } from "ChillMainAssets/lib/api/apiMethods";

 interface AccompanyingPeriodWorkSelectorModalProps {
-  accompanyingPeriodId: number;
+    accompanyingPeriodId: number;
 }

 const selectedAcpw = ref<AccompanyingPeriodWork | null>(null);
@@ -65,25 +81,25 @@ const accompanyingPeriodWorks = ref<AccompanyingPeriodWork[]>([]);
 const props = defineProps<AccompanyingPeriodWorkSelectorModalProps>();

 const emit = defineEmits<{
-  pickWork: [payload: { work: AccompanyingPeriodWork | null }];
+    pickWork: [payload: { work: AccompanyingPeriodWork | null }];
 }>();

 onMounted(() => {
-  if (props.accompanyingPeriodId) {
-    getAccompanyingPeriodWorks(props.accompanyingPeriodId);
-  } else {
-    console.error("No accompanyingperiod id was given");
-  }
+    if (props.accompanyingPeriodId) {
+        getAccompanyingPeriodWorks(props.accompanyingPeriodId);
+    } else {
+        console.error("No accompanyingperiod id was given");
+    }
 });
 const getAccompanyingPeriodWorks = async (periodId: number) => {
-  const url = `/api/1.0/person/accompanying-course/${periodId}/works.json`;
+    const url = `/api/1.0/person/accompanying-course/${periodId}/works.json`;

-  try {
-    accompanyingPeriodWorks.value = await fetchResults(url);
-  } catch (error) {
-    console.log(error);
-  }
-/*  makeFetch<number, AccompanyingPeriodWork[]>("GET", url)
+    try {
+        accompanyingPeriodWorks.value = await fetchResults(url);
+    } catch (error) {
+        console.log(error);
+    }
+    /*  makeFetch<number, AccompanyingPeriodWork[]>("GET", url)
    .then((response) => {
      accompanyingPeriodWorks.value = response;
    })
@@ -95,7 +111,7 @@ const getAccompanyingPeriodWorks = async (periodId: number) => {
 const openModal = () => (showModal.value = true);
 const closeModal = () => (showModal.value = false);
 const confirmSelection = () => {
-  emit("pickWork", { work: selectedAcpw.value });
-  closeModal();
+    emit("pickWork", { work: selectedAcpw.value });
+    closeModal();
 };
 </script>
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/_components/AddPersons.vue
@@ -377,7 +377,7 @@ export default {
                                        "/api/1.0/person/household/members/move.json",
                                        member,
                                    )
-                                        .then((_response) => {
+                                        .then(() => {
                                            makeFetch(
                                                "POST",
                                                `/api/1.0/person/household/${responseHousehold.id}/address.json`,