Fixed: add scope to generated document ref #11

src/Bundle/ChillPersonBundle/Service/DocGenerator/PersonContext.php

@@ -20,52 +20,72 @@ use Chill\DocStoreBundle\Entity\DocumentCategory;
 use Chill\DocStoreBundle\Entity\PersonDocument;
 use Chill\DocStoreBundle\Entity\StoredObject;
 use Chill\DocStoreBundle\Repository\DocumentCategoryRepository;
-use Chill\MainBundle\Form\ScopeType;
+use Chill\DocStoreBundle\Security\Authorization\PersonDocumentVoter;
+use Chill\MainBundle\Entity\Scope;
+use Chill\MainBundle\Form\Type\ScopePickerType;
 use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
+use Chill\MainBundle\Security\Authorization\AuthorizationHelperInterface;
+use Chill\MainBundle\Security\Resolver\CenterResolverManagerInterface;
 use Chill\MainBundle\Templating\TranslatableStringHelperInterface;
 use Chill\PersonBundle\Entity\Person;
 use DateTime;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
+use LogicException;
 use Symfony\Bridge\Doctrine\Form\Type\EntityType;
+use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\Form\FormBuilderInterface;
+use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
-use Symfony\Contracts\Translation\TranslatorInterface;
 
+use Symfony\Contracts\Translation\TranslatorInterface;
 use function array_key_exists;
+use function count;
 
 class PersonContext implements DocGeneratorContextWithAdminFormInterface, DocGeneratorContextWithPublicFormInterface
 {
+    private AuthorizationHelperInterface $authorizationHelper;
+
     private BaseContextData $baseContextData;
 
+    private CenterResolverManagerInterface $centerResolverManager;
+
     private DocumentCategoryRepository $documentCategoryRepository;
 
     private EntityManagerInterface $em;
 
     private NormalizerInterface $normalizer;
 
+    private Security $security;
+
+    private bool $showScopes;
+
     private TranslatableStringHelperInterface $translatableStringHelper;
 
     private TranslatorInterface $translator;
 
-    private AuthorizationHelper $authorizationHelper;
-
     public function __construct(
-        DocumentCategoryRepository $documentCategoryRepository,
-        NormalizerInterface $normalizer,
-        TranslatableStringHelperInterface $translatableStringHelper,
-        EntityManagerInterface $em,
-        TranslatorInterface $translator,
+        AuthorizationHelperInterface $authorizationHelper,
         BaseContextData $baseContextData,
-        AuthorizationHelper $authorizationHelper
+        CenterResolverManagerInterface $centerResolverManager,
+        DocumentCategoryRepository $documentCategoryRepository,
+        EntityManagerInterface $em,
+        NormalizerInterface $normalizer,
+        ParameterBagInterface $parameterBag,
+        Security $security,
+        TranslatorInterface $translator,
+        TranslatableStringHelperInterface $translatableStringHelper
     ) {
-        $this->documentCategoryRepository = $documentCategoryRepository;
-        $this->normalizer = $normalizer;
-        $this->translatableStringHelper = $translatableStringHelper;
-        $this->em = $em;
-        $this->baseContextData = $baseContextData;
-        $this->translator = $translator;
         $this->authorizationHelper = $authorizationHelper;
+        $this->centerResolverManager = $centerResolverManager;
+        $this->baseContextData = $baseContextData;
+        $this->documentCategoryRepository = $documentCategoryRepository;
+        $this->em = $em;
+        $this->normalizer = $normalizer;
+        $this->security = $security;
+        $this->showScopes = $parameterBag->get('chill_main')['acl']['form_show_scopes'];
+        $this->translator = $translator;
+        $this->translatableStringHelper = $translatableStringHelper;
     }
 
     public function adminFormReverseTransform(array $data): array
@@ -112,6 +132,18 @@ class PersonContext implements DocGeneratorContextWithAdminFormInterface, DocGen
             ]);
     }
 
+    /**
+     * @param Person $entity
+     */
+    public function buildPublicForm(FormBuilderInterface $builder, DocGeneratorTemplate $template, $entity): void
+    {
+        $builder->add('scope', ScopePickerType::class, [
+            'center' => $this->centerResolverManager->resolveCenters($entity),
+            'role' => PersonDocumentVoter::CREATE,
+            'label' => 'Scope',
+        ]);
+    }
+
     public function getData(DocGeneratorTemplate $template, $entity, array $contextGenerationData = []): array
     {
         if (!$entity instanceof Person) {
@@ -163,6 +195,14 @@ class PersonContext implements DocGeneratorContextWithAdminFormInterface, DocGen
         return true;
     }
 
+    /**
+     * @param Person $entity
+     */
+    public function hasPublicForm(DocGeneratorTemplate $template, $entity): bool
+    {
+        return $this->isScopeNecessary($entity);
+    }
+
     /**
      * @param Person $entity
      */
@@ -185,42 +225,36 @@ class PersonContext implements DocGeneratorContextWithAdminFormInterface, DocGen
                 );
         }
 
-        if ($this->showScopes()) {
-
-            $scopes = $this->authorizationHelper->getReachableScopes();
-
-            if (count($scopes > 1))
-            {
-                $scope = $this->getFormData();
-                $doc->setScope($scope);
-
-            } else {
-
-                $doc->setScope($scopes[0]);
+        if ($this->isScopeNecessary($entity)) {
+            $doc->setScope($contextGenerationData['scope']);
+        } elseif ($this->showScopes) {
+            // in this case, it should have only one scope possible, we get it through AuthorizationHelper::getReachableScopes
+            $scopes = $this->authorizationHelper->getReachableScopes(
+                $this->security->getUser(),
+                PersonDocumentVoter::CREATE,
+                $this->centerResolverManager->resolveCenters($entity)
+            );
 
+            if (1 !== count($scopes)) {
+                throw new LogicException('at this step, it should have only one scope');
             }
+
+            $doc->setScope($scopes[0]);
         }
 
         $this->em->persist($doc);
     }
 
-    public function showScopes(){
-        return $this->parameterBag->get('chill_main')['acl']['form_show_scopes'];
-    }
-
-    public function buildPublicForm(FormBuilderInterface $builder, DocGeneratorTemplate $template, $entity): void
+    private function isScopeNecessary(Person $person): bool
     {
-        $builder->add('Center', ScopeType::class, [
-            'required' => true
-        ]);
-    }
-
-    public function hasPublicForm(DocGeneratorTemplate $template, $entity): bool
-    {
-        if ($this->showScopes()) {
+        if ($this->showScopes && 1 < $this->authorizationHelper->getReachableScopes(
+            $this->security->getUser(),
+            PersonDocumentVoter::CREATE,
+            $this->centerResolverManager->resolveCenters($person)
+        )) {
             return true;
-        } else {
-            return false;
         }
+
+        return false;
     }
 }