Merge branch 'master' into upgrade-sf5

src/Bundle/ChillPersonBundle/Tests/Serializer/Normalizer/AccompanyingPeriodWorkDocGenNormalizerTest.php

@@ -11,13 +11,13 @@ declare(strict_types=1);
 
 namespace Serializer\Normalizer;
 
+use Chill\DocGeneratorBundle\Test\DocGenNormalizerTestAbstract;
 use Chill\MainBundle\Entity\User;
 use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWork;
 use Chill\PersonBundle\Entity\AccompanyingPeriod\AccompanyingPeriodWorkGoal;
 use Chill\PersonBundle\Entity\Person;
 use Chill\PersonBundle\Entity\SocialWork\Goal;
 use Chill\PersonBundle\Entity\SocialWork\Result;
-use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 
@@ -25,8 +25,10 @@ use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
  * @internal
  *
  * @coversNothing
+ *
+ * @template-extends DocGenNormalizerTestAbstract<AccompanyingPeriodWork>
  */
-final class AccompanyingPeriodWorkDocGenNormalizerTest extends KernelTestCase
+final class AccompanyingPeriodWorkDocGenNormalizerTest extends DocGenNormalizerTestAbstract
 {
     private NormalizerInterface $normalizer;
 
@@ -36,28 +38,31 @@ final class AccompanyingPeriodWorkDocGenNormalizerTest extends KernelTestCase
         $this->normalizer = self::getContainer()->get(NormalizerInterface::class);
     }
 
-    public function testNormalizationNull()
+    public function provideNotNullObject(): object
     {
-        $actual = $this->normalizer->normalize(null, 'docgen', [
-            'docgen:expects' => AccompanyingPeriodWork::class,
-            AbstractNormalizer::GROUPS => ['docgen:read'],
-        ]);
+        $work = new AccompanyingPeriodWork();
+        $work
+            ->addPerson((new Person())->setFirstName('hello')->setLastName('name'))
+            ->addGoal($g = new AccompanyingPeriodWorkGoal())
+            ->addResult($r = new Result())
+            ->setCreatedAt(new \DateTimeImmutable())
+            ->setUpdatedAt(new \DateTimeImmutable())
+            ->setCreatedBy($user = new User())
+            ->setUpdatedBy($user);
+        $g->addResult($r)->setGoal($goal = new Goal());
+        $goal->addResult($r);
 
-        $expected = [
-            'id' => '',
-        ];
+        return $work;
+    }
 
-        $this->assertIsArray($actual);
-        $this->markTestSkipped('specification still not finalized');
-        $this->assertEqualsCanonicalizing(array_keys($expected), array_keys($actual));
+    public function provideDocGenExpectClass(): string
+    {
+        return AccompanyingPeriodWork::class;
+    }
 
-        foreach ($expected as $key => $item) {
-            if ('@ignored' === $item) {
-                continue;
-            }
-
-            $this->assertEquals($item, $actual[$key]);
-        }
+    public function getNormalizer(): NormalizerInterface
+    {
+        return $this->normalizer;
     }
 
     public function testNormalize()
@@ -79,20 +84,6 @@ final class AccompanyingPeriodWorkDocGenNormalizerTest extends KernelTestCase
             AbstractNormalizer::GROUPS => ['docgen:read'],
         ]);
 
-        $expected = [
-            'id' => 0,
-        ];
-
         $this->assertIsArray($actual);
-        $this->markTestSkipped('specification still not finalized');
-        $this->assertEqualsCanonicalizing(array_keys($expected), array_keys($actual));
-
-        foreach ($expected as $key => $item) {
-            if (0 === $item) {
-                continue;
-            }
-
-            $this->assertEquals($item, $actual[$key]);
-        }
     }
 }