fix double person creation + button for creating accompanying course on creation + simplification person create

The controller now register data from a previous post on the form, and
register it in the session.

The next post compare the data with previous one and, if yes, show a
review page if there are "alternate persons.

src/Bundle/ChillPersonBundle/Form/CreationPersonType.php

@@ -21,6 +21,7 @@
 
 namespace Chill\PersonBundle\Form;
 
+use Chill\PersonBundle\Entity\Person;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
@@ -48,7 +49,7 @@ final class CreationPersonType extends AbstractType
      * @var CenterTransformer
      */
     private $centerTransformer;
-    
+
     /**
      *
      * @var ConfigPersonAltNamesHelper
@@ -69,57 +70,22 @@ final class CreationPersonType extends AbstractType
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-        if ($options['form_status'] === self::FORM_BEING_REVIEWED) {
+        $builder
+            ->add('firstName')
+            ->add('lastName')
+            ->add('birthdate', ChillDateType::class, [
+                'required' => false,
+            ])
+            ->add('gender', GenderType::class, array(
+                'required' => true, 'placeholder' => null
+            ))
+            ->add('center', CenterType::class)
+        ;
 
-            $dateToStringTransformer = new DateTimeToStringTransformer(
-                    null, null, 'd-m-Y', false);
-
-            $builder->add('firstName', HiddenType::class)
-                    ->add('lastName', HiddenType::class)
-                    ->add('birthdate', HiddenType::class, array(
-                        'property_path' => 'birthdate'
-                    ))
-                    ->add('gender', HiddenType::class)
-                    ->add('form_status', HiddenType::class, array(
-                        'mapped' => false,
-                        'data' => $options['form_status']
-                    ))
-                    ->add('center', HiddenType::class)
-                    ;
-            
-            if ($this->configPersonAltNamesHelper->hasAltNames()) {
-                    $builder->add('altNames', PersonAltNameType::class, [
-                        'by_reference' => false,
-                        'force_hidden' => true
-                ]);
-            }
-            
-            $builder->get('birthdate')
-                    ->addModelTransformer($dateToStringTransformer);
-            $builder->get('center')
-                    ->addModelTransformer($this->centerTransformer);
-        } else {
-            $builder
-                ->add('firstName')
-                ->add('lastName')
-                ->add('birthdate', ChillDateType::class, [
-                    'required' => false,
-                ])
-                ->add('gender', GenderType::class, array(
-                    'required' => true, 'placeholder' => null
-                ))
-                ->add('form_status', HiddenType::class, array(
-                    'data' => $options['form_status'],
-                    'mapped' => false
-                    ))
-                ->add('center', CenterType::class)
-            ;
-            
-            if ($this->configPersonAltNamesHelper->hasAltNames()) {
-                    $builder->add('altNames', PersonAltNameType::class, [
-                        'by_reference' => false
-                ]);
-            }
+        if ($this->configPersonAltNamesHelper->hasAltNames()) {
+                $builder->add('altNames', PersonAltNameType::class, [
+                    'by_reference' => false
+            ]);
         }
     }
 
@@ -129,15 +95,8 @@ final class CreationPersonType extends AbstractType
     public function configureOptions(OptionsResolver $resolver)
     {
         $resolver->setDefaults(array(
-            'data_class' => 'Chill\PersonBundle\Entity\Person'
+            'data_class' => Person::class
         ));
-
-        $resolver->setRequired('form_status')
-              ->setAllowedValues('form_status', array(
-                 self::FORM_BEING_REVIEWED,
-                 self::FORM_NOT_REVIEWED,
-                 self::FORM_REVIEWED
-              ));
     }
 
     /**