GenericDoc: add provider for AccompanyingCourseDocument, without filtering

src/Bundle/ChillDocStoreBundle/Tests/GenericDoc/FetchQueryToSqlBuilderTest.php

@@ -13,6 +13,7 @@ namespace Chill\DocStoreBundle\Tests\GenericDoc;
 
 use Chill\DocStoreBundle\GenericDoc\FetchQueryToSqlBuilder;
 use Chill\DocStoreBundle\GenericDoc\FetchQuery;
+use Doctrine\DBAL\Types\Types;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
 /**
@@ -29,15 +30,15 @@ class FetchQueryToSqlBuilderTest extends KernelTestCase
             'a.datecolumn',
             'my_table a'
         );
-        $query->addJoinClause('LEFT JOIN other b ON a.id = b.foreign_id', ['foo']);
-        $index = $query->addJoinClause('LEFT JOIN other c ON a.id = c.foreign_id', ['bar']);
-        $query->addJoinClause('LEFT JOIN other d ON a.id = d.foreign_id', ['bar_baz']);
+        $query->addJoinClause('LEFT JOIN other b ON a.id = b.foreign_id', ['foo'], [Types::STRING]);
+        $index = $query->addJoinClause('LEFT JOIN other c ON a.id = c.foreign_id', ['bar'], [Types::STRING]);
+        $query->addJoinClause('LEFT JOIN other d ON a.id = d.foreign_id', ['bar_baz'], [Types::STRING]);
         $query->removeJoinClause($index);
-        $query->addWhereClause('b.item = ?', ['baz']);
-        $index = $query->addWhereClause('b.cancel', [ 'foz']);
+        $query->addWhereClause('b.item = ?', ['baz'], [Types::STRING]);
+        $index = $query->addWhereClause('b.cancel', [ 'foz'], [Types::STRING]);
         $query->removeWhereClause($index);
 
-        ['sql' => $sql, 'params' => $params] = (new FetchQueryToSqlBuilder())->toSql($query);
+        ['sql' => $sql, 'params' => $params, 'types' => $types] = (new FetchQueryToSqlBuilder())->toSql($query);
 
         $filteredSql =
             implode(" ", array_filter(
@@ -48,10 +49,41 @@ class FetchQueryToSqlBuilderTest extends KernelTestCase
 
         self::assertEquals(
             "SELECT 'test' AS key, jsonb_build_object('id', a.column) AS identifiers, ".
-            "a.datecolumn AS doc_date FROM my_table a LEFT JOIN other b ON a.id = b.foreign_id LEFT JOIN other d ON a.id = d.foreign_id WHERE b.item = ?",
+            "a.datecolumn::date AS doc_date FROM my_table a LEFT JOIN other b ON a.id = b.foreign_id LEFT JOIN other d ON a.id = d.foreign_id WHERE b.item = ?",
             $filteredSql
         );
         self::assertEquals(['foo', 'bar_baz', 'baz'], $params);
+        self::assertEquals([Types::STRING, Types::STRING, Types::STRING], $types);
+
+
+
+    }
+
+    public function testToSqlWithoutWhere(): void
+    {
+        $query = new FetchQuery(
+            'test',
+            'jsonb_build_object(\'id\', a.column)',
+            'a.datecolumn',
+            'my_table a'
+        );
+
+        ['sql' => $sql, 'params' => $params, 'types' => $types] = (new FetchQueryToSqlBuilder())->toSql($query);
+
+        $filteredSql =
+            implode(" ", array_filter(
+                explode(" ", str_replace("\n", "", $sql)),
+                fn (string $tok) => $tok !== ""
+            ))
+        ;
+
+        self::assertEquals(
+            "SELECT 'test' AS key, jsonb_build_object('id', a.column) AS identifiers, ".
+            "a.datecolumn::date AS doc_date FROM my_table a",
+            $filteredSql
+        );
+        self::assertEquals([], $params);
+        self::assertEquals([], $types);
     }
 
 }

src/Bundle/ChillDocStoreBundle/Tests/GenericDoc/ManagerTest.php

@@ -11,9 +11,15 @@ declare(strict_types=1);
 
 namespace Chill\DocStoreBundle\Tests\GenericDoc;
 
+use Chill\DocStoreBundle\GenericDoc\FetchQuery;
+use Chill\DocStoreBundle\GenericDoc\FetchQueryInterface;
+use Chill\DocStoreBundle\GenericDoc\GenericDocDTO;
 use Chill\DocStoreBundle\GenericDoc\Manager;
+use Chill\DocStoreBundle\GenericDoc\ProviderForAccompanyingPeriodInterface;
 use Chill\PersonBundle\Entity\AccompanyingPeriod;
+use Doctrine\DBAL\Connection;
 use Doctrine\ORM\EntityManagerInterface;
+use Prophecy\PhpUnit\ProphecyTrait;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
 /**
@@ -22,21 +28,17 @@ use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
  */
 class ManagerTest extends KernelTestCase
 {
-    private Manager $manager;
-
+    use ProphecyTrait;
     private EntityManagerInterface $em;
 
+    private Connection $connection;
+
     protected function setUp(): void
     {
         self::bootKernel();
 
         $this->em = self::$container->get(EntityManagerInterface::class);
-
-        if (null !== $manager = self::$container->get(Manager::class)) {
-            $this->manager = $manager;
-        } else {
-            throw new \UnexpectedValueException("the manager was not found in the kernel");
-        }
+        $this->connection = self::$container->get(Connection::class);
     }
 
     public function testCountByAccompanyingPeriod(): void
@@ -49,8 +51,51 @@ class ManagerTest extends KernelTestCase
             throw new \UnexpectedValueException("period not found");
         }
 
-        $nb = $this->manager->countDocForAccompanyingPeriod($period);
+        $manager = new Manager(
+            [new SimpleProvider()],
+            $this->connection,
+        );
+
+        $nb = $manager->countDocForAccompanyingPeriod($period);
 
         self::assertIsInt($nb);
     }
+
+    public function testFindDocByAccompanyingPeriod(): void
+    {
+        $period = $this->em->createQuery('SELECT a FROM '.AccompanyingPeriod::class.' a')
+            ->setMaxResults(1)
+            ->getSingleResult();
+
+        if (null === $period) {
+            throw new \UnexpectedValueException("period not found");
+        }
+
+        $manager = new Manager(
+            [new SimpleProvider()],
+            $this->connection,
+        );
+
+        foreach ($manager->findDocForAccompanyingPeriod($period) as $doc) {
+            self::assertInstanceOf(GenericDocDTO::class, $doc);
+        }
+    }
+}
+
+final readonly class SimpleProvider implements ProviderForAccompanyingPeriodInterface
+{
+    public function buildFetchQueryForAccompanyingPeriod(AccompanyingPeriod $accompanyingPeriod, ?\DateTimeImmutable $startDate = null, ?\DateTimeImmutable $endDate = null, ?string $content = null, ?string $origin = null): FetchQueryInterface
+    {
+        return new FetchQuery(
+            'accompanying_course_document',
+            sprintf('jsonb_build_object(\'id\', %s)', 'id'),
+            'd',
+            '(VALUES (1, \'2023-05-01\'::date), (2, \'2023-05-01\'::date)) AS sq (id, d)',
+        );
+    }
+
+    public function isAllowedForAccompanyingPeriod(AccompanyingPeriod $accompanyingPeriod): bool
+    {
+        return true;
+    }
 }

src/Bundle/ChillDocStoreBundle/Tests/GenericDoc/Providers/AccompanyingCourseDocumentProviderTest.php

@@ -0,0 +1,78 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\Tests\GenericDoc\Providers;
+
+use Chill\DocStoreBundle\GenericDoc\FetchQueryToSqlBuilder;
+use Chill\DocStoreBundle\GenericDoc\Providers\AccompanyingCourseDocumentProvider;
+use Chill\DocStoreBundle\Security\Authorization\AccompanyingCourseDocumentVoter;
+use Chill\PersonBundle\Entity\AccompanyingPeriod;
+use Doctrine\DBAL\Types\Types;
+use Doctrine\ORM\EntityManagerInterface;
+use Prophecy\PhpUnit\ProphecyTrait;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\Security\Core\Security;
+
+/**
+ * @internal
+ * @coversNothing
+ */
+class AccompanyingCourseDocumentProviderTest extends KernelTestCase
+{
+    use ProphecyTrait;
+    private EntityManagerInterface $entityManager;
+
+    public function setUp(): void
+    {
+        self::bootKernel();
+
+        $this->entityManager = self::$container->get(EntityManagerInterface::class);
+    }
+
+    /**
+     * @dataProvider provideSearchArguments
+     */
+    public function testWithoutAnyArgument(?\DateTimeImmutable $startDate, ?\DateTimeImmutable $endDate, ?string $content = null): void
+    {
+        $period = $this->entityManager->createQuery('SELECT a FROM '.AccompanyingPeriod::class.' a')
+            ->setMaxResults(1)
+            ->getSingleResult();
+
+        if (null === $period) {
+            throw new \UnexpectedValueException("period not found");
+        }
+
+        $security = $this->prophesize(Security::class);
+        $security->isGranted(AccompanyingCourseDocumentVoter::SEE, $period)
+            ->willReturn(true);
+
+        $provider = new AccompanyingCourseDocumentProvider(
+            $security->reveal(),
+            $this->entityManager
+        );
+
+        $query = $provider->buildFetchQueryForAccompanyingPeriod($period, $startDate, $endDate, $content);
+
+        ['sql' => $sql, 'params' => $params, 'types' => $types] = (new FetchQueryToSqlBuilder())->toSql($query);
+
+        $this->entityManager->getConnection()->executeQuery($sql, $params, $types);
+
+        self::assertTrue(true, "test that no errors occurs");
+    }
+
+    public function provideSearchArguments(): iterable
+    {
+        yield [null, null, null];
+        yield [new \DateTimeImmutable('1 month ago'), null, null];
+        yield [new \DateTimeImmutable('1 month ago'), new \DateTimeImmutable('now'), null];
+        yield [null, null, 'test'];
+    }
+}