Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-29 05:26:13 +00:00
Code Issues Actions Projects Releases Wiki Activity

DX: fix ci and phpstan issues

Browse Source
This commit is contained in:
Julien Fastré 2023-04-11 22:01:47 +02:00
parent 4db1ff405e
commit 8bec6feb96
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
4 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Bundle/ChillActivityBundle/Tests/Form/ActivityTypeTest.php
View File

@ -112,9 +112,9 @@ final class ActivityTypeTest extends KernelTestCase
'attendee' => true, 'attendee' => true,
]]); ]]);
// var_dump($form->getErrors()->count()); var_dump($form->isValid()); // var_dump($form->getErrors()->count()); var_dump($form->isValid());
// foreach($form->getErrors() as $e) { fwrite(STDOUT, var_dump($e->getMessage())); } // foreach($form->getErrors() as $e) { fwrite(STDOUT, var_dump($e->getMessage())); }
// var_dump($form->getErrors()); // var_dump($form->getErrors());
$this->assertTrue($form->isSynchronized(), 'Test the form is synchronized'); $this->assertTrue($form->isSynchronized(), 'Test the form is synchronized');
$this->assertTrue($form->isValid(), 'test the form is valid'); $this->assertTrue($form->isValid(), 'test the form is valid');

2
src/Bundle/ChillMainBundle/CRUD/Routing/CRUDRoutesLoader.php
View File

@ -101,7 +101,7 @@ class CRUDRoutesLoader extends Loader
$singleCollection = $action['single_collection'] ?? '_entity' === $name ? 'single' : null; $singleCollection = $action['single_collection'] ?? '_entity' === $name ? 'single' : null;
if ('collection' === $singleCollection) { if ('collection' === $singleCollection) {
// continue; // continue;
} }
// compute default action // compute default action

5
src/Bundle/ChillThirdPartyBundle/Search/ThirdPartySearch.php
View File

@ -100,9 +100,8 @@ class ThirdPartySearch implements SearchInterface
'more' => $paginator->hasNextPage(), 'more' => $paginator->hasNextPage(),
]; ];
} }
if ('html' === $format) { // format "html"
throw new \UnexpectedValueException("format not supported"); throw new \UnexpectedValueException("format html not supported");
}
} }
public function supports($domain, $format): bool public function supports($domain, $format): bool

2
src/Bundle/ChillThirdPartyBundle/migrations/Version20230215175150.php
View File

@ -25,7 +25,7 @@ final class Version20230215175150 extends AbstractMigration implements Container
public function down(Schema $schema): void public function down(Schema $schema): void
{ {
$this->addSql('ALTER TABLE chill_3party.third_party DROP profession'); $this->addSql('ALTER TABLE chill_3party.third_party DROP profession');
// $this->addSql('ALTER TABLE chill_3party.third_party ADD profession_id INT DEFAULT NULL'); // $this->addSql('ALTER TABLE chill_3party.third_party ADD profession_id INT DEFAULT NULL');
} }
public function getDescription(): string public function getDescription(): string