Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-12 21:34:25 +00:00
Code Issues Actions Projects Releases Wiki Activity

Merge branch 'simplify-statement' into 'master'

Browse Source 
fix: Simplify statements and fix syntax.

See merge request Chill-Projet/chill-bundles!20
This commit is contained in:
Julien Fastré 2021-04-26 11:33:08 +00:00
commit 8adb05c24f
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Bundle/ChillMainBundle/Notification/Mailer.php
View File

@ -104,7 +104,7 @@ class Mailer
* @param \User $to * @param \User $to
* @param array $subject Subject of the message [ 0 => $message (required), 1 => $parameters (optional), 3 => $domain (optional) ] * @param array $subject Subject of the message [ 0 => $message (required), 1 => $parameters (optional), 3 => $domain (optional) ]
* @param array $bodies The bodies. An array where keys are the contentType and values the bodies * @param array $bodies The bodies. An array where keys are the contentType and values the bodies
* @param \callable $callback a callback to customize the message (add attachment, etc.) * @param callable $callback a callback to customize the message (add attachment, etc.)
*/ */
public function sendNotification( public function sendNotification(
$recipient, $recipient,

7
src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php
View File

@ -152,7 +152,7 @@ class SingleTaskController extends AbstractController
$em = $this->getDoctrine()->getManager(); $em = $this->getDoctrine()->getManager();
$task = $em->getRepository(SingleTask::class)->find($id); $task = $em->getRepository(SingleTask::class)->find($id);
if (!is_null($task->getPerson() === !null)) { if ($task->getPerson() !== null) {
$personId = $task->getPerson()->getId(); $personId = $task->getPerson()->getId();
if ($personId === null) { if ($personId === null) {
@ -206,7 +206,7 @@ class SingleTaskController extends AbstractController
$em = $this->getDoctrine()->getManager(); $em = $this->getDoctrine()->getManager();
$task = $em->getRepository(SingleTask::class)->find($id); $task = $em->getRepository(SingleTask::class)->find($id);
if (!is_null($task->getPerson() === !null)) { if ($task->getPerson() !== null) {
$personId = $task->getPerson()->getId(); $personId = $task->getPerson()->getId();
if ($personId === null) { if ($personId === null) {
return new Response("You must provide a person_id", Response::HTTP_BAD_REQUEST); return new Response("You must provide a person_id", Response::HTTP_BAD_REQUEST);
@ -303,8 +303,7 @@ class SingleTaskController extends AbstractController
throw $this->createNotFoundException('Unable to find Task entity.'); throw $this->createNotFoundException('Unable to find Task entity.');
} }
if (!is_null($task->getPerson() === !null)) { if ($task->getPerson() !== null) {
$personId = $task->getPerson()->getId(); $personId = $task->getPerson()->getId();
if ($personId === null) { if ($personId === null) {
return new Response("You must provide a person_id", Response::HTTP_BAD_REQUEST); return new Response("You must provide a person_id", Response::HTTP_BAD_REQUEST);