Chill-project/chill-bundles
6
0
Fork 0
mirror of https://gitlab.com/Chill-Projet/chill-bundles.git synced 2025-06-13 13:54:23 +00:00
Code Issues Actions Projects Releases Wiki Activity

DX: review for hasNoActivityFilter

Browse Source
This commit is contained in:
Julien Fastré 2022-11-02 13:21:26 +01:00
parent 094a912e42
commit 84e5be6a60
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Bundle/ChillActivityBundle/Export/Filter/ACPFilters/HasNoActivityFilter.php
View File

@ -14,10 +14,8 @@ namespace Chill\ActivityBundle\Export\Filter\ACPFilters;
use Chill\ActivityBundle\Entity\Activity; use Chill\ActivityBundle\Entity\Activity;
use Chill\MainBundle\Export\FilterInterface; use Chill\MainBundle\Export\FilterInterface;
use Chill\PersonBundle\Export\Declarations; use Chill\PersonBundle\Export\Declarations;
use Doctrine\ORM\Query\Expr;
use Doctrine\ORM\QueryBuilder; use Doctrine\ORM\QueryBuilder;
use Symfony\Component\Form\FormBuilderInterface; use Symfony\Component\Form\FormBuilderInterface;
use function in_array;
class HasNoActivityFilter implements FilterInterface class HasNoActivityFilter implements FilterInterface
{ {
@ -28,13 +26,7 @@ class HasNoActivityFilter implements FilterInterface
public function alterQuery(QueryBuilder $qb, $data) public function alterQuery(QueryBuilder $qb, $data)
{ {
if (!in_array('activity', $qb->getAllAliases(), true)) {
$qb->join(Activity::class, 'activity', Expr\Join::WITH, 'activity.accompanyingPeriod = acp');
}
$qb $qb
//->andWhere('COUNT(acp.activities) IS NULL')
//TODO check this:
->andWhere(' ->andWhere('
NOT EXISTS ( NOT EXISTS (
SELECT 1 FROM ' . Activity::class . ' activity SELECT 1 FROM ' . Activity::class . ' activity
@ -55,7 +47,7 @@ class HasNoActivityFilter implements FilterInterface
public function describeAction($data, $format = 'string'): array public function describeAction($data, $format = 'string'): array
{ {
return ['Filtered acp which has no activities']; return ['Filtered acp which has no activities', []];
} }
public function getTitle(): string public function getTitle(): string

2
src/Bundle/ChillActivityBundle/translations/messages.fr.yml
View File

@ -278,7 +278,7 @@ Filter activity by userscope: Filtrer les activités par service du créateur
Accepted userscope: Services Accepted userscope: Services
Filter acp which has no activity: Filtrer les parcours qui n’ont pas d’activité Filter acp which has no activity: Filtrer les parcours qui n’ont pas d’activité
Filtered acp which has no activities: Filtrés les parcours qui n'ont pas d'activités Filtered acp which has no activities: Filtrer les parcours sans activité associée
Group acp by activity number: Grouper les parcours par nombre d’activité Group acp by activity number: Grouper les parcours par nombre d’activité
Group activity by sentreceived: Grouper les activités par envoyé / reçu Group activity by sentreceived: Grouper les activités par envoyé / reçu