Add todo as reminder to change isSignature logic in controller

This commit is contained in:
Julie Lenaerts 2024-07-10 15:05:08 +02:00
parent b1885de3e2
commit 8209990437

View File

@ -281,11 +281,12 @@ class WorkflowController extends AbstractController
$handler = $this->entityWorkflowManager->getHandler($entityWorkflow); $handler = $this->entityWorkflowManager->getHandler($entityWorkflow);
$workflow = $this->registry->get($entityWorkflow, $entityWorkflow->getWorkflowName()); $workflow = $this->registry->get($entityWorkflow, $entityWorkflow->getWorkflowName());
$errors = []; $errors = [];
$signaturesByPerson = false; $isSignaturePerson = false;
$signatures = $entityWorkflow->getCurrentStep()->getSignatures(); $signatures = $entityWorkflow->getCurrentStep()->getSignatures();
//todo: change this logic to use the workflow definition metadata isSignature
if (!$signatures->isEmpty()) { if (!$signatures->isEmpty()) {
$signaturesByPerson = $signatures[0]->getSigner() instanceof Person; $isSignaturePerson = $signatures[0]->getSigner() instanceof Person;
} }
if (\count($workflow->getEnabledTransitions($entityWorkflow)) > 0) { if (\count($workflow->getEnabledTransitions($entityWorkflow)) > 0) {
@ -358,7 +359,7 @@ class WorkflowController extends AbstractController
'entity_workflow' => $entityWorkflow, 'entity_workflow' => $entityWorkflow,
'transition_form_errors' => $errors, 'transition_form_errors' => $errors,
'signatures' => $signatures, 'signatures' => $signatures,
'signaturesByPerson' => $signaturesByPerson, 'signaturesByPerson' => $isSignaturePerson,
// 'comment_form' => $commentForm->createView(), // 'comment_form' => $commentForm->createView(),
] ]
); );