From 8209990437a321894d39732a89fcdccfb35822f8 Mon Sep 17 00:00:00 2001
From: Julie Lenaerts <julielenaerts@gmail.com>
Date: Wed, 10 Jul 2024 15:05:08 +0200
Subject: [PATCH] Add todo as reminder to change isSignature logic in
 controller

---
 .../ChillMainBundle/Controller/WorkflowController.php      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Bundle/ChillMainBundle/Controller/WorkflowController.php b/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
index 93eb24bfc..ce9220d3c 100644
--- a/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
+++ b/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
@@ -281,11 +281,12 @@ class WorkflowController extends AbstractController
         $handler = $this->entityWorkflowManager->getHandler($entityWorkflow);
         $workflow = $this->registry->get($entityWorkflow, $entityWorkflow->getWorkflowName());
         $errors = [];
-        $signaturesByPerson = false;
+        $isSignaturePerson = false;
 
         $signatures = $entityWorkflow->getCurrentStep()->getSignatures();
+        //todo: change this logic to use the workflow definition metadata isSignature
         if (!$signatures->isEmpty()) {
-            $signaturesByPerson = $signatures[0]->getSigner() instanceof Person;
+            $isSignaturePerson = $signatures[0]->getSigner() instanceof Person;
         }
 
         if (\count($workflow->getEnabledTransitions($entityWorkflow)) > 0) {
@@ -358,7 +359,7 @@ class WorkflowController extends AbstractController
                 'entity_workflow' => $entityWorkflow,
                 'transition_form_errors' => $errors,
                 'signatures' => $signatures,
-                'signaturesByPerson' => $signaturesByPerson,
+                'signaturesByPerson' => $isSignaturePerson,
                 // 'comment_form' => $commentForm->createView(),
             ]
         );