refactor file drop widget

src/Bundle/ChillDocStoreBundle/Form/AccompanyingCourseDocumentType.php

@@ -14,47 +14,21 @@ namespace Chill\DocStoreBundle\Form;
 use Chill\DocStoreBundle\Entity\AccompanyingCourseDocument;
 use Chill\DocStoreBundle\Entity\Document;
 use Chill\DocStoreBundle\Entity\DocumentCategory;
-use Chill\MainBundle\Entity\User;
 use Chill\MainBundle\Form\Type\ChillDateType;
 use Chill\MainBundle\Form\Type\ChillTextareaType;
-use Chill\MainBundle\Security\Authorization\AuthorizationHelper;
-use Chill\MainBundle\Templating\TranslatableStringHelper;
+use Chill\MainBundle\Templating\TranslatableStringHelperInterface;
 use Doctrine\ORM\EntityRepository;
-use Doctrine\Persistence\ObjectManager;
 use Symfony\Bridge\Doctrine\Form\Type\EntityType;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
-class AccompanyingCourseDocumentType extends AbstractType
+final class AccompanyingCourseDocumentType extends AbstractType
 {
-    /**
-     * @var AuthorizationHelper
-     */
-    protected $authorizationHelper;
-
-    /**
-     * @var ObjectManager
-     */
-    protected $om;
-
-    /**
-     * @var TranslatableStringHelper
-     */
-    protected $translatableStringHelper;
-
-    /**
-     * the user running this form.
-     *
-     * @var User
-     */
-    protected $user;
-
     public function __construct(
-        TranslatableStringHelper $translatableStringHelper
+        private readonly TranslatableStringHelperInterface $translatableStringHelper
     ) {
-        $this->translatableStringHelper = $translatableStringHelper;
     }
 
     public function buildForm(FormBuilderInterface $builder, array $options)

src/Bundle/ChillDocStoreBundle/Form/CollectionStoredObjectType.php

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\Form;
+
+use Chill\MainBundle\Form\Type\ChillCollectionType;
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+
+class CollectionStoredObjectType extends AbstractType
+{
+    public function configureOptions(OptionsResolver $resolver)
+    {
+        $resolver
+            ->setDefault('entry_type', StoredObjectType::class)
+            ->setDefault('allow_add', true)
+            ->setDefault('allow_delete', true)
+            ->setDefault('button_add_label', 'stored_object.Insert a document')
+            ->setDefault('button_remove_label', 'stored_object.Remove a document')
+            ->setDefault('empty_collection_explain', 'No documents')
+            ->setDefault('entry_options', ['has_title' => true])
+            ->setDefault('js_caller', 'data-collection-stored-object');
+    }
+
+    public function getParent()
+    {
+        return ChillCollectionType::class;
+    }
+}

src/Bundle/ChillDocStoreBundle/Form/DataMapper/StoredObjectDataMapper.php

@@ -0,0 +1,82 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\Form\DataMapper;
+
+use Chill\DocStoreBundle\Entity\StoredObject;
+use Doctrine\ORM\EntityManagerInterface;
+use Symfony\Component\Form\DataMapperInterface;
+use Symfony\Component\Form\Exception;
+use Symfony\Component\Form\FormInterface;
+
+class StoredObjectDataMapper implements DataMapperInterface
+{
+    public function __construct(
+        private EntityManagerInterface $entityManager,
+    ) {
+    }
+
+    /**
+     * @param FormInterface[]|\Traversable $forms A list of {@link FormInterface} instances
+     */
+    public function mapDataToForms($viewData, $forms)
+    {
+        if (null === $viewData) {
+            return;
+        }
+
+        if (!$viewData instanceof StoredObject) {
+            throw new Exception\UnexpectedTypeException($viewData, StoredObject::class);
+        }
+
+        $forms = iterator_to_array($forms);
+        if (array_key_exists('title', $forms)) {
+            $forms['title']->setData($viewData->getTitle());
+        }
+        $forms['stored_object']->setData($viewData);
+    }
+
+    /**
+     * @param FormInterface[]|\Traversable $forms A list of {@link FormInterface} instances
+     */
+    public function mapFormsToData($forms, &$viewData)
+    {
+        $forms = iterator_to_array($forms);
+
+        if (!(null === $viewData || $viewData instanceof StoredObject)) {
+            throw new Exception\UnexpectedTypeException($viewData, StoredObject::class);
+        }
+
+        dump($forms['stored_object']->getData(), $viewData);
+
+        if (null === $forms['stored_object']->getData()) {
+
+            return;
+        }
+
+        /** @var StoredObject $viewData */
+        if ($viewData->getFilename() !== $forms['stored_object']->getData()['filename']) {
+            // we do not want to erase the previous object
+            $viewData = new StoredObject();
+        }
+
+        $viewData->setFilename($forms['stored_object']->getData()['filename']);
+        $viewData->setIv($forms['stored_object']->getData()['iv']);
+        $viewData->setKeyInfos($forms['stored_object']->getData()['keyInfos']);
+        $viewData->setType($forms['stored_object']->getData()['type']);
+
+        if (array_key_exists('title', $forms)) {
+            $viewData->setTitle($forms['title']->getData());
+        }
+
+        dump($viewData);
+    }
+}

src/Bundle/ChillDocStoreBundle/Form/DataTransformer/StoredObjectDataTransformer.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Chill\DocStoreBundle\Form\DataTransformer;
+
+use Chill\DocStoreBundle\Entity\StoredObject;
+use Chill\DocStoreBundle\Serializer\Normalizer\StoredObjectNormalizer;
+use Symfony\Component\Form\DataTransformerInterface;
+use Symfony\Component\Form\Exception\UnexpectedTypeException;
+use Symfony\Component\Serializer\SerializerInterface;
+
+class StoredObjectDataTransformer implements DataTransformerInterface
+{
+    public function __construct(
+        private SerializerInterface $serializer
+    ) {
+    }
+
+    public function transform(mixed $value): mixed
+    {
+        if (null === $value) {
+            return '';
+        }
+
+        if ($value instanceof StoredObject) {
+            return $this->serializer->serialize($value, 'json', [
+                'groups' => [
+                    StoredObjectNormalizer::ADD_DAV_EDIT_LINK_CONTEXT,
+                ],
+            ]);
+        }
+
+        throw new UnexpectedTypeException($value, StoredObject::class);
+    }
+
+    public function reverseTransform(mixed $value): mixed
+    {
+        if ('' === $value || null === $value) {
+            return null;
+        }
+
+        return json_decode($value, true, 10, JSON_THROW_ON_ERROR);
+    }
+}

src/Bundle/ChillDocStoreBundle/Form/StoredObjectType.php

@@ -11,11 +11,10 @@ declare(strict_types=1);
 
 namespace Chill\DocStoreBundle\Form;
 
-use ChampsLibres\AsyncUploaderBundle\Form\Type\AsyncUploaderType;
 use Chill\DocStoreBundle\Entity\StoredObject;
-use Doctrine\ORM\EntityManagerInterface;
+use Chill\DocStoreBundle\Form\DataMapper\StoredObjectDataMapper;
+use Chill\DocStoreBundle\Form\DataTransformer\StoredObjectDataTransformer;
 use Symfony\Component\Form\AbstractType;
-use Symfony\Component\Form\CallbackTransformer;
 use Symfony\Component\Form\Extension\Core\Type\HiddenType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\Form\FormBuilderInterface;
@@ -24,16 +23,12 @@ use Symfony\Component\OptionsResolver\OptionsResolver;
 /**
  * Form type which allow to join a document.
  */
-class StoredObjectType extends AbstractType
+final class StoredObjectType extends AbstractType
 {
-    /**
-     * @var EntityManagerInterface
-     */
-    protected $em;
-
-    public function __construct(EntityManagerInterface $em)
-    {
-        $this->em = $em;
+    public function __construct(
+        private readonly StoredObjectDataTransformer $storedObjectDataTransformer,
+        private readonly StoredObjectDataMapper $storedObjectDataMapper,
+    ) {
     }
 
     public function buildForm(FormBuilderInterface $builder, array $options)
@@ -45,30 +40,9 @@ class StoredObjectType extends AbstractType
                 ]);
         }
 
-        $builder
-            ->add('filename', AsyncUploaderType::class)
-            ->add('type', HiddenType::class)
-            ->add('keyInfos', HiddenType::class)
-            ->add('iv', HiddenType::class);
-
-        $builder
-            ->get('keyInfos')
-            ->addModelTransformer(new CallbackTransformer(
-                $this->transform(...),
-                $this->reverseTransform(...)
-            ));
-        $builder
-            ->get('iv')
-            ->addModelTransformer(new CallbackTransformer(
-                $this->transform(...),
-                $this->reverseTransform(...)
-            ));
-
-        $builder
-            ->addModelTransformer(new CallbackTransformer(
-                $this->transformObject(...),
-                $this->reverseTransformObject(...)
-            ));
+        $builder->add('stored_object', HiddenType::class);
+        $builder->get('stored_object')->addModelTransformer($this->storedObjectDataTransformer);
+        $builder->setDataMapper($this->storedObjectDataMapper);
     }
 
     public function configureOptions(OptionsResolver $resolver)
@@ -80,43 +54,4 @@ class StoredObjectType extends AbstractType
             ->setDefault('has_title', false)
             ->setAllowedTypes('has_title', ['bool']);
     }
-
-    public function reverseTransform($value)
-    {
-        if (null === $value) {
-            return null;
-        }
-
-        return \json_decode((string) $value, true, 512, JSON_THROW_ON_ERROR);
-    }
-
-    public function reverseTransformObject($object)
-    {
-        if (null === $object) {
-            return null;
-        }
-
-        if (null === $object->getFilename()) {
-            // remove the original object
-            $this->em->remove($object);
-
-            return null;
-        }
-
-        return $object;
-    }
-
-    public function transform($object)
-    {
-        if (null === $object) {
-            return null;
-        }
-
-        return \json_encode($object, JSON_THROW_ON_ERROR);
-    }
-
-    public function transformObject($object = null)
-    {
-        return $object;
-    }
 }