Merge remote-tracking branch 'origin/master' into issue593_bug_addAddress

2025-06-07 18:44:08 +00:00 · 2022-04-28 17:46:42 +02:00 · 2022-04-28 17:46:42 +02:00 · 6daee268bf
commit 6daee268bf
parent 6662e0fb5f 86a7bb5880
28 changed files with 238 additions and 106 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -12,11 +12,10 @@ and this project adheres to

 <!-- write down unreleased development here -->
 * [address] fix bug when editing address: update location and addressreferenceId + better update of the map in edition (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/593)
-
+* [main] avoid address reference search on undefined post code (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/561)
+* [person] prevent duplicate relationship in filiation/household graph (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/560)
 * [Documents] Validate storedObject and allow for null data (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/565)
-* [Activity form] invert 'incoming' and 'receiving' in Activity form
-* [Activity form] keep the same order for 'attendee' field in new and edit form
-* [list with period] use "sameas" test operator to introduce requestor in list
+* [parcours]: Comments can be unpinned + edit/delete for all users that are allowed to edit parcours (https://gitlab.com/champs-libres/departement-de-la-vendee/chill/-/issues/566)

 ## Test releases

--- a/phpstan-critical.neon
+++ b/phpstan-critical.neon
@ -5,11 +5,6 @@ parameters:
            count: 1
            path: src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php

-        -
-            message: "#^Access to an undefined property Chill\\\\PersonBundle\\\\Entity\\\\Person\\:\\:\\$currentHouseholdParticipationAt\\.$#"
-            count: 3
-            path: src/Bundle/ChillPersonBundle/Entity/Person.php
-
        -
            message: "#^Access to an undefined property Chill\\\\PersonBundle\\\\Entity\\\\Household\\\\PersonHouseholdAddress\\:\\:\\$relation\\.$#"
            count: 1
--- a/phpstan.neon.dist
+++ b/phpstan.neon.dist
@ -3,6 +3,7 @@ parameters:
    paths:
        - src/
    excludePaths:
+        - .php_cs*
        - docs/
        - src/Bundle/*/Tests/*
        - src/Bundle/*/tests/*
--- a/src/Bundle/ChillMainBundle/CRUD/Controller/ApiController.php
+++ b/src/Bundle/ChillMainBundle/CRUD/Controller/ApiController.php
@ -16,9 +16,9 @@ use Chill\MainBundle\Serializer\Model\Collection;
 use Exception;
 use LogicException;
 use RuntimeException;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Serializer\Exception\NotEncodableValueException;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
 use Symfony\Component\Serializer\SerializerInterface;
@ -55,7 +55,7 @@ class ApiController extends AbstractCRUDController
                return $this->entityDelete('_entity', $request, $id, $_format);

            default:
-                throw new \Symfony\Component\HttpFoundation\Exception\BadRequestException('This method is not implemented');
+                throw new BadRequestHttpException('This method is not implemented');
        }
    }

@ -120,7 +120,7 @@ class ApiController extends AbstractCRUDController
                return $this->entityPostAction('_entity', $request, $_format);

            default:
-                throw new \Symfony\Component\HttpFoundation\Exception\BadRequestException('This method is not implemented');
+                throw new BadRequestHttpException('This method is not implemented');
        }
    }

@ -160,7 +160,7 @@ class ApiController extends AbstractCRUDController
        try {
            $entity = $this->deserialize($action, $request, $_format, $entity);
        } catch (NotEncodableValueException $e) {
-            throw new BadRequestException('invalid json', 400, $e);
+            throw new BadRequestHttpException('invalid json', 400, $e);
        }

        $errors = $this->validate($action, $request, $_format, $entity);
@ -273,7 +273,7 @@ class ApiController extends AbstractCRUDController
        try {
            $postedData = $this->getSerializer()->deserialize($request->getContent(), $postedDataType, $_format, $postedDataContext);
        } catch (\Symfony\Component\Serializer\Exception\UnexpectedValueException $e) {
-            throw new BadRequestException(sprintf('Unable to deserialize posted ' .
+            throw new BadRequestHttpException(sprintf('Unable to deserialize posted ' .
                'data: %s', $e->getMessage()), 0, $e);
        }

@ -290,7 +290,7 @@ class ApiController extends AbstractCRUDController
                break;

            default:
-                throw new BadRequestException('this method is not supported');
+                throw new BadRequestHttpException('this method is not supported');
        }

        $errors = $this->validate($action, $request, $_format, $entity, [$postedData]);
@ -408,7 +408,7 @@ class ApiController extends AbstractCRUDController
            return $this->json($entity, Response::HTTP_OK, [], $context);
        }

-        throw new \Symfony\Component\HttpFoundation\Exception\BadRequestException('This format is not implemented');
+        throw new BadRequestHttpException('This format is not implemented');
    }

    protected function entityPostAction($action, Request $request, string $_format): Response
@ -418,7 +418,7 @@ class ApiController extends AbstractCRUDController
        try {
            $entity = $this->deserialize($action, $request, $_format, $entity);
        } catch (NotEncodableValueException $e) {
-            throw new BadRequestException('invalid json', 400, $e);
+            throw new BadRequestHttpException('invalid json', 400, $e);
        }

        $errors = $this->validate($action, $request, $_format, $entity);
--- a/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php
+++ b/src/Bundle/ChillMainBundle/CRUD/Controller/CRUDController.php
@ -25,6 +25,7 @@ use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Security\Core\Role\Role;
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
@ -1140,6 +1141,6 @@ class CRUDController extends AbstractController
            return $this->json($entity, Response::HTTP_OK, [], $context);
        }

-        throw new \Symfony\Component\HttpFoundation\Exception\BadRequestException('This format is not implemented');
+        throw new BadRequestHttpException('This format is not implemented');
    }
 }
--- a/src/Bundle/ChillMainBundle/Controller/SearchController.php
+++ b/src/Bundle/ChillMainBundle/Controller/SearchController.php
@ -22,7 +22,6 @@ use Chill\MainBundle\Search\UnknowSearchNameException;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
@ -216,7 +215,7 @@ class SearchController extends AbstractController
        $types = $request->query->get('type', []);

        if (count($types) === 0) {
-            throw new BadRequestException('The request must contains at '
+            throw new BadRequestHttpException('The request must contains at '
                . ' one type');
        }

--- a/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
+++ b/src/Bundle/ChillMainBundle/Controller/WorkflowController.php
@ -25,7 +25,6 @@ use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
@ -144,7 +143,7 @@ class WorkflowController extends AbstractController
    public function getAccessByAccessKey(EntityWorkflowStep $entityWorkflowStep, Request $request): Response
    {
        if (null === $accessKey = $request->query->get('accessKey', null)) {
-            throw new BadRequestException('accessKey is missing');
+            throw new BadRequestHttpException('accessKey is missing');
        }

        if (!$this->getUser() instanceof User) {
--- a/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/AddressSelection.vue
+++ b/src/Bundle/ChillMainBundle/Resources/public/vuejs/Address/components/AddAddress/AddressSelection.vue
@ -119,7 +119,7 @@ export default {
      },
      listenInputSearch(query) {
         //console.log('listenInputSearch', query, this.isAddressSelectorOpen);
-         if (!this.entity.selected.writeNew.postcode) {
+         if (!this.entity.selected.writeNew.postcode && 'id' in this.entity.selected.city) {
            if (query.length > 2) {
               this.isLoading = true;
               searchReferenceAddresses(query, this.entity.selected.city).then(
--- a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseApiController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseApiController.php
@ -33,10 +33,10 @@ use DateInterval;
 use DateTimeImmutable;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Symfony\Component\Serializer\Exception\RuntimeException;
@ -185,7 +185,7 @@ final class AccompanyingCourseApiController extends ApiController
            ->deserialize($request->getContent(), Person::class, $_format, []);

        if (null === $person) {
-            throw new BadRequestException('person id not found');
+            throw new BadRequestHttpException('person id not found');
        }

        // TODO add acl
@ -204,7 +204,7 @@ final class AccompanyingCourseApiController extends ApiController
                break;

            default:
-                throw new BadRequestException('This method is not supported');
+                throw new BadRequestHttpException('This method is not supported');
        }

        $errors = $this->validator->validate($accompanyingPeriod);
@ -247,12 +247,12 @@ final class AccompanyingCourseApiController extends ApiController
            }

            if (null === $requestor) {
-                throw new BadRequestException('Could not find any person or thirdparty', 0, null);
+                throw new BadRequestHttpException('Could not find any person or thirdparty', 0, null);
            }

            $accompanyingPeriod->setRequestor($requestor);
        } else {
-            throw new BadRequestException('method not supported');
+            throw new BadRequestHttpException('method not supported');
        }

        $errors = $this->validator->validate($accompanyingPeriod);
--- a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseCommentController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseCommentController.php
@ -186,6 +186,24 @@ class AccompanyingCourseCommentController extends AbstractController
        ]);
    }

+    /**
+     * @Route("/{_locale}/parcours/comment/{id}/unpin", name="chill_person_accompanying_period_comment_unpin")
+     */
+    public function unpinComment(AccompanyingPeriod\Comment $comment): Response
+    {
+        $this->denyAccessUnlessGranted(AccompanyingPeriodVoter::EDIT, $comment->getAccompanyingPeriod());
+
+        $comment->getAccompanyingPeriod()->setPinnedComment(null);
+
+        $this->getDoctrine()->getManager()->flush();
+
+        $this->addFlash('success', $this->translator->trans('accompanying_course.comment is unpinned'));
+
+        return $this->redirectToRoute('chill_person_accompanying_period_comment_list', [
+            'accompanying_period_id' => $comment->getAccompanyingPeriod()->getId(),
+        ]);
+    }
+
    private function createCommentForm(AccompanyingPeriod\Comment $comment, string $step): FormInterface
    {
        return $this->formFactory->createNamed($step, AccompanyingCourseCommentType::class, $comment);
--- a/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/AccompanyingCourseController.php
@ -21,9 +21,9 @@ use Chill\PersonBundle\Security\Authorization\AccompanyingPeriodVoter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Component\Validator\ConstraintViolationInterface;
@ -255,7 +255,7 @@ class AccompanyingCourseController extends Controller
            $personIds = $request->query->get('person_id');

            if (false === is_array($personIds)) {
-                throw new BadRequestException('person_id parameter should be an array');
+                throw new BadRequestHttpException('person_id parameter should be an array');
            }

            foreach ($personIds as $personId) {
--- a/src/Bundle/ChillPersonBundle/Controller/HouseholdController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/HouseholdController.php
@ -21,8 +21,8 @@ use Chill\PersonBundle\Security\Authorization\HouseholdVoter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Form\FormInterface;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
@ -202,7 +202,7 @@ class HouseholdController extends AbstractController
        $this->denyAccessUnlessGranted(HouseholdVoter::EDIT, $household);

        if (!$request->query->has('address_id')) {
-            throw new BadRequestException('parameter address_id is missing');
+            throw new BadRequestHttpException('parameter address_id is missing');
        }

        $address_id = $request->query->getInt('address_id');
@ -218,7 +218,7 @@ class HouseholdController extends AbstractController
        }

        if (null === $address) {
-            throw new BadRequestException('The edited address does not belongs to the household');
+            throw new BadRequestHttpException('The edited address does not belongs to the household');
        }

        $form = $this->createForm(AddressDateType::class, $address, []);
--- a/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php
+++ b/src/Bundle/ChillPersonBundle/Controller/HouseholdMemberController.php
@ -20,9 +20,9 @@ use Chill\PersonBundle\Form\HouseholdMemberType;
 use Chill\PersonBundle\Household\MembersEditor;
 use Chill\PersonBundle\Repository\AccompanyingPeriodRepository;
 use Chill\PersonBundle\Security\Authorization\PersonVoter;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Serializer\Exception;
@ -105,7 +105,7 @@ class HouseholdMemberController extends ApiController
            $ids = $request->query->get('persons', []);

            if (0 === count($ids)) {
-                throw new BadRequestException('parameters persons in query ' .
+                throw new BadRequestHttpException('parameters persons in query ' .
                    'is not an array or empty');
            }

@ -121,7 +121,8 @@ class HouseholdMemberController extends ApiController
            }
        }

-        if ($householdId = $request->query->get('household', false)) {
+        if ($request->query->has('household')) {
+            $householdId = $request->query->get('household', false);
            $household = $em->getRepository(Household::class)
                ->find($householdId);
            $allowHouseholdCreate = false;
@ -189,7 +190,7 @@ class HouseholdMemberController extends ApiController
                    ['groups' => ['read']]
                );
        } catch (Exception\InvalidArgumentException|Exception\UnexpectedValueException $e) {
-            throw new BadRequestException("Deserialization error: {$e->getMessage()}", 45896, $e);
+            throw new BadRequestHttpException("Deserialization error: {$e->getMessage()}", 45896, $e);
        }

        // TODO ACL
--- a/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
+++ b/src/Bundle/ChillPersonBundle/Entity/AccompanyingPeriod.php
@ -1258,10 +1258,6 @@ class AccompanyingPeriod implements
     */
    public function setPinnedComment(?Comment $comment = null): self
    {
-        if (null !== $this->pinnedComment) {
-            $this->removeComment($this->pinnedComment);
-        }
-
        if (null !== $this->pinnedComment) {
            $this->addComment($this->pinnedComment);
        }
--- a/src/Bundle/ChillPersonBundle/Entity/Person.php
+++ b/src/Bundle/ChillPersonBundle/Entity/Person.php
@ -240,6 +240,11 @@ class Person implements HasCenterInterface, TrackCreationInterface, TrackUpdateI
     */
    private array $currentHouseholdAt = [];

+    /**
+     * Cache for the computation of current household participation.
+     */
+    private array $currentHouseholdParticipationAt = [];
+
    /**
     * The current person address.
     *
--- a/src/Bundle/ChillPersonBundle/Entity/Relationships/Relationship.php
+++ b/src/Bundle/ChillPersonBundle/Entity/Relationships/Relationship.php
@ -15,6 +15,7 @@ use Chill\MainBundle\Doctrine\Model\TrackCreationInterface;
 use Chill\MainBundle\Doctrine\Model\TrackUpdateInterface;
 use Chill\MainBundle\Entity\User;
 use Chill\PersonBundle\Entity\Person;
+use Chill\PersonBundle\Validator\Constraints\Relationship\RelationshipNoDuplicate;
 use DateTimeImmutable;
 use DateTimeInterface;
 use Doctrine\ORM\Mapping as ORM;
@ -31,6 +32,7 @@ use Symfony\Component\Validator\Constraints as Assert;
 * @DiscriminatorMap(typeProperty="type", mapping={
 *     "relationship": Relationship::class
 * })
+ * @RelationshipNoDuplicate
 */
 class Relationship implements TrackCreationInterface, TrackUpdateInterface
 {
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/App.vue
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/App.vue
@ -480,7 +480,17 @@ export default {
                     this.forceUpdateComponent()
                     resolve()
                  }))
-               .catch()
+                  .catch( error => {
+                     if (error.name === 'ValidationException') {
+                        for (let v of error.violations) {
+                           this.$toast.open({message: v });
+                           console.log(v)
+                        }
+                     } else {
+                        this.$toast.open({message: 'An error occurred'});
+                     }
+                  }
+               )

            case 'edit':
               return patchRelationship(this.modal.data)
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/api.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/api.js
@ -1,50 +1,5 @@
-import { splitId } from './vis-network'
-
-/**
- * @function makeFetch
- * @param method
- * @param url
- * @param body
- * @returns {Promise<Response>}
- */
-const makeFetch = (method, url, body) => {
-    return fetch(url, {
-        method: method,
-        headers: {
-            'Content-Type': 'application/json;charset=utf-8'
-        },
-        body: (body !== null) ? JSON.stringify(body) : null
-    })
-    .then(response => {
-
-        if (response.ok) {
-            return response.json();
-        }
-
-        if (response.status === 422) {
-            return response.json().then(violations => {
-                throw ValidationException(violations)
-            });
-        }
-
-        throw {
-            msg: 'Error while updating AccompanyingPeriod Course.',
-            sta: response.status,
-            txt: response.statusText,
-            err: new Error(),
-            body: response.body
-        };
-    });
-}
-
-/**
- * @param violations
- * @constructor
- */
-const ValidationException = (violations) => {
-    this.violations = violations
-    this.name = 'ValidationException'
-}
+import { splitId } from './vis-network';
+import {makeFetch} from 'ChillMainAssets/lib/api/apiMethods.js';

 /**
 * @function getFetch
@ -136,7 +91,7 @@ const getRelationsList = () => {
 * @returns {Promise<Response>}
 */
 const postRelationship = (relationship) => {
-    //console.log(relationship)
+    //console.log(relationship);
    return postFetch(
        `/api/1.0/relations/relationship.json`,
        {
--- a/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/index.js
+++ b/src/Bundle/ChillPersonBundle/Resources/public/vuejs/VisGraph/index.js
@ -3,8 +3,10 @@ import { store } from "./store.js"
 import { _createI18n } from 'ChillMainAssets/vuejs/_js/i18n'
 import { visMessages } from './i18n'
 import App from './App.vue'
+import VueToast from 'vue-toast-notification';
+import 'vue-toast-notification/dist/theme-sugar.css';

-import './vis-network'
+import './vis-network';

 const i18n = _createI18n(visMessages)
 const container = document.getElementById('relationship-graph')
@ -25,5 +27,11 @@ const app = createApp({
 })
 .use(store)
 .use(i18n)
+.use(VueToast, {
+    position: "bottom-right",
+    type: "error",
+    duration: 5000,
+    dismissible: true
+ })
 .component('app', App)
 .mount('#relationship-graph')
--- a/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/Comment/index.html.twig
+++ b/src/Bundle/ChillPersonBundle/Resources/views/AccompanyingCourse/Comment/index.html.twig
@ -8,6 +8,17 @@

 {% macro recordAction(comment, isPinned) %}
    {% if isPinned is defined and isPinned == true %}
+        <li>
+            <form method="post" action="{{ chill_path_forward_return_path('chill_person_accompanying_period_comment_unpin', {'id': comment.id}) }}">
+                <button class="btn btn-sm btn-misc" type="submit">
+                    <span class="fa-stack">
+                        <i class="fa fa-flag fa-stack-1x"></i>
+                        <i class="fa fa-ban fa-stack-2x text-danger"></i>
+                    </span>
+                    {{ 'Unpin comment'|trans }}
+                </button>
+            </form>
+        </li>
    {% else %}
        <li>
            <form method="post" action="{{ chill_path_forward_return_path('chill_person_accompanying_period_comment_pin', {'id': comment.id}) }}">
@ -17,7 +28,7 @@
            </form>
        </li>
    {% endif %}
-    {% if is_granted('CHILL_PERSON_ACCOMPANYING_PERIOD_COMMENT_EDIT', comment) %}
+    {% if is_granted('CHILL_PERSON_ACCOMPANYING_PERIOD_UPDATE', comment.accompanyingPeriod) %}
        <li>
            <a class="btn btn-sm btn-edit" title="{{ 'Edit'|trans }}" href="{{ path('chill_person_accompanying_period_comment_list',  {
                '_fragment': 'comment-' ~ comment.id,
@ -26,7 +37,7 @@
            }) }}"></a>
        </li>
    {% endif %}
-    {% if is_granted('CHILL_PERSON_ACCOMPANYING_PERIOD_COMMENT_DELETE', comment) %}
+    {% if is_granted('CHILL_PERSON_ACCOMPANYING_PERIOD_UPDATE', comment.accompanyingPeriod) %}
        <li>
            <a class="btn btn-sm btn-delete" title="{{ 'Delete'|trans }}" href="{{ path('chill_person_accompanying_period_comment_delete', {'id': comment.id}) }}"></a>
        </li>
--- a/src/Bundle/ChillPersonBundle/Security/Authorization/AccompanyingPeriodCommentVoter.php
+++ b/src/Bundle/ChillPersonBundle/Security/Authorization/AccompanyingPeriodCommentVoter.php
@ -14,6 +14,7 @@ namespace Chill\PersonBundle\Security\Authorization;
 use Chill\PersonBundle\Entity\AccompanyingPeriod\Comment;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\Voter;
+use Symfony\Component\Security\Core\Security;
 use UnexpectedValueException;

 class AccompanyingPeriodCommentVoter extends Voter
@ -22,6 +23,13 @@ class AccompanyingPeriodCommentVoter extends Voter

    public const EDIT = 'CHILL_PERSON_ACCOMPANYING_PERIOD_COMMENT_EDIT';

+    private Security $security;
+
+    public function __construct(Security $security)
+    {
+        $this->security = $security;
+    }
+
    protected function supports($attribute, $subject)
    {
        return $subject instanceof Comment;
@ -32,8 +40,10 @@ class AccompanyingPeriodCommentVoter extends Voter
        /** @var Comment $subject */
        switch ($attribute) {
            case self::EDIT:
+                return $this->security->isGranted(AccompanyingPeriodVoter::EDIT, $subject->getAccompanyingPeriod());
+
            case self::DELETE:
-                return $subject->getCreator() === $token->getUser();
+                return $this->security->isGranted(AccompanyingPeriodVoter::EDIT, $subject->getAccompanyingPeriod());

            default:
                throw new UnexpectedValueException("This attribute {$attribute} is not supported");
--- a/src/Bundle/ChillPersonBundle/Validator/Constraints/Relationship/RelationshipNoDuplicate.php
+++ b/src/Bundle/ChillPersonBundle/Validator/Constraints/Relationship/RelationshipNoDuplicate.php
@ -0,0 +1,27 @@
+<?php
+
+/**
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Chill\PersonBundle\Validator\Constraints\Relationship;
+
+use Symfony\Component\Validator\Constraint;
+
+/**
+ * @Annotation
+ */
+class RelationshipNoDuplicate extends Constraint
+{
+    public $message = 'relationship.duplicate';
+
+    public function getTargets()
+    {
+        return self::CLASS_CONSTRAINT;
+    }
+}
--- a/src/Bundle/ChillPersonBundle/Validator/Constraints/Relationship/RelationshipNoDuplicateValidator.php
+++ b/src/Bundle/ChillPersonBundle/Validator/Constraints/Relationship/RelationshipNoDuplicateValidator.php
@ -0,0 +1,54 @@
+<?php
+
+/**
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Chill\PersonBundle\Validator\Constraints\Relationship;
+
+use Chill\PersonBundle\Repository\Relationships\RelationshipRepository;
+use Symfony\Component\Form\Exception\UnexpectedTypeException;
+use Symfony\Component\Validator\Constraint;
+use Symfony\Component\Validator\ConstraintValidator;
+
+class RelationshipNoDuplicateValidator extends ConstraintValidator
+{
+    private RelationshipRepository $relationshipRepository;
+
+    public function __construct(RelationshipRepository $relationshipRepository)
+    {
+        $this->relationshipRepository = $relationshipRepository;
+    }
+
+    public function validate($relationship, Constraint $constraint)
+    {
+        if (!$constraint instanceof RelationshipNoDuplicate) {
+            throw new UnexpectedTypeException($constraint, RelationshipNoDuplicate::class);
+        }
+
+        $fromPerson = $relationship->getFromPerson();
+        $toPerson = $relationship->getToPerson();
+
+        $relationships = $this->relationshipRepository->findBy([
+            'fromPerson' => [$fromPerson, $toPerson],
+            'toPerson' => [$fromPerson, $toPerson],
+        ]);
+
+        foreach ($relationships as $r) {
+            if (
+                $r->getFromPerson() === $fromPerson
+                || $r->getFromPerson() === $toPerson
+                || $r->getToPerson() === $fromPerson
+                || $r->getToPerson() === $toPerson
+            ) {
+                $this->context->buildViolation($constraint->message)
+                    ->addViolation();
+            }
+        }
+    }
+}
--- a/src/Bundle/ChillPersonBundle/migrations/Version20220425000000.php
+++ b/src/Bundle/ChillPersonBundle/migrations/Version20220425000000.php
@ -0,0 +1,36 @@
+<?php
+
+/**
+ * Chill is a software for social workers
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Chill\Migrations\Person;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Add constraint with a index on chill_person_relationships.
+ */
+final class Version20220425000000 extends AbstractMigration
+{
+    public function down(Schema $schema): void
+    {
+        $this->addSql('DROP INDEX IDX_RELATIONSHIPS000');
+    }
+
+    public function getDescription(): string
+    {
+        return 'Add constraint with a index on chill_person_relationships.';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql('CREATE UNIQUE INDEX IDX_RELATIONSHIPS000 ON chill_person_relationships (least(fromperson_id, toperson_id), greatest(fromperson_id, toperson_id))');
+    }
+}
--- a/src/Bundle/ChillPersonBundle/translations/messages.fr.yml
+++ b/src/Bundle/ChillPersonBundle/translations/messages.fr.yml
@ -465,6 +465,7 @@ fix it: Compléter
 accompanying_course:
    administrative_location: Localisation administrative
    comment is pinned: Le commentaire est épinglé
+    comment is unpinned: Le commentaire est désépinglé
 show: Montrer
 hide: Masquer
 closed periods: parcours clôturer
@ -474,6 +475,7 @@ Accompanying Course Comment: Commentaire
 Accompanying Course Comment list: Commentaires du parcours
 pinned: épinglé
 Pin comment: Épingler
+Unpin comment: Désépingler
 Post a new comment: Poster un nouveau commentaire
 Write a new comment: Écrire un nouveau commentaire
 Edit a comment: Modifier le commentaire
--- a/src/Bundle/ChillPersonBundle/translations/validators.fr.yml
+++ b/src/Bundle/ChillPersonBundle/translations/validators.fr.yml
@ -62,3 +62,7 @@ You cannot associate a resource with the same person: Vous ne pouvez pas ajouter
 #location
 The period must remain located: 'Un parcours doit être localisé'
 The person where the course is located must be associated to the course. Change course's location before removing the person.: "Le parcours est localisé auprès cet usager. Veuillez changer la localisation du parcours avant de suprimer l'usager"
+
+#relationship
+relationship:
+    duplicate: Une relation de filiation existe déjà entre ces 2 personnes
--- a/src/Bundle/ChillReportBundle/Controller/ReportController.php
+++ b/src/Bundle/ChillReportBundle/Controller/ReportController.php
@ -334,7 +334,7 @@ class ReportController extends AbstractController

        $cFGroupId = $request->query->get('cFGroup');

-        if ($cFGroupId) {
+        if ($request->query->has('cFGroup')) {
            return $this->redirect(
                $this->generateUrl(
                    'report_new',
@ -391,7 +391,7 @@ class ReportController extends AbstractController
    {
        $cFGroupId = $request->query->get('cFGroup');

-        if ($cFGroupId) {
+        if ($request->query->has('cFGroup')) {
            return $this->redirect(
                $this->generateUrl(
                    'report_export_list',
--- a/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php
+++ b/src/Bundle/ChillTaskBundle/Controller/SingleTaskController.php
@ -33,7 +33,6 @@ use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormFactoryInterface;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@ -494,7 +493,7 @@ final class SingleTaskController extends AbstractController
                );

            default:
-                throw new BadRequestException("format not supported: {$_format}");
+                throw new BadRequestHttpException("format not supported: {$_format}");
        }
    }