DX: Remove deprecation on $this->get inside controller

This commit is contained in:
Julien Fastré 2023-01-13 16:15:58 +01:00
parent 164beb3ca9
commit 6bba6f68b3
Signed by: julienfastre
GPG Key ID: BDE2190974723FCB
2 changed files with 14 additions and 7 deletions

View File

@ -45,6 +45,7 @@ use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException; use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Serializer\SerializerInterface; use Symfony\Component\Serializer\SerializerInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
class CalendarController extends AbstractController class CalendarController extends AbstractController
{ {
@ -68,6 +69,8 @@ class CalendarController extends AbstractController
private TranslatableStringHelperInterface $translatableStringHelper; private TranslatableStringHelperInterface $translatableStringHelper;
private TranslatorInterface $translator;
private UserRepositoryInterface $userRepository; private UserRepositoryInterface $userRepository;
public function __construct( public function __construct(
@ -81,7 +84,8 @@ class CalendarController extends AbstractController
TranslatableStringHelperInterface $translatableStringHelper, TranslatableStringHelperInterface $translatableStringHelper,
PersonRepository $personRepository, PersonRepository $personRepository,
AccompanyingPeriodRepository $accompanyingPeriodRepository, AccompanyingPeriodRepository $accompanyingPeriodRepository,
UserRepositoryInterface $userRepository UserRepositoryInterface $userRepository,
TranslatorInterface $translator
) { ) {
$this->calendarACLAwareRepository = $calendarACLAwareRepository; $this->calendarACLAwareRepository = $calendarACLAwareRepository;
$this->docGeneratorTemplateRepository = $docGeneratorTemplateRepository; $this->docGeneratorTemplateRepository = $docGeneratorTemplateRepository;
@ -94,6 +98,7 @@ class CalendarController extends AbstractController
$this->personRepository = $personRepository; $this->personRepository = $personRepository;
$this->accompanyingPeriodRepository = $accompanyingPeriodRepository; $this->accompanyingPeriodRepository = $accompanyingPeriodRepository;
$this->userRepository = $userRepository; $this->userRepository = $userRepository;
$this->translator = $translator;
} }
/** /**
@ -131,7 +136,7 @@ class CalendarController extends AbstractController
$em->remove($entity); $em->remove($entity);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator') $this->addFlash('success', $this->translator
->trans('The calendar item has been successfully removed.')); ->trans('The calendar item has been successfully removed.'));
return new RedirectResponse($redirectRoute); return new RedirectResponse($redirectRoute);
@ -190,7 +195,7 @@ class CalendarController extends AbstractController
if ($form->isSubmitted() && $form->isValid()) { if ($form->isSubmitted() && $form->isValid()) {
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans('Success : calendar item updated!')); $this->addFlash('success', $this->translator->trans('Success : calendar item updated!'));
if ($form->get('save_and_upload_doc')->isClicked()) { if ($form->get('save_and_upload_doc')->isClicked()) {
return $this->redirectToRoute('chill_calendar_calendardoc_new', ['id' => $entity->getId()]); return $this->redirectToRoute('chill_calendar_calendardoc_new', ['id' => $entity->getId()]);
@ -210,7 +215,7 @@ class CalendarController extends AbstractController
} }
if ($form->isSubmitted() && !$form->isValid()) { if ($form->isSubmitted() && !$form->isValid()) {
$this->addFlash('error', $this->get('translator')->trans('This form contains errors')); $this->addFlash('error', $this->translator->trans('This form contains errors'));
} }
$entity_array = $this->serializer->normalize($entity, 'json', ['groups' => 'read']); $entity_array = $this->serializer->normalize($entity, 'json', ['groups' => 'read']);
@ -369,7 +374,7 @@ class CalendarController extends AbstractController
$em->persist($entity); $em->persist($entity);
$em->flush(); $em->flush();
$this->addFlash('success', $this->get('translator')->trans('Success : calendar item created!')); $this->addFlash('success', $this->translator->trans('Success : calendar item created!'));
if ($form->get('save_and_upload_doc')->isClicked()) { if ($form->get('save_and_upload_doc')->isClicked()) {
return $this->redirectToRoute('chill_calendar_calendardoc_new', ['id' => $entity->getId()]); return $this->redirectToRoute('chill_calendar_calendardoc_new', ['id' => $entity->getId()]);
@ -393,7 +398,7 @@ class CalendarController extends AbstractController
} }
if ($form->isSubmitted() && !$form->isValid()) { if ($form->isSubmitted() && !$form->isValid()) {
$this->addFlash('error', $this->get('translator')->trans('This form contains errors')); $this->addFlash('error', $this->translator->trans('This form contains errors'));
} }
if (null === $view) { if (null === $view) {

View File

@ -356,7 +356,9 @@ class SocialIssue
{ {
$this->parent = $parent; $this->parent = $parent;
$parent->addChild($this); if (null !== $parent) {
$parent->addChild($this);
}
return $this; return $this;
} }